Re: [RFC 4/4] gpio: sifive: Add GPIO driver for SiFive SoCs

2019-09-18 Thread Bin Meng
Hi, On Wed, Oct 17, 2018 at 9:01 AM Atish Patra wrote: > > On 10/10/18 5:35 AM, Linus Walleij wrote: > > Hi Atish, > > > > thanks for your patch! > > > > On Tue, Oct 9, 2018 at 8:51 PM Atish Patra wrote: > > > >> From: "Wesley W. Terpstra" > >> > >> Adds the GPIO driver for SiFive RISC-V SoCs.

Re: [RFC 4/4] gpio: sifive: Add GPIO driver for SiFive SoCs

2018-10-16 Thread Atish Patra
On 10/10/18 5:35 AM, Linus Walleij wrote: Hi Atish, thanks for your patch! On Tue, Oct 9, 2018 at 8:51 PM Atish Patra wrote: From: "Wesley W. Terpstra" Adds the GPIO driver for SiFive RISC-V SoCs. Signed-off-by: Wesley W. Terpstra [Atish: Various fixes and code cleanup] Signed-off-by:

Re: [RFC 4/4] gpio: sifive: Add GPIO driver for SiFive SoCs

2018-10-16 Thread Atish Patra
On 10/10/18 5:35 AM, Linus Walleij wrote: Hi Atish, thanks for your patch! On Tue, Oct 9, 2018 at 8:51 PM Atish Patra wrote: From: "Wesley W. Terpstra" Adds the GPIO driver for SiFive RISC-V SoCs. Signed-off-by: Wesley W. Terpstra [Atish: Various fixes and code cleanup] Signed-off-by:

Re: [RFC 4/4] gpio: sifive: Add GPIO driver for SiFive SoCs

2018-10-10 Thread Andreas Schwab
On Okt 10 2018, Christoph Hellwig wrote: > On Wed, Oct 10, 2018 at 03:01:29PM +0200, Andreas Schwab wrote: >> On Okt 09 2018, Atish Patra wrote: >> >> > +static void sifive_set_ie(struct sifive_gpio *chip, unsigned int offset) >> > +{ >> > + unsigned long flags; >> > + unsigned int trigger;

Re: [RFC 4/4] gpio: sifive: Add GPIO driver for SiFive SoCs

2018-10-10 Thread Andreas Schwab
On Okt 10 2018, Christoph Hellwig wrote: > On Wed, Oct 10, 2018 at 03:01:29PM +0200, Andreas Schwab wrote: >> On Okt 09 2018, Atish Patra wrote: >> >> > +static void sifive_set_ie(struct sifive_gpio *chip, unsigned int offset) >> > +{ >> > + unsigned long flags; >> > + unsigned int trigger;

Re: [RFC 4/4] gpio: sifive: Add GPIO driver for SiFive SoCs

2018-10-10 Thread Christoph Hellwig
On Wed, Oct 10, 2018 at 03:01:29PM +0200, Andreas Schwab wrote: > On Okt 09 2018, Atish Patra wrote: > > > +static void sifive_set_ie(struct sifive_gpio *chip, unsigned int offset) > > +{ > > + unsigned long flags; > > + unsigned int trigger; > > + > > + raw_spin_lock_irqsave(>lock,

Re: [RFC 4/4] gpio: sifive: Add GPIO driver for SiFive SoCs

2018-10-10 Thread Christoph Hellwig
On Wed, Oct 10, 2018 at 03:01:29PM +0200, Andreas Schwab wrote: > On Okt 09 2018, Atish Patra wrote: > > > +static void sifive_set_ie(struct sifive_gpio *chip, unsigned int offset) > > +{ > > + unsigned long flags; > > + unsigned int trigger; > > + > > + raw_spin_lock_irqsave(>lock,

Re: [RFC 4/4] gpio: sifive: Add GPIO driver for SiFive SoCs

2018-10-10 Thread Andreas Schwab
On Okt 09 2018, Atish Patra wrote: > +static void sifive_set_ie(struct sifive_gpio *chip, unsigned int offset) > +{ > + unsigned long flags; > + unsigned int trigger; > + > + raw_spin_lock_irqsave(>lock, flags); > + trigger = (chip->enabled & BIT(offset)) ? chip->trigger[offset]

Re: [RFC 4/4] gpio: sifive: Add GPIO driver for SiFive SoCs

2018-10-10 Thread Andreas Schwab
On Okt 09 2018, Atish Patra wrote: > +static void sifive_set_ie(struct sifive_gpio *chip, unsigned int offset) > +{ > + unsigned long flags; > + unsigned int trigger; > + > + raw_spin_lock_irqsave(>lock, flags); > + trigger = (chip->enabled & BIT(offset)) ? chip->trigger[offset]

Re: [RFC 4/4] gpio: sifive: Add GPIO driver for SiFive SoCs

2018-10-10 Thread Linus Walleij
Hi Atish, thanks for your patch! On Tue, Oct 9, 2018 at 8:51 PM Atish Patra wrote: > From: "Wesley W. Terpstra" > > Adds the GPIO driver for SiFive RISC-V SoCs. > > Signed-off-by: Wesley W. Terpstra > [Atish: Various fixes and code cleanup] > Signed-off-by: Atish Patra (...) > +config

Re: [RFC 4/4] gpio: sifive: Add GPIO driver for SiFive SoCs

2018-10-10 Thread Linus Walleij
Hi Atish, thanks for your patch! On Tue, Oct 9, 2018 at 8:51 PM Atish Patra wrote: > From: "Wesley W. Terpstra" > > Adds the GPIO driver for SiFive RISC-V SoCs. > > Signed-off-by: Wesley W. Terpstra > [Atish: Various fixes and code cleanup] > Signed-off-by: Atish Patra (...) > +config