Re: [RFC PATCH] i2c: busses: i2c-omap: Increase timeout for i2c interrupt

2015-07-10 Thread Grygorii Strashko
Hi Wolfram, On 07/10/2015 12:09 PM, Wolfram Sang wrote: > >> 60 s sounds way too much and actually I simply don't believe this is >> the root cause. If I take a look into the driver, then I see, that > > I agree, this is just a workaround. > >> the design is not really the best. The whole IRQ

Re: [RFC PATCH] i2c: busses: i2c-omap: Increase timeout for i2c interrupt

2015-07-10 Thread Grygorii Strashko
On 07/10/2015 04:26 PM, Alexander Sverdlin wrote: > Hi! > > On 10/07/15 15:17, ext Vignesh R wrote: I would propose you to throw away spinlocks. Convert threaded IRQ to Agree. Looks like spinlock is not needed. >> just one hardirq handler. And continue debugging. You will reduce the

Re: [RFC PATCH] i2c: busses: i2c-omap: Increase timeout for i2c interrupt

2015-07-10 Thread Vignesh R
Hi, On 07/10/2015 06:56 PM, Alexander Sverdlin wrote: > Hi! > > On 10/07/15 15:17, ext Vignesh R wrote: I would propose you to throw away spinlocks. Convert threaded IRQ to >> just one hardirq handler. And continue debugging. You will reduce the >> load of the system with the above

Re: [RFC PATCH] i2c: busses: i2c-omap: Increase timeout for i2c interrupt

2015-07-10 Thread Alexander Sverdlin
Hi! On 10/07/15 15:17, ext Vignesh R wrote: >>> I would propose you to throw away spinlocks. Convert threaded IRQ to >>> >> just one hardirq handler. And continue debugging. You will reduce the >>> >> load of the system with the above measures, maybe it will not happen >>> >> any more, maybe

Re: [RFC PATCH] i2c: busses: i2c-omap: Increase timeout for i2c interrupt

2015-07-10 Thread Vignesh R
On 07/10/2015 02:39 PM, Wolfram Sang wrote: > >> 60 s sounds way too much and actually I simply don't believe this is >> the root cause. If I take a look into the driver, then I see, that > > I agree, this is just a workaround. > Yes, this is a workaround. I thought this is simpler change

Re: [RFC PATCH] i2c: busses: i2c-omap: Increase timeout for i2c interrupt

2015-07-10 Thread Wolfram Sang
> 60 s sounds way too much and actually I simply don't believe this is > the root cause. If I take a look into the driver, then I see, that I agree, this is just a workaround. > the design is not really the best. The whole IRQ handling could be > actually performed in hard IRQ handler, without

Re: [RFC PATCH] i2c: busses: i2c-omap: Increase timeout for i2c interrupt

2015-07-10 Thread Alexander Sverdlin
Hi Vignesh, On 10/07/15 07:09, ext Vignesh R wrote: > When system is under load and there is an i2c transaction running > following warning appears on the console: > > [ 730.003617] omap_i2c 4807.i2c: controller timed out > [ 731.023643] omap_i2c 4807.i2c: controller timed out > >

Re: [RFC PATCH] i2c: busses: i2c-omap: Increase timeout for i2c interrupt

2015-07-10 Thread Roger Quadros
Vignesh, On 10/07/15 08:09, Vignesh R wrote: > When system is under load and there is an i2c transaction running > following warning appears on the console: > > [ 730.003617] omap_i2c 4807.i2c: controller timed out > [ 731.023643] omap_i2c 4807.i2c: controller timed out > > This is

Re: [RFC PATCH] i2c: busses: i2c-omap: Increase timeout for i2c interrupt

2015-07-10 Thread Alexander Sverdlin
Hi Vignesh, On 10/07/15 07:09, ext Vignesh R wrote: When system is under load and there is an i2c transaction running following warning appears on the console: [ 730.003617] omap_i2c 4807.i2c: controller timed out [ 731.023643] omap_i2c 4807.i2c: controller timed out This is

Re: [RFC PATCH] i2c: busses: i2c-omap: Increase timeout for i2c interrupt

2015-07-10 Thread Wolfram Sang
60 s sounds way too much and actually I simply don't believe this is the root cause. If I take a look into the driver, then I see, that I agree, this is just a workaround. the design is not really the best. The whole IRQ handling could be actually performed in hard IRQ handler, without

Re: [RFC PATCH] i2c: busses: i2c-omap: Increase timeout for i2c interrupt

2015-07-10 Thread Roger Quadros
Vignesh, On 10/07/15 08:09, Vignesh R wrote: When system is under load and there is an i2c transaction running following warning appears on the console: [ 730.003617] omap_i2c 4807.i2c: controller timed out [ 731.023643] omap_i2c 4807.i2c: controller timed out This is because,

Re: [RFC PATCH] i2c: busses: i2c-omap: Increase timeout for i2c interrupt

2015-07-10 Thread Vignesh R
On 07/10/2015 02:39 PM, Wolfram Sang wrote: 60 s sounds way too much and actually I simply don't believe this is the root cause. If I take a look into the driver, then I see, that I agree, this is just a workaround. Yes, this is a workaround. I thought this is simpler change and can go

Re: [RFC PATCH] i2c: busses: i2c-omap: Increase timeout for i2c interrupt

2015-07-10 Thread Alexander Sverdlin
Hi! On 10/07/15 15:17, ext Vignesh R wrote: I would propose you to throw away spinlocks. Convert threaded IRQ to just one hardirq handler. And continue debugging. You will reduce the load of the system with the above measures, maybe it will not happen any more, maybe you'll figure out that

Re: [RFC PATCH] i2c: busses: i2c-omap: Increase timeout for i2c interrupt

2015-07-10 Thread Vignesh R
Hi, On 07/10/2015 06:56 PM, Alexander Sverdlin wrote: Hi! On 10/07/15 15:17, ext Vignesh R wrote: I would propose you to throw away spinlocks. Convert threaded IRQ to just one hardirq handler. And continue debugging. You will reduce the load of the system with the above measures, maybe it

Re: [RFC PATCH] i2c: busses: i2c-omap: Increase timeout for i2c interrupt

2015-07-10 Thread Grygorii Strashko
Hi Wolfram, On 07/10/2015 12:09 PM, Wolfram Sang wrote: 60 s sounds way too much and actually I simply don't believe this is the root cause. If I take a look into the driver, then I see, that I agree, this is just a workaround. the design is not really the best. The whole IRQ handling

Re: [RFC PATCH] i2c: busses: i2c-omap: Increase timeout for i2c interrupt

2015-07-10 Thread Grygorii Strashko
On 07/10/2015 04:26 PM, Alexander Sverdlin wrote: Hi! On 10/07/15 15:17, ext Vignesh R wrote: I would propose you to throw away spinlocks. Convert threaded IRQ to Agree. Looks like spinlock is not needed. just one hardirq handler. And continue debugging. You will reduce the load of the