Re: [RFC PATCH 00/10] ARM: dts: exynos: Fix invalid GIC interrupt flags
On Fri, Sep 16, 2016 at 09:42:41PM +0200, Krzysztof Kozlowski wrote: > Hi, > > Marek (internally), Geert and Alban reported errors like: > genirq: Setting trigger mode 0 for irq 16 failed (gic_set_type+0x0/0x68) > The patchset fixes this issue. > > Tested on: > 1. Exynos4412: Odroid U3, > 2. Exynos5410: Odroid XU, > 3. Exynos5422: Odroid XU3. > > Other platforms not tested so testing would be highly appreciated. Applied entire patchset for v4.10. Let it boil for some time in linux-next. Best regards, Krzysztof
Re: [RFC PATCH 00/10] ARM: dts: exynos: Fix invalid GIC interrupt flags
On Sun, Sep 18, 2016 at 10:34:36AM +0100, Marc Zyngier wrote: > On Sat, 17 Sep 2016 19:55:53 +0200 > Krzysztof Kozlowski wrote: > > > On Sat, Sep 17, 2016 at 11:05:39PM +0530, Alim Akhtar wrote: > > > Hi Krzysztof, > > > > > > On Sat, Sep 17, 2016 at 1:12 AM, Krzysztof Kozlowski > > > wrote: > > > > Hi, > > > > > > > > Marek (internally), Geert and Alban reported errors like: > > > > genirq: Setting trigger mode 0 for irq 16 failed > > > > (gic_set_type+0x0/0x68) > > > > The patchset fixes this issue. > > > > > > > > Tested on: > > > > 1. Exynos4412: Odroid U3, > > > > 2. Exynos5410: Odroid XU, > > > > 3. Exynos5422: Odroid XU3. > > > > > > > > > > Tested on Exynos5800 based peach-pi board, so fpr patch 06/10 > > > > > > Tested-by: Alim Akhtar > > > > > > > > > > Other platforms not tested so testing would be highly appreciated. > > > > > > > > Best regards, > > > > Krzysztof > > > > > > > > Krzysztof Kozlowski (10): > > > > ARM: dts: exynos: Fix invalid GIC interrupt flags in exynos4 > > > > ARM: dts: exynos: Fix invalid GIC interrupt flags in exynos4210 > > > > ARM: dts: exynos: Fix invalid GIC interrupt flags in exynos4x12 > > > > ARM: dts: exynos: Fix invalid GIC interrupt flags in exynos4415 > > > > ARM: dts: exynos: Fix invalid GIC interrupt flags in exynos3250 > > > > ARM: dts: exynos: Fix invalid GIC interrupt flags in exynos5 > > > > ARM: dts: exynos: Fix invalid GIC interrupt flags in exynos5250 > > > > ARM: dts: exynos: Fix invalid GIC interrupt flags in > > > > exynos5410/exynos542x > > > > ARM: dts: exynos: Fix invalid GIC interrupt flags in exynos5260 > > > > ARM: dts: exynos: Fix invalid GIC interrupt flags in exynos5440 > > > > > > > > > > In general these patches looks good, feel free to add my review-by tag > > > for this series. > > > > > > Reviewed-by: Alim Akhtar > > > > > > > Thanks, I'll add your reviewed-by to all patches. > > There is a couple of things that I don't like about these patches: > > - Are you sure that all your interrupts are level? I appreciate that's > a very common setting, but you seem to have simply decided that there > wasn't any edge interrupt. Is that a "Let's see what breaks" > situation? If so, It'd be good to state it. Yes, that's the case. I can mention it in commit msg more explicitly. Anyway till now, Exynos platform always used IRQ_TYPE_NONE. Also vendor kernel uses it. However this did not affect the platform. I didn't dig too much into it but it seemts that __irq_set_trigger wasn't called before for these interrupts. > > - You've used the IRQ_TYPE_LEVEL_HIGH macro everywhere, but didn't use > the GIC_SPI macro as the first argument of each interrupt specifier. > I'm by no mean a fan of these macros, but you should at least have > some consistency inside an interrupt specifier. I wanted to fix here only the error itself. Using GIC_SPI instead of 0 is not related so I replaced it in separate patches [1]. Keeping such change separate makes testing easy - dtx_diff. Best regards, Krzysztof [1] https://patchwork.kernel.org/patch/9336781/
Re: [RFC PATCH 00/10] ARM: dts: exynos: Fix invalid GIC interrupt flags
On Sat, 17 Sep 2016 19:55:53 +0200 Krzysztof Kozlowski wrote: > On Sat, Sep 17, 2016 at 11:05:39PM +0530, Alim Akhtar wrote: > > Hi Krzysztof, > > > > On Sat, Sep 17, 2016 at 1:12 AM, Krzysztof Kozlowski > > wrote: > > > Hi, > > > > > > Marek (internally), Geert and Alban reported errors like: > > > genirq: Setting trigger mode 0 for irq 16 failed > > > (gic_set_type+0x0/0x68) > > > The patchset fixes this issue. > > > > > > Tested on: > > > 1. Exynos4412: Odroid U3, > > > 2. Exynos5410: Odroid XU, > > > 3. Exynos5422: Odroid XU3. > > > > > > > Tested on Exynos5800 based peach-pi board, so fpr patch 06/10 > > > > Tested-by: Alim Akhtar > > > > > > > Other platforms not tested so testing would be highly appreciated. > > > > > > Best regards, > > > Krzysztof > > > > > > Krzysztof Kozlowski (10): > > > ARM: dts: exynos: Fix invalid GIC interrupt flags in exynos4 > > > ARM: dts: exynos: Fix invalid GIC interrupt flags in exynos4210 > > > ARM: dts: exynos: Fix invalid GIC interrupt flags in exynos4x12 > > > ARM: dts: exynos: Fix invalid GIC interrupt flags in exynos4415 > > > ARM: dts: exynos: Fix invalid GIC interrupt flags in exynos3250 > > > ARM: dts: exynos: Fix invalid GIC interrupt flags in exynos5 > > > ARM: dts: exynos: Fix invalid GIC interrupt flags in exynos5250 > > > ARM: dts: exynos: Fix invalid GIC interrupt flags in > > > exynos5410/exynos542x > > > ARM: dts: exynos: Fix invalid GIC interrupt flags in exynos5260 > > > ARM: dts: exynos: Fix invalid GIC interrupt flags in exynos5440 > > > > > > > In general these patches looks good, feel free to add my review-by tag > > for this series. > > > > Reviewed-by: Alim Akhtar > > > > Thanks, I'll add your reviewed-by to all patches. There is a couple of things that I don't like about these patches: - Are you sure that all your interrupts are level? I appreciate that's a very common setting, but you seem to have simply decided that there wasn't any edge interrupt. Is that a "Let's see what breaks" situation? If so, It'd be good to state it. - You've used the IRQ_TYPE_LEVEL_HIGH macro everywhere, but didn't use the GIC_SPI macro as the first argument of each interrupt specifier. I'm by no mean a fan of these macros, but you should at least have some consistency inside an interrupt specifier. Thanks, M. -- Jazz is not dead. It just smells funny.
Re: [RFC PATCH 00/10] ARM: dts: exynos: Fix invalid GIC interrupt flags
Hi Krzysztof,
On Fri, Sep 16, 2016 at 9:42 PM, Krzysztof Kozlowski wrote:
> Marek (internally), Geert and Alban reported errors like:
> genirq: Setting trigger mode 0 for irq 16 failed
> (gic_set_type+0x0/0x68)
I didn't report these on Exynos, though, so I think you should drop my
Reported-by.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Re: [RFC PATCH 00/10] ARM: dts: exynos: Fix invalid GIC interrupt flags
On Sat, Sep 17, 2016 at 11:05:39PM +0530, Alim Akhtar wrote: > Hi Krzysztof, > > On Sat, Sep 17, 2016 at 1:12 AM, Krzysztof Kozlowski wrote: > > Hi, > > > > Marek (internally), Geert and Alban reported errors like: > > genirq: Setting trigger mode 0 for irq 16 failed > > (gic_set_type+0x0/0x68) > > The patchset fixes this issue. > > > > Tested on: > > 1. Exynos4412: Odroid U3, > > 2. Exynos5410: Odroid XU, > > 3. Exynos5422: Odroid XU3. > > > > Tested on Exynos5800 based peach-pi board, so fpr patch 06/10 > > Tested-by: Alim Akhtar > > > > Other platforms not tested so testing would be highly appreciated. > > > > Best regards, > > Krzysztof > > > > Krzysztof Kozlowski (10): > > ARM: dts: exynos: Fix invalid GIC interrupt flags in exynos4 > > ARM: dts: exynos: Fix invalid GIC interrupt flags in exynos4210 > > ARM: dts: exynos: Fix invalid GIC interrupt flags in exynos4x12 > > ARM: dts: exynos: Fix invalid GIC interrupt flags in exynos4415 > > ARM: dts: exynos: Fix invalid GIC interrupt flags in exynos3250 > > ARM: dts: exynos: Fix invalid GIC interrupt flags in exynos5 > > ARM: dts: exynos: Fix invalid GIC interrupt flags in exynos5250 > > ARM: dts: exynos: Fix invalid GIC interrupt flags in > > exynos5410/exynos542x > > ARM: dts: exynos: Fix invalid GIC interrupt flags in exynos5260 > > ARM: dts: exynos: Fix invalid GIC interrupt flags in exynos5440 > > > > In general these patches looks good, feel free to add my review-by tag > for this series. > > Reviewed-by: Alim Akhtar > Thanks, I'll add your reviewed-by to all patches. Best regards, Krzysztof
Re: [RFC PATCH 00/10] ARM: dts: exynos: Fix invalid GIC interrupt flags
Hi Krzysztof, On Sat, Sep 17, 2016 at 1:12 AM, Krzysztof Kozlowski wrote: > Hi, > > Marek (internally), Geert and Alban reported errors like: > genirq: Setting trigger mode 0 for irq 16 failed > (gic_set_type+0x0/0x68) > The patchset fixes this issue. > > Tested on: > 1. Exynos4412: Odroid U3, > 2. Exynos5410: Odroid XU, > 3. Exynos5422: Odroid XU3. > Tested on Exynos5800 based peach-pi board, so fpr patch 06/10 Tested-by: Alim Akhtar > Other platforms not tested so testing would be highly appreciated. > > Best regards, > Krzysztof > > Krzysztof Kozlowski (10): > ARM: dts: exynos: Fix invalid GIC interrupt flags in exynos4 > ARM: dts: exynos: Fix invalid GIC interrupt flags in exynos4210 > ARM: dts: exynos: Fix invalid GIC interrupt flags in exynos4x12 > ARM: dts: exynos: Fix invalid GIC interrupt flags in exynos4415 > ARM: dts: exynos: Fix invalid GIC interrupt flags in exynos3250 > ARM: dts: exynos: Fix invalid GIC interrupt flags in exynos5 > ARM: dts: exynos: Fix invalid GIC interrupt flags in exynos5250 > ARM: dts: exynos: Fix invalid GIC interrupt flags in > exynos5410/exynos542x > ARM: dts: exynos: Fix invalid GIC interrupt flags in exynos5260 > ARM: dts: exynos: Fix invalid GIC interrupt flags in exynos5440 > In general these patches looks good, feel free to add my review-by tag for this series. Reviewed-by: Alim Akhtar > arch/arm/boot/dts/exynos3250-pinctrl.dtsi | 20 +-- > arch/arm/boot/dts/exynos3250.dtsi | 93 +- > arch/arm/boot/dts/exynos4.dtsi| 94 > --- > arch/arm/boot/dts/exynos4210-pinctrl.dtsi | 20 +-- > arch/arm/boot/dts/exynos4210.dtsi | 36 > arch/arm/boot/dts/exynos4415-pinctrl.dtsi | 20 +-- > arch/arm/boot/dts/exynos4415.dtsi | 92 +- > arch/arm/boot/dts/exynos4x12-pinctrl.dtsi | 20 +-- > arch/arm/boot/dts/exynos4x12.dtsi | 48 ++-- > arch/arm/boot/dts/exynos5.dtsi| 60 ++-- > arch/arm/boot/dts/exynos5250.dtsi | 80 +- > arch/arm/boot/dts/exynos5260.dtsi | 39 - > arch/arm/boot/dts/exynos5410.dtsi | 26 - > arch/arm/boot/dts/exynos5420.dtsi | 78 - > arch/arm/boot/dts/exynos5440.dtsi | 48 ++-- > arch/arm/boot/dts/exynos54xx.dtsi | 34 +-- > 16 files changed, 485 insertions(+), 323 deletions(-) > > -- > 2.7.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" > in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Regards, Alim
