Re: [RFC PATCH 01/10] timer: Prevent base->clk from moving backward

2020-07-02 Thread Juri Lelli
On 02/07/20 16:32, Frederic Weisbecker wrote: > On Thu, Jul 02, 2020 at 11:59:59AM +0200, Juri Lelli wrote: > > On 02/07/20 01:20, Frederic Weisbecker wrote: > > > On Wed, Jul 01, 2020 at 06:35:04PM +0200, Juri Lelli wrote: > > > > Guess you might be faster to understand what I'm missing. :-) > >

Re: [RFC PATCH 01/10] timer: Prevent base->clk from moving backward

2020-07-02 Thread Frederic Weisbecker
On Thu, Jul 02, 2020 at 11:59:59AM +0200, Juri Lelli wrote: > On 02/07/20 01:20, Frederic Weisbecker wrote: > > On Wed, Jul 01, 2020 at 06:35:04PM +0200, Juri Lelli wrote: > > > Guess you might be faster to understand what I'm missing. :-) > > > > So, did you port only this patch or the whole set

Re: [RFC PATCH 01/10] timer: Prevent base->clk from moving backward

2020-07-02 Thread Frederic Weisbecker
On Thu, Jul 02, 2020 at 11:59:59AM +0200, Juri Lelli wrote: > On 02/07/20 01:20, Frederic Weisbecker wrote: > > On Wed, Jul 01, 2020 at 06:35:04PM +0200, Juri Lelli wrote: > > > Guess you might be faster to understand what I'm missing. :-) > > > > So, did you port only this patch or the whole set

Re: [RFC PATCH 01/10] timer: Prevent base->clk from moving backward

2020-07-02 Thread Juri Lelli
On 02/07/20 01:20, Frederic Weisbecker wrote: > On Wed, Jul 01, 2020 at 06:35:04PM +0200, Juri Lelli wrote: > > Guess you might be faster to understand what I'm missing. :-) > > So, did you port only this patch or the whole set in order to > trigger this? > > If it was the whole set, can you try

Re: [RFC PATCH 01/10] timer: Prevent base->clk from moving backward

2020-07-02 Thread Thomas Gleixner
Frederic Weisbecker writes: > When a timer is enqueued with a negative delta (ie: expiry is below > base->clk), it gets added to the wheel as expiring now (base->clk). > > Yet the value that gets stored in base->next_expiry, while calling > trigger_dyntick_cpu(), is the initial timer->expires

Re: [RFC PATCH 01/10] timer: Prevent base->clk from moving backward

2020-07-01 Thread Frederic Weisbecker
On Wed, Jul 01, 2020 at 06:35:04PM +0200, Juri Lelli wrote: > Guess you might be faster to understand what I'm missing. :-) So, did you port only this patch or the whole set in order to trigger this? If it was the whole set, can you try this patch alone? Thanks!

Re: [RFC PATCH 01/10] timer: Prevent base->clk from moving backward

2020-07-01 Thread Juri Lelli
Hi, Thanks for the set, first of all. Reviewing and testing it. On 01/07/20 03:10, Frederic Weisbecker wrote: > When a timer is enqueued with a negative delta (ie: expiry is below > base->clk), it gets added to the wheel as expiring now (base->clk). > > Yet the value that gets stored in