Re: [RFC PATCH 01/35] syscalls: define goal to not call sys_xyzzy() from within the kernel

2018-03-12 Thread Dominik Brodowski 
On Sun, Mar 11, 2018 at 03:24:01PM +, Andy Lutomirski wrote:
> On Sun, Mar 11, 2018 at 10:55 AM, Dominik Brodowski
>  wrote:
> > +
> > +/*
> > + * The kernel should not use call syscalls (i.e., sys_xyzyyz()) directly.
> > + * Instead, use one of the following functions which work equivalent to
> > + * the syscall they are named for.
> 
> "Instead, use one of the functions which work equivalently, e.g. do_xysyyz()"

On Mon, Mar 12, 2018 at 08:27:49AM +0100, Ingo Molnar wrote:
> The previous sentence has a typo as well, should be:
> 
>   * Kernel code should not call syscalls (i.e., sys_xyzyyz()) directly.

Thanks for your feedback. Here's what I will do for v2, unless you find more
typos or areas for improvement:

/*
 * Kernel code should not call syscalls (i.e., sys_xyzyyz()) directly.
 * Instead, use one of the functions which work equivalently, such as
 * the ksys_xyzyyz() functions prototyped below.
 */

Thanks,
Dominik

Re: [RFC PATCH 01/35] syscalls: define goal to not call sys_xyzzy() from within the kernel

2018-03-12 Thread Ingo Molnar 

* Andy Lutomirski  wrote:

> On Sun, Mar 11, 2018 at 10:55 AM, Dominik Brodowski
>  wrote:
> > The syscall entry points to the kernel defined by SYSCALL_DEFINEx()
> > and COMPAT_SYSCALL_DEFINEx() should only be called from userspace
> > through kernel entry points, but not from the kernel itself. This
> > will allow cleanups and optimizations to the entry paths *and* to
> > the parts of the kernel code which currently need to pretend to be
> > userspace in order to make use of syscalls.
> >
> 
> > +
> > +/*
> > + * The kernel should not use call syscalls (i.e., sys_xyzyyz()) directly.
> > + * Instead, use one of the following functions which work equivalent to
> > + * the syscall they are named for.
> 
> "Instead, use one of the functions which work equivalently, e.g. do_xysyyz()"

The previous sentence has a typo as well, should be:

  * Kernel code should not call syscalls (i.e., sys_xyzyyz()) directly.

or so.

Thanks,

Ingo

Re: [RFC PATCH 01/35] syscalls: define goal to not call sys_xyzzy() from within the kernel

2018-03-11 Thread Andy Lutomirski 
On Sun, Mar 11, 2018 at 10:55 AM, Dominik Brodowski
 wrote:
> The syscall entry points to the kernel defined by SYSCALL_DEFINEx()
> and COMPAT_SYSCALL_DEFINEx() should only be called from userspace
> through kernel entry points, but not from the kernel itself. This
> will allow cleanups and optimizations to the entry paths *and* to
> the parts of the kernel code which currently need to pretend to be
> userspace in order to make use of syscalls.
>

> +
> +/*
> + * The kernel should not use call syscalls (i.e., sys_xyzyyz()) directly.
> + * Instead, use one of the following functions which work equivalent to
> + * the syscall they are named for.

"Instead, use one of the functions which work equivalently, e.g. do_xysyyz()"