Re: [RFC PATCH 1/3] x86: use defined names for all CPU feature flags
> --- 2.6.21-rc7-d390.orig/arch/x86_64/kernel/setup.c > +++ 2.6.21-rc7-d390/arch/x86_64/kernel/setup.c > @@ -576,7 +576,7 @@ static void __cpuinit init_amd(struct cp > > /* Bit 31 in normal CPUID used for nonstandard 3DNow ID; > 3DNow is IDd by bit 31 in extended CPUID (1*32+31) anyway */ > - clear_bit(0*32+31, >x86_capability); > + clear_bit(X86_FEATURE_PBE, >x86_capability); And this is more clear why ? > +#define X86_FEATURE_PBE (0*32+31) /* PBE */ For these platforms it isn't "PBE" its 3DNow Alan - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RFC PATCH 1/3] x86: use defined names for all CPU feature flags
On Saturday 21 April 2007 00:52:52 Chuck Ebbert wrote: > /* Bit 31 in normal CPUID used for nonstandard 3DNow ID; > 3DNow is IDd by bit 31 in extended CPUID (1*32+31) anyway */ > - clear_bit(0*32+31, >x86_capability); > + clear_bit(X86_FEATURE_PBE, >x86_capability); > That doesn't match the comment. -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RFC PATCH 1/3] x86: use defined names for all CPU feature flags
On Fri, Apr 20, 2007 at 06:52:52PM -0400, Chuck Ebbert wrote: > --- 2.6.21-rc7-d390.orig/arch/x86_64/kernel/setup.c > +++ 2.6.21-rc7-d390/arch/x86_64/kernel/setup.c > @@ -576,7 +576,7 @@ static void __cpuinit init_amd(struct cp > > /* Bit 31 in normal CPUID used for nonstandard 3DNow ID; > 3DNow is IDd by bit 31 in extended CPUID (1*32+31) anyway */ > -clear_bit(0*32+31, >x86_capability); > +clear_bit(X86_FEATURE_PBE, >x86_capability); The comment suggests this should be X86_FEATURE_3DNOW Same for the other instances. Dave -- http://www.codemonkey.org.uk - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RFC PATCH 1/3] x86: use defined names for all CPU feature flags
On Fri, Apr 20, 2007 at 06:52:52PM -0400, Chuck Ebbert wrote: --- 2.6.21-rc7-d390.orig/arch/x86_64/kernel/setup.c +++ 2.6.21-rc7-d390/arch/x86_64/kernel/setup.c @@ -576,7 +576,7 @@ static void __cpuinit init_amd(struct cp /* Bit 31 in normal CPUID used for nonstandard 3DNow ID; 3DNow is IDd by bit 31 in extended CPUID (1*32+31) anyway */ -clear_bit(0*32+31, c-x86_capability); +clear_bit(X86_FEATURE_PBE, c-x86_capability); The comment suggests this should be X86_FEATURE_3DNOW Same for the other instances. Dave -- http://www.codemonkey.org.uk - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RFC PATCH 1/3] x86: use defined names for all CPU feature flags
On Saturday 21 April 2007 00:52:52 Chuck Ebbert wrote: /* Bit 31 in normal CPUID used for nonstandard 3DNow ID; 3DNow is IDd by bit 31 in extended CPUID (1*32+31) anyway */ - clear_bit(0*32+31, c-x86_capability); + clear_bit(X86_FEATURE_PBE, c-x86_capability); That doesn't match the comment. -Andi - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [RFC PATCH 1/3] x86: use defined names for all CPU feature flags
--- 2.6.21-rc7-d390.orig/arch/x86_64/kernel/setup.c +++ 2.6.21-rc7-d390/arch/x86_64/kernel/setup.c @@ -576,7 +576,7 @@ static void __cpuinit init_amd(struct cp /* Bit 31 in normal CPUID used for nonstandard 3DNow ID; 3DNow is IDd by bit 31 in extended CPUID (1*32+31) anyway */ - clear_bit(0*32+31, c-x86_capability); + clear_bit(X86_FEATURE_PBE, c-x86_capability); And this is more clear why ? +#define X86_FEATURE_PBE (0*32+31) /* PBE */ For these platforms it isn't PBE its 3DNow Alan - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
