Re: [RFC PATCH 35/35] syscalls: do not call sys_close() within the kernel

2018-03-12 Thread Ingo Molnar
* Dominik Brodowski wrote: > On Mon, Mar 12, 2018 at 08:37:19AM +0100, Ingo Molnar wrote: > > > > * Dominik Brodowski wrote: > > > > > --- a/fs/open.c > > > +++ b/fs/open.c > > > @@ -1200,7 +1200,7 @@ SYSCALL_DEFINE1(close, unsigned int, fd) > > > > > > return retval; > > > } > > > -EXPO

Re: [RFC PATCH 35/35] syscalls: do not call sys_close() within the kernel

2018-03-12 Thread Dominik Brodowski
On Mon, Mar 12, 2018 at 08:37:19AM +0100, Ingo Molnar wrote: > > * Dominik Brodowski wrote: > > > --- a/fs/open.c > > +++ b/fs/open.c > > @@ -1200,7 +1200,7 @@ SYSCALL_DEFINE1(close, unsigned int, fd) > > > > return retval; > > } > > -EXPORT_SYMBOL(sys_close); > > + > > > > /* > > Nit

Re: [RFC PATCH 35/35] syscalls: do not call sys_close() within the kernel

2018-03-12 Thread Ingo Molnar
* Dominik Brodowski wrote: > --- a/fs/open.c > +++ b/fs/open.c > @@ -1200,7 +1200,7 @@ SYSCALL_DEFINE1(close, unsigned int, fd) > > return retval; > } > -EXPORT_SYMBOL(sys_close); > + > > /* Nit: this introduces a stray newline. > --- a/include/linux/syscalls.h > +++ b/include/linu