Re: [RFC PATCH 6/8] dts: coresight: Clean up the device tree graph bindings

2018-07-03 Thread Suzuki K Poulose
Hi Rob, On 14/06/18 14:59, Rob Herring wrote: On Thu, Jun 14, 2018 at 2:53 AM, Suzuki K Poulose wrote: On 13/06/18 22:07, Matt Sealey wrote: -Original Message- From: Mathieu Poirier So, if the suggestion is to use an existing property "unit", I am fine with it, if people agree

Re: [RFC PATCH 6/8] dts: coresight: Clean up the device tree graph bindings

2018-07-03 Thread Suzuki K Poulose
Hi Rob, On 14/06/18 14:59, Rob Herring wrote: On Thu, Jun 14, 2018 at 2:53 AM, Suzuki K Poulose wrote: On 13/06/18 22:07, Matt Sealey wrote: -Original Message- From: Mathieu Poirier So, if the suggestion is to use an existing property "unit", I am fine with it, if people agree

Re: [RFC PATCH 6/8] dts: coresight: Clean up the device tree graph bindings

2018-06-15 Thread Suzuki K Poulose
On 14/06/18 14:59, Rob Herring wrote: On Thu, Jun 14, 2018 at 2:53 AM, Suzuki K Poulose wrote: On 13/06/18 22:07, Matt Sealey wrote: -Original Message- From: Mathieu Poirier So, if the suggestion is to use an existing property "unit", I am fine with it, if people agree to it.

Re: [RFC PATCH 6/8] dts: coresight: Clean up the device tree graph bindings

2018-06-15 Thread Suzuki K Poulose
On 14/06/18 14:59, Rob Herring wrote: On Thu, Jun 14, 2018 at 2:53 AM, Suzuki K Poulose wrote: On 13/06/18 22:07, Matt Sealey wrote: -Original Message- From: Mathieu Poirier So, if the suggestion is to use an existing property "unit", I am fine with it, if people agree to it.

RE: [RFC PATCH 6/8] dts: coresight: Clean up the device tree graph bindings

2018-06-14 Thread Matt Sealey
Hi Rob, To take this in a somewhat different direction... > > No, the above comment is about using "unit" ( if it is a standard > > property for specifying something specific to hardware) instead of > > "coresight,hwid". I would prefer to stick to the DT graph bindings, > > because : > > "unit"

RE: [RFC PATCH 6/8] dts: coresight: Clean up the device tree graph bindings

2018-06-14 Thread Matt Sealey
Hi Rob, To take this in a somewhat different direction... > > No, the above comment is about using "unit" ( if it is a standard > > property for specifying something specific to hardware) instead of > > "coresight,hwid". I would prefer to stick to the DT graph bindings, > > because : > > "unit"

Re: [RFC PATCH 6/8] dts: coresight: Clean up the device tree graph bindings

2018-06-14 Thread Rob Herring
On Thu, Jun 14, 2018 at 2:53 AM, Suzuki K Poulose wrote: > On 13/06/18 22:07, Matt Sealey wrote: >> >> >> >>> -Original Message- >>> From: Mathieu Poirier >>> So, if the suggestion is to use an existing property "unit", I am fine with it, if people agree to it. >>> >>> >>> If

Re: [RFC PATCH 6/8] dts: coresight: Clean up the device tree graph bindings

2018-06-14 Thread Rob Herring
On Thu, Jun 14, 2018 at 2:53 AM, Suzuki K Poulose wrote: > On 13/06/18 22:07, Matt Sealey wrote: >> >> >> >>> -Original Message- >>> From: Mathieu Poirier >>> So, if the suggestion is to use an existing property "unit", I am fine with it, if people agree to it. >>> >>> >>> If

Re: [RFC PATCH 6/8] dts: coresight: Clean up the device tree graph bindings

2018-06-14 Thread Suzuki K Poulose
On 13/06/18 22:07, Matt Sealey wrote: -Original Message- From: Mathieu Poirier So, if the suggestion is to use an existing property "unit", I am fine with it, if people agree to it. If we're going to have something sharply different than ACPI I prefer Rob's idea. No, the above

Re: [RFC PATCH 6/8] dts: coresight: Clean up the device tree graph bindings

2018-06-14 Thread Suzuki K Poulose
On 13/06/18 22:07, Matt Sealey wrote: -Original Message- From: Mathieu Poirier So, if the suggestion is to use an existing property "unit", I am fine with it, if people agree to it. If we're going to have something sharply different than ACPI I prefer Rob's idea. No, the above

RE: [RFC PATCH 6/8] dts: coresight: Clean up the device tree graph bindings

2018-06-13 Thread Matt Sealey
> -Original Message- > From: Mathieu Poirier > > > So, if the suggestion is to use an existing property "unit", I am fine > > with it, if people agree to it. > > If we're going to have something sharply different than ACPI I prefer > Rob's idea. What are you trying to say about being

RE: [RFC PATCH 6/8] dts: coresight: Clean up the device tree graph bindings

2018-06-13 Thread Matt Sealey
> -Original Message- > From: Mathieu Poirier > > > So, if the suggestion is to use an existing property "unit", I am fine > > with it, if people agree to it. > > If we're going to have something sharply different than ACPI I prefer > Rob's idea. What are you trying to say about being

Re: [RFC PATCH 6/8] dts: coresight: Clean up the device tree graph bindings

2018-06-13 Thread Mathieu Poirier
On 13 June 2018 at 11:07, Suzuki K Poulose wrote: > Hi Matt, > > On 13/06/18 16:47, Matt Sealey wrote: >> >> Hi Suzuki, >> Why not use “unit”? I believe we had this discussion years ago about numbering serial ports and sdhci (i.e. how do you know it’s UART0 or UART1 from just

Re: [RFC PATCH 6/8] dts: coresight: Clean up the device tree graph bindings

2018-06-13 Thread Mathieu Poirier
On 13 June 2018 at 11:07, Suzuki K Poulose wrote: > Hi Matt, > > On 13/06/18 16:47, Matt Sealey wrote: >> >> Hi Suzuki, >> Why not use “unit”? I believe we had this discussion years ago about numbering serial ports and sdhci (i.e. how do you know it’s UART0 or UART1 from just

Re: [RFC PATCH 6/8] dts: coresight: Clean up the device tree graph bindings

2018-06-13 Thread Suzuki K Poulose
Hi Matt, On 13/06/18 16:47, Matt Sealey wrote: Hi Suzuki, Why not use “unit”? I believe we had this discussion years ago about numbering serial ports and sdhci (i.e. how do you know it’s UART0 or UART1 from just the address? Some SoC’s don’t address sequentially *or* in a forward direction)

Re: [RFC PATCH 6/8] dts: coresight: Clean up the device tree graph bindings

2018-06-13 Thread Suzuki K Poulose
Hi Matt, On 13/06/18 16:47, Matt Sealey wrote: Hi Suzuki, Why not use “unit”? I believe we had this discussion years ago about numbering serial ports and sdhci (i.e. how do you know it’s UART0 or UART1 from just the address? Some SoC’s don’t address sequentially *or* in a forward direction)

RE: [RFC PATCH 6/8] dts: coresight: Clean up the device tree graph bindings

2018-06-13 Thread Matt Sealey
Hi Suzuki, > > Why not use “unit”? > > > > I believe we had this discussion years ago about numbering serial ports > > and sdhci (i.e. how do you know it’s UART0 or UART1 from just the address? > > Some SoC’s don’t address sequentially *or* in a forward direction) - I > > believe it’s not exactly

RE: [RFC PATCH 6/8] dts: coresight: Clean up the device tree graph bindings

2018-06-13 Thread Matt Sealey
Hi Suzuki, > > Why not use “unit”? > > > > I believe we had this discussion years ago about numbering serial ports > > and sdhci (i.e. how do you know it’s UART0 or UART1 from just the address? > > Some SoC’s don’t address sequentially *or* in a forward direction) - I > > believe it’s not exactly

Re: [RFC PATCH 6/8] dts: coresight: Clean up the device tree graph bindings

2018-06-13 Thread Rob Herring
On Wed, Jun 13, 2018 at 7:35 AM, Suzuki K Poulose wrote: > Hi Matt, > > Thanks for your comments, responses inline. > > On 13/06/18 13:49, Matt Sealey wrote: >> >> Suzuki, >> >> Why not use “unit”? >> >> I believe we had this discussion years ago about numbering serial ports >> and sdhci (i.e.

Re: [RFC PATCH 6/8] dts: coresight: Clean up the device tree graph bindings

2018-06-13 Thread Rob Herring
On Wed, Jun 13, 2018 at 7:35 AM, Suzuki K Poulose wrote: > Hi Matt, > > Thanks for your comments, responses inline. > > On 13/06/18 13:49, Matt Sealey wrote: >> >> Suzuki, >> >> Why not use “unit”? >> >> I believe we had this discussion years ago about numbering serial ports >> and sdhci (i.e.

Re: [RFC PATCH 6/8] dts: coresight: Clean up the device tree graph bindings

2018-06-13 Thread Suzuki K Poulose
Hi Matt, Thanks for your comments, responses inline. On 13/06/18 13:49, Matt Sealey wrote: Suzuki, Why not use “unit”? I believe we had this discussion years ago about numbering serial ports and sdhci (i.e. how do you know it’s UART0 or UART1 from just the address? Some SoC’s don’t address

Re: [RFC PATCH 6/8] dts: coresight: Clean up the device tree graph bindings

2018-06-13 Thread Suzuki K Poulose
Hi Matt, Thanks for your comments, responses inline. On 13/06/18 13:49, Matt Sealey wrote: Suzuki, Why not use “unit”? I believe we had this discussion years ago about numbering serial ports and sdhci (i.e. how do you know it’s UART0 or UART1 from just the address? Some SoC’s don’t address

Re: [RFC PATCH 6/8] dts: coresight: Clean up the device tree graph bindings

2018-06-13 Thread Matt Sealey
Suzuki, Why not use “unit”? I believe we had this discussion years ago about numbering serial ports and sdhci (i.e. how do you know it’s UART0 or UART1 from just the address? Some SoC’s don’t address sequentially *or* in a forward direction) - I believe it’s not exactly codified in ePAPR, not

Re: [RFC PATCH 6/8] dts: coresight: Clean up the device tree graph bindings

2018-06-13 Thread Matt Sealey
Suzuki, Why not use “unit”? I believe we had this discussion years ago about numbering serial ports and sdhci (i.e. how do you know it’s UART0 or UART1 from just the address? Some SoC’s don’t address sequentially *or* in a forward direction) - I believe it’s not exactly codified in ePAPR, not

Re: [RFC PATCH 6/8] dts: coresight: Clean up the device tree graph bindings

2018-06-13 Thread Suzuki K Poulose
Hi Rob, On 12/06/18 21:48, Rob Herring wrote: On Fri, Jun 01, 2018 at 02:16:05PM +0100, Suzuki K Poulose wrote: The coresight drivers relied on default bindings for graph in DT, while reusing the "reg" field of the "ports" to indicate the actual hardware port number for the connections.

Re: [RFC PATCH 6/8] dts: coresight: Clean up the device tree graph bindings

2018-06-13 Thread Suzuki K Poulose
Hi Rob, On 12/06/18 21:48, Rob Herring wrote: On Fri, Jun 01, 2018 at 02:16:05PM +0100, Suzuki K Poulose wrote: The coresight drivers relied on default bindings for graph in DT, while reusing the "reg" field of the "ports" to indicate the actual hardware port number for the connections.

Re: [RFC PATCH 6/8] dts: coresight: Clean up the device tree graph bindings

2018-06-12 Thread Rob Herring
On Fri, Jun 01, 2018 at 02:16:05PM +0100, Suzuki K Poulose wrote: > The coresight drivers relied on default bindings for graph > in DT, while reusing the "reg" field of the "ports" to indicate > the actual hardware port number for the connections. However, > with the rules getting stricter w.r.t

Re: [RFC PATCH 6/8] dts: coresight: Clean up the device tree graph bindings

2018-06-12 Thread Rob Herring
On Fri, Jun 01, 2018 at 02:16:05PM +0100, Suzuki K Poulose wrote: > The coresight drivers relied on default bindings for graph > in DT, while reusing the "reg" field of the "ports" to indicate > the actual hardware port number for the connections. However, > with the rules getting stricter w.r.t

Re: [RFC PATCH 6/8] dts: coresight: Clean up the device tree graph bindings

2018-06-01 Thread Mathieu Poirier
On Fri, Jun 01, 2018 at 02:16:05PM +0100, Suzuki K Poulose wrote: > The coresight drivers relied on default bindings for graph > in DT, while reusing the "reg" field of the "ports" to indicate > the actual hardware port number for the connections. However, > with the rules getting stricter w.r.t

Re: [RFC PATCH 6/8] dts: coresight: Clean up the device tree graph bindings

2018-06-01 Thread Mathieu Poirier
On Fri, Jun 01, 2018 at 02:16:05PM +0100, Suzuki K Poulose wrote: > The coresight drivers relied on default bindings for graph > in DT, while reusing the "reg" field of the "ports" to indicate > the actual hardware port number for the connections. However, > with the rules getting stricter w.r.t