Re: [RFC PATCH v3 1/2] ARM: dts: samsung: add rga-lvds panel in itop elite

2016-09-19 Thread ayaka 



On 09/20/2016 03:12 AM, Fabio Estevam wrote:

On Mon, Sep 19, 2016 at 4:02 PM, Randy Li  wrote:


+   vcc_sys_lcd: sys-lcd {
+   compatible = "regulator-fixed";
+   regulator-name = "vcc_5v";
+   regulator-min-microvolt = <500>;
+   regulator-max-microvolt = <500>;
+   gpio = <&gpl0 4 GPIO_ACTIVE_HIGH>;

Is this really active high? If so, you should add the
'enable-active-high' property.
I see, thank you. Btw, let me make it clearly, it is really an 
independentTransistor, not be controlled by PMIC.

Re: [RFC PATCH v3 1/2] ARM: dts: samsung: add rga-lvds panel in itop elite

2016-09-19 Thread Fabio Estevam 
On Mon, Sep 19, 2016 at 4:02 PM, Randy Li  wrote:

> +   vcc_sys_lcd: sys-lcd {
> +   compatible = "regulator-fixed";
> +   regulator-name = "vcc_5v";
> +   regulator-min-microvolt = <500>;
> +   regulator-max-microvolt = <500>;
> +   gpio = <&gpl0 4 GPIO_ACTIVE_HIGH>;

Is this really active high? If so, you should add the
'enable-active-high' property.