Re: [V9fs-developer] [PATCH 5/6] 9p: Use a slab for allocating requests

2018-07-11 Thread Dominique Martinet
Matthew Wilcox wrote on Wed, Jul 11, 2018: > On Wed, Jul 11, 2018 at 03:33:13PM +0200, Dominique Martinet wrote: > > Well this appears to work but P9_NOTAG being '(u16)(~0)' I'm not too > > confident with P9_NOTAG + 1. . . it doesn't look like it's overflowing > > before the cast on my laptop but i

Re: [V9fs-developer] [PATCH 5/6] 9p: Use a slab for allocating requests

2018-07-11 Thread Matthew Wilcox
On Wed, Jul 11, 2018 at 03:33:13PM +0200, Dominique Martinet wrote: > Matthew Wilcox wrote on Thu, Jun 28, 2018: > > /** > > * struct p9_client - per client instance state > > - * @lock: protect @fidlist > > + * @lock: protect @fids and @reqs > > * @msize: maximum data size negotiated by proto

Re: [V9fs-developer] [PATCH 5/6] 9p: Use a slab for allocating requests

2018-07-11 Thread Dominique Martinet
Matthew Wilcox wrote on Thu, Jun 28, 2018: > diff --git a/include/net/9p/client.h b/include/net/9p/client.h > index 0fa0fbab33b0..fd326811ebd4 100644 > --- a/include/net/9p/client.h > +++ b/include/net/9p/client.h > @@ -92,24 +85,12 @@ enum p9_req_status_t { > * struct p9_req_t - request slots >