Re: [alsa-devel] [PATCH v2 2/2] ASoC: ak5558: Add bindings for AK5558 ADC

[Fabio Estevam]

Hi Daniel,

You missed to add the dt maintainer, Rob Herring.

On Fri, Feb 2, 2018 at 2:20 PM, Daniel Baluta  wrote:
> Signed-off-by: Daniel Baluta 

Please add a commit log.

> ---
>  Documentation/devicetree/bindings/sound/ak5558.txt | 23 
> ++
>  1 file changed, 23 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/sound/ak5558.txt
>
> diff --git a/Documentation/devicetree/bindings/sound/ak5558.txt 
> b/Documentation/devicetree/bindings/sound/ak5558.txt
> new file mode 100644
> index 000..61c85568
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/ak5558.txt
> @@ -0,0 +1,23 @@
> +AK5558 8 channel differential 32-bit delta-sigma ADC
> +
> +This device supports I2C mode only.
> +
> +Required properties:
> +
> +- compatible : "asahi-kasei,ak5558"
> +- reg : The I2C address of the device for I2C.

No need for repeating "I2C" in this phrase.

"- reg : The I2C address of the device." would be better.

> +Optional properties:
> +
> +- reset-gpios: A GPIO specifier for the GPIO controlling
> +   the power down & reset pin.

No need for repeating "GPIO" in this phrase.

"- reset-gpios: A GPIO specifier for the the power down & reset pin."
would be better.

Re: [alsa-devel] [PATCH v2 2/2] ASoC: ak5558: Add bindings for AK5558 ADC

[Fabio Estevam]

Hi Daniel,

You missed to add the dt maintainer, Rob Herring.

On Fri, Feb 2, 2018 at 2:20 PM, Daniel Baluta  wrote:
> Signed-off-by: Daniel Baluta 

Please add a commit log.

> ---
>  Documentation/devicetree/bindings/sound/ak5558.txt | 23 
> ++
>  1 file changed, 23 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/sound/ak5558.txt
>
> diff --git a/Documentation/devicetree/bindings/sound/ak5558.txt 
> b/Documentation/devicetree/bindings/sound/ak5558.txt
> new file mode 100644
> index 000..61c85568
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/ak5558.txt
> @@ -0,0 +1,23 @@
> +AK5558 8 channel differential 32-bit delta-sigma ADC
> +
> +This device supports I2C mode only.
> +
> +Required properties:
> +
> +- compatible : "asahi-kasei,ak5558"
> +- reg : The I2C address of the device for I2C.

No need for repeating "I2C" in this phrase.

"- reg : The I2C address of the device." would be better.

> +Optional properties:
> +
> +- reset-gpios: A GPIO specifier for the GPIO controlling
> +   the power down & reset pin.

No need for repeating "GPIO" in this phrase.

"- reset-gpios: A GPIO specifier for the the power down & reset pin."
would be better.