Re: [discuss] [2.6 patch] include/asm-x86_64 "extern inline" -> "static inline"

2005-09-06 Thread H. Peter Anvin
Michael Matz wrote: As "extern inline" is a GNU extension I don't understand this remark. Sort of. C99 has the equivalent construct, but spell it differently: inline foo(int bar) { ... } extern foo(int bar); There is no "static inline" in C99 either; it's just "inline".

Re: [discuss] [2.6 patch] include/asm-x86_64 "extern inline" -> "static inline"

2005-09-06 Thread Andi Kleen
On Tuesday 06 September 2005 22:55, Terrence Miller wrote: > Andi Kleen wrote: > > I don't think the functionality of having single copies in case > > an out of line version was needed was ever required by the Linux kernel. > > But shouldn't the compiler that compiles Linux be C99 compliant? At

Re: [discuss] [2.6 patch] include/asm-x86_64 "extern inline" -> "static inline"

2005-09-06 Thread Michael Matz
Hi, On Tue, 6 Sep 2005, Terrence Miller wrote: > Andi Kleen wrote: > > I don't think the functionality of having single copies in case > > an out of line version was needed was ever required by the Linux kernel. > > But shouldn't the compiler that compiles Linux be C99 compliant? As "extern

Re: [discuss] [2.6 patch] include/asm-x86_64 "extern inline" -> "static inline"

2005-09-06 Thread Terrence Miller
Andi Kleen wrote: > I don't think the functionality of having single copies in case > an out of line version was needed was ever required by the Linux kernel. But shouldn't the compiler that compiles Linux be C99 compliant? > extern inline was used in the kernel a long time ago as a "poor man's

Re: [discuss] [2.6 patch] include/asm-x86_64 "extern inline" -> "static inline"

2005-09-06 Thread David S. Miller
From: Andi Kleen <[EMAIL PROTECTED]> Date: Tue, 6 Sep 2005 22:23:50 +0200 > I don't think the functionality of having single copies in case > an out of line version was needed was ever required by the Linux kernel. Alpha does, exactly for the kind of case this gcc inlining feature was designed

Re: [discuss] [2.6 patch] include/asm-x86_64 "extern inline" -> "static inline"

2005-09-06 Thread Andi Kleen
I don't think the functionality of having single copies in case an out of line version was needed was ever required by the Linux kernel. extern inline was used in the kernel a long time ago as a "poor man's -Winline". Basically the intention was to get an linker error if the inlining didn't

Re: [discuss] [2.6 patch] include/asm-x86_64 "extern inline" -> "static inline"

2005-09-06 Thread Terrence Miller
Jakub Jelinek wrote: > On Mon, Sep 05, 2005 at 08:00:05PM +0200, Adrian Bunk wrote: > >>It isn't the same, but "static inline" is the correct variant. >> >>"extern inline __attribute__((always_inline))" (which is what >>"extern inline" is expanded to) doesn't make sense. > > > It does make

Re: [discuss] [2.6 patch] include/asm-x86_64 extern inline - static inline

2005-09-06 Thread Terrence Miller
Jakub Jelinek wrote: On Mon, Sep 05, 2005 at 08:00:05PM +0200, Adrian Bunk wrote: It isn't the same, but static inline is the correct variant. extern inline __attribute__((always_inline)) (which is what extern inline is expanded to) doesn't make sense. It does make sense and is different

Re: [discuss] [2.6 patch] include/asm-x86_64 extern inline - static inline

2005-09-06 Thread Andi Kleen
I don't think the functionality of having single copies in case an out of line version was needed was ever required by the Linux kernel. extern inline was used in the kernel a long time ago as a poor man's -Winline. Basically the intention was to get an linker error if the inlining didn't

Re: [discuss] [2.6 patch] include/asm-x86_64 extern inline - static inline

2005-09-06 Thread David S. Miller
From: Andi Kleen [EMAIL PROTECTED] Date: Tue, 6 Sep 2005 22:23:50 +0200 I don't think the functionality of having single copies in case an out of line version was needed was ever required by the Linux kernel. Alpha does, exactly for the kind of case this gcc inlining feature was designed for.

Re: [discuss] [2.6 patch] include/asm-x86_64 extern inline - static inline

2005-09-06 Thread Terrence Miller
Andi Kleen wrote: I don't think the functionality of having single copies in case an out of line version was needed was ever required by the Linux kernel. But shouldn't the compiler that compiles Linux be C99 compliant? extern inline was used in the kernel a long time ago as a poor man's

Re: [discuss] [2.6 patch] include/asm-x86_64 extern inline - static inline

2005-09-06 Thread Michael Matz
Hi, On Tue, 6 Sep 2005, Terrence Miller wrote: Andi Kleen wrote: I don't think the functionality of having single copies in case an out of line version was needed was ever required by the Linux kernel. But shouldn't the compiler that compiles Linux be C99 compliant? As extern inline is

Re: [discuss] [2.6 patch] include/asm-x86_64 extern inline - static inline

2005-09-06 Thread Andi Kleen
On Tuesday 06 September 2005 22:55, Terrence Miller wrote: Andi Kleen wrote: I don't think the functionality of having single copies in case an out of line version was needed was ever required by the Linux kernel. But shouldn't the compiler that compiles Linux be C99 compliant? At least

Re: [discuss] [2.6 patch] include/asm-x86_64 extern inline - static inline

2005-09-06 Thread H. Peter Anvin
Michael Matz wrote: As extern inline is a GNU extension I don't understand this remark. Sort of. C99 has the equivalent construct, but spell it differently: inline foo(int bar) { ... } extern foo(int bar); There is no static inline in C99 either; it's just inline. -hpa -

Re: [discuss] [2.6 patch] include/asm-x86_64 "extern inline" -> "static inline"

2005-09-05 Thread H. Peter Anvin
Followup to: <[EMAIL PROTECTED]> By author:Adrian Bunk <[EMAIL PROTECTED]> In newsgroup: linux.dev.kernel > > On Mon, Sep 05, 2005 at 02:47:40PM -0400, Jakub Jelinek wrote: > > On Mon, Sep 05, 2005 at 08:00:05PM +0200, Adrian Bunk wrote: > > > It isn't the same, but "static inline" is the

Re: [discuss] [2.6 patch] include/asm-x86_64 "extern inline" -> "static inline"

2005-09-05 Thread Andi Kleen
On Friday 02 September 2005 22:31, Adrian Bunk wrote: > "extern inline" doesn't make much sense. > > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Thanks applied (with a better description) -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a

Re: [discuss] [2.6 patch] include/asm-x86_64 "extern inline" -> "static inline"

2005-09-05 Thread Adrian Bunk
On Mon, Sep 05, 2005 at 02:47:40PM -0400, Jakub Jelinek wrote: > On Mon, Sep 05, 2005 at 08:00:05PM +0200, Adrian Bunk wrote: > > It isn't the same, but "static inline" is the correct variant. > > > > "extern inline __attribute__((always_inline))" (which is what > > "extern inline" is expanded

Re: [discuss] [2.6 patch] include/asm-x86_64 "extern inline" -> "static inline"

2005-09-05 Thread Jakub Jelinek
On Mon, Sep 05, 2005 at 08:00:05PM +0200, Adrian Bunk wrote: > It isn't the same, but "static inline" is the correct variant. > > "extern inline __attribute__((always_inline))" (which is what > "extern inline" is expanded to) doesn't make sense. It does make sense and is different from static

Re: [discuss] [2.6 patch] include/asm-x86_64 "extern inline" -> "static inline"

2005-09-05 Thread Adrian Bunk
On Mon, Sep 05, 2005 at 10:52:47AM +0200, Michael Matz wrote: > Hi, > > On Fri, 2 Sep 2005, Adrian Bunk wrote: > > > "extern inline" doesn't make much sense. > > It does. It's a GCC extension which says "never ever emit an out-of-line > version of this function, not even if its address is

Re: [discuss] [2.6 patch] include/asm-x86_64 "extern inline" -> "static inline"

2005-09-05 Thread Michael Matz
Hi, On Fri, 2 Sep 2005, Adrian Bunk wrote: > "extern inline" doesn't make much sense. It does. It's a GCC extension which says "never ever emit an out-of-line version of this function, not even if its address is taken", i.e. it's implicitely assumed, that if there is a need for such

Re: [discuss] [2.6 patch] include/asm-x86_64 extern inline - static inline

2005-09-05 Thread Michael Matz
Hi, On Fri, 2 Sep 2005, Adrian Bunk wrote: extern inline doesn't make much sense. It does. It's a GCC extension which says never ever emit an out-of-line version of this function, not even if its address is taken, i.e. it's implicitely assumed, that if there is a need for such out-of-line

Re: [discuss] [2.6 patch] include/asm-x86_64 extern inline - static inline

2005-09-05 Thread Adrian Bunk
On Mon, Sep 05, 2005 at 10:52:47AM +0200, Michael Matz wrote: Hi, On Fri, 2 Sep 2005, Adrian Bunk wrote: extern inline doesn't make much sense. It does. It's a GCC extension which says never ever emit an out-of-line version of this function, not even if its address is taken, i.e. it's

Re: [discuss] [2.6 patch] include/asm-x86_64 extern inline - static inline

2005-09-05 Thread Jakub Jelinek
On Mon, Sep 05, 2005 at 08:00:05PM +0200, Adrian Bunk wrote: It isn't the same, but static inline is the correct variant. extern inline __attribute__((always_inline)) (which is what extern inline is expanded to) doesn't make sense. It does make sense and is different from static inline

Re: [discuss] [2.6 patch] include/asm-x86_64 extern inline - static inline

2005-09-05 Thread Adrian Bunk
On Mon, Sep 05, 2005 at 02:47:40PM -0400, Jakub Jelinek wrote: On Mon, Sep 05, 2005 at 08:00:05PM +0200, Adrian Bunk wrote: It isn't the same, but static inline is the correct variant. extern inline __attribute__((always_inline)) (which is what extern inline is expanded to) doesn't make

Re: [discuss] [2.6 patch] include/asm-x86_64 extern inline - static inline

2005-09-05 Thread Andi Kleen
On Friday 02 September 2005 22:31, Adrian Bunk wrote: extern inline doesn't make much sense. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] Thanks applied (with a better description) -Andi - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to

Re: [discuss] [2.6 patch] include/asm-x86_64 extern inline - static inline

2005-09-05 Thread H. Peter Anvin
Followup to: [EMAIL PROTECTED] By author:Adrian Bunk [EMAIL PROTECTED] In newsgroup: linux.dev.kernel On Mon, Sep 05, 2005 at 02:47:40PM -0400, Jakub Jelinek wrote: On Mon, Sep 05, 2005 at 08:00:05PM +0200, Adrian Bunk wrote: It isn't the same, but static inline is the correct variant.