Re: [kernel-hardening] [PATCH v5 04/10] arm64: Add __flush_tlb_one()

2017-08-31 Thread Tycho Andersen
Hi all, On Thu, Aug 31, 2017 at 10:47:27AM +0100, Mark Rutland wrote: > On Thu, Aug 31, 2017 at 11:43:53AM +0200, Juerg Haefliger wrote: > > On 08/30/2017 06:47 PM, Tycho Andersen wrote: > > > On Wed, Aug 30, 2017 at 07:31:25AM +0200, Juerg Haefliger wrote: > > >> > > >> > > >> On 08/23/2017

Re: [kernel-hardening] [PATCH v5 04/10] arm64: Add __flush_tlb_one()

2017-08-31 Thread Tycho Andersen
Hi all, On Thu, Aug 31, 2017 at 10:47:27AM +0100, Mark Rutland wrote: > On Thu, Aug 31, 2017 at 11:43:53AM +0200, Juerg Haefliger wrote: > > On 08/30/2017 06:47 PM, Tycho Andersen wrote: > > > On Wed, Aug 30, 2017 at 07:31:25AM +0200, Juerg Haefliger wrote: > > >> > > >> > > >> On 08/23/2017

Re: [kernel-hardening] [PATCH v5 04/10] arm64: Add __flush_tlb_one()

2017-08-31 Thread Mark Rutland
On Thu, Aug 31, 2017 at 11:43:53AM +0200, Juerg Haefliger wrote: > On 08/30/2017 06:47 PM, Tycho Andersen wrote: > > On Wed, Aug 30, 2017 at 07:31:25AM +0200, Juerg Haefliger wrote: > >> > >> > >> On 08/23/2017 07:04 PM, Mark Rutland wrote: > >>> On Wed, Aug 23, 2017 at 10:58:42AM -0600, Tycho

Re: [kernel-hardening] [PATCH v5 04/10] arm64: Add __flush_tlb_one()

2017-08-31 Thread Mark Rutland
On Thu, Aug 31, 2017 at 11:43:53AM +0200, Juerg Haefliger wrote: > On 08/30/2017 06:47 PM, Tycho Andersen wrote: > > On Wed, Aug 30, 2017 at 07:31:25AM +0200, Juerg Haefliger wrote: > >> > >> > >> On 08/23/2017 07:04 PM, Mark Rutland wrote: > >>> On Wed, Aug 23, 2017 at 10:58:42AM -0600, Tycho

Re: [kernel-hardening] [PATCH v5 04/10] arm64: Add __flush_tlb_one()

2017-08-31 Thread Juerg Haefliger
On 08/30/2017 06:47 PM, Tycho Andersen wrote: > On Wed, Aug 30, 2017 at 07:31:25AM +0200, Juerg Haefliger wrote: >> >> >> On 08/23/2017 07:04 PM, Mark Rutland wrote: >>> On Wed, Aug 23, 2017 at 10:58:42AM -0600, Tycho Andersen wrote: Hi Mark, On Mon, Aug 14, 2017 at 05:50:47PM

Re: [kernel-hardening] [PATCH v5 04/10] arm64: Add __flush_tlb_one()

2017-08-31 Thread Juerg Haefliger
On 08/30/2017 06:47 PM, Tycho Andersen wrote: > On Wed, Aug 30, 2017 at 07:31:25AM +0200, Juerg Haefliger wrote: >> >> >> On 08/23/2017 07:04 PM, Mark Rutland wrote: >>> On Wed, Aug 23, 2017 at 10:58:42AM -0600, Tycho Andersen wrote: Hi Mark, On Mon, Aug 14, 2017 at 05:50:47PM

Re: [kernel-hardening] [PATCH v5 04/10] arm64: Add __flush_tlb_one()

2017-08-30 Thread Tycho Andersen
On Wed, Aug 30, 2017 at 07:31:25AM +0200, Juerg Haefliger wrote: > > > On 08/23/2017 07:04 PM, Mark Rutland wrote: > > On Wed, Aug 23, 2017 at 10:58:42AM -0600, Tycho Andersen wrote: > >> Hi Mark, > >> > >> On Mon, Aug 14, 2017 at 05:50:47PM +0100, Mark Rutland wrote: > >>> That said, is there

Re: [kernel-hardening] [PATCH v5 04/10] arm64: Add __flush_tlb_one()

2017-08-30 Thread Tycho Andersen
On Wed, Aug 30, 2017 at 07:31:25AM +0200, Juerg Haefliger wrote: > > > On 08/23/2017 07:04 PM, Mark Rutland wrote: > > On Wed, Aug 23, 2017 at 10:58:42AM -0600, Tycho Andersen wrote: > >> Hi Mark, > >> > >> On Mon, Aug 14, 2017 at 05:50:47PM +0100, Mark Rutland wrote: > >>> That said, is there

Re: [kernel-hardening] [PATCH v5 04/10] arm64: Add __flush_tlb_one()

2017-08-29 Thread Juerg Haefliger
On 08/23/2017 07:04 PM, Mark Rutland wrote: > On Wed, Aug 23, 2017 at 10:58:42AM -0600, Tycho Andersen wrote: >> Hi Mark, >> >> On Mon, Aug 14, 2017 at 05:50:47PM +0100, Mark Rutland wrote: >>> That said, is there any reason not to use flush_tlb_kernel_range() >>> directly? >> >> So it turns out

Re: [kernel-hardening] [PATCH v5 04/10] arm64: Add __flush_tlb_one()

2017-08-29 Thread Juerg Haefliger
On 08/23/2017 07:04 PM, Mark Rutland wrote: > On Wed, Aug 23, 2017 at 10:58:42AM -0600, Tycho Andersen wrote: >> Hi Mark, >> >> On Mon, Aug 14, 2017 at 05:50:47PM +0100, Mark Rutland wrote: >>> That said, is there any reason not to use flush_tlb_kernel_range() >>> directly? >> >> So it turns out

Re: [kernel-hardening] [PATCH v5 04/10] arm64: Add __flush_tlb_one()

2017-08-29 Thread Tycho Andersen
Hi Mark, On Thu, Aug 24, 2017 at 04:45:19PM +0100, Mark Rutland wrote: > On Wed, Aug 23, 2017 at 11:13:02AM -0600, Tycho Andersen wrote: > > On Wed, Aug 23, 2017 at 06:04:43PM +0100, Mark Rutland wrote: > > > On Wed, Aug 23, 2017 at 10:58:42AM -0600, Tycho Andersen wrote: > > > > Hi Mark, > > > >

Re: [kernel-hardening] [PATCH v5 04/10] arm64: Add __flush_tlb_one()

2017-08-29 Thread Tycho Andersen
Hi Mark, On Thu, Aug 24, 2017 at 04:45:19PM +0100, Mark Rutland wrote: > On Wed, Aug 23, 2017 at 11:13:02AM -0600, Tycho Andersen wrote: > > On Wed, Aug 23, 2017 at 06:04:43PM +0100, Mark Rutland wrote: > > > On Wed, Aug 23, 2017 at 10:58:42AM -0600, Tycho Andersen wrote: > > > > Hi Mark, > > > >

Re: [kernel-hardening] [PATCH v5 04/10] arm64: Add __flush_tlb_one()

2017-08-24 Thread Mark Rutland
On Wed, Aug 23, 2017 at 11:13:02AM -0600, Tycho Andersen wrote: > On Wed, Aug 23, 2017 at 06:04:43PM +0100, Mark Rutland wrote: > > On Wed, Aug 23, 2017 at 10:58:42AM -0600, Tycho Andersen wrote: > > > Hi Mark, > > > > > > On Mon, Aug 14, 2017 at 05:50:47PM +0100, Mark Rutland wrote: > > > > That

Re: [kernel-hardening] [PATCH v5 04/10] arm64: Add __flush_tlb_one()

2017-08-24 Thread Mark Rutland
On Wed, Aug 23, 2017 at 11:13:02AM -0600, Tycho Andersen wrote: > On Wed, Aug 23, 2017 at 06:04:43PM +0100, Mark Rutland wrote: > > On Wed, Aug 23, 2017 at 10:58:42AM -0600, Tycho Andersen wrote: > > > Hi Mark, > > > > > > On Mon, Aug 14, 2017 at 05:50:47PM +0100, Mark Rutland wrote: > > > > That

Re: [kernel-hardening] [PATCH v5 04/10] arm64: Add __flush_tlb_one()

2017-08-23 Thread Tycho Andersen
On Wed, Aug 23, 2017 at 06:04:43PM +0100, Mark Rutland wrote: > On Wed, Aug 23, 2017 at 10:58:42AM -0600, Tycho Andersen wrote: > > Hi Mark, > > > > On Mon, Aug 14, 2017 at 05:50:47PM +0100, Mark Rutland wrote: > > > That said, is there any reason not to use flush_tlb_kernel_range() > > >

Re: [kernel-hardening] [PATCH v5 04/10] arm64: Add __flush_tlb_one()

2017-08-23 Thread Tycho Andersen
On Wed, Aug 23, 2017 at 06:04:43PM +0100, Mark Rutland wrote: > On Wed, Aug 23, 2017 at 10:58:42AM -0600, Tycho Andersen wrote: > > Hi Mark, > > > > On Mon, Aug 14, 2017 at 05:50:47PM +0100, Mark Rutland wrote: > > > That said, is there any reason not to use flush_tlb_kernel_range() > > >

Re: [kernel-hardening] [PATCH v5 04/10] arm64: Add __flush_tlb_one()

2017-08-23 Thread Mark Rutland
On Wed, Aug 23, 2017 at 10:58:42AM -0600, Tycho Andersen wrote: > Hi Mark, > > On Mon, Aug 14, 2017 at 05:50:47PM +0100, Mark Rutland wrote: > > That said, is there any reason not to use flush_tlb_kernel_range() > > directly? > > So it turns out that there is a difference between

Re: [kernel-hardening] [PATCH v5 04/10] arm64: Add __flush_tlb_one()

2017-08-23 Thread Mark Rutland
On Wed, Aug 23, 2017 at 10:58:42AM -0600, Tycho Andersen wrote: > Hi Mark, > > On Mon, Aug 14, 2017 at 05:50:47PM +0100, Mark Rutland wrote: > > That said, is there any reason not to use flush_tlb_kernel_range() > > directly? > > So it turns out that there is a difference between

Re: [kernel-hardening] [PATCH v5 04/10] arm64: Add __flush_tlb_one()

2017-08-23 Thread Tycho Andersen
Hi Mark, On Mon, Aug 14, 2017 at 05:50:47PM +0100, Mark Rutland wrote: > That said, is there any reason not to use flush_tlb_kernel_range() > directly? So it turns out that there is a difference between __flush_tlb_one() and flush_tlb_kernel_range() on x86: flush_tlb_kernel_range() flushes all

Re: [kernel-hardening] [PATCH v5 04/10] arm64: Add __flush_tlb_one()

2017-08-23 Thread Tycho Andersen
Hi Mark, On Mon, Aug 14, 2017 at 05:50:47PM +0100, Mark Rutland wrote: > That said, is there any reason not to use flush_tlb_kernel_range() > directly? So it turns out that there is a difference between __flush_tlb_one() and flush_tlb_kernel_range() on x86: flush_tlb_kernel_range() flushes all

Re: [kernel-hardening] [PATCH v5 04/10] arm64: Add __flush_tlb_one()

2017-08-14 Thread Tycho Andersen
On Mon, Aug 14, 2017 at 05:50:47PM +0100, Mark Rutland wrote: > On Mon, Aug 14, 2017 at 10:35:36AM -0600, Tycho Andersen wrote: > > Hi Mark, > > > > On Sat, Aug 12, 2017 at 12:26:03PM +0100, Mark Rutland wrote: > > > On Wed, Aug 09, 2017 at 02:07:49PM -0600, Tycho Andersen wrote: > > > > +static

Re: [kernel-hardening] [PATCH v5 04/10] arm64: Add __flush_tlb_one()

2017-08-14 Thread Tycho Andersen
On Mon, Aug 14, 2017 at 05:50:47PM +0100, Mark Rutland wrote: > On Mon, Aug 14, 2017 at 10:35:36AM -0600, Tycho Andersen wrote: > > Hi Mark, > > > > On Sat, Aug 12, 2017 at 12:26:03PM +0100, Mark Rutland wrote: > > > On Wed, Aug 09, 2017 at 02:07:49PM -0600, Tycho Andersen wrote: > > > > +static

Re: [kernel-hardening] [PATCH v5 04/10] arm64: Add __flush_tlb_one()

2017-08-14 Thread Mark Rutland
On Mon, Aug 14, 2017 at 10:35:36AM -0600, Tycho Andersen wrote: > Hi Mark, > > On Sat, Aug 12, 2017 at 12:26:03PM +0100, Mark Rutland wrote: > > On Wed, Aug 09, 2017 at 02:07:49PM -0600, Tycho Andersen wrote: > > > +static inline void __flush_tlb_one(unsigned long addr) > > > +{ > > > +

Re: [kernel-hardening] [PATCH v5 04/10] arm64: Add __flush_tlb_one()

2017-08-14 Thread Mark Rutland
On Mon, Aug 14, 2017 at 10:35:36AM -0600, Tycho Andersen wrote: > Hi Mark, > > On Sat, Aug 12, 2017 at 12:26:03PM +0100, Mark Rutland wrote: > > On Wed, Aug 09, 2017 at 02:07:49PM -0600, Tycho Andersen wrote: > > > +static inline void __flush_tlb_one(unsigned long addr) > > > +{ > > > +

Re: [kernel-hardening] [PATCH v5 04/10] arm64: Add __flush_tlb_one()

2017-08-14 Thread Tycho Andersen
Hi Mark, On Sat, Aug 12, 2017 at 12:26:03PM +0100, Mark Rutland wrote: > On Wed, Aug 09, 2017 at 02:07:49PM -0600, Tycho Andersen wrote: > > From: Juerg Haefliger > > > > Add a hook for flushing a single TLB entry on arm64. > > > > Signed-off-by: Juerg Haefliger

Re: [kernel-hardening] [PATCH v5 04/10] arm64: Add __flush_tlb_one()

2017-08-14 Thread Tycho Andersen
Hi Mark, On Sat, Aug 12, 2017 at 12:26:03PM +0100, Mark Rutland wrote: > On Wed, Aug 09, 2017 at 02:07:49PM -0600, Tycho Andersen wrote: > > From: Juerg Haefliger > > > > Add a hook for flushing a single TLB entry on arm64. > > > > Signed-off-by: Juerg Haefliger > > Tested-by: Tycho Andersen

Re: [kernel-hardening] [PATCH v5 04/10] arm64: Add __flush_tlb_one()

2017-08-12 Thread Mark Rutland
On Wed, Aug 09, 2017 at 02:07:49PM -0600, Tycho Andersen wrote: > From: Juerg Haefliger > > Add a hook for flushing a single TLB entry on arm64. > > Signed-off-by: Juerg Haefliger > Tested-by: Tycho Andersen > --- >

Re: [kernel-hardening] [PATCH v5 04/10] arm64: Add __flush_tlb_one()

2017-08-12 Thread Mark Rutland
On Wed, Aug 09, 2017 at 02:07:49PM -0600, Tycho Andersen wrote: > From: Juerg Haefliger > > Add a hook for flushing a single TLB entry on arm64. > > Signed-off-by: Juerg Haefliger > Tested-by: Tycho Andersen > --- > arch/arm64/include/asm/tlbflush.h | 8 > 1 file changed, 8