Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-03-17 Thread Lee Revell
On Sat, 2005-02-19 at 15:45 -0500, Lee Revell wrote: > On Sat, 2005-02-19 at 10:03 +0100, Ingo Molnar wrote: > > * Ingo Molnar <[EMAIL PROTECTED]> wrote: > > > > > > Testing on an all SCSI 1.3Ghz Athlon XP system, I am seeing very long > > > > latencies in the journalling code with

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-03-17 Thread Lee Revell
On Sat, 2005-02-19 at 15:45 -0500, Lee Revell wrote: On Sat, 2005-02-19 at 10:03 +0100, Ingo Molnar wrote: * Ingo Molnar [EMAIL PROTECTED] wrote: Testing on an all SCSI 1.3Ghz Athlon XP system, I am seeing very long latencies in the journalling code with 2.6.11-rc4-RT-V0.7.39-02.

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-03-16 Thread Lee Revell
On Wed, 2005-03-16 at 02:50 -0500, Steven Rostedt wrote: > > On Tue, 15 Mar 2005, Lee Revell wrote: > > > On Tue, 2005-03-15 at 13:05 -0500, Steven Rostedt wrote: > > > Damn! The answer was right there in front of my eyes! Here's the cleanest > > > solution. I forgot about wait_on_bit_lock.

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-03-16 Thread Andrew Morton
Ingo Molnar <[EMAIL PROTECTED]> wrote: > > > * Steven Rostedt <[EMAIL PROTECTED]> wrote: > > > Damn! The answer was right there in front of my eyes! Here's the > > cleanest solution. I forgot about wait_on_bit_lock. I've converted > > all the locks to use this instead. [...] > > ah, indeed,

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-03-16 Thread Ingo Molnar
* Steven Rostedt <[EMAIL PROTECTED]> wrote: > Damn! The answer was right there in front of my eyes! Here's the > cleanest solution. I forgot about wait_on_bit_lock. I've converted > all the locks to use this instead. [...] ah, indeed, this looks really nifty. Andrew? Ingo - To

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-03-16 Thread Ingo Molnar
* Steven Rostedt [EMAIL PROTECTED] wrote: Damn! The answer was right there in front of my eyes! Here's the cleanest solution. I forgot about wait_on_bit_lock. I've converted all the locks to use this instead. [...] ah, indeed, this looks really nifty. Andrew? Ingo - To unsubscribe

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-03-16 Thread Andrew Morton
Ingo Molnar [EMAIL PROTECTED] wrote: * Steven Rostedt [EMAIL PROTECTED] wrote: Damn! The answer was right there in front of my eyes! Here's the cleanest solution. I forgot about wait_on_bit_lock. I've converted all the locks to use this instead. [...] ah, indeed, this looks really

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-03-16 Thread Lee Revell
On Wed, 2005-03-16 at 02:50 -0500, Steven Rostedt wrote: On Tue, 15 Mar 2005, Lee Revell wrote: On Tue, 2005-03-15 at 13:05 -0500, Steven Rostedt wrote: Damn! The answer was right there in front of my eyes! Here's the cleanest solution. I forgot about wait_on_bit_lock. I've converted

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-03-15 Thread Steven Rostedt
On Tue, 15 Mar 2005, Lee Revell wrote: > On Tue, 2005-03-15 at 13:05 -0500, Steven Rostedt wrote: > > Damn! The answer was right there in front of my eyes! Here's the cleanest > > solution. I forgot about wait_on_bit_lock. I've converted all the locks > > to use this instead. We probably need

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-03-15 Thread Steven Rostedt
On Tue, 15 Mar 2005, Steven Rostedt wrote: > > > On Tue, 15 Mar 2005, Ingo Molnar wrote: > > > > i'd go for removing bit-spinlocks altogether, in the upstream kernel. It > > would simplify things, besides making PREEMPT_RT simpler as well. The > > memory overhead is not a big issue i believe.

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-03-15 Thread Lee Revell
On Tue, 2005-03-15 at 13:05 -0500, Steven Rostedt wrote: > Damn! The answer was right there in front of my eyes! Here's the cleanest > solution. I forgot about wait_on_bit_lock. I've converted all the locks > to use this instead. We probably need to get priority inheritence working > on this too

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-03-15 Thread Andrew Morton
Steven Rostedt <[EMAIL PROTECTED]> wrote: > > The problem here is that it's not ext3 bh's only. They're still the normal > buffer head. The problem arrises because the ext3 "journal head" is > allocated within these bit spin locks. Yes, the locks do want to live inside the buffer_head.

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-03-15 Thread Steven Rostedt
On Tue, 15 Mar 2005, Ingo Molnar wrote: > > i'd go for removing bit-spinlocks altogether, in the upstream kernel. It > would simplify things, besides making PREEMPT_RT simpler as well. The > memory overhead is not a big issue i believe. (8 more bytes per ext3 bh, > on x86) > Hi Ingo, Damn! The

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-03-15 Thread Steven Rostedt
On Tue, 15 Mar 2005, Ingo Molnar wrote: > > * Steven Rostedt <[EMAIL PROTECTED]> wrote: > > > > What should we use instead of #ifdef PREEMPT_RT? Or should we just > > keep it the same for both. Since this fix is only to fix spinlocks > > that schedule, I figured that it would be better not to

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-03-15 Thread Ingo Molnar
* Steven Rostedt <[EMAIL PROTECTED]> wrote: > > good progress - but the global lock may be a scalability worry on > > upstream though. Would it be possible to just mirror much of the current > > lock logic, but with spinlocks instead of bitlocks? And there should be > > no #ifdefs on PREEMPT_RT.

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-03-15 Thread Steven Rostedt
On Tue, 15 Mar 2005, Ingo Molnar wrote: > > * Steven Rostedt <[EMAIL PROTECTED]> wrote: > > > I've realized that my previous patch had too many problems with the > > way the journaling system works. So I went back to my first approach > > but added the journal_head lock as one global lock to

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-03-15 Thread Ingo Molnar
* Steven Rostedt <[EMAIL PROTECTED]> wrote: > I've realized that my previous patch had too many problems with the > way the journaling system works. So I went back to my first approach > but added the journal_head lock as one global lock to keep the buffer > head size smaller. I only added the

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-03-15 Thread Steven Rostedt
I've realized that my previous patch had too many problems with the way the journaling system works. So I went back to my first approach but added the journal_head lock as one global lock to keep the buffer head size smaller. I only added the state lock to the buffer head. I've tested this for

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-03-15 Thread Steven Rostedt
I've realized that my previous patch had too many problems with the way the journaling system works. So I went back to my first approach but added the journal_head lock as one global lock to keep the buffer head size smaller. I only added the state lock to the buffer head. I've tested this for

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-03-15 Thread Ingo Molnar
* Steven Rostedt [EMAIL PROTECTED] wrote: I've realized that my previous patch had too many problems with the way the journaling system works. So I went back to my first approach but added the journal_head lock as one global lock to keep the buffer head size smaller. I only added the state

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-03-15 Thread Steven Rostedt
On Tue, 15 Mar 2005, Ingo Molnar wrote: * Steven Rostedt [EMAIL PROTECTED] wrote: I've realized that my previous patch had too many problems with the way the journaling system works. So I went back to my first approach but added the journal_head lock as one global lock to keep the

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-03-15 Thread Ingo Molnar
* Steven Rostedt [EMAIL PROTECTED] wrote: good progress - but the global lock may be a scalability worry on upstream though. Would it be possible to just mirror much of the current lock logic, but with spinlocks instead of bitlocks? And there should be no #ifdefs on PREEMPT_RT. The

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-03-15 Thread Steven Rostedt
On Tue, 15 Mar 2005, Ingo Molnar wrote: * Steven Rostedt [EMAIL PROTECTED] wrote: What should we use instead of #ifdef PREEMPT_RT? Or should we just keep it the same for both. Since this fix is only to fix spinlocks that schedule, I figured that it would be better not to waste the

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-03-15 Thread Steven Rostedt
On Tue, 15 Mar 2005, Ingo Molnar wrote: i'd go for removing bit-spinlocks altogether, in the upstream kernel. It would simplify things, besides making PREEMPT_RT simpler as well. The memory overhead is not a big issue i believe. (8 more bytes per ext3 bh, on x86) Hi Ingo, Damn! The

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-03-15 Thread Andrew Morton
Steven Rostedt [EMAIL PROTECTED] wrote: The problem here is that it's not ext3 bh's only. They're still the normal buffer head. The problem arrises because the ext3 journal head is allocated within these bit spin locks. Yes, the locks do want to live inside the buffer_head. Stephen has

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-03-15 Thread Lee Revell
On Tue, 2005-03-15 at 13:05 -0500, Steven Rostedt wrote: Damn! The answer was right there in front of my eyes! Here's the cleanest solution. I forgot about wait_on_bit_lock. I've converted all the locks to use this instead. We probably need to get priority inheritence working on this too

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-03-15 Thread Steven Rostedt
On Tue, 15 Mar 2005, Steven Rostedt wrote: On Tue, 15 Mar 2005, Ingo Molnar wrote: i'd go for removing bit-spinlocks altogether, in the upstream kernel. It would simplify things, besides making PREEMPT_RT simpler as well. The memory overhead is not a big issue i believe. (8 more

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-03-15 Thread Steven Rostedt
On Tue, 15 Mar 2005, Lee Revell wrote: On Tue, 2005-03-15 at 13:05 -0500, Steven Rostedt wrote: Damn! The answer was right there in front of my eyes! Here's the cleanest solution. I forgot about wait_on_bit_lock. I've converted all the locks to use this instead. We probably need to get

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-03-14 Thread Steven Rostedt
Hi Ingo, I've found something that is very interesting and I can't explain it. On Mon, 14 Mar 2005, Steven Rostedt wrote: > > > On Mon, 14 Mar 2005, Steven Rostedt wrote: > > > > On Mon, 14 Mar 2005, Steven Rostedt wrote: > > > > > > I just downloaded -40 and applied my patch, compiled it with

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-03-14 Thread Steven Rostedt
On Mon, 14 Mar 2005, Steven Rostedt wrote: > > On Mon, 14 Mar 2005, Steven Rostedt wrote: > > > > I just downloaded -40 and applied my patch, compiled it with > > PREEMPT_DESKTOP and data=ordered, ran it and everything seems OK, except > > I'm getting the following... > > > > BUG: Unable to

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-03-14 Thread Steven Rostedt
On Mon, 14 Mar 2005, Steven Rostedt wrote: > > I just downloaded -40 and applied my patch, compiled it with > PREEMPT_DESKTOP and data=ordered, ran it and everything seems OK, except > I'm getting the following... > > BUG: Unable to handle kernel NULL pointer dereference at virtual address >

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-03-14 Thread Steven Rostedt
On Mon, 14 Mar 2005, Steven Rostedt wrote: > > > > I'll test this with PREEMPT_DESKTOP and data=ordered also and see how it > > > goes. > > > > Does not seem to work at all with the above settings. It seemed OK > > until I started X. Then every time I launched an xterm it would > > disappear

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-03-14 Thread Steven Rostedt
On Mon, 14 Mar 2005, Steven Rostedt wrote: I'll test this with PREEMPT_DESKTOP and data=ordered also and see how it goes. Does not seem to work at all with the above settings. It seemed OK until I started X. Then every time I launched an xterm it would disappear as soon as I

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-03-14 Thread Steven Rostedt
On Mon, 14 Mar 2005, Steven Rostedt wrote: I just downloaded -40 and applied my patch, compiled it with PREEMPT_DESKTOP and data=ordered, ran it and everything seems OK, except I'm getting the following... BUG: Unable to handle kernel NULL pointer dereference at virtual address

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-03-14 Thread Steven Rostedt
On Mon, 14 Mar 2005, Steven Rostedt wrote: On Mon, 14 Mar 2005, Steven Rostedt wrote: I just downloaded -40 and applied my patch, compiled it with PREEMPT_DESKTOP and data=ordered, ran it and everything seems OK, except I'm getting the following... BUG: Unable to handle kernel NULL

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-03-14 Thread Steven Rostedt
Hi Ingo, I've found something that is very interesting and I can't explain it. On Mon, 14 Mar 2005, Steven Rostedt wrote: On Mon, 14 Mar 2005, Steven Rostedt wrote: On Mon, 14 Mar 2005, Steven Rostedt wrote: I just downloaded -40 and applied my patch, compiled it with

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-03-13 Thread Steven Rostedt
On Fri, 11 Mar 2005, Lee Revell wrote: > On Fri, 2005-03-11 at 15:46 -0500, Lee Revell wrote: > > On Fri, 2005-03-11 at 15:39 -0500, Steven Rostedt wrote: > > > I'm leaving now for the weekend, so I won't be able to respond to anyone > > > till Monday. I'll also run this patch over the weekend

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-03-13 Thread Steven Rostedt
On Fri, 11 Mar 2005, Lee Revell wrote: On Fri, 2005-03-11 at 15:46 -0500, Lee Revell wrote: On Fri, 2005-03-11 at 15:39 -0500, Steven Rostedt wrote: I'm leaving now for the weekend, so I won't be able to respond to anyone till Monday. I'll also run this patch over the weekend while

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-03-11 Thread Lee Revell
On Fri, 2005-03-11 at 15:46 -0500, Lee Revell wrote: > On Fri, 2005-03-11 at 15:39 -0500, Steven Rostedt wrote: > > I'm leaving now for the weekend, so I won't be able to respond to anyone > > till Monday. I'll also run this patch over the weekend while compiling > > the kernel in an endless loop

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-03-11 Thread Lee Revell
On Fri, 2005-03-11 at 15:39 -0500, Steven Rostedt wrote: > I'm leaving now for the weekend, so I won't be able to respond to anyone > till Monday. I'll also run this patch over the weekend while compiling > the kernel in an endless loop I'll test this with PREEMPT_DESKTOP and data=ordered also

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-03-11 Thread Steven Rostedt
On Fri, 11 Mar 2005, Ingo Molnar wrote: > > * Steven Rostedt <[EMAIL PROTECTED]> wrote: > > > Here's the patch. It's probably more of an overkill wrt buffer heads, > > but it seems to be the easiest solution. > > isnt there some ext3-private journal structure (journal-bh) linked off > the bh?

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-03-11 Thread Steven Rostedt
On Fri, 11 Mar 2005, Ingo Molnar wrote: > > * Steven Rostedt <[EMAIL PROTECTED]> wrote: > > > Here's the patch. It's probably more of an overkill wrt buffer heads, > > but it seems to be the easiest solution. > > isnt there some ext3-private journal structure (journal-bh) linked off > the bh? If

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-03-11 Thread Ingo Molnar
* Steven Rostedt <[EMAIL PROTECTED]> wrote: > Here's the patch. It's probably more of an overkill wrt buffer heads, > but it seems to be the easiest solution. isnt there some ext3-private journal structure (journal-bh) linked off the bh? If the lock is in that structure then the overhead would

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-03-11 Thread K.R. Foley
Steven Rostedt wrote: +#ifdef CONFIG_PREEMPT_RT +#define PICK_SPIN_LOCK(otype,bit,name) spin_##otype(>b_##name##_lock) +#else +#define PICK_SPIN_LOCK(otype,bit,name) bit_spin_##otype(bit,bh->b_state); +#endif + Oops, extra semicolon on the non RT side. I'll try again. -- Steve Haven't tried it

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-03-11 Thread Steven Rostedt
> > +#ifdef CONFIG_PREEMPT_RT > +#define PICK_SPIN_LOCK(otype,bit,name) spin_##otype(>b_##name##_lock) > +#else > +#define PICK_SPIN_LOCK(otype,bit,name) bit_spin_##otype(bit,bh->b_state); > +#endif > + Oops, extra semicolon on the non RT side. I'll try again. -- Steve diff -ur

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-03-11 Thread Steven Rostedt
Here's the patch. It's probably more of an overkill wrt buffer heads, but it seems to be the easiest solution. I also put back some of the changes you made for the bit_spin_locks, so that they act the same as the vanilla kernel if PREEMPT_RT is not defined. Now I only tested this with

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-03-11 Thread Steven Rostedt
On Fri, 11 Mar 2005, Andrew Morton wrote: > Steven Rostedt <[EMAIL PROTECTED]> wrote: > > No, I'll try that now. I just didn't want to modify the buffer head struct > > just for journaling. But if it is the quickest and easiest fix, then I'll > > submit it and we can change it later. > >

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-03-11 Thread Andrew Morton
Steven Rostedt <[EMAIL PROTECTED]> wrote: > > > did you try the canonical way of putting a spinlock into every > > buffer_head? > > > > No, I'll try that now. I just didn't want to modify the buffer head struct > just for journaling. But if it is the quickest and easiest fix, then I'll >

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-03-11 Thread Ingo Molnar
* Steven Rostedt <[EMAIL PROTECTED]> wrote: > > > Doing a quick search on the kernel, it looks like only kjournald uses > > > the bit_spin_locks. I'll start converting them to spinlocks. The use > > > seems to be more of a hack, since it is using bits in the state field > > > for locking, and

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-03-11 Thread Steven Rostedt
On Fri, 11 Mar 2005, Ingo Molnar wrote: > > * Steven Rostedt <[EMAIL PROTECTED]> wrote: > > > > The short term fix is probably to put back the preempt_disables, the long > > > term is to get rid of these stupid bit_spin_lock busy loops. > > > > Doing a quick search on the kernel, it looks like

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-03-11 Thread Ingo Molnar
* Steven Rostedt <[EMAIL PROTECTED]> wrote: > > The short term fix is probably to put back the preempt_disables, the long > > term is to get rid of these stupid bit_spin_lock busy loops. > > Doing a quick search on the kernel, it looks like only kjournald uses > the bit_spin_locks. I'll start

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-03-11 Thread Ingo Molnar
* Steven Rostedt [EMAIL PROTECTED] wrote: The short term fix is probably to put back the preempt_disables, the long term is to get rid of these stupid bit_spin_lock busy loops. Doing a quick search on the kernel, it looks like only kjournald uses the bit_spin_locks. I'll start converting

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-03-11 Thread Steven Rostedt
On Fri, 11 Mar 2005, Ingo Molnar wrote: * Steven Rostedt [EMAIL PROTECTED] wrote: The short term fix is probably to put back the preempt_disables, the long term is to get rid of these stupid bit_spin_lock busy loops. Doing a quick search on the kernel, it looks like only kjournald

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-03-11 Thread Ingo Molnar
* Steven Rostedt [EMAIL PROTECTED] wrote: Doing a quick search on the kernel, it looks like only kjournald uses the bit_spin_locks. I'll start converting them to spinlocks. The use seems to be more of a hack, since it is using bits in the state field for locking, and these bits

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-03-11 Thread Andrew Morton
Steven Rostedt [EMAIL PROTECTED] wrote: did you try the canonical way of putting a spinlock into every buffer_head? No, I'll try that now. I just didn't want to modify the buffer head struct just for journaling. But if it is the quickest and easiest fix, then I'll submit it and

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-03-11 Thread Steven Rostedt
On Fri, 11 Mar 2005, Andrew Morton wrote: Steven Rostedt [EMAIL PROTECTED] wrote: No, I'll try that now. I just didn't want to modify the buffer head struct just for journaling. But if it is the quickest and easiest fix, then I'll submit it and we can change it later. You'll need

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-03-11 Thread Steven Rostedt
Here's the patch. It's probably more of an overkill wrt buffer heads, but it seems to be the easiest solution. I also put back some of the changes you made for the bit_spin_locks, so that they act the same as the vanilla kernel if PREEMPT_RT is not defined. Now I only tested this with

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-03-11 Thread Steven Rostedt
+#ifdef CONFIG_PREEMPT_RT +#define PICK_SPIN_LOCK(otype,bit,name) spin_##otype(bh-b_##name##_lock) +#else +#define PICK_SPIN_LOCK(otype,bit,name) bit_spin_##otype(bit,bh-b_state); +#endif + Oops, extra semicolon on the non RT side. I'll try again. -- Steve diff -ur

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-03-11 Thread K.R. Foley
Steven Rostedt wrote: +#ifdef CONFIG_PREEMPT_RT +#define PICK_SPIN_LOCK(otype,bit,name) spin_##otype(bh-b_##name##_lock) +#else +#define PICK_SPIN_LOCK(otype,bit,name) bit_spin_##otype(bit,bh-b_state); +#endif + Oops, extra semicolon on the non RT side. I'll try again. -- Steve Haven't tried it

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-03-11 Thread Ingo Molnar
* Steven Rostedt [EMAIL PROTECTED] wrote: Here's the patch. It's probably more of an overkill wrt buffer heads, but it seems to be the easiest solution. isnt there some ext3-private journal structure (journal-bh) linked off the bh? If the lock is in that structure then the overhead would

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-03-11 Thread Steven Rostedt
On Fri, 11 Mar 2005, Ingo Molnar wrote: * Steven Rostedt [EMAIL PROTECTED] wrote: Here's the patch. It's probably more of an overkill wrt buffer heads, but it seems to be the easiest solution. isnt there some ext3-private journal structure (journal-bh) linked off the bh? If the lock is

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-03-11 Thread Steven Rostedt
On Fri, 11 Mar 2005, Ingo Molnar wrote: * Steven Rostedt [EMAIL PROTECTED] wrote: Here's the patch. It's probably more of an overkill wrt buffer heads, but it seems to be the easiest solution. isnt there some ext3-private journal structure (journal-bh) linked off the bh? If the lock

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-03-11 Thread Lee Revell
On Fri, 2005-03-11 at 15:39 -0500, Steven Rostedt wrote: I'm leaving now for the weekend, so I won't be able to respond to anyone till Monday. I'll also run this patch over the weekend while compiling the kernel in an endless loop I'll test this with PREEMPT_DESKTOP and data=ordered also and

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-03-11 Thread Lee Revell
On Fri, 2005-03-11 at 15:46 -0500, Lee Revell wrote: On Fri, 2005-03-11 at 15:39 -0500, Steven Rostedt wrote: I'm leaving now for the weekend, so I won't be able to respond to anyone till Monday. I'll also run this patch over the weekend while compiling the kernel in an endless loop

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-03-10 Thread Steven Rostedt
On Thu, 10 Mar 2005, Steven Rostedt wrote: > The short term fix is probably to put back the preempt_disables, the long > term is to get rid of these stupid bit_spin_lock busy loops. > Doing a quick search on the kernel, it looks like only kjournald uses the bit_spin_locks. I'll start converting

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-03-10 Thread Steven Rostedt
Hi Ingo, I notice a problem with the bit_spin_locks that would probably explain the kjournald latency problems. I'm working on a custom kernel based on your's and I needed to temporarily remove the scheduler_tick from update_process_times to implement some special scheduling needs. This caused

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-03-10 Thread Steven Rostedt
Hi Ingo, I notice a problem with the bit_spin_locks that would probably explain the kjournald latency problems. I'm working on a custom kernel based on your's and I needed to temporarily remove the scheduler_tick from update_process_times to implement some special scheduling needs. This caused

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-03-10 Thread Steven Rostedt
On Thu, 10 Mar 2005, Steven Rostedt wrote: The short term fix is probably to put back the preempt_disables, the long term is to get rid of these stupid bit_spin_lock busy loops. Doing a quick search on the kernel, it looks like only kjournald uses the bit_spin_locks. I'll start converting

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-02-22 Thread Lee Revell
On Sat, 2005-02-19 at 10:03 +0100, Ingo Molnar wrote: > * Ingo Molnar <[EMAIL PROTECTED]> wrote: > > > > Testing on an all SCSI 1.3Ghz Athlon XP system, I am seeing very long > > > latencies in the journalling code with 2.6.11-rc4-RT-V0.7.39-02. > > > > could you send me the full trace? > On

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-02-22 Thread Lee Revell
On Sat, 2005-02-19 at 10:03 +0100, Ingo Molnar wrote: * Ingo Molnar [EMAIL PROTECTED] wrote: Testing on an all SCSI 1.3Ghz Athlon XP system, I am seeing very long latencies in the journalling code with 2.6.11-rc4-RT-V0.7.39-02. could you send me the full trace? On my other machine

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-02-19 Thread Lee Revell
On Sat, 2005-02-19 at 15:45 -0500, Lee Revell wrote: > I have not tried "data=journal". As previously stated "data=writeback" > works perfectly - I ran JACK overnight while stressing the fs and did > not get one xrun. "data=journal" has the same good performance as "data=writeback". Only the

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-02-19 Thread Ingo Molnar
* Lee Revell <[EMAIL PROTECTED]> wrote: > On Fri, 2005-02-04 at 11:03 +0100, Ingo Molnar wrote: > > http://redhat.com/~mingo/realtime-preempt/ > > > > Testing on an all SCSI 1.3Ghz Athlon XP system, I am seeing very long > latencies in the journalling code with 2.6.11-rc4-RT-V0.7.39-02.

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-02-19 Thread Ingo Molnar
* Ingo Molnar <[EMAIL PROTECTED]> wrote: > > Testing on an all SCSI 1.3Ghz Athlon XP system, I am seeing very long > > latencies in the journalling code with 2.6.11-rc4-RT-V0.7.39-02. > > could you send me the full trace? just in case the system in question is still running - could you also do

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-02-19 Thread Ingo Molnar
* Ingo Molnar [EMAIL PROTECTED] wrote: Testing on an all SCSI 1.3Ghz Athlon XP system, I am seeing very long latencies in the journalling code with 2.6.11-rc4-RT-V0.7.39-02. could you send me the full trace? just in case the system in question is still running - could you also do a

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-02-19 Thread Ingo Molnar
* Lee Revell [EMAIL PROTECTED] wrote: On Fri, 2005-02-04 at 11:03 +0100, Ingo Molnar wrote: http://redhat.com/~mingo/realtime-preempt/ Testing on an all SCSI 1.3Ghz Athlon XP system, I am seeing very long latencies in the journalling code with 2.6.11-rc4-RT-V0.7.39-02. could you

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-02-19 Thread Lee Revell
On Sat, 2005-02-19 at 15:45 -0500, Lee Revell wrote: I have not tried data=journal. As previously stated data=writeback works perfectly - I ran JACK overnight while stressing the fs and did not get one xrun. data=journal has the same good performance as data=writeback. Only the ordered data

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-02-18 Thread Lee Revell
On Sat, 2005-02-19 at 00:08 -0500, Lee Revell wrote: > On Fri, 2005-02-04 at 11:03 +0100, Ingo Molnar wrote: > > http://redhat.com/~mingo/realtime-preempt/ > > > > Testing on an all SCSI 1.3Ghz Athlon XP system, I am seeing very long > latencies in the journalling code with

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-02-18 Thread Lee Revell
On Fri, 2005-02-04 at 11:03 +0100, Ingo Molnar wrote: > http://redhat.com/~mingo/realtime-preempt/ > Testing on an all SCSI 1.3Ghz Athlon XP system, I am seeing very long latencies in the journalling code with 2.6.11-rc4-RT-V0.7.39-02. preemption latency trace v1.1.4 on

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-02-18 Thread Lee Revell
On Fri, 2005-02-04 at 11:03 +0100, Ingo Molnar wrote: http://redhat.com/~mingo/realtime-preempt/ Testing on an all SCSI 1.3Ghz Athlon XP system, I am seeing very long latencies in the journalling code with 2.6.11-rc4-RT-V0.7.39-02. preemption latency trace v1.1.4 on 2.6.11-rc4-RT-V0.7.39-02

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-02-18 Thread Lee Revell
On Sat, 2005-02-19 at 00:08 -0500, Lee Revell wrote: On Fri, 2005-02-04 at 11:03 +0100, Ingo Molnar wrote: http://redhat.com/~mingo/realtime-preempt/ Testing on an all SCSI 1.3Ghz Athlon XP system, I am seeing very long latencies in the journalling code with 2.6.11-rc4-RT-V0.7.39-02.

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-02-13 Thread Steven Rostedt
On Sun, 2005-02-13 at 13:59 +0100, Ingo Molnar wrote: > yeah - it's "M" already in fs/proc/array.c, but i missed the sched.c > case. > You also missed the kernel/rt.c case :-) -- Steve Index: kernel/rt.c === --- kernel/rt.c

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-02-13 Thread Ingo Molnar
* Steven Rostedt <[EMAIL PROTECTED]> wrote: > Ingo, > > Here's a trivial patch to help others from freaking out when they see > on a show_trace that most of their processes are TASK_UNINTERRUPTIBLE. thanks, applied it to -39-00. > - static const char *stat_nam[] = { "R", "S", "D", "T",

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-02-13 Thread Ingo Molnar
* Steven Rostedt [EMAIL PROTECTED] wrote: Ingo, Here's a trivial patch to help others from freaking out when they see on a show_trace that most of their processes are TASK_UNINTERRUPTIBLE. thanks, applied it to -39-00. - static const char *stat_nam[] = { R, S, D, T, t, Z, X }; +

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-02-13 Thread Steven Rostedt
On Sun, 2005-02-13 at 13:59 +0100, Ingo Molnar wrote: yeah - it's M already in fs/proc/array.c, but i missed the sched.c case. You also missed the kernel/rt.c case :-) -- Steve Index: kernel/rt.c === --- kernel/rt.c (revision

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-02-11 Thread Steven Rostedt
Ingo, Here's a trivial patch to help others from freaking out when they see on a show_trace that most of their processes are TASK_UNINTERRUPTIBLE. Index: kernel/sched.c === --- kernel/sched.c (revision 75) +++ kernel/sched.c

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-02-11 Thread Ingo Molnar
* Sven Dietrich <[EMAIL PROTECTED]> wrote: > > this patch only changes xtime_lock back and forth - it does > > in no way impact the 'threadedness' of the timer IRQ. (it > > does not move the timer IRQ into an interrupt thread.) > > > > nor do we really want to make it configurable - it's > >

RE: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-02-11 Thread Sven Dietrich
Ingo wrote: > > * Sven Dietrich <[EMAIL PROTECTED]> wrote: > > > This patch adds a config option to allow you to select > whether timer > > IRQ runs in thread or not. > > this patch only changes xtime_lock back and forth - it does > in no way impact the 'threadedness' of the timer IRQ.

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-02-11 Thread Ingo Molnar
* Sven Dietrich <[EMAIL PROTECTED]> wrote: > No, this is not in arm. Here is the patch. > > Index: linux-2.6.10/include/asm-i386/spinlock.h what version do you have? The current released patch is 2.6.11-rc3-V0.7.38-10. Ingo - To unsubscribe from this list: send the line "unsubscribe

RE: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-02-11 Thread Sven Dietrich
l.org > Subject: Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01 > > > > * George Anzinger wrote: > > > Possibly from: > > define __raw_spin_is_locked(x) (*(volatile signed char > *)(&(x)->lock) <= 0) > > #define __raw_spin_unlo

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-02-11 Thread Ingo Molnar
* George Anzinger wrote: > Possibly from: > define __raw_spin_is_locked(x)(*(volatile signed char *)(&(x)->lock) > <= 0) > #define __raw_spin_unlock_wait(x) \ > do { barrier(); } while(__spin_is_locked(x)) > in asm/spinlock.h > > should that be __raw_spin_is_locked(x) instead?

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-02-11 Thread Ingo Molnar
* Sven Dietrich <[EMAIL PROTECTED]> wrote: > This patch adds a config option to allow you to select whether timer > IRQ runs in thread or not. this patch only changes xtime_lock back and forth - it does in no way impact the 'threadedness' of the timer IRQ. (it does not move the timer IRQ into

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-02-11 Thread Ingo Molnar
* Sven Dietrich [EMAIL PROTECTED] wrote: This patch adds a config option to allow you to select whether timer IRQ runs in thread or not. this patch only changes xtime_lock back and forth - it does in no way impact the 'threadedness' of the timer IRQ. (it does not move the timer IRQ into an

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-02-11 Thread Ingo Molnar
* George Anzinger george@mvista.com wrote: Possibly from: define __raw_spin_is_locked(x)(*(volatile signed char *)((x)-lock) = 0) #define __raw_spin_unlock_wait(x) \ do { barrier(); } while(__spin_is_locked(x)) in asm/spinlock.h should that be __raw_spin_is_locked(x)

RE: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-02-11 Thread Sven Dietrich
spin_lock_string \ \n1:\t \ -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Ingo Molnar Sent: Friday, February 11, 2005 12:34 AM To: George Anzinger Cc: William Weston; linux-kernel@vger.kernel.org Subject: Re: [patch] Real-Time Preemption

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-02-11 Thread Ingo Molnar
* Sven Dietrich [EMAIL PROTECTED] wrote: No, this is not in arm. Here is the patch. Index: linux-2.6.10/include/asm-i386/spinlock.h what version do you have? The current released patch is 2.6.11-rc3-V0.7.38-10. Ingo - To unsubscribe from this list: send the line unsubscribe

RE: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-02-11 Thread Sven Dietrich
Ingo wrote: * Sven Dietrich [EMAIL PROTECTED] wrote: This patch adds a config option to allow you to select whether timer IRQ runs in thread or not. this patch only changes xtime_lock back and forth - it does in no way impact the 'threadedness' of the timer IRQ. (it does not

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-02-11 Thread Ingo Molnar
* Sven Dietrich [EMAIL PROTECTED] wrote: this patch only changes xtime_lock back and forth - it does in no way impact the 'threadedness' of the timer IRQ. (it does not move the timer IRQ into an interrupt thread.) nor do we really want to make it configurable - it's non-threaded

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-02-11 Thread Steven Rostedt
Ingo, Here's a trivial patch to help others from freaking out when they see on a show_trace that most of their processes are TASK_UNINTERRUPTIBLE. Index: kernel/sched.c === --- kernel/sched.c (revision 75) +++ kernel/sched.c

Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-02-10 Thread George Anzinger
Molnar Cc: William Weston; linux-kernel@vger.kernel.org Subject: Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01 If I want to write a patch that will work with or without the RT patch applied is the following enough? #ifndef RAW_SPIN_LOCK_UNLOCKED typedef raw_spinlock_t spinlock_t

RE: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

2005-02-10 Thread Sven Dietrich
[EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On Behalf Of > George Anzinger > Sent: Thursday, February 10, 2005 12:21 PM > To: Ingo Molnar > Cc: William Weston; linux-kernel@vger.kernel.org > Subject: Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01 > >

  1   2   >