Re: [patch 1/2] natsemi: Add support for using MII port with no PHY

2007-02-20 Thread Jeff Garzik
Mark Brown wrote: This patch provides code paths which allow the natsemi driver to use the external MII port on the chip but ignore any PHYs that may be attached to it. The link state will be left as it was when the driver started and can be configured via ethtool. Any PHYs that are present can

Re: [patch 1/2] natsemi: Add support for using MII port with no PHY

2007-02-20 Thread Jeff Garzik
Mark Brown wrote: This patch provides code paths which allow the natsemi driver to use the external MII port on the chip but ignore any PHYs that may be attached to it. The link state will be left as it was when the driver started and can be configured via ethtool. Any PHYs that are present can

Re: [patch 1/2] natsemi: Add support for using MII port with no PHY

2007-02-17 Thread Jeff Garzik
Mark Brown wrote: This patch provides code paths which allow the natsemi driver to use the external MII port on the chip but ignore any PHYs that may be attached to it. The link state will be left as it was when the driver started and can be configured via ethtool. Any PHYs that are present can

Re: [patch 1/2] natsemi: Add support for using MII port with no PHY

2007-02-17 Thread Jeff Garzik
Mark Brown wrote: This patch provides code paths which allow the natsemi driver to use the external MII port on the chip but ignore any PHYs that may be attached to it. The link state will be left as it was when the driver started and can be configured via ethtool. Any PHYs that are present can

Re: [patch 1/2] natsemi: Add support for using MII port with no PHY

2007-02-14 Thread Mark Brown
On Wed, Feb 14, 2007 at 03:28:34PM +0200, Ahmed S. Darwish wrote: > A trivial comment actually, Is there a point to write multi-line comments > in two different formats ? No goal in doing that, no - it wasn't a conscious decision. -- "You grabbed my hand and we fell into it, like a daydream -

Re: [patch 1/2] natsemi: Add support for using MII port with no PHY

2007-02-14 Thread Ahmed S. Darwish
On Wed, Feb 14, 2007 at 10:02:04AM +, Mark Brown wrote: > Signed-Off-By: Mark Brown <[EMAIL PROTECTED]> > [...] > - if (np->phy_addr_external == PHY_ADDR_NONE) { > + /* If we're ignoring the PHY it doesn't matter if we can't > + * find one. */ > +

Re: [patch 1/2] natsemi: Add support for using MII port with no PHY

2007-02-14 Thread Ahmed S. Darwish
On Wed, Feb 14, 2007 at 10:02:04AM +, Mark Brown wrote: Signed-Off-By: Mark Brown [EMAIL PROTECTED] [...] - if (np-phy_addr_external == PHY_ADDR_NONE) { + /* If we're ignoring the PHY it doesn't matter if we can't + * find one. */ + if

Re: [patch 1/2] natsemi: Add support for using MII port with no PHY

2007-02-14 Thread Mark Brown
On Wed, Feb 14, 2007 at 03:28:34PM +0200, Ahmed S. Darwish wrote: A trivial comment actually, Is there a point to write multi-line comments in two different formats ? No goal in doing that, no - it wasn't a conscious decision. -- You grabbed my hand and we fell into it, like a daydream - or