Re: [patch V6 19/37] x86/irq: Convey vector as argument and not in ptregs

2020-05-22 Thread Thomas Gleixner
Josh Poimboeuf writes: > On Fri, May 22, 2020 at 02:48:53PM -0400, Boris Ostrovsky wrote: >> > Yes. They just make objtool very unhappy: >> > >> > arch/x86/entry/entry_64.o: warning: objtool: .entry.text+0xfd0: special: >> > can't find orig instruction >> > >> > Peter suggested to use: >> > >> >

Re: [patch V6 19/37] x86/irq: Convey vector as argument and not in ptregs

2020-05-22 Thread Josh Poimboeuf
On Fri, May 22, 2020 at 02:48:53PM -0400, Boris Ostrovsky wrote: > > Yes. They just make objtool very unhappy: > > > > arch/x86/entry/entry_64.o: warning: objtool: .entry.text+0xfd0: special: > > can't find orig instruction > > > > Peter suggested to use: > > > > .pos = . > > .byte.. >

Re: [patch V6 19/37] x86/irq: Convey vector as argument and not in ptregs

2020-05-22 Thread Boris Ostrovsky
On 5/21/20 9:22 AM, Thomas Gleixner wrote: > Andy Lutomirski writes: >> On Fri, May 15, 2020 at 5:10 PM Thomas Gleixner wrote: >> >> + .align 8 >>> +SYM_CODE_START(irq_entries_start) >>> +vector=FIRST_EXTERNAL_VECTOR >>> +.rept (FIRST_SYSTEM_VECTOR - FIRST_EXTERNAL_VECTOR) >>> +

Re: [patch V6 19/37] x86/irq: Convey vector as argument and not in ptregs

2020-05-21 Thread Thomas Gleixner
Andy Lutomirski writes: > On Fri, May 15, 2020 at 5:10 PM Thomas Gleixner wrote: > > + .align 8 >> +SYM_CODE_START(irq_entries_start) >> +vector=FIRST_EXTERNAL_VECTOR >> +.rept (FIRST_SYSTEM_VECTOR - FIRST_EXTERNAL_VECTOR) >> + UNWIND_HINT_IRET_REGS >> + .byte 0x6a, v

Re: [patch V6 19/37] x86/irq: Convey vector as argument and not in ptregs

2020-05-19 Thread Andy Lutomirski
On Fri, May 15, 2020 at 5:10 PM Thomas Gleixner wrote: > > > Device interrupts which go through do_IRQ() or the spurious interrupt > handler have their separate entry code on 64 bit for no good reason. > > Both 32 and 64 bit transport the vector number through ORIG_[RE]AX in > pt_regs. Further the