Re: ARM64-cpuinfo: Combine six calls for sequence output into one seq_printf() call in c_show()

2016-10-17 Thread Mark Rutland
On Mon, Oct 17, 2016 at 02:50:57PM +0200, SF Markus Elfring wrote: > > I prefer the code as-is. Unless there's a compelling reason to change it. > > Is the chance for faster log output interesting enough? Is there a particular user that cares today, or are we trying to work backwards to a rationa

Re: ARM64-cpuinfo: Combine six calls for sequence output into one seq_printf() call in c_show()

2016-10-17 Thread SF Markus Elfring
> I prefer the code as-is. Unless there's a compelling reason to change it. Is the chance for faster log output interesting enough? Regards, Markus

Re: ARM64-cpuinfo: Combine six calls for sequence output into one seq_printf() call in c_show()

2016-10-17 Thread Mark Rutland
On Mon, Oct 17, 2016 at 01:30:59PM +0200, SF Markus Elfring wrote: > >> Some data were printed into a sequence by six separate function calls. > >> Print the same data by a single function call instead. > > > > ... why? > > > > Beyond simply having fewer function calls, is there an upside? > > W

Re: ARM64-cpuinfo: Combine six calls for sequence output into one seq_printf() call in c_show()

2016-10-17 Thread SF Markus Elfring
>> Some data were printed into a sequence by six separate function calls. >> Print the same data by a single function call instead. > > ... why? > > Beyond simply having fewer function calls, is there an upside? Will it matter to improve run time characteristics at this source code place? > Th