Re: Build breakage in 3.8.4 [was: Linux 3.8.4]

2013-04-01 Thread Greg KH
On Wed, Mar 27, 2013 at 05:43:14AM +, Ben Hutchings wrote:
> On Tue, 2013-03-26 at 09:18 -0700, Greg KH wrote:
> > On Tue, Mar 26, 2013 at 08:56:20AM -0700, Kees Cook wrote:
> > > On Sun, Mar 24, 2013 at 12:31 PM, Jiri Slaby  wrote:
> > > > On 03/20/2013 11:25 PM, Sebastian Gottschall wrote:
> > > >
> > > >> Am 20.03.2013 21:15, schrieb Greg KH:
> > > >>> I'm announcing the release of the 3.8.4 kernel.
> > > > ...
> > > >>>signal: always clear sa_restorer on execve
> > > >> consider that this kernel is not compileable on mips targets due the
> > > >> patch in kernel/signal.c
> > > >>
> > > >> SA_RESTORER is defined in mips, but sa_restorer does not exist on that
> > > >> platform
> > > >
> > > > The same for ia64...
> > > >
> > > > kernel/signal.c: In function 'flush_signal_handlers':
> > > > kernel/signal.c:441: error: 'struct sigaction' has no member named
> > > > 'sa_restorer'
> > > >
> > > > Do we need this in 3.0, 3.4, 3.8 too?
> > > > commit 522cff142d7d2f9230839c9e1f21a4d8bcc22a4a
> > > > Author: Andrew Morton 
> > > > Date:   Wed Mar 13 14:59:34 2013 -0700
> > > >
> > > > kernel/signal.c: use __ARCH_HAS_SA_RESTORER instead of SA_RESTORER
> > > >
> > > > __ARCH_HAS_SA_RESTORER is the preferred conditional for use in 3.9 
> > > > and
> > > > later kernels, per Kees.
> > > 
> > > Hrm, if so, we'll need to also backport the changes that aded
> > > __ARCH_HAS_SA_RESTORER...
> > 
> > Ok, well, can someone provide me the needed patches?  Otherwise I will
> > have to revert the offending change from the stable releases.
> 
> For the third time... use the attached patch followed by Andrew's commit
> 522cff142d7d2f9230839c9e1f21a4d8bcc22a4a.

Sorry for being thick, you are right, now applied, thanks.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: Build breakage in 3.8.4 [was: Linux 3.8.4]

2013-04-01 Thread Greg KH
On Wed, Mar 27, 2013 at 05:43:14AM +, Ben Hutchings wrote:
 On Tue, 2013-03-26 at 09:18 -0700, Greg KH wrote:
  On Tue, Mar 26, 2013 at 08:56:20AM -0700, Kees Cook wrote:
   On Sun, Mar 24, 2013 at 12:31 PM, Jiri Slaby jsl...@suse.cz wrote:
On 03/20/2013 11:25 PM, Sebastian Gottschall wrote:
   
Am 20.03.2013 21:15, schrieb Greg KH:
I'm announcing the release of the 3.8.4 kernel.
...
   signal: always clear sa_restorer on execve
consider that this kernel is not compileable on mips targets due the
patch in kernel/signal.c
   
SA_RESTORER is defined in mips, but sa_restorer does not exist on that
platform
   
The same for ia64...
   
kernel/signal.c: In function 'flush_signal_handlers':
kernel/signal.c:441: error: 'struct sigaction' has no member named
'sa_restorer'
   
Do we need this in 3.0, 3.4, 3.8 too?
commit 522cff142d7d2f9230839c9e1f21a4d8bcc22a4a
Author: Andrew Morton a...@linux-foundation.org
Date:   Wed Mar 13 14:59:34 2013 -0700
   
kernel/signal.c: use __ARCH_HAS_SA_RESTORER instead of SA_RESTORER
   
__ARCH_HAS_SA_RESTORER is the preferred conditional for use in 3.9 
and
later kernels, per Kees.
   
   Hrm, if so, we'll need to also backport the changes that aded
   __ARCH_HAS_SA_RESTORER...
  
  Ok, well, can someone provide me the needed patches?  Otherwise I will
  have to revert the offending change from the stable releases.
 
 For the third time... use the attached patch followed by Andrew's commit
 522cff142d7d2f9230839c9e1f21a4d8bcc22a4a.

Sorry for being thick, you are right, now applied, thanks.

greg k-h
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: Build breakage in 3.8.4 [was: Linux 3.8.4]

2013-03-26 Thread Ben Hutchings
On Tue, 2013-03-26 at 09:18 -0700, Greg KH wrote:
> On Tue, Mar 26, 2013 at 08:56:20AM -0700, Kees Cook wrote:
> > On Sun, Mar 24, 2013 at 12:31 PM, Jiri Slaby  wrote:
> > > On 03/20/2013 11:25 PM, Sebastian Gottschall wrote:
> > >
> > >> Am 20.03.2013 21:15, schrieb Greg KH:
> > >>> I'm announcing the release of the 3.8.4 kernel.
> > > ...
> > >>>signal: always clear sa_restorer on execve
> > >> consider that this kernel is not compileable on mips targets due the
> > >> patch in kernel/signal.c
> > >>
> > >> SA_RESTORER is defined in mips, but sa_restorer does not exist on that
> > >> platform
> > >
> > > The same for ia64...
> > >
> > > kernel/signal.c: In function 'flush_signal_handlers':
> > > kernel/signal.c:441: error: 'struct sigaction' has no member named
> > > 'sa_restorer'
> > >
> > > Do we need this in 3.0, 3.4, 3.8 too?
> > > commit 522cff142d7d2f9230839c9e1f21a4d8bcc22a4a
> > > Author: Andrew Morton 
> > > Date:   Wed Mar 13 14:59:34 2013 -0700
> > >
> > > kernel/signal.c: use __ARCH_HAS_SA_RESTORER instead of SA_RESTORER
> > >
> > > __ARCH_HAS_SA_RESTORER is the preferred conditional for use in 3.9 and
> > > later kernels, per Kees.
> > 
> > Hrm, if so, we'll need to also backport the changes that aded
> > __ARCH_HAS_SA_RESTORER...
> 
> Ok, well, can someone provide me the needed patches?  Otherwise I will
> have to revert the offending change from the stable releases.

For the third time... use the attached patch followed by Andrew's commit
522cff142d7d2f9230839c9e1f21a4d8bcc22a4a.

Ben.

-- 
Ben Hutchings
I'm not a reverse psychological virus.  Please don't copy me into your sig.
From: Ben Hutchings 
Date: Sun, 25 Nov 2012 22:24:19 -0500
Subject: signal: Define __ARCH_HAS_SA_RESTORER so we know whether to clear sa_restorer

flush_signal_handlers() needs to know whether sigaction::sa_restorer
is defined, not whether SA_RESTORER is defined.  Define the
__ARCH_HAS_SA_RESTORER macro to indicate this.

Vaguely based on upstream commit 574c4866e33d 'consolidate kernel-side
struct sigaction declarations'.

Signed-off-by: Ben Hutchings 
Cc: Al Viro 
---
--- a/arch/arm/include/asm/signal.h
+++ b/arch/arm/include/asm/signal.h
@@ -29,6 +29,7 @@ struct sigaction {
 	__sigrestore_t sa_restorer;
 	sigset_t sa_mask;		/* mask last for extensibility */
 };
+#define __ARCH_HAS_SA_RESTORER
 
 struct k_sigaction {
 	struct sigaction sa;
--- a/arch/avr32/include/asm/signal.h
+++ b/arch/avr32/include/asm/signal.h
@@ -29,6 +29,7 @@ struct sigaction {
 	__sigrestore_t sa_restorer;
 	sigset_t sa_mask;		/* mask last for extensibility */
 };
+#define __ARCH_HAS_SA_RESTORER
 
 struct k_sigaction {
 	struct sigaction sa;
--- a/arch/cris/include/asm/signal.h
+++ b/arch/cris/include/asm/signal.h
@@ -29,6 +29,7 @@ struct sigaction {
 	void (*sa_restorer)(void);
 	sigset_t sa_mask;		/* mask last for extensibility */
 };
+#define __ARCH_HAS_SA_RESTORER
 
 struct k_sigaction {
 	struct sigaction sa;
--- a/arch/h8300/include/asm/signal.h
+++ b/arch/h8300/include/asm/signal.h
@@ -29,6 +29,7 @@ struct sigaction {
 	void (*sa_restorer)(void);
 	sigset_t sa_mask;		/* mask last for extensibility */
 };
+#define __ARCH_HAS_SA_RESTORER
 
 struct k_sigaction {
 	struct sigaction sa;
--- a/arch/m32r/include/asm/signal.h
+++ b/arch/m32r/include/asm/signal.h
@@ -22,6 +22,7 @@ struct sigaction {
 	__sigrestore_t sa_restorer;
 	sigset_t sa_mask;		/* mask last for extensibility */
 };
+#define __ARCH_HAS_SA_RESTORER
 
 struct k_sigaction {
 	struct sigaction sa;
--- a/arch/m68k/include/asm/signal.h
+++ b/arch/m68k/include/asm/signal.h
@@ -29,6 +29,7 @@ struct sigaction {
 	__sigrestore_t sa_restorer;
 	sigset_t sa_mask;		/* mask last for extensibility */
 };
+#define __ARCH_HAS_SA_RESTORER
 
 struct k_sigaction {
 	struct sigaction sa;
--- a/arch/mn10300/include/asm/signal.h
+++ b/arch/mn10300/include/asm/signal.h
@@ -39,6 +39,7 @@ struct sigaction {
 	__sigrestore_t sa_restorer;
 	sigset_t sa_mask;		/* mask last for extensibility */
 };
+#define __ARCH_HAS_SA_RESTORER
 
 struct k_sigaction {
 	struct sigaction sa;
--- a/arch/powerpc/include/asm/signal.h
+++ b/arch/powerpc/include/asm/signal.h
@@ -1,6 +1,7 @@
 #ifndef _ASM_POWERPC_SIGNAL_H
 #define _ASM_POWERPC_SIGNAL_H
 
+#define __ARCH_HAS_SA_RESTORER
 #include 
 
 #endif /* _ASM_POWERPC_SIGNAL_H */
--- a/arch/s390/include/asm/signal.h
+++ b/arch/s390/include/asm/signal.h
@@ -34,6 +34,7 @@ struct sigaction {
 void (*sa_restorer)(void);
 sigset_t sa_mask;   /* mask last for extensibility */
 };
+#define __ARCH_HAS_SA_RESTORER
 
 struct k_sigaction {
 struct sigaction sa;
--- a/arch/sparc/include/asm/signal.h
+++ b/arch/sparc/include/asm/signal.h
@@ -26,5 +26,7 @@ struct k_sigaction {
 	void			__user *ka_restorer;
 };
 
+#define __ARCH_HAS_SA_RESTORER
+
 #endif /* !(__ASSEMBLY__) */
 #endif /* !(__SPARC_SIGNAL_H) */
--- a/arch/x86/include/asm/signal.h
+++ b/arch/x86/include/asm/signal.h
@@ -31,6 +31,9 @@ typedef sigset_t 

Re: Build breakage in 3.8.4 [was: Linux 3.8.4]

2013-03-26 Thread Luis Henriques
On Tue, Mar 26, 2013 at 08:56:20AM -0700, Kees Cook wrote:
> On Sun, Mar 24, 2013 at 12:31 PM, Jiri Slaby  wrote:
> > On 03/20/2013 11:25 PM, Sebastian Gottschall wrote:
> >
> >> Am 20.03.2013 21:15, schrieb Greg KH:
> >>> I'm announcing the release of the 3.8.4 kernel.
> > ...
> >>>signal: always clear sa_restorer on execve
> >> consider that this kernel is not compileable on mips targets due the
> >> patch in kernel/signal.c
> >>
> >> SA_RESTORER is defined in mips, but sa_restorer does not exist on that
> >> platform
> >
> > The same for ia64...
> >
> > kernel/signal.c: In function 'flush_signal_handlers':
> > kernel/signal.c:441: error: 'struct sigaction' has no member named
> > 'sa_restorer'
> >
> > Do we need this in 3.0, 3.4, 3.8 too?
> > commit 522cff142d7d2f9230839c9e1f21a4d8bcc22a4a
> > Author: Andrew Morton 
> > Date:   Wed Mar 13 14:59:34 2013 -0700
> >
> > kernel/signal.c: use __ARCH_HAS_SA_RESTORER instead of SA_RESTORER
> >
> > __ARCH_HAS_SA_RESTORER is the preferred conditional for use in 3.9 and
> > later kernels, per Kees.
> 
> Hrm, if so, we'll need to also backport the changes that aded
> __ARCH_HAS_SA_RESTORER...

Isn't the solution provided by Ben [1] enough to solve this?

[1] https://lkml.org/lkml/2013/3/26/12

Cheers,
--
Luis

> 
> -Kees
> 
> >
> > thanks,
> > --
> > js
> > suse labs
> 
> 
> 
> --
> Kees Cook
> Chrome OS Security
> --
> To unsubscribe from this list: send the line "unsubscribe stable" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: Build breakage in 3.8.4 [was: Linux 3.8.4]

2013-03-26 Thread Greg KH
On Tue, Mar 26, 2013 at 08:56:20AM -0700, Kees Cook wrote:
> On Sun, Mar 24, 2013 at 12:31 PM, Jiri Slaby  wrote:
> > On 03/20/2013 11:25 PM, Sebastian Gottschall wrote:
> >
> >> Am 20.03.2013 21:15, schrieb Greg KH:
> >>> I'm announcing the release of the 3.8.4 kernel.
> > ...
> >>>signal: always clear sa_restorer on execve
> >> consider that this kernel is not compileable on mips targets due the
> >> patch in kernel/signal.c
> >>
> >> SA_RESTORER is defined in mips, but sa_restorer does not exist on that
> >> platform
> >
> > The same for ia64...
> >
> > kernel/signal.c: In function 'flush_signal_handlers':
> > kernel/signal.c:441: error: 'struct sigaction' has no member named
> > 'sa_restorer'
> >
> > Do we need this in 3.0, 3.4, 3.8 too?
> > commit 522cff142d7d2f9230839c9e1f21a4d8bcc22a4a
> > Author: Andrew Morton 
> > Date:   Wed Mar 13 14:59:34 2013 -0700
> >
> > kernel/signal.c: use __ARCH_HAS_SA_RESTORER instead of SA_RESTORER
> >
> > __ARCH_HAS_SA_RESTORER is the preferred conditional for use in 3.9 and
> > later kernels, per Kees.
> 
> Hrm, if so, we'll need to also backport the changes that aded
> __ARCH_HAS_SA_RESTORER...

Ok, well, can someone provide me the needed patches?  Otherwise I will
have to revert the offending change from the stable releases.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: Build breakage in 3.8.4 [was: Linux 3.8.4]

2013-03-26 Thread Kees Cook
On Sun, Mar 24, 2013 at 12:31 PM, Jiri Slaby  wrote:
> On 03/20/2013 11:25 PM, Sebastian Gottschall wrote:
>
>> Am 20.03.2013 21:15, schrieb Greg KH:
>>> I'm announcing the release of the 3.8.4 kernel.
> ...
>>>signal: always clear sa_restorer on execve
>> consider that this kernel is not compileable on mips targets due the
>> patch in kernel/signal.c
>>
>> SA_RESTORER is defined in mips, but sa_restorer does not exist on that
>> platform
>
> The same for ia64...
>
> kernel/signal.c: In function 'flush_signal_handlers':
> kernel/signal.c:441: error: 'struct sigaction' has no member named
> 'sa_restorer'
>
> Do we need this in 3.0, 3.4, 3.8 too?
> commit 522cff142d7d2f9230839c9e1f21a4d8bcc22a4a
> Author: Andrew Morton 
> Date:   Wed Mar 13 14:59:34 2013 -0700
>
> kernel/signal.c: use __ARCH_HAS_SA_RESTORER instead of SA_RESTORER
>
> __ARCH_HAS_SA_RESTORER is the preferred conditional for use in 3.9 and
> later kernels, per Kees.

Hrm, if so, we'll need to also backport the changes that aded
__ARCH_HAS_SA_RESTORER...

-Kees

>
> thanks,
> --
> js
> suse labs



--
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: Build breakage in 3.8.4 [was: Linux 3.8.4]

2013-03-26 Thread Kees Cook
On Sun, Mar 24, 2013 at 12:31 PM, Jiri Slaby jsl...@suse.cz wrote:
 On 03/20/2013 11:25 PM, Sebastian Gottschall wrote:

 Am 20.03.2013 21:15, schrieb Greg KH:
 I'm announcing the release of the 3.8.4 kernel.
 ...
signal: always clear sa_restorer on execve
 consider that this kernel is not compileable on mips targets due the
 patch in kernel/signal.c

 SA_RESTORER is defined in mips, but sa_restorer does not exist on that
 platform

 The same for ia64...

 kernel/signal.c: In function 'flush_signal_handlers':
 kernel/signal.c:441: error: 'struct sigaction' has no member named
 'sa_restorer'

 Do we need this in 3.0, 3.4, 3.8 too?
 commit 522cff142d7d2f9230839c9e1f21a4d8bcc22a4a
 Author: Andrew Morton a...@linux-foundation.org
 Date:   Wed Mar 13 14:59:34 2013 -0700

 kernel/signal.c: use __ARCH_HAS_SA_RESTORER instead of SA_RESTORER

 __ARCH_HAS_SA_RESTORER is the preferred conditional for use in 3.9 and
 later kernels, per Kees.

Hrm, if so, we'll need to also backport the changes that aded
__ARCH_HAS_SA_RESTORER...

-Kees


 thanks,
 --
 js
 suse labs



--
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: Build breakage in 3.8.4 [was: Linux 3.8.4]

2013-03-26 Thread Greg KH
On Tue, Mar 26, 2013 at 08:56:20AM -0700, Kees Cook wrote:
 On Sun, Mar 24, 2013 at 12:31 PM, Jiri Slaby jsl...@suse.cz wrote:
  On 03/20/2013 11:25 PM, Sebastian Gottschall wrote:
 
  Am 20.03.2013 21:15, schrieb Greg KH:
  I'm announcing the release of the 3.8.4 kernel.
  ...
 signal: always clear sa_restorer on execve
  consider that this kernel is not compileable on mips targets due the
  patch in kernel/signal.c
 
  SA_RESTORER is defined in mips, but sa_restorer does not exist on that
  platform
 
  The same for ia64...
 
  kernel/signal.c: In function 'flush_signal_handlers':
  kernel/signal.c:441: error: 'struct sigaction' has no member named
  'sa_restorer'
 
  Do we need this in 3.0, 3.4, 3.8 too?
  commit 522cff142d7d2f9230839c9e1f21a4d8bcc22a4a
  Author: Andrew Morton a...@linux-foundation.org
  Date:   Wed Mar 13 14:59:34 2013 -0700
 
  kernel/signal.c: use __ARCH_HAS_SA_RESTORER instead of SA_RESTORER
 
  __ARCH_HAS_SA_RESTORER is the preferred conditional for use in 3.9 and
  later kernels, per Kees.
 
 Hrm, if so, we'll need to also backport the changes that aded
 __ARCH_HAS_SA_RESTORER...

Ok, well, can someone provide me the needed patches?  Otherwise I will
have to revert the offending change from the stable releases.

thanks,

greg k-h
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: Build breakage in 3.8.4 [was: Linux 3.8.4]

2013-03-26 Thread Luis Henriques
On Tue, Mar 26, 2013 at 08:56:20AM -0700, Kees Cook wrote:
 On Sun, Mar 24, 2013 at 12:31 PM, Jiri Slaby jsl...@suse.cz wrote:
  On 03/20/2013 11:25 PM, Sebastian Gottschall wrote:
 
  Am 20.03.2013 21:15, schrieb Greg KH:
  I'm announcing the release of the 3.8.4 kernel.
  ...
 signal: always clear sa_restorer on execve
  consider that this kernel is not compileable on mips targets due the
  patch in kernel/signal.c
 
  SA_RESTORER is defined in mips, but sa_restorer does not exist on that
  platform
 
  The same for ia64...
 
  kernel/signal.c: In function 'flush_signal_handlers':
  kernel/signal.c:441: error: 'struct sigaction' has no member named
  'sa_restorer'
 
  Do we need this in 3.0, 3.4, 3.8 too?
  commit 522cff142d7d2f9230839c9e1f21a4d8bcc22a4a
  Author: Andrew Morton a...@linux-foundation.org
  Date:   Wed Mar 13 14:59:34 2013 -0700
 
  kernel/signal.c: use __ARCH_HAS_SA_RESTORER instead of SA_RESTORER
 
  __ARCH_HAS_SA_RESTORER is the preferred conditional for use in 3.9 and
  later kernels, per Kees.
 
 Hrm, if so, we'll need to also backport the changes that aded
 __ARCH_HAS_SA_RESTORER...

Isn't the solution provided by Ben [1] enough to solve this?

[1] https://lkml.org/lkml/2013/3/26/12

Cheers,
--
Luis

 
 -Kees
 
 
  thanks,
  --
  js
  suse labs
 
 
 
 --
 Kees Cook
 Chrome OS Security
 --
 To unsubscribe from this list: send the line unsubscribe stable in
 the body of a message to majord...@vger.kernel.org
 More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: Build breakage in 3.8.4 [was: Linux 3.8.4]

2013-03-26 Thread Ben Hutchings
On Tue, 2013-03-26 at 09:18 -0700, Greg KH wrote:
 On Tue, Mar 26, 2013 at 08:56:20AM -0700, Kees Cook wrote:
  On Sun, Mar 24, 2013 at 12:31 PM, Jiri Slaby jsl...@suse.cz wrote:
   On 03/20/2013 11:25 PM, Sebastian Gottschall wrote:
  
   Am 20.03.2013 21:15, schrieb Greg KH:
   I'm announcing the release of the 3.8.4 kernel.
   ...
  signal: always clear sa_restorer on execve
   consider that this kernel is not compileable on mips targets due the
   patch in kernel/signal.c
  
   SA_RESTORER is defined in mips, but sa_restorer does not exist on that
   platform
  
   The same for ia64...
  
   kernel/signal.c: In function 'flush_signal_handlers':
   kernel/signal.c:441: error: 'struct sigaction' has no member named
   'sa_restorer'
  
   Do we need this in 3.0, 3.4, 3.8 too?
   commit 522cff142d7d2f9230839c9e1f21a4d8bcc22a4a
   Author: Andrew Morton a...@linux-foundation.org
   Date:   Wed Mar 13 14:59:34 2013 -0700
  
   kernel/signal.c: use __ARCH_HAS_SA_RESTORER instead of SA_RESTORER
  
   __ARCH_HAS_SA_RESTORER is the preferred conditional for use in 3.9 and
   later kernels, per Kees.
  
  Hrm, if so, we'll need to also backport the changes that aded
  __ARCH_HAS_SA_RESTORER...
 
 Ok, well, can someone provide me the needed patches?  Otherwise I will
 have to revert the offending change from the stable releases.

For the third time... use the attached patch followed by Andrew's commit
522cff142d7d2f9230839c9e1f21a4d8bcc22a4a.

Ben.

-- 
Ben Hutchings
I'm not a reverse psychological virus.  Please don't copy me into your sig.
From: Ben Hutchings b...@decadent.org.uk
Date: Sun, 25 Nov 2012 22:24:19 -0500
Subject: signal: Define __ARCH_HAS_SA_RESTORER so we know whether to clear sa_restorer

flush_signal_handlers() needs to know whether sigaction::sa_restorer
is defined, not whether SA_RESTORER is defined.  Define the
__ARCH_HAS_SA_RESTORER macro to indicate this.

Vaguely based on upstream commit 574c4866e33d 'consolidate kernel-side
struct sigaction declarations'.

Signed-off-by: Ben Hutchings b...@decadent.org.uk
Cc: Al Viro v...@zeniv.linux.org.uk
---
--- a/arch/arm/include/asm/signal.h
+++ b/arch/arm/include/asm/signal.h
@@ -29,6 +29,7 @@ struct sigaction {
 	__sigrestore_t sa_restorer;
 	sigset_t sa_mask;		/* mask last for extensibility */
 };
+#define __ARCH_HAS_SA_RESTORER
 
 struct k_sigaction {
 	struct sigaction sa;
--- a/arch/avr32/include/asm/signal.h
+++ b/arch/avr32/include/asm/signal.h
@@ -29,6 +29,7 @@ struct sigaction {
 	__sigrestore_t sa_restorer;
 	sigset_t sa_mask;		/* mask last for extensibility */
 };
+#define __ARCH_HAS_SA_RESTORER
 
 struct k_sigaction {
 	struct sigaction sa;
--- a/arch/cris/include/asm/signal.h
+++ b/arch/cris/include/asm/signal.h
@@ -29,6 +29,7 @@ struct sigaction {
 	void (*sa_restorer)(void);
 	sigset_t sa_mask;		/* mask last for extensibility */
 };
+#define __ARCH_HAS_SA_RESTORER
 
 struct k_sigaction {
 	struct sigaction sa;
--- a/arch/h8300/include/asm/signal.h
+++ b/arch/h8300/include/asm/signal.h
@@ -29,6 +29,7 @@ struct sigaction {
 	void (*sa_restorer)(void);
 	sigset_t sa_mask;		/* mask last for extensibility */
 };
+#define __ARCH_HAS_SA_RESTORER
 
 struct k_sigaction {
 	struct sigaction sa;
--- a/arch/m32r/include/asm/signal.h
+++ b/arch/m32r/include/asm/signal.h
@@ -22,6 +22,7 @@ struct sigaction {
 	__sigrestore_t sa_restorer;
 	sigset_t sa_mask;		/* mask last for extensibility */
 };
+#define __ARCH_HAS_SA_RESTORER
 
 struct k_sigaction {
 	struct sigaction sa;
--- a/arch/m68k/include/asm/signal.h
+++ b/arch/m68k/include/asm/signal.h
@@ -29,6 +29,7 @@ struct sigaction {
 	__sigrestore_t sa_restorer;
 	sigset_t sa_mask;		/* mask last for extensibility */
 };
+#define __ARCH_HAS_SA_RESTORER
 
 struct k_sigaction {
 	struct sigaction sa;
--- a/arch/mn10300/include/asm/signal.h
+++ b/arch/mn10300/include/asm/signal.h
@@ -39,6 +39,7 @@ struct sigaction {
 	__sigrestore_t sa_restorer;
 	sigset_t sa_mask;		/* mask last for extensibility */
 };
+#define __ARCH_HAS_SA_RESTORER
 
 struct k_sigaction {
 	struct sigaction sa;
--- a/arch/powerpc/include/asm/signal.h
+++ b/arch/powerpc/include/asm/signal.h
@@ -1,6 +1,7 @@
 #ifndef _ASM_POWERPC_SIGNAL_H
 #define _ASM_POWERPC_SIGNAL_H
 
+#define __ARCH_HAS_SA_RESTORER
 #include uapi/asm/signal.h
 
 #endif /* _ASM_POWERPC_SIGNAL_H */
--- a/arch/s390/include/asm/signal.h
+++ b/arch/s390/include/asm/signal.h
@@ -34,6 +34,7 @@ struct sigaction {
 void (*sa_restorer)(void);
 sigset_t sa_mask;   /* mask last for extensibility */
 };
+#define __ARCH_HAS_SA_RESTORER
 
 struct k_sigaction {
 struct sigaction sa;
--- a/arch/sparc/include/asm/signal.h
+++ b/arch/sparc/include/asm/signal.h
@@ -26,5 +26,7 @@ struct k_sigaction {
 	void			__user *ka_restorer;
 };
 
+#define __ARCH_HAS_SA_RESTORER
+
 #endif /* !(__ASSEMBLY__) */
 #endif /* !(__SPARC_SIGNAL_H) */
--- a/arch/x86/include/asm/signal.h
+++ b/arch/x86/include/asm/signal.h
@@ -31,6 +31,9 @@ typedef