Re: Dell docking station & Dell Embedded Controller & PS/2 devices
On Monday 07 May 2018 20:32:16 mario.limoncie...@dell.com wrote: > > The items that show up in this structure are supposed to be dynamic > > values but static addresses. I was asking to check before bootup in > > case this was a problem of Linux caching SMBIOS table information once. > > The values I was referring to might be for older generation dock though, > > I'll see if I can find anything else you can check. > > Can you check if structure type 08 or structure type 09 change based on > dock being plugged in? Again you might have to do it across a boot > with/without dock in case of Linux kernel caches values. The only difference is: --- dmidecode_laptop_docked 2018-05-07 22:34:02.650325758 +0200 +++ dmidecode_laptop_undocked 2018-05-07 22:39:27.580306838 +0200 @@ -913,7 +913,7 @@ System Power Supply Asset Tag: To Be Filled By O.E.M. Model Part Number: To Be Filled By O.E.M. Revision: To Be Filled By O.E.M. - Max Power Capacity: 90 W + Max Power Capacity: Unknown Status: Present, OK Type: Switching Input Voltage Range Switching: Auto-switch And this is in block Handle 0x003E, DMI type 39, 22 bytes - System Power Supply. So looks like that DMI data are same. -- Pali Rohár pali.ro...@gmail.com signature.asc Description: PGP signature
RE: Dell docking station & Dell Embedded Controller & PS/2 devices
> -Original Message- > From: Limonciello, Mario > Sent: Monday, May 7, 2018 3:30 PM > To: 'Pali Rohár' > Cc: dmitry.torok...@gmail.com; linux-in...@vger.kernel.org; linux- > ker...@vger.kernel.org > Subject: RE: Dell docking station & Dell Embedded Controller & PS/2 devices > > > -Original Message- > > From: Pali Rohár [mailto:pali.ro...@gmail.com] > > Sent: Monday, May 7, 2018 3:28 PM > > To: Limonciello, Mario > > Cc: dmitry.torok...@gmail.com; linux-in...@vger.kernel.org; linux- > > ker...@vger.kernel.org > > Subject: Re: Dell docking station & Dell Embedded Controller & PS/2 devices > > > > On Monday 07 May 2018 20:18:30 mario.limoncie...@dell.com wrote: > > > > > > So I guess you could write a platform driver that would install > > > > > > i8042 > > > > > > filter on Dell laptops/portables, monitor keyboard data stream and > > > > > > kick > > > > > > of rescans on serio ports. The problem is filter gets "serio" so > > > > > > you do > > > > > > not really know whether ACK is spurious or not. And I would really > > > > > > prefer keeping this crap out of atkbd proper... And all of this is > > > > > > racy > > > > > > as hell. What happens if we get keyboard reconnected as we > > > > > > reinitialize > > > > > > it? > > > > > > > > > > If it's done as a platform driver I would suspect it's possible to > > > > > tell whether > > > > > a dock is connected to at least give you some heuristic here to have > > > > > a better > > > > > guess whether it's spurious. > > > > > > > > Apparently checking for docking station is not enough. There are also > > > > Dell Legacy Extenders (or how it is called) which exports internal PS/2, > > > > Parallel and Serial Ports. It is also connecting to bottom of laptop. > > > > But currently I do not have them for testing. > > > > > > > > > Pali on your system that supports this dock, check and see how many > > > > > System Enclosure SMBIOS tables (structure type 03) are present. > > > > > > > > Do you mean DMI type 3 structure? Here is something from dmidecode: > > > > > > > > Handle 0x0003, DMI type 3, 22 bytes > > > > Chassis Information > > > > Manufacturer: Dell Inc. > > > > Type: Laptop > > > > Lock: Not Present > > > > Version: Not Specified > > > > Serial Number: --REMOVED-- > > > > Asset Tag: Not Specified > > > > Boot-up State: Safe > > > > Power Supply State: Safe > > > > Thermal State: Safe > > > > Security Status: None > > > > OEM Information: 0x > > > > Height: Unspecified > > > > Number Of Power Cords: 1 > > > > Contained Elements: 0 > > > > SKU Number: To be filled by O.E.M. > > > > > > > > But probably you mean something different? > > > > > > Plug in your dock before you boot up and see if you have a second > > > structure like > > > that type produced. > > > > I already started docked laptop via dock power button. And in dmidecode > > output is only one DMI type 3 block. > > > > > If not, then I guess this isn't a reliable way to find the dock > > > on that system and I'll have to see if there is another. > > > > Seems not. Also detection of dock should work also when you connect > > laptop at system runtime, not only when connected prior to booting. > > > > The items that show up in this structure are supposed to be dynamic > values but static addresses. I was asking to check before bootup in > case this was a problem of Linux caching SMBIOS table information once. > The values I was referring to might be for older generation dock though, > I'll see if I can find anything else you can check. Can you check if structure type 08 or structure type 09 change based on dock being plugged in? Again you might have to do it across a boot with/without dock in case of Linux kernel caches values.
RE: Dell docking station & Dell Embedded Controller & PS/2 devices
> -Original Message- > From: Pali Rohár [mailto:pali.ro...@gmail.com] > Sent: Monday, May 7, 2018 3:28 PM > To: Limonciello, Mario > Cc: dmitry.torok...@gmail.com; linux-in...@vger.kernel.org; linux- > ker...@vger.kernel.org > Subject: Re: Dell docking station & Dell Embedded Controller & PS/2 devices > > On Monday 07 May 2018 20:18:30 mario.limoncie...@dell.com wrote: > > > > > So I guess you could write a platform driver that would install i8042 > > > > > filter on Dell laptops/portables, monitor keyboard data stream and > > > > > kick > > > > > of rescans on serio ports. The problem is filter gets "serio" so you > > > > > do > > > > > not really know whether ACK is spurious or not. And I would really > > > > > prefer keeping this crap out of atkbd proper... And all of this is > > > > > racy > > > > > as hell. What happens if we get keyboard reconnected as we > > > > > reinitialize > > > > > it? > > > > > > > > If it's done as a platform driver I would suspect it's possible to tell > > > > whether > > > > a dock is connected to at least give you some heuristic here to have a > > > > better > > > > guess whether it's spurious. > > > > > > Apparently checking for docking station is not enough. There are also > > > Dell Legacy Extenders (or how it is called) which exports internal PS/2, > > > Parallel and Serial Ports. It is also connecting to bottom of laptop. > > > But currently I do not have them for testing. > > > > > > > Pali on your system that supports this dock, check and see how many > > > > System Enclosure SMBIOS tables (structure type 03) are present. > > > > > > Do you mean DMI type 3 structure? Here is something from dmidecode: > > > > > > Handle 0x0003, DMI type 3, 22 bytes > > > Chassis Information > > > Manufacturer: Dell Inc. > > > Type: Laptop > > > Lock: Not Present > > > Version: Not Specified > > > Serial Number: --REMOVED-- > > > Asset Tag: Not Specified > > > Boot-up State: Safe > > > Power Supply State: Safe > > > Thermal State: Safe > > > Security Status: None > > > OEM Information: 0x > > > Height: Unspecified > > > Number Of Power Cords: 1 > > > Contained Elements: 0 > > > SKU Number: To be filled by O.E.M. > > > > > > But probably you mean something different? > > > > Plug in your dock before you boot up and see if you have a second structure > > like > > that type produced. > > I already started docked laptop via dock power button. And in dmidecode > output is only one DMI type 3 block. > > > If not, then I guess this isn't a reliable way to find the dock > > on that system and I'll have to see if there is another. > > Seems not. Also detection of dock should work also when you connect > laptop at system runtime, not only when connected prior to booting. > The items that show up in this structure are supposed to be dynamic values but static addresses. I was asking to check before bootup in case this was a problem of Linux caching SMBIOS table information once. The values I was referring to might be for older generation dock though, I'll see if I can find anything else you can check.
Re: Dell docking station & Dell Embedded Controller & PS/2 devices
On Monday 07 May 2018 20:18:30 mario.limoncie...@dell.com wrote: > > > > So I guess you could write a platform driver that would install i8042 > > > > filter on Dell laptops/portables, monitor keyboard data stream and kick > > > > of rescans on serio ports. The problem is filter gets "serio" so you do > > > > not really know whether ACK is spurious or not. And I would really > > > > prefer keeping this crap out of atkbd proper... And all of this is racy > > > > as hell. What happens if we get keyboard reconnected as we reinitialize > > > > it? > > > > > > If it's done as a platform driver I would suspect it's possible to tell > > > whether > > > a dock is connected to at least give you some heuristic here to have a > > > better > > > guess whether it's spurious. > > > > Apparently checking for docking station is not enough. There are also > > Dell Legacy Extenders (or how it is called) which exports internal PS/2, > > Parallel and Serial Ports. It is also connecting to bottom of laptop. > > But currently I do not have them for testing. > > > > > Pali on your system that supports this dock, check and see how many > > > System Enclosure SMBIOS tables (structure type 03) are present. > > > > Do you mean DMI type 3 structure? Here is something from dmidecode: > > > > Handle 0x0003, DMI type 3, 22 bytes > > Chassis Information > > Manufacturer: Dell Inc. > > Type: Laptop > > Lock: Not Present > > Version: Not Specified > > Serial Number: --REMOVED-- > > Asset Tag: Not Specified > > Boot-up State: Safe > > Power Supply State: Safe > > Thermal State: Safe > > Security Status: None > > OEM Information: 0x > > Height: Unspecified > > Number Of Power Cords: 1 > > Contained Elements: 0 > > SKU Number: To be filled by O.E.M. > > > > But probably you mean something different? > > Plug in your dock before you boot up and see if you have a second structure > like > that type produced. I already started docked laptop via dock power button. And in dmidecode output is only one DMI type 3 block. > If not, then I guess this isn't a reliable way to find the dock > on that system and I'll have to see if there is another. Seems not. Also detection of dock should work also when you connect laptop at system runtime, not only when connected prior to booting. -- Pali Rohár pali.ro...@gmail.com signature.asc Description: PGP signature
RE: Dell docking station & Dell Embedded Controller & PS/2 devices
> > > So I guess you could write a platform driver that would install i8042 > > > filter on Dell laptops/portables, monitor keyboard data stream and kick > > > of rescans on serio ports. The problem is filter gets "serio" so you do > > > not really know whether ACK is spurious or not. And I would really > > > prefer keeping this crap out of atkbd proper... And all of this is racy > > > as hell. What happens if we get keyboard reconnected as we reinitialize > > > it? > > > > If it's done as a platform driver I would suspect it's possible to tell > > whether > > a dock is connected to at least give you some heuristic here to have a > > better > > guess whether it's spurious. > > Apparently checking for docking station is not enough. There are also > Dell Legacy Extenders (or how it is called) which exports internal PS/2, > Parallel and Serial Ports. It is also connecting to bottom of laptop. > But currently I do not have them for testing. > > > Pali on your system that supports this dock, check and see how many > > System Enclosure SMBIOS tables (structure type 03) are present. > > Do you mean DMI type 3 structure? Here is something from dmidecode: > > Handle 0x0003, DMI type 3, 22 bytes > Chassis Information > Manufacturer: Dell Inc. > Type: Laptop > Lock: Not Present > Version: Not Specified > Serial Number: --REMOVED-- > Asset Tag: Not Specified > Boot-up State: Safe > Power Supply State: Safe > Thermal State: Safe > Security Status: None > OEM Information: 0x > Height: Unspecified > Number Of Power Cords: 1 > Contained Elements: 0 > SKU Number: To be filled by O.E.M. > > But probably you mean something different? Plug in your dock before you boot up and see if you have a second structure like that type produced. If not, then I guess this isn't a reliable way to find the dock on that system and I'll have to see if there is another.
Re: Dell docking station & Dell Embedded Controller & PS/2 devices
On Monday 07 May 2018 19:59:14 mario.limoncie...@dell.com wrote: > > -Original Message- > > From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com] > > Sent: Monday, May 7, 2018 2:33 PM > > To: Pali Rohár > > Cc: Limonciello, Mario; linux-in...@vger.kernel.org; > > linux-kernel@vger.kernel.org > > Subject: Re: Dell docking station & Dell Embedded Controller & PS/2 devices > > > > On Mon, May 07, 2018 at 10:44:31AM +0200, Pali Rohár wrote: > > > On Sunday 06 May 2018 15:47:33 Pali Rohár wrote: > > > > On Thursday 01 February 2018 11:29:45 Dmitry Torokhov wrote: > > > > > Hi Pali, > > > > > > > > > > On Wed, Jan 24, 2018 at 11:41:21AM +0100, Pali Rohár wrote: > > > > > > Hi Dmitry! > > > > > > > > > > > > I'm observing a problem with internal touchpad (handled by > > > > > > psmouse.ko) > > > > > > on Dell laptops connected to Dell E docking station. When I connect > > > > > > external PS/2 keyboard to docking station then internal laptop > > > > > > touchpad > > > > > > switch from multitouch absolute mode to relative bare PS/2 mode. > > > > > > > > > > > > And because ALPS driver in psmouse.ko is capable to process > > > > > > interleaved > > > > > > bare 3-byte PS/2 packets with 6-byte ALPS packets (which handles > > > > > > trackstick data on some ALPS models), ALPS driver does not show any > > > > > > message about this "downgrade" from multitouch to bare mode. And > > > > > > continue working in bare mode. > > > > > > > > > > > > When I rmmod psmouse and modprobe it again, then touchpad switch > > > > > > back > > to > > > > > > multitouch mode. > > > > > > > > > > > > Mario told me that Dell Embedded Controller, which handle internal > > > > > > keyboard, internal touchpad and external PS/2 keyboard, > > > > > > automatically > > > > > > send RESET command to *all* those devices when external PS/2 > > > > > > keyboard is > > > > > > connected. Therefore this is reason why touchpad downgrade to to > > > > > > bare > > > > > > mode. And according to Mario, host system should issue vendor > > > > > > specific > > > > > > PS/2 commands to re-initialize all PS/2 devices when this situation > > > > > > happen. Mario also told me that Windows is doing this action. > > > > > > > > > > Yeah, I remember fun with Inspiron 8100 - when you dock it it woudl > > > > > silently switch Synaptics touchpad into standard mode and it would not > > > > > come back as Synaptics until you disconnect. And there was no > > > > > notification to the kernel as far as I could tell. > > > > > > > > > > It could be that we need to monitor dock events and then kick > > > > > reconnect > > > > > of serio port, either from userspace via udev (I think that would be > > > > > preferred), or in kernel. > > > > > > > > > > > > > > > > > Every time when I connect external PS/2 keyboard to dock I see this > > > > > > message in dmesg: > > > > > > > > > > > > Spurious ACK... Some program might be trying to access hardware > > > > > > directly. > > > > > > > > > > > > I see it also every time when I dock laptop into docking station (to > > > > > > which is keyboard already connected). And it happens also when I > > > > > > connect > > > > > > external PS/2 mouse to dock. > > > > > > > > > > > > Dmitry, how to handle this situation to re-initialize psmouse.ko > > > > > > when > > > > > > external PS/2 device is connected to Dell E docking station? > > > > > > According > > > > > > to Mario, this is how Dell Embedded Controller is designed and > > > > > > suppose > > > > > > how OS should work with it. > > > > > > > > > > > > Manually rmmoding and modprobing for every docking/undocking laptop > > > > > > is > > > > > > not ideal solution. > > > &g
Re: Dell docking station & Dell Embedded Controller & PS/2 devices
On Monday 07 May 2018 12:33:06 Dmitry Torokhov wrote:
> On Mon, May 07, 2018 at 10:44:31AM +0200, Pali Rohár wrote:
> > On Sunday 06 May 2018 15:47:33 Pali Rohár wrote:
> > > On Thursday 01 February 2018 11:29:45 Dmitry Torokhov wrote:
> > > > Hi Pali,
> > > >
> > > > On Wed, Jan 24, 2018 at 11:41:21AM +0100, Pali Rohár wrote:
> > > > > Hi Dmitry!
> > > > >
> > > > > I'm observing a problem with internal touchpad (handled by psmouse.ko)
> > > > > on Dell laptops connected to Dell E docking station. When I connect
> > > > > external PS/2 keyboard to docking station then internal laptop
> > > > > touchpad
> > > > > switch from multitouch absolute mode to relative bare PS/2 mode.
> > > > >
> > > > > And because ALPS driver in psmouse.ko is capable to process
> > > > > interleaved
> > > > > bare 3-byte PS/2 packets with 6-byte ALPS packets (which handles
> > > > > trackstick data on some ALPS models), ALPS driver does not show any
> > > > > message about this "downgrade" from multitouch to bare mode. And
> > > > > continue working in bare mode.
> > > > >
> > > > > When I rmmod psmouse and modprobe it again, then touchpad switch back
> > > > > to
> > > > > multitouch mode.
> > > > >
> > > > > Mario told me that Dell Embedded Controller, which handle internal
> > > > > keyboard, internal touchpad and external PS/2 keyboard, automatically
> > > > > send RESET command to *all* those devices when external PS/2 keyboard
> > > > > is
> > > > > connected. Therefore this is reason why touchpad downgrade to to bare
> > > > > mode. And according to Mario, host system should issue vendor specific
> > > > > PS/2 commands to re-initialize all PS/2 devices when this situation
> > > > > happen. Mario also told me that Windows is doing this action.
> > > >
> > > > Yeah, I remember fun with Inspiron 8100 - when you dock it it woudl
> > > > silently switch Synaptics touchpad into standard mode and it would not
> > > > come back as Synaptics until you disconnect. And there was no
> > > > notification to the kernel as far as I could tell.
> > > >
> > > > It could be that we need to monitor dock events and then kick reconnect
> > > > of serio port, either from userspace via udev (I think that would be
> > > > preferred), or in kernel.
> > > >
> > > > >
> > > > > Every time when I connect external PS/2 keyboard to dock I see this
> > > > > message in dmesg:
> > > > >
> > > > > Spurious ACK... Some program might be trying to access hardware
> > > > > directly.
> > > > >
> > > > > I see it also every time when I dock laptop into docking station (to
> > > > > which is keyboard already connected). And it happens also when I
> > > > > connect
> > > > > external PS/2 mouse to dock.
> > > > >
> > > > > Dmitry, how to handle this situation to re-initialize psmouse.ko when
> > > > > external PS/2 device is connected to Dell E docking station? According
> > > > > to Mario, this is how Dell Embedded Controller is designed and suppose
> > > > > how OS should work with it.
> > > > >
> > > > > Manually rmmoding and modprobing for every docking/undocking laptop is
> > > > > not ideal solution.
> > > > >
> > > > > Could it be possible to use that Spurious ATKBD_RET_ACK from atkbd.c
> > > > > be
> > > > > handled on Dell systems (probably via DMI) as an event to reset and
> > > > > reinitialize all PS/2 devices?
> > > >
> > > > So we need to figure out what exactly we are getting from the docking
> > > > station in this case. We do try to handle the new device 0xaa 0x00
> > > > announcements:
> > > >
> > > > /* Check if this is a new device announcement (0xAA 0x00) */
> > > > if (unlikely(psmouse->packet[0] == PSMOUSE_RET_BAT &&
> > > > psmouse->pktcnt <= 2)) {
> > > > if (psmouse->pktcnt == 1) {
> > > > psmouse->last = jiffies;
> > > > goto out;
> > > > }
> > > >
> > > > if (psmouse->packet[1] == PSMOUSE_RET_ID ||
> > > > (psmouse->protocol->type == PSMOUSE_HGPK &&
> > > > psmouse->packet[1] == PSMOUSE_RET_BAT)) {
> > > > __psmouse_set_state(psmouse, PSMOUSE_IGNORE);
> > > > serio_reconnect(serio);
> > > > goto out;
> > > > }
> > > >
> > > > ...
> > > >
> > > > I am not sure where the "spurious ACK comes from". Can you enable i8042
> > > > debug before trying to dock and capture the data stream from the mouse?
> > > >
> > > > Thanks.
> > > >
> > >
> > > Hi Dmitry!
> > >
> > > I enabled unmask_kbd_data and debug and here is output from dmesg.
> > >
> > > echo Y > /sys/module/i8042/parameters/debug
> > > echo Y > /sys/module/i8042/parameters/unmask_kbd_data
> > >
> > > PS/2 keyboard is already connected in dock and laptop was just docked:
> > >
> > > [25461.552314] i8042: [6365474] fa <- i8042 (interrupt, 0, 1)
> > > [25461.552319] atkbd serio0: Spurious ACK on isa0060/serio0. Som
RE: Dell docking station & Dell Embedded Controller & PS/2 devices
> -Original Message- > From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com] > Sent: Monday, May 7, 2018 2:33 PM > To: Pali Rohár > Cc: Limonciello, Mario; linux-in...@vger.kernel.org; > linux-kernel@vger.kernel.org > Subject: Re: Dell docking station & Dell Embedded Controller & PS/2 devices > > On Mon, May 07, 2018 at 10:44:31AM +0200, Pali Rohár wrote: > > On Sunday 06 May 2018 15:47:33 Pali Rohár wrote: > > > On Thursday 01 February 2018 11:29:45 Dmitry Torokhov wrote: > > > > Hi Pali, > > > > > > > > On Wed, Jan 24, 2018 at 11:41:21AM +0100, Pali Rohár wrote: > > > > > Hi Dmitry! > > > > > > > > > > I'm observing a problem with internal touchpad (handled by psmouse.ko) > > > > > on Dell laptops connected to Dell E docking station. When I connect > > > > > external PS/2 keyboard to docking station then internal laptop > > > > > touchpad > > > > > switch from multitouch absolute mode to relative bare PS/2 mode. > > > > > > > > > > And because ALPS driver in psmouse.ko is capable to process > > > > > interleaved > > > > > bare 3-byte PS/2 packets with 6-byte ALPS packets (which handles > > > > > trackstick data on some ALPS models), ALPS driver does not show any > > > > > message about this "downgrade" from multitouch to bare mode. And > > > > > continue working in bare mode. > > > > > > > > > > When I rmmod psmouse and modprobe it again, then touchpad switch back > to > > > > > multitouch mode. > > > > > > > > > > Mario told me that Dell Embedded Controller, which handle internal > > > > > keyboard, internal touchpad and external PS/2 keyboard, automatically > > > > > send RESET command to *all* those devices when external PS/2 keyboard > > > > > is > > > > > connected. Therefore this is reason why touchpad downgrade to to bare > > > > > mode. And according to Mario, host system should issue vendor specific > > > > > PS/2 commands to re-initialize all PS/2 devices when this situation > > > > > happen. Mario also told me that Windows is doing this action. > > > > > > > > Yeah, I remember fun with Inspiron 8100 - when you dock it it woudl > > > > silently switch Synaptics touchpad into standard mode and it would not > > > > come back as Synaptics until you disconnect. And there was no > > > > notification to the kernel as far as I could tell. > > > > > > > > It could be that we need to monitor dock events and then kick reconnect > > > > of serio port, either from userspace via udev (I think that would be > > > > preferred), or in kernel. > > > > > > > > > > > > > > Every time when I connect external PS/2 keyboard to dock I see this > > > > > message in dmesg: > > > > > > > > > > Spurious ACK... Some program might be trying to access hardware > > > > > directly. > > > > > > > > > > I see it also every time when I dock laptop into docking station (to > > > > > which is keyboard already connected). And it happens also when I > > > > > connect > > > > > external PS/2 mouse to dock. > > > > > > > > > > Dmitry, how to handle this situation to re-initialize psmouse.ko when > > > > > external PS/2 device is connected to Dell E docking station? According > > > > > to Mario, this is how Dell Embedded Controller is designed and suppose > > > > > how OS should work with it. > > > > > > > > > > Manually rmmoding and modprobing for every docking/undocking laptop is > > > > > not ideal solution. > > > > > > > > > > Could it be possible to use that Spurious ATKBD_RET_ACK from atkbd.c > > > > > be > > > > > handled on Dell systems (probably via DMI) as an event to reset and > > > > > reinitialize all PS/2 devices? > > > > > > > > So we need to figure out what exactly we are getting from the docking > > > > station in this case. We do try to handle the new device 0xaa 0x00 > > > > announcements: > > > > > > > > /* Check if this is a new device announcement (0xAA 0x00) */ > > > > if (unlikely(psmouse->packet[0] == PSMOUSE_RET_BAT &
Re: Dell docking station & Dell Embedded Controller & PS/2 devices
On Mon, May 07, 2018 at 10:44:31AM +0200, Pali Rohár wrote:
> On Sunday 06 May 2018 15:47:33 Pali Rohár wrote:
> > On Thursday 01 February 2018 11:29:45 Dmitry Torokhov wrote:
> > > Hi Pali,
> > >
> > > On Wed, Jan 24, 2018 at 11:41:21AM +0100, Pali Rohár wrote:
> > > > Hi Dmitry!
> > > >
> > > > I'm observing a problem with internal touchpad (handled by psmouse.ko)
> > > > on Dell laptops connected to Dell E docking station. When I connect
> > > > external PS/2 keyboard to docking station then internal laptop touchpad
> > > > switch from multitouch absolute mode to relative bare PS/2 mode.
> > > >
> > > > And because ALPS driver in psmouse.ko is capable to process interleaved
> > > > bare 3-byte PS/2 packets with 6-byte ALPS packets (which handles
> > > > trackstick data on some ALPS models), ALPS driver does not show any
> > > > message about this "downgrade" from multitouch to bare mode. And
> > > > continue working in bare mode.
> > > >
> > > > When I rmmod psmouse and modprobe it again, then touchpad switch back to
> > > > multitouch mode.
> > > >
> > > > Mario told me that Dell Embedded Controller, which handle internal
> > > > keyboard, internal touchpad and external PS/2 keyboard, automatically
> > > > send RESET command to *all* those devices when external PS/2 keyboard is
> > > > connected. Therefore this is reason why touchpad downgrade to to bare
> > > > mode. And according to Mario, host system should issue vendor specific
> > > > PS/2 commands to re-initialize all PS/2 devices when this situation
> > > > happen. Mario also told me that Windows is doing this action.
> > >
> > > Yeah, I remember fun with Inspiron 8100 - when you dock it it woudl
> > > silently switch Synaptics touchpad into standard mode and it would not
> > > come back as Synaptics until you disconnect. And there was no
> > > notification to the kernel as far as I could tell.
> > >
> > > It could be that we need to monitor dock events and then kick reconnect
> > > of serio port, either from userspace via udev (I think that would be
> > > preferred), or in kernel.
> > >
> > > >
> > > > Every time when I connect external PS/2 keyboard to dock I see this
> > > > message in dmesg:
> > > >
> > > > Spurious ACK... Some program might be trying to access hardware
> > > > directly.
> > > >
> > > > I see it also every time when I dock laptop into docking station (to
> > > > which is keyboard already connected). And it happens also when I connect
> > > > external PS/2 mouse to dock.
> > > >
> > > > Dmitry, how to handle this situation to re-initialize psmouse.ko when
> > > > external PS/2 device is connected to Dell E docking station? According
> > > > to Mario, this is how Dell Embedded Controller is designed and suppose
> > > > how OS should work with it.
> > > >
> > > > Manually rmmoding and modprobing for every docking/undocking laptop is
> > > > not ideal solution.
> > > >
> > > > Could it be possible to use that Spurious ATKBD_RET_ACK from atkbd.c be
> > > > handled on Dell systems (probably via DMI) as an event to reset and
> > > > reinitialize all PS/2 devices?
> > >
> > > So we need to figure out what exactly we are getting from the docking
> > > station in this case. We do try to handle the new device 0xaa 0x00
> > > announcements:
> > >
> > > /* Check if this is a new device announcement (0xAA 0x00) */
> > > if (unlikely(psmouse->packet[0] == PSMOUSE_RET_BAT && psmouse->pktcnt
> > > <= 2)) {
> > > if (psmouse->pktcnt == 1) {
> > > psmouse->last = jiffies;
> > > goto out;
> > > }
> > >
> > > if (psmouse->packet[1] == PSMOUSE_RET_ID ||
> > > (psmouse->protocol->type == PSMOUSE_HGPK &&
> > >psmouse->packet[1] == PSMOUSE_RET_BAT)) {
> > > __psmouse_set_state(psmouse, PSMOUSE_IGNORE);
> > > serio_reconnect(serio);
> > > goto out;
> > > }
> > >
> > > ...
> > >
> > > I am not sure where the "spurious ACK comes from". Can you enable i8042
> > > debug before trying to dock and capture the data stream from the mouse?
> > >
> > > Thanks.
> > >
> >
> > Hi Dmitry!
> >
> > I enabled unmask_kbd_data and debug and here is output from dmesg.
> >
> > echo Y > /sys/module/i8042/parameters/debug
> > echo Y > /sys/module/i8042/parameters/unmask_kbd_data
> >
> > PS/2 keyboard is already connected in dock and laptop was just docked:
> >
> > [25461.552314] i8042: [6365474] fa <- i8042 (interrupt, 0, 1)
> > [25461.552319] atkbd serio0: Spurious ACK on isa0060/serio0. Some program
> > might be trying to access hardware directly.
> > [25462.707296] i8042: [6365763] ed -> i8042 (kbd-data)
> > [25462.851289] i8042: [6365799] fa <- i8042 (interrupt, 0, 1)
> > [25462.851303] i8042: [6365799] 00 -> i8042 (kbd-data)
> > [25462.858437] i8042: [6365801] fa <- i8042 (interrupt, 0, 1)
> > [25462.869512] i8042: [6365804] fa <- i8042 (interrupt, 0, 1)
> > [25462.869517] atkbd
Re: Dell docking station & Dell Embedded Controller & PS/2 devices
On Sunday 06 May 2018 15:47:33 Pali Rohár wrote:
> On Thursday 01 February 2018 11:29:45 Dmitry Torokhov wrote:
> > Hi Pali,
> >
> > On Wed, Jan 24, 2018 at 11:41:21AM +0100, Pali Rohár wrote:
> > > Hi Dmitry!
> > >
> > > I'm observing a problem with internal touchpad (handled by psmouse.ko)
> > > on Dell laptops connected to Dell E docking station. When I connect
> > > external PS/2 keyboard to docking station then internal laptop touchpad
> > > switch from multitouch absolute mode to relative bare PS/2 mode.
> > >
> > > And because ALPS driver in psmouse.ko is capable to process interleaved
> > > bare 3-byte PS/2 packets with 6-byte ALPS packets (which handles
> > > trackstick data on some ALPS models), ALPS driver does not show any
> > > message about this "downgrade" from multitouch to bare mode. And
> > > continue working in bare mode.
> > >
> > > When I rmmod psmouse and modprobe it again, then touchpad switch back to
> > > multitouch mode.
> > >
> > > Mario told me that Dell Embedded Controller, which handle internal
> > > keyboard, internal touchpad and external PS/2 keyboard, automatically
> > > send RESET command to *all* those devices when external PS/2 keyboard is
> > > connected. Therefore this is reason why touchpad downgrade to to bare
> > > mode. And according to Mario, host system should issue vendor specific
> > > PS/2 commands to re-initialize all PS/2 devices when this situation
> > > happen. Mario also told me that Windows is doing this action.
> >
> > Yeah, I remember fun with Inspiron 8100 - when you dock it it woudl
> > silently switch Synaptics touchpad into standard mode and it would not
> > come back as Synaptics until you disconnect. And there was no
> > notification to the kernel as far as I could tell.
> >
> > It could be that we need to monitor dock events and then kick reconnect
> > of serio port, either from userspace via udev (I think that would be
> > preferred), or in kernel.
> >
> > >
> > > Every time when I connect external PS/2 keyboard to dock I see this
> > > message in dmesg:
> > >
> > > Spurious ACK... Some program might be trying to access hardware directly.
> > >
> > > I see it also every time when I dock laptop into docking station (to
> > > which is keyboard already connected). And it happens also when I connect
> > > external PS/2 mouse to dock.
> > >
> > > Dmitry, how to handle this situation to re-initialize psmouse.ko when
> > > external PS/2 device is connected to Dell E docking station? According
> > > to Mario, this is how Dell Embedded Controller is designed and suppose
> > > how OS should work with it.
> > >
> > > Manually rmmoding and modprobing for every docking/undocking laptop is
> > > not ideal solution.
> > >
> > > Could it be possible to use that Spurious ATKBD_RET_ACK from atkbd.c be
> > > handled on Dell systems (probably via DMI) as an event to reset and
> > > reinitialize all PS/2 devices?
> >
> > So we need to figure out what exactly we are getting from the docking
> > station in this case. We do try to handle the new device 0xaa 0x00
> > announcements:
> >
> > /* Check if this is a new device announcement (0xAA 0x00) */
> > if (unlikely(psmouse->packet[0] == PSMOUSE_RET_BAT && psmouse->pktcnt
> > <= 2)) {
> > if (psmouse->pktcnt == 1) {
> > psmouse->last = jiffies;
> > goto out;
> > }
> >
> > if (psmouse->packet[1] == PSMOUSE_RET_ID ||
> > (psmouse->protocol->type == PSMOUSE_HGPK &&
> > psmouse->packet[1] == PSMOUSE_RET_BAT)) {
> > __psmouse_set_state(psmouse, PSMOUSE_IGNORE);
> > serio_reconnect(serio);
> > goto out;
> > }
> >
> > ...
> >
> > I am not sure where the "spurious ACK comes from". Can you enable i8042
> > debug before trying to dock and capture the data stream from the mouse?
> >
> > Thanks.
> >
>
> Hi Dmitry!
>
> I enabled unmask_kbd_data and debug and here is output from dmesg.
>
> echo Y > /sys/module/i8042/parameters/debug
> echo Y > /sys/module/i8042/parameters/unmask_kbd_data
>
> PS/2 keyboard is already connected in dock and laptop was just docked:
>
> [25461.552314] i8042: [6365474] fa <- i8042 (interrupt, 0, 1)
> [25461.552319] atkbd serio0: Spurious ACK on isa0060/serio0. Some program
> might be trying to access hardware directly.
> [25462.707296] i8042: [6365763] ed -> i8042 (kbd-data)
> [25462.851289] i8042: [6365799] fa <- i8042 (interrupt, 0, 1)
> [25462.851303] i8042: [6365799] 00 -> i8042 (kbd-data)
> [25462.858437] i8042: [6365801] fa <- i8042 (interrupt, 0, 1)
> [25462.869512] i8042: [6365804] fa <- i8042 (interrupt, 0, 1)
> [25462.869517] atkbd serio0: Spurious ACK on isa0060/serio0. Some program
> might be trying to access hardware directly.
> [25463.670515] i8042: [6366004] ed -> i8042 (kbd-data)
> [25463.670647] i8042: [6366004] fa <- i8042 (interrupt, 0, 1)
> [25463.670655] i8042: [6366004
Re: Dell docking station & Dell Embedded Controller & PS/2 devices
On Thursday 01 February 2018 11:29:45 Dmitry Torokhov wrote:
> Hi Pali,
>
> On Wed, Jan 24, 2018 at 11:41:21AM +0100, Pali Rohár wrote:
> > Hi Dmitry!
> >
> > I'm observing a problem with internal touchpad (handled by psmouse.ko)
> > on Dell laptops connected to Dell E docking station. When I connect
> > external PS/2 keyboard to docking station then internal laptop touchpad
> > switch from multitouch absolute mode to relative bare PS/2 mode.
> >
> > And because ALPS driver in psmouse.ko is capable to process interleaved
> > bare 3-byte PS/2 packets with 6-byte ALPS packets (which handles
> > trackstick data on some ALPS models), ALPS driver does not show any
> > message about this "downgrade" from multitouch to bare mode. And
> > continue working in bare mode.
> >
> > When I rmmod psmouse and modprobe it again, then touchpad switch back to
> > multitouch mode.
> >
> > Mario told me that Dell Embedded Controller, which handle internal
> > keyboard, internal touchpad and external PS/2 keyboard, automatically
> > send RESET command to *all* those devices when external PS/2 keyboard is
> > connected. Therefore this is reason why touchpad downgrade to to bare
> > mode. And according to Mario, host system should issue vendor specific
> > PS/2 commands to re-initialize all PS/2 devices when this situation
> > happen. Mario also told me that Windows is doing this action.
>
> Yeah, I remember fun with Inspiron 8100 - when you dock it it woudl
> silently switch Synaptics touchpad into standard mode and it would not
> come back as Synaptics until you disconnect. And there was no
> notification to the kernel as far as I could tell.
>
> It could be that we need to monitor dock events and then kick reconnect
> of serio port, either from userspace via udev (I think that would be
> preferred), or in kernel.
>
> >
> > Every time when I connect external PS/2 keyboard to dock I see this
> > message in dmesg:
> >
> > Spurious ACK... Some program might be trying to access hardware directly.
> >
> > I see it also every time when I dock laptop into docking station (to
> > which is keyboard already connected). And it happens also when I connect
> > external PS/2 mouse to dock.
> >
> > Dmitry, how to handle this situation to re-initialize psmouse.ko when
> > external PS/2 device is connected to Dell E docking station? According
> > to Mario, this is how Dell Embedded Controller is designed and suppose
> > how OS should work with it.
> >
> > Manually rmmoding and modprobing for every docking/undocking laptop is
> > not ideal solution.
> >
> > Could it be possible to use that Spurious ATKBD_RET_ACK from atkbd.c be
> > handled on Dell systems (probably via DMI) as an event to reset and
> > reinitialize all PS/2 devices?
>
> So we need to figure out what exactly we are getting from the docking
> station in this case. We do try to handle the new device 0xaa 0x00
> announcements:
>
> /* Check if this is a new device announcement (0xAA 0x00) */
> if (unlikely(psmouse->packet[0] == PSMOUSE_RET_BAT && psmouse->pktcnt
> <= 2)) {
> if (psmouse->pktcnt == 1) {
> psmouse->last = jiffies;
> goto out;
> }
>
> if (psmouse->packet[1] == PSMOUSE_RET_ID ||
> (psmouse->protocol->type == PSMOUSE_HGPK &&
>psmouse->packet[1] == PSMOUSE_RET_BAT)) {
> __psmouse_set_state(psmouse, PSMOUSE_IGNORE);
> serio_reconnect(serio);
> goto out;
> }
>
> ...
>
> I am not sure where the "spurious ACK comes from". Can you enable i8042
> debug before trying to dock and capture the data stream from the mouse?
>
> Thanks.
>
Hi Dmitry!
I enabled unmask_kbd_data and debug and here is output from dmesg.
echo Y > /sys/module/i8042/parameters/debug
echo Y > /sys/module/i8042/parameters/unmask_kbd_data
PS/2 keyboard is already connected in dock and laptop was just docked:
[25461.552314] i8042: [6365474] fa <- i8042 (interrupt, 0, 1)
[25461.552319] atkbd serio0: Spurious ACK on isa0060/serio0. Some program might
be trying to access hardware directly.
[25462.707296] i8042: [6365763] ed -> i8042 (kbd-data)
[25462.851289] i8042: [6365799] fa <- i8042 (interrupt, 0, 1)
[25462.851303] i8042: [6365799] 00 -> i8042 (kbd-data)
[25462.858437] i8042: [6365801] fa <- i8042 (interrupt, 0, 1)
[25462.869512] i8042: [6365804] fa <- i8042 (interrupt, 0, 1)
[25462.869517] atkbd serio0: Spurious ACK on isa0060/serio0. Some program might
be trying to access hardware directly.
[25463.670515] i8042: [6366004] ed -> i8042 (kbd-data)
[25463.670647] i8042: [6366004] fa <- i8042 (interrupt, 0, 1)
[25463.670655] i8042: [6366004] 02 -> i8042 (kbd-data)
[25463.676769] i8042: [6366005] fa <- i8042 (interrupt, 0, 1)
Laptop is docked and PS/2 keyboard was just connected:
[26571.014368] i8042: [6642848] fa <- i8042 (interrupt, 0, 1)
[26571.014380] atkbd serio0: Spuri
Re: Dell docking station & Dell Embedded Controller & PS/2 devices
On Thursday 01 February 2018 21:23:40 mario.limoncie...@dell.com wrote: > > -Original Message- > > From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com] > > Sent: Thursday, February 1, 2018 3:14 PM > > To: Limonciello, Mario > > Cc: Pali Rohár ; linux-in...@vger.kernel.org; lkml > > > ker...@vger.kernel.org> > > Subject: Re: Dell docking station & Dell Embedded Controller & PS/2 devices > > > > On Thu, Feb 1, 2018 at 11:35 AM, wrote: > > > > > > > > >> -Original Message- > > >> From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com] > > >> Sent: Thursday, February 1, 2018 1:30 PM > > >> To: Pali Rohár > > >> Cc: Limonciello, Mario ; linux- > > >> in...@vger.kernel.org; linux-kernel@vger.kernel.org > > >> Subject: Re: Dell docking station & Dell Embedded Controller & PS/2 > > >> devices > > >> > > >> Hi Pali, > > >> > > >> On Wed, Jan 24, 2018 at 11:41:21AM +0100, Pali Rohár wrote: > > >> > Hi Dmitry! > > >> > > > >> > I'm observing a problem with internal touchpad (handled by psmouse.ko) > > >> > on Dell laptops connected to Dell E docking station. When I connect > > >> > external PS/2 keyboard to docking station then internal laptop touchpad > > >> > switch from multitouch absolute mode to relative bare PS/2 mode. > > >> > > > >> > And because ALPS driver in psmouse.ko is capable to process interleaved > > >> > bare 3-byte PS/2 packets with 6-byte ALPS packets (which handles > > >> > trackstick data on some ALPS models), ALPS driver does not show any > > >> > message about this "downgrade" from multitouch to bare mode. And > > >> > continue working in bare mode. > > >> > > > >> > When I rmmod psmouse and modprobe it again, then touchpad switch back > > >> > to > > >> > multitouch mode. > > >> > > > >> > Mario told me that Dell Embedded Controller, which handle internal > > >> > keyboard, internal touchpad and external PS/2 keyboard, automatically > > >> > send RESET command to *all* those devices when external PS/2 keyboard > > >> > is > > >> > connected. Therefore this is reason why touchpad downgrade to to bare > > >> > mode. And according to Mario, host system should issue vendor specific > > >> > PS/2 commands to re-initialize all PS/2 devices when this situation > > >> > happen. Mario also told me that Windows is doing this action. > > >> > > >> Yeah, I remember fun with Inspiron 8100 - when you dock it it woudl > > >> silently switch Synaptics touchpad into standard mode and it would not > > >> come back as Synaptics until you disconnect. And there was no > > >> notification to the kernel as far as I could tell. > > >> > > >> It could be that we need to monitor dock events and then kick reconnect > > >> of serio port, either from userspace via udev (I think that would be > > >> preferred), or in kernel. > > >> > > >> > > > >> > Every time when I connect external PS/2 keyboard to dock I see this > > >> > message in dmesg: > > >> > > > >> > Spurious ACK... Some program might be trying to access hardware > > >> > directly. > > >> > > > >> > I see it also every time when I dock laptop into docking station (to > > >> > which is keyboard already connected). And it happens also when I > > >> > connect > > >> > external PS/2 mouse to dock. > > >> > > > >> > Dmitry, how to handle this situation to re-initialize psmouse.ko when > > >> > external PS/2 device is connected to Dell E docking station? According > > >> > to Mario, this is how Dell Embedded Controller is designed and suppose > > >> > how OS should work with it. > > >> > > > >> > Manually rmmoding and modprobing for every docking/undocking laptop is > > >> > not ideal solution. > > >> > > > >> > Could it be possible to use that Spurious ATKBD_RET_ACK from atkbd.c be > > >> > handled on Dell systems (probably via DMI) as an event to reset and > > >> > reinitialize all PS/2 devices? > > >> > > >> So we need to figur
RE: Dell docking station & Dell Embedded Controller & PS/2 devices
> -Original Message- > From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com] > Sent: Thursday, February 1, 2018 3:14 PM > To: Limonciello, Mario > Cc: Pali Rohár ; linux-in...@vger.kernel.org; lkml > ker...@vger.kernel.org> > Subject: Re: Dell docking station & Dell Embedded Controller & PS/2 devices > > On Thu, Feb 1, 2018 at 11:35 AM, wrote: > > > > > >> -Original Message- > >> From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com] > >> Sent: Thursday, February 1, 2018 1:30 PM > >> To: Pali Rohár > >> Cc: Limonciello, Mario ; linux- > >> in...@vger.kernel.org; linux-kernel@vger.kernel.org > >> Subject: Re: Dell docking station & Dell Embedded Controller & PS/2 devices > >> > >> Hi Pali, > >> > >> On Wed, Jan 24, 2018 at 11:41:21AM +0100, Pali Rohár wrote: > >> > Hi Dmitry! > >> > > >> > I'm observing a problem with internal touchpad (handled by psmouse.ko) > >> > on Dell laptops connected to Dell E docking station. When I connect > >> > external PS/2 keyboard to docking station then internal laptop touchpad > >> > switch from multitouch absolute mode to relative bare PS/2 mode. > >> > > >> > And because ALPS driver in psmouse.ko is capable to process interleaved > >> > bare 3-byte PS/2 packets with 6-byte ALPS packets (which handles > >> > trackstick data on some ALPS models), ALPS driver does not show any > >> > message about this "downgrade" from multitouch to bare mode. And > >> > continue working in bare mode. > >> > > >> > When I rmmod psmouse and modprobe it again, then touchpad switch back to > >> > multitouch mode. > >> > > >> > Mario told me that Dell Embedded Controller, which handle internal > >> > keyboard, internal touchpad and external PS/2 keyboard, automatically > >> > send RESET command to *all* those devices when external PS/2 keyboard is > >> > connected. Therefore this is reason why touchpad downgrade to to bare > >> > mode. And according to Mario, host system should issue vendor specific > >> > PS/2 commands to re-initialize all PS/2 devices when this situation > >> > happen. Mario also told me that Windows is doing this action. > >> > >> Yeah, I remember fun with Inspiron 8100 - when you dock it it woudl > >> silently switch Synaptics touchpad into standard mode and it would not > >> come back as Synaptics until you disconnect. And there was no > >> notification to the kernel as far as I could tell. > >> > >> It could be that we need to monitor dock events and then kick reconnect > >> of serio port, either from userspace via udev (I think that would be > >> preferred), or in kernel. > >> > >> > > >> > Every time when I connect external PS/2 keyboard to dock I see this > >> > message in dmesg: > >> > > >> > Spurious ACK... Some program might be trying to access hardware directly. > >> > > >> > I see it also every time when I dock laptop into docking station (to > >> > which is keyboard already connected). And it happens also when I connect > >> > external PS/2 mouse to dock. > >> > > >> > Dmitry, how to handle this situation to re-initialize psmouse.ko when > >> > external PS/2 device is connected to Dell E docking station? According > >> > to Mario, this is how Dell Embedded Controller is designed and suppose > >> > how OS should work with it. > >> > > >> > Manually rmmoding and modprobing for every docking/undocking laptop is > >> > not ideal solution. > >> > > >> > Could it be possible to use that Spurious ATKBD_RET_ACK from atkbd.c be > >> > handled on Dell systems (probably via DMI) as an event to reset and > >> > reinitialize all PS/2 devices? > >> > >> So we need to figure out what exactly we are getting from the docking > >> station in this case. We do try to handle the new device 0xaa 0x00 > >> announcements: > > > > Docking station itself won't have sent any events. The PS2 ports in it > > are electrically wired to the external PS2 pins in the docking adapter on > > the system. > > > > System EC is what will be sending any PS2 events. > > OK, it does not matter from the input layer POW, if they are PS/2 > events they should be coming from i8042. > > > > >> >
Re: Dell docking station & Dell Embedded Controller & PS/2 devices
On Thu, Feb 1, 2018 at 11:35 AM, wrote:
>
>
>> -Original Message-
>> From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com]
>> Sent: Thursday, February 1, 2018 1:30 PM
>> To: Pali Rohár
>> Cc: Limonciello, Mario ; linux-
>> in...@vger.kernel.org; linux-kernel@vger.kernel.org
>> Subject: Re: Dell docking station & Dell Embedded Controller & PS/2 devices
>>
>> Hi Pali,
>>
>> On Wed, Jan 24, 2018 at 11:41:21AM +0100, Pali Rohár wrote:
>> > Hi Dmitry!
>> >
>> > I'm observing a problem with internal touchpad (handled by psmouse.ko)
>> > on Dell laptops connected to Dell E docking station. When I connect
>> > external PS/2 keyboard to docking station then internal laptop touchpad
>> > switch from multitouch absolute mode to relative bare PS/2 mode.
>> >
>> > And because ALPS driver in psmouse.ko is capable to process interleaved
>> > bare 3-byte PS/2 packets with 6-byte ALPS packets (which handles
>> > trackstick data on some ALPS models), ALPS driver does not show any
>> > message about this "downgrade" from multitouch to bare mode. And
>> > continue working in bare mode.
>> >
>> > When I rmmod psmouse and modprobe it again, then touchpad switch back to
>> > multitouch mode.
>> >
>> > Mario told me that Dell Embedded Controller, which handle internal
>> > keyboard, internal touchpad and external PS/2 keyboard, automatically
>> > send RESET command to *all* those devices when external PS/2 keyboard is
>> > connected. Therefore this is reason why touchpad downgrade to to bare
>> > mode. And according to Mario, host system should issue vendor specific
>> > PS/2 commands to re-initialize all PS/2 devices when this situation
>> > happen. Mario also told me that Windows is doing this action.
>>
>> Yeah, I remember fun with Inspiron 8100 - when you dock it it woudl
>> silently switch Synaptics touchpad into standard mode and it would not
>> come back as Synaptics until you disconnect. And there was no
>> notification to the kernel as far as I could tell.
>>
>> It could be that we need to monitor dock events and then kick reconnect
>> of serio port, either from userspace via udev (I think that would be
>> preferred), or in kernel.
>>
>> >
>> > Every time when I connect external PS/2 keyboard to dock I see this
>> > message in dmesg:
>> >
>> > Spurious ACK... Some program might be trying to access hardware directly.
>> >
>> > I see it also every time when I dock laptop into docking station (to
>> > which is keyboard already connected). And it happens also when I connect
>> > external PS/2 mouse to dock.
>> >
>> > Dmitry, how to handle this situation to re-initialize psmouse.ko when
>> > external PS/2 device is connected to Dell E docking station? According
>> > to Mario, this is how Dell Embedded Controller is designed and suppose
>> > how OS should work with it.
>> >
>> > Manually rmmoding and modprobing for every docking/undocking laptop is
>> > not ideal solution.
>> >
>> > Could it be possible to use that Spurious ATKBD_RET_ACK from atkbd.c be
>> > handled on Dell systems (probably via DMI) as an event to reset and
>> > reinitialize all PS/2 devices?
>>
>> So we need to figure out what exactly we are getting from the docking
>> station in this case. We do try to handle the new device 0xaa 0x00
>> announcements:
>
> Docking station itself won't have sent any events. The PS2 ports in it
> are electrically wired to the external PS2 pins in the docking adapter on
> the system.
>
> System EC is what will be sending any PS2 events.
OK, it does not matter from the input layer POW, if they are PS/2
events they should be coming from i8042.
>
>>
>> /* Check if this is a new device announcement (0xAA 0x00) */
>> if (unlikely(psmouse->packet[0] == PSMOUSE_RET_BAT && psmouse-
>> >pktcnt <= 2)) {
>> if (psmouse->pktcnt == 1) {
>> psmouse->last = jiffies;
>> goto out;
>> }
>>
>> if (psmouse->packet[1] == PSMOUSE_RET_ID ||
>> (psmouse->protocol->type == PSMOUSE_HGPK &&
>>psmouse->packet[1] == PSMOUSE_RET_BAT)) {
>> __psmouse_set_state(psmouse, PSMOUSE_IGNORE);
>> serio_reconnect(serio);
>> goto out;
>> }
>>
>> ...
>>
>> I am not sure where the "spurious ACK comes from". Can you enable i8042
>> debug before trying to dock and capture the data stream from the mouse?
>>
>
> The system EC has reset PS2 devices (but AFAIK kernel won't have seen this
> communication).
So what kind of communication does EC send when docking? It sounds it
is completely out of band from PS/2 connection.
Thanks.
--
Dmitry
RE: Dell docking station & Dell Embedded Controller & PS/2 devices
> -Original Message-
> From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com]
> Sent: Thursday, February 1, 2018 1:30 PM
> To: Pali Rohár
> Cc: Limonciello, Mario ; linux-
> in...@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: Dell docking station & Dell Embedded Controller & PS/2 devices
>
> Hi Pali,
>
> On Wed, Jan 24, 2018 at 11:41:21AM +0100, Pali Rohár wrote:
> > Hi Dmitry!
> >
> > I'm observing a problem with internal touchpad (handled by psmouse.ko)
> > on Dell laptops connected to Dell E docking station. When I connect
> > external PS/2 keyboard to docking station then internal laptop touchpad
> > switch from multitouch absolute mode to relative bare PS/2 mode.
> >
> > And because ALPS driver in psmouse.ko is capable to process interleaved
> > bare 3-byte PS/2 packets with 6-byte ALPS packets (which handles
> > trackstick data on some ALPS models), ALPS driver does not show any
> > message about this "downgrade" from multitouch to bare mode. And
> > continue working in bare mode.
> >
> > When I rmmod psmouse and modprobe it again, then touchpad switch back to
> > multitouch mode.
> >
> > Mario told me that Dell Embedded Controller, which handle internal
> > keyboard, internal touchpad and external PS/2 keyboard, automatically
> > send RESET command to *all* those devices when external PS/2 keyboard is
> > connected. Therefore this is reason why touchpad downgrade to to bare
> > mode. And according to Mario, host system should issue vendor specific
> > PS/2 commands to re-initialize all PS/2 devices when this situation
> > happen. Mario also told me that Windows is doing this action.
>
> Yeah, I remember fun with Inspiron 8100 - when you dock it it woudl
> silently switch Synaptics touchpad into standard mode and it would not
> come back as Synaptics until you disconnect. And there was no
> notification to the kernel as far as I could tell.
>
> It could be that we need to monitor dock events and then kick reconnect
> of serio port, either from userspace via udev (I think that would be
> preferred), or in kernel.
>
> >
> > Every time when I connect external PS/2 keyboard to dock I see this
> > message in dmesg:
> >
> > Spurious ACK... Some program might be trying to access hardware directly.
> >
> > I see it also every time when I dock laptop into docking station (to
> > which is keyboard already connected). And it happens also when I connect
> > external PS/2 mouse to dock.
> >
> > Dmitry, how to handle this situation to re-initialize psmouse.ko when
> > external PS/2 device is connected to Dell E docking station? According
> > to Mario, this is how Dell Embedded Controller is designed and suppose
> > how OS should work with it.
> >
> > Manually rmmoding and modprobing for every docking/undocking laptop is
> > not ideal solution.
> >
> > Could it be possible to use that Spurious ATKBD_RET_ACK from atkbd.c be
> > handled on Dell systems (probably via DMI) as an event to reset and
> > reinitialize all PS/2 devices?
>
> So we need to figure out what exactly we are getting from the docking
> station in this case. We do try to handle the new device 0xaa 0x00
> announcements:
Docking station itself won't have sent any events. The PS2 ports in it
are electrically wired to the external PS2 pins in the docking adapter on
the system.
System EC is what will be sending any PS2 events.
>
> /* Check if this is a new device announcement (0xAA 0x00) */
> if (unlikely(psmouse->packet[0] == PSMOUSE_RET_BAT && psmouse-
> >pktcnt <= 2)) {
> if (psmouse->pktcnt == 1) {
> psmouse->last = jiffies;
> goto out;
> }
>
> if (psmouse->packet[1] == PSMOUSE_RET_ID ||
> (psmouse->protocol->type == PSMOUSE_HGPK &&
>psmouse->packet[1] == PSMOUSE_RET_BAT)) {
> __psmouse_set_state(psmouse, PSMOUSE_IGNORE);
> serio_reconnect(serio);
> goto out;
> }
>
> ...
>
> I am not sure where the "spurious ACK comes from". Can you enable i8042
> debug before trying to dock and capture the data stream from the mouse?
>
The system EC has reset PS2 devices (but AFAIK kernel won't have seen this
communication).
Re: Dell docking station & Dell Embedded Controller & PS/2 devices
Hi Pali,
On Wed, Jan 24, 2018 at 11:41:21AM +0100, Pali Rohár wrote:
> Hi Dmitry!
>
> I'm observing a problem with internal touchpad (handled by psmouse.ko)
> on Dell laptops connected to Dell E docking station. When I connect
> external PS/2 keyboard to docking station then internal laptop touchpad
> switch from multitouch absolute mode to relative bare PS/2 mode.
>
> And because ALPS driver in psmouse.ko is capable to process interleaved
> bare 3-byte PS/2 packets with 6-byte ALPS packets (which handles
> trackstick data on some ALPS models), ALPS driver does not show any
> message about this "downgrade" from multitouch to bare mode. And
> continue working in bare mode.
>
> When I rmmod psmouse and modprobe it again, then touchpad switch back to
> multitouch mode.
>
> Mario told me that Dell Embedded Controller, which handle internal
> keyboard, internal touchpad and external PS/2 keyboard, automatically
> send RESET command to *all* those devices when external PS/2 keyboard is
> connected. Therefore this is reason why touchpad downgrade to to bare
> mode. And according to Mario, host system should issue vendor specific
> PS/2 commands to re-initialize all PS/2 devices when this situation
> happen. Mario also told me that Windows is doing this action.
Yeah, I remember fun with Inspiron 8100 - when you dock it it woudl
silently switch Synaptics touchpad into standard mode and it would not
come back as Synaptics until you disconnect. And there was no
notification to the kernel as far as I could tell.
It could be that we need to monitor dock events and then kick reconnect
of serio port, either from userspace via udev (I think that would be
preferred), or in kernel.
>
> Every time when I connect external PS/2 keyboard to dock I see this
> message in dmesg:
>
> Spurious ACK... Some program might be trying to access hardware directly.
>
> I see it also every time when I dock laptop into docking station (to
> which is keyboard already connected). And it happens also when I connect
> external PS/2 mouse to dock.
>
> Dmitry, how to handle this situation to re-initialize psmouse.ko when
> external PS/2 device is connected to Dell E docking station? According
> to Mario, this is how Dell Embedded Controller is designed and suppose
> how OS should work with it.
>
> Manually rmmoding and modprobing for every docking/undocking laptop is
> not ideal solution.
>
> Could it be possible to use that Spurious ATKBD_RET_ACK from atkbd.c be
> handled on Dell systems (probably via DMI) as an event to reset and
> reinitialize all PS/2 devices?
So we need to figure out what exactly we are getting from the docking
station in this case. We do try to handle the new device 0xaa 0x00
announcements:
/* Check if this is a new device announcement (0xAA 0x00) */
if (unlikely(psmouse->packet[0] == PSMOUSE_RET_BAT && psmouse->pktcnt
<= 2)) {
if (psmouse->pktcnt == 1) {
psmouse->last = jiffies;
goto out;
}
if (psmouse->packet[1] == PSMOUSE_RET_ID ||
(psmouse->protocol->type == PSMOUSE_HGPK &&
psmouse->packet[1] == PSMOUSE_RET_BAT)) {
__psmouse_set_state(psmouse, PSMOUSE_IGNORE);
serio_reconnect(serio);
goto out;
}
...
I am not sure where the "spurious ACK comes from". Can you enable i8042
debug before trying to dock and capture the data stream from the mouse?
Thanks.
--
Dmitry
