Re: Hackbench pipes regression bisected to PSI

2018-11-27 Thread Johannes Weiner
On Tue, Nov 27, 2018 at 11:46:17AM -0500, Johannes Weiner wrote: > From 347b69a52d1ec7e71df1108cbc5703d6dd0616ba Mon Sep 17 00:00:00 2001 > From: Johannes Weiner > Date: Mon, 26 Nov 2018 09:39:23 -0500 > Subject: [PATCH] psi: make disabling/enabling easier for vendor kernels > > Mel Gorman

Re: Hackbench pipes regression bisected to PSI

2018-11-27 Thread Johannes Weiner
On Tue, Nov 27, 2018 at 11:46:17AM -0500, Johannes Weiner wrote: > From 347b69a52d1ec7e71df1108cbc5703d6dd0616ba Mon Sep 17 00:00:00 2001 > From: Johannes Weiner > Date: Mon, 26 Nov 2018 09:39:23 -0500 > Subject: [PATCH] psi: make disabling/enabling easier for vendor kernels > > Mel Gorman

Re: Hackbench pipes regression bisected to PSI

2018-11-27 Thread Johannes Weiner
On Mon, Nov 26, 2018 at 11:29:26PM +, Mel Gorman wrote: > The following is a comparision using CONFIG_PSI=n as a baseline against > your patch and a vanilla kernel > > 4.20.0-rc4 4.20.0-rc4 > 4.20.0-rc4 > kconfigdisable-v1r1

Re: Hackbench pipes regression bisected to PSI

2018-11-27 Thread Johannes Weiner
On Mon, Nov 26, 2018 at 11:29:26PM +, Mel Gorman wrote: > The following is a comparision using CONFIG_PSI=n as a baseline against > your patch and a vanilla kernel > > 4.20.0-rc4 4.20.0-rc4 > 4.20.0-rc4 > kconfigdisable-v1r1

Re: Hackbench pipes regression bisected to PSI

2018-11-26 Thread Mel Gorman
On Mon, Nov 26, 2018 at 12:32:18PM -0500, Johannes Weiner wrote: > > > > Bit late to notice but this switch should be in > > Documentation/admin-guide/kernel-parameters.txt. If you really want to > > match the automatic numa balancing switch then it also should be > > psi=[enable|disable] instead

Re: Hackbench pipes regression bisected to PSI

2018-11-26 Thread Mel Gorman
On Mon, Nov 26, 2018 at 12:32:18PM -0500, Johannes Weiner wrote: > > > > Bit late to notice but this switch should be in > > Documentation/admin-guide/kernel-parameters.txt. If you really want to > > match the automatic numa balancing switch then it also should be > > psi=[enable|disable] instead

Re: Hackbench pipes regression bisected to PSI

2018-11-26 Thread Mel Gorman
On Mon, Nov 26, 2018 at 12:32:18PM -0500, Johannes Weiner wrote: > On Mon, Nov 26, 2018 at 04:54:47PM +, Mel Gorman wrote: > > On Mon, Nov 26, 2018 at 11:07:24AM -0500, Johannes Weiner wrote: > > > @@ -509,6 +509,15 @@ config PSI > > > > > > Say N if unsure. > > > > > > +config

Re: Hackbench pipes regression bisected to PSI

2018-11-26 Thread Mel Gorman
On Mon, Nov 26, 2018 at 12:32:18PM -0500, Johannes Weiner wrote: > On Mon, Nov 26, 2018 at 04:54:47PM +, Mel Gorman wrote: > > On Mon, Nov 26, 2018 at 11:07:24AM -0500, Johannes Weiner wrote: > > > @@ -509,6 +509,15 @@ config PSI > > > > > > Say N if unsure. > > > > > > +config

Re: Hackbench pipes regression bisected to PSI

2018-11-26 Thread Johannes Weiner
On Mon, Nov 26, 2018 at 04:54:47PM +, Mel Gorman wrote: > On Mon, Nov 26, 2018 at 11:07:24AM -0500, Johannes Weiner wrote: > > @@ -509,6 +509,15 @@ config PSI > > > > Say N if unsure. > > > > +config PSI_DEFAULT_DISABLED > > + bool "Require boot parameter to enable pressure stall

Re: Hackbench pipes regression bisected to PSI

2018-11-26 Thread Johannes Weiner
On Mon, Nov 26, 2018 at 04:54:47PM +, Mel Gorman wrote: > On Mon, Nov 26, 2018 at 11:07:24AM -0500, Johannes Weiner wrote: > > @@ -509,6 +509,15 @@ config PSI > > > > Say N if unsure. > > > > +config PSI_DEFAULT_DISABLED > > + bool "Require boot parameter to enable pressure stall

Re: Hackbench pipes regression bisected to PSI

2018-11-26 Thread Mel Gorman
On Mon, Nov 26, 2018 at 11:07:24AM -0500, Johannes Weiner wrote: > Hi Mel, > > On Mon, Nov 26, 2018 at 01:34:20PM +, Mel Gorman wrote: > > Hi Johannes, > > > > PSI is a great idea but it does have overhead and if enabled by Kconfig > > then it incurs a hit whether the user is aware of the

Re: Hackbench pipes regression bisected to PSI

2018-11-26 Thread Mel Gorman
On Mon, Nov 26, 2018 at 11:07:24AM -0500, Johannes Weiner wrote: > Hi Mel, > > On Mon, Nov 26, 2018 at 01:34:20PM +, Mel Gorman wrote: > > Hi Johannes, > > > > PSI is a great idea but it does have overhead and if enabled by Kconfig > > then it incurs a hit whether the user is aware of the

Re: Hackbench pipes regression bisected to PSI

2018-11-26 Thread Johannes Weiner
Hi Mel, On Mon, Nov 26, 2018 at 01:34:20PM +, Mel Gorman wrote: > Hi Johannes, > > PSI is a great idea but it does have overhead and if enabled by Kconfig > then it incurs a hit whether the user is aware of the feature or not. I > think enabling by default is unnecessary as it should only be

Re: Hackbench pipes regression bisected to PSI

2018-11-26 Thread Johannes Weiner
Hi Mel, On Mon, Nov 26, 2018 at 01:34:20PM +, Mel Gorman wrote: > Hi Johannes, > > PSI is a great idea but it does have overhead and if enabled by Kconfig > then it incurs a hit whether the user is aware of the feature or not. I > think enabling by default is unnecessary as it should only be