Re: No sound (es1371) after test7
On Sun, 24 Sep 2000, Jeff Garzik wrote:
>
> h The patch was submitted by me, but it came straight from
> 2.2.x... after being whipped, I shall look into both versions of
> ac97_codec some more...
The "->id" field has nothing to do with the device ID number, it's a
"which codec is this" field, and is zero for the master ac97 codec. See
how it is used - it's basically used mostly as
if (codec->id) {
... handle secondary codec case ...
and thus the change to ac97_codec.c completely broke most all codec
handling because suddenly all codec were "secondary".
Yeah, it's probably bad naming - it should probably use something like
"codex->index" instead of "codec->id".
But I'm surprised that it works at all in 2.2.x - that implies that the
2.2.x code is completely different from the 2.4.x logic.
Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/
Re: No sound (es1371) after test7
> > codec->id = ac97_codec_ids[i].id; > > > > (line 591 or something around that), and be happy. I think it will work > > after that. > > This does indeed fix the problem. ELO is playing via XMMS at the > moment to prove it. :-) Also killed in 2.2.18pre. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: No sound (es1371) after test7
> For some unknown reason codec->id is set in ac97_probe_codec(), which is > WRONG. Just remove the line that says > > codec->id = ac97_codec_ids[i].id; > > (line 591 or something around that), and be happy. I think it will work > after that. Its an escapee bug from 2.2 that leaked into 2.4. Not the fault of whoever forward ported, its a debugging thing that wasnt removed - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: No sound (es1371) after test7
On 23 Sep 2000, Linus Torvalds wrote: > Linus Torvalds <[EMAIL PROTECTED]> wrote: > > > >Go into "drivers/sound/ac97_codec.c" to around line 570 or so, and > >comment out the line that says > > > > current->state = TASK_UNINTERRUPTIBLE; > > > >and see if that fixes the problem. > > Nope. But I found another "bugfix" that seems to completely miss the > mark. > > For some unknown reason codec->id is set in ac97_probe_codec(), which is > WRONG. Just remove the line that says > > codec->id = ac97_codec_ids[i].id; > > (line 591 or something around that), and be happy. I think it will work > after that. > > I will now hunt down the person who sent me that patch, and do nasty > things to him. After I whip myself for accepting it in the first place. h The patch was submitted by me, but it came straight from 2.2.x... after being whipped, I shall look into both versions of ac97_codec some more... Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: No sound (es1371) after test7
On Sat, Sep 23, 2000 at 11:15:31PM -0700, Linus Torvalds wrote: > >Go into "drivers/sound/ac97_codec.c" > WRONG. Just remove the line that says > > codec->id = ac97_codec_ids[i].id; > > (line 591 or something around that), and be happy. I think it will work > after that. This does indeed fix the problem. ELO is playing via XMMS at the moment to prove it. :-) Thanks Linus, Jon. -- Jon Evans / Red Internet Ltd. / +44 1869 337977 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: No sound (es1371) after test7
In article <8qk483$4ua$[EMAIL PROTECTED]>, Linus Torvalds <[EMAIL PROTECTED]> wrote: > >Go into "drivers/sound/ac97_codec.c" to around line 570 or so, and >comment out the line that says > > current->state = TASK_UNINTERRUPTIBLE; > >and see if that fixes the problem. Nope. But I found another "bugfix" that seems to completely miss the mark. For some unknown reason codec->id is set in ac97_probe_codec(), which is WRONG. Just remove the line that says codec->id = ac97_codec_ids[i].id; (line 591 or something around that), and be happy. I think it will work after that. I will now hunt down the person who sent me that patch, and do nasty things to him. After I whip myself for accepting it in the first place. Pls tell me if removing that line still doesn't give you sound back, Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: No sound (es1371) after test7
In article 8qk483$4ua$[EMAIL PROTECTED], Linus Torvalds [EMAIL PROTECTED] wrote: Go into "drivers/sound/ac97_codec.c" to around line 570 or so, and comment out the line that says current-state = TASK_UNINTERRUPTIBLE; and see if that fixes the problem. Nope. But I found another "bugfix" that seems to completely miss the mark. For some unknown reason codec-id is set in ac97_probe_codec(), which is WRONG. Just remove the line that says codec-id = ac97_codec_ids[i].id; (line 591 or something around that), and be happy. I think it will work after that. I will now hunt down the person who sent me that patch, and do nasty things to him. After I whip myself for accepting it in the first place. Pls tell me if removing that line still doesn't give you sound back, Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: No sound (es1371) after test7
On Sat, Sep 23, 2000 at 11:15:31PM -0700, Linus Torvalds wrote: Go into "drivers/sound/ac97_codec.c" WRONG. Just remove the line that says codec-id = ac97_codec_ids[i].id; (line 591 or something around that), and be happy. I think it will work after that. This does indeed fix the problem. ELO is playing via XMMS at the moment to prove it. :-) Thanks Linus, Jon. -- Jon Evans / Red Internet Ltd. / +44 1869 337977 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: No sound (es1371) after test7
On 23 Sep 2000, Linus Torvalds wrote: Linus Torvalds [EMAIL PROTECTED] wrote: Go into "drivers/sound/ac97_codec.c" to around line 570 or so, and comment out the line that says current-state = TASK_UNINTERRUPTIBLE; and see if that fixes the problem. Nope. But I found another "bugfix" that seems to completely miss the mark. For some unknown reason codec-id is set in ac97_probe_codec(), which is WRONG. Just remove the line that says codec-id = ac97_codec_ids[i].id; (line 591 or something around that), and be happy. I think it will work after that. I will now hunt down the person who sent me that patch, and do nasty things to him. After I whip myself for accepting it in the first place. h The patch was submitted by me, but it came straight from 2.2.x... after being whipped, I shall look into both versions of ac97_codec some more... Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: No sound (es1371) after test7
On Sun, 24 Sep 2000, Jeff Garzik wrote:
h The patch was submitted by me, but it came straight from
2.2.x... after being whipped, I shall look into both versions of
ac97_codec some more...
The "-id" field has nothing to do with the device ID number, it's a
"which codec is this" field, and is zero for the master ac97 codec. See
how it is used - it's basically used mostly as
if (codec-id) {
... handle secondary codec case ...
and thus the change to ac97_codec.c completely broke most all codec
handling because suddenly all codec were "secondary".
Yeah, it's probably bad naming - it should probably use something like
"codex-index" instead of "codec-id".
But I'm surprised that it works at all in 2.2.x - that implies that the
2.2.x code is completely different from the 2.4.x logic.
Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/
Re: No sound (es1371) after test7
In article <[EMAIL PROTECTED]>, Jon Evans <[EMAIL PROTECTED]> wrote: >On Fri, Sep 22, 2000 at 09:14:23AM -0400, Kernel Related Emails wrote: > >> Well everythings working fine in test9-pre5 except for the fact that sound >> has stopped functioning on my es1371 card. I had no problems with it at >> all in test7 but since then it doesn't work. On boot it detects normally, >> pops and crackles for a second, and then just doesn't work. Any >> ideas? I'm getting no kernel messages or any output that would indicate >> the problem. > >Just as a data point, I have the same problem. /dev/dsp seems to block when opened. Ehh. One of the differences in the test9-pre kernels is a "trivial bugfix" that actually makes one of the "schedule_timeout()" calls in drivers/sound/ac97_codec.c actually _do_ something. Go into "drivers/sound/ac97_codec.c" to around line 570 or so, and comment out the line that says current->state = TASK_UNINTERRUPTIBLE; and see if that fixes the problem. Now, removing the above line will basically make the schdule_timeout() be a no-op, so on the face of it the code has always before been completely nonsensical. But maybe the nonsensical code works, and the logical code is broken. As far as I can tell, no other changes have happened in the sound drivers, which is why I'd ask people to do this apparently idiotic reversal of that single line.. Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: No sound (es1371) after test7
On Fri, Sep 22, 2000 at 09:14:23AM -0400, Kernel Related Emails wrote: > Well everythings working fine in test9-pre5 except for the fact that sound > has stopped functioning on my es1371 card. I had no problems with it at > all in test7 but since then it doesn't work. On boot it detects normally, > pops and crackles for a second, and then just doesn't work. Any > ideas? I'm getting no kernel messages or any output that would indicate > the problem. Just as a data point, I have the same problem. /dev/dsp seems to block when opened. kernel: es1371: version v0.26 time 21:39:34 Sep 21 2000 kernel: es1371: found chip, vendor id 0x1274 device id 0x1371 revision 0x08 kernel: es1371: found es1371 rev 8 at io 0xc400 irq 19 kernel: es1371: features: joystick 0x0 kernel: ac97_codec: AC97 audio codec, id: 0x8384:0x7609 (SigmaTel STAC9721/23) Jon. -- Jon Evans / Red Internet Ltd. / +44 1869 337977 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: No sound (es1371) after test7
On 2000-9-23 06:26:27 "H. Peter Anvin" wrote: >With 2.4.0-test9-pre6, I don't get anything (writers on /dev/dsp block >indefinitely) using the es1371 driver, with the following specs: > >es1371: version v0.26 time 21:30:39 Sep 22 2000 >es1371: found chip, vendor id 0x1274 device id 0x1371 revision 0x08 >es1371: found es1371 rev 8 at io 0xef00 irq 18 >es1371: features: joystick 0x0 >ac97_codec: AC97 audio codec, id: 0x8384:0x7609 (SigmaTel STAC9721/23) I'm running 2.4.0-test9-pre6 with my es1371 sound working just fine. Here is a snippet from messages: kernel: <6>es1371: version v0.26 time 08:02:58 Sep 23 2000 kernel: <6>es1371: found chip, vendor id 0x1274 device id 0x1371 revision 0x06 kernel: <6>es1371: found es1371 rev 6 at io 0x1080 irq 11 kernel: <6>es1371: features: joystick 0x0 sound: Loading sound module (es1371) succeeded I also first ran the system with support for es1371 compiled in, and that worked fine too. This is running on sparkling new Linux-Mandrake 7.2 beta 3 distro. One possible glitch with the sound; the mixer on my system was defaulted to zero volume at first, so you obviously have to crank that up to hear anything. Good luck to all. Regards, Steven Cole - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: No sound (es1371) after test7
Followup to: <[EMAIL PROTECTED]> By author:Mordechai Ovits <[EMAIL PROTECTED]> In newsgroup: linux.dev.kernel > > On Fri, Sep 22, 2000 at 09:14:23AM -0400, Kernel Related Emails wrote: > > List, > > > > Well everythings working fine in test9-pre5 except for the fact that sound > > has stopped functioning on my es1371 card. I had no problems with it at > > all in test7 but since then it doesn't work. On boot it detects normally, > > pops and crackles for a second, and then just doesn't work. Any > > ideas? I'm getting no kernel messages or any output that would indicate > > the problem. > > Just as a datapoint, my es1371 is pumping out music under test8 as I type > this. I did have some mixer wierdness tha twere probably unrelated, but > check your volumes. > With 2.4.0-test9-pre6, I don't get anything (writers on /dev/dsp block indefinitely) using the es1371 driver, with the following specs: es1371: version v0.26 time 21:30:39 Sep 22 2000 es1371: found chip, vendor id 0x1274 device id 0x1371 revision 0x08 es1371: found es1371 rev 8 at io 0xef00 irq 18 es1371: features: joystick 0x0 ac97_codec: AC97 audio codec, id: 0x8384:0x7609 (SigmaTel STAC9721/23) The chip itself says "Creative ES1373" on it; it's on the motherboard. Unfortunately I can't verify that it ever worked as I just upgraded both kernel and motherboard. -hpa -- <[EMAIL PROTECTED]> at work, <[EMAIL PROTECTED]> in private! "Unix gives you enough rope to shoot yourself in the foot." http://www.zytor.com/~hpa/puzzle.txt - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: No sound (es1371) after test7
On 2000-9-23 06:26:27 "H. Peter Anvin" wrote: With 2.4.0-test9-pre6, I don't get anything (writers on /dev/dsp block indefinitely) using the es1371 driver, with the following specs: es1371: version v0.26 time 21:30:39 Sep 22 2000 es1371: found chip, vendor id 0x1274 device id 0x1371 revision 0x08 es1371: found es1371 rev 8 at io 0xef00 irq 18 es1371: features: joystick 0x0 ac97_codec: AC97 audio codec, id: 0x8384:0x7609 (SigmaTel STAC9721/23) I'm running 2.4.0-test9-pre6 with my es1371 sound working just fine. Here is a snippet from messages: kernel: 6es1371: version v0.26 time 08:02:58 Sep 23 2000 kernel: 6es1371: found chip, vendor id 0x1274 device id 0x1371 revision 0x06 kernel: 6es1371: found es1371 rev 6 at io 0x1080 irq 11 kernel: 6es1371: features: joystick 0x0 sound: Loading sound module (es1371) succeeded I also first ran the system with support for es1371 compiled in, and that worked fine too. This is running on sparkling new Linux-Mandrake 7.2 beta 3 distro. One possible glitch with the sound; the mixer on my system was defaulted to zero volume at first, so you obviously have to crank that up to hear anything. Good luck to all. Regards, Steven Cole - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: No sound (es1371) after test7
In article [EMAIL PROTECTED], Jon Evans [EMAIL PROTECTED] wrote: On Fri, Sep 22, 2000 at 09:14:23AM -0400, Kernel Related Emails wrote: Well everythings working fine in test9-pre5 except for the fact that sound has stopped functioning on my es1371 card. I had no problems with it at all in test7 but since then it doesn't work. On boot it detects normally, pops and crackles for a second, and then just doesn't work. Any ideas? I'm getting no kernel messages or any output that would indicate the problem. Just as a data point, I have the same problem. /dev/dsp seems to block when opened. Ehh. One of the differences in the test9-pre kernels is a "trivial bugfix" that actually makes one of the "schedule_timeout()" calls in drivers/sound/ac97_codec.c actually _do_ something. Go into "drivers/sound/ac97_codec.c" to around line 570 or so, and comment out the line that says current-state = TASK_UNINTERRUPTIBLE; and see if that fixes the problem. Now, removing the above line will basically make the schdule_timeout() be a no-op, so on the face of it the code has always before been completely nonsensical. But maybe the nonsensical code works, and the logical code is broken. As far as I can tell, no other changes have happened in the sound drivers, which is why I'd ask people to do this apparently idiotic reversal of that single line.. Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: No sound (es1371) after test7
On Fri, Sep 22, 2000 at 09:14:23AM -0400, Kernel Related Emails wrote: > List, > > Well everythings working fine in test9-pre5 except for the fact that sound > has stopped functioning on my es1371 card. I had no problems with it at > all in test7 but since then it doesn't work. On boot it detects normally, > pops and crackles for a second, and then just doesn't work. Any > ideas? I'm getting no kernel messages or any output that would indicate > the problem. Just as a datapoint, my es1371 is pumping out music under test8 as I type this. I did have some mixer wierdness tha twere probably unrelated, but check your volumes. Mordy > Thanks, > Kris > [EMAIL PROTECTED] > > - > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to [EMAIL PROTECTED] > Please read the FAQ at http://www.tux.org/lkml/ > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
Re: No sound (es1371) after test7
On Fri, Sep 22, 2000 at 09:14:23AM -0400, Kernel Related Emails wrote: List, Well everythings working fine in test9-pre5 except for the fact that sound has stopped functioning on my es1371 card. I had no problems with it at all in test7 but since then it doesn't work. On boot it detects normally, pops and crackles for a second, and then just doesn't work. Any ideas? I'm getting no kernel messages or any output that would indicate the problem. Just as a datapoint, my es1371 is pumping out music under test8 as I type this. I did have some mixer wierdness tha twere probably unrelated, but check your volumes. Mordy Thanks, Kris [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
