Re: Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let ksoftirqd do its job"

2017-02-08 Thread Will Deacon
On Mon, Feb 06, 2017 at 06:49:42PM +, Russell King - ARM Linux wrote: > On Mon, Feb 06, 2017 at 06:46:19PM +, Will Deacon wrote: > > Converting the smc91x driver over to NAPI would probably solve this problem, > > but given the "vintage" of this code, I'd be more tempted by a simpler > > po

Re: Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let ksoftirqd do its job"

2017-02-06 Thread Russell King - ARM Linux
On Mon, Feb 06, 2017 at 06:46:19PM +, Will Deacon wrote: > Converting the smc91x driver over to NAPI would probably solve this problem, > but given the "vintage" of this code, I'd be more tempted by a simpler > point fix if only I could think of one. I'm not sure if converting it to NAPI would

Re: Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let ksoftirqd do its job"

2017-02-06 Thread Will Deacon
Hi all, I've also stumbled over this issue with the ARM fastmodel and, somewhat embarrassingly, blamed the model developers for the regression. I'm using NFS and copying ~14MB file from NFS to a virtio-blk device which takes over 20 minutes with 4cd13c21b207, but <1 min with it reverted. I also t

Re: Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let ksoftirqd do its job"

2016-11-25 Thread Brian Starkey
Hi, On Wed, Nov 23, 2016 at 12:03:28PM -0800, Eric Dumazet wrote: On Wed, Nov 23, 2016 at 10:21 AM, Brian Starkey wrote: This patch didn't help. I did get some new traces though - I've attached the diff for the trace_printks I added. Before 4cd13c21b207: https://drive.google.com/open?id=0B8

Re: Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let ksoftirqd do its job"

2016-11-23 Thread Eric Dumazet
On Wed, Nov 23, 2016 at 10:21 AM, Brian Starkey wrote: > This patch didn't help. > > I did get some new traces though - I've attached the diff for the > trace_printks I added. > > Before 4cd13c21b207: > https://drive.google.com/open?id=0B8siaK6ZjvEwcEtOeFQzTmY0Nnc > After 4cd13c21b207: > https://

Re: Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let ksoftirqd do its job"

2016-11-23 Thread Brian Starkey
Hi Eric, On Tue, Nov 22, 2016 at 08:09:58AM -0800, Eric Dumazet wrote: Looks like there's a few similarly named devices and drivers. Mine is an SMSC LAN91C111 using the smc91x driver in drivers/net/ethernet/smsc/smc91x.c, rather than smc911x.c. So the interrupt handler is smc_interrupt() CONFI

Re: Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let ksoftirqd do its job"

2016-11-22 Thread Eric Dumazet
> > Looks like there's a few similarly named devices and drivers. Mine is > an SMSC LAN91C111 using the smc91x driver in > drivers/net/ethernet/smsc/smc91x.c, rather than smc911x.c. So the > interrupt handler is smc_interrupt() > > CONFIG_ARCH_PXA is not set, nor is SMC_USE_PXA_DMA or SMC_USE_DMA.

Re: Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let ksoftirqd do its job"

2016-11-22 Thread Brian Starkey
Hi Eric, On Tue, Nov 22, 2016 at 06:29:33AM -0800, Eric Dumazet wrote: On Tue, Nov 22, 2016 at 2:33 AM, Brian Starkey wrote: Hi, On Fri, Nov 18, 2016 at 01:40:43AM +0100, Thomas Gleixner wrote: Brian, On Thu, 17 Nov 2016, Brian Starkey wrote: No joy with this patch :-( I had to add an

Re: Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let ksoftirqd do its job"

2016-11-22 Thread Eric Dumazet
On Tue, Nov 22, 2016 at 2:33 AM, Brian Starkey wrote: > > Hi, > > On Fri, Nov 18, 2016 at 01:40:43AM +0100, Thomas Gleixner wrote: >> >> Brian, >> >> On Thu, 17 Nov 2016, Brian Starkey wrote: >>> >>> No joy with this patch :-( >>> >>> I had to add an ioaddr argument because apparently that macro d

Re: Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let ksoftirqd do its job"

2016-11-22 Thread Brian Starkey
Hi, On Fri, Nov 18, 2016 at 01:40:43AM +0100, Thomas Gleixner wrote: Brian, On Thu, 17 Nov 2016, Brian Starkey wrote: No joy with this patch :-( I had to add an ioaddr argument because apparently that macro depends on local context (yuck...), but it doesn't help my issue. FWIW I don't see an

Re: Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let ksoftirqd do its job"

2016-11-18 Thread Brian Starkey
Hi Thomas, On Fri, Nov 18, 2016 at 01:40:43AM +0100, Thomas Gleixner wrote: Brian, On Thu, 17 Nov 2016, Brian Starkey wrote: No joy with this patch :-( I had to add an ioaddr argument because apparently that macro depends on local context (yuck...), but it doesn't help my issue. FWIW I don't

Re: Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let ksoftirqd do its job"

2016-11-17 Thread Thomas Gleixner
Brian, On Thu, 17 Nov 2016, Brian Starkey wrote: > No joy with this patch :-( > > I had to add an ioaddr argument because apparently that macro depends > on local context (yuck...), but it doesn't help my issue. > > FWIW I don't see any timeouts, either with or without the patch. > (I don't know

Re: Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let ksoftirqd do its job"

2016-11-17 Thread Brian Starkey
Hi Eric, On Thu, Nov 17, 2016 at 07:29:14AM -0800, Eric Dumazet wrote: On Wed, Nov 16, 2016 at 1:01 PM, Brian Starkey wrote: On Wed, Nov 16, 2016 at 10:49:06AM -0800, Eric Dumazet wrote: On Wed, Nov 16, 2016 at 10:01 AM, Brian Starkey wrote: The smc91x driver does seem to have some trick

Re: Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let ksoftirqd do its job"

2016-11-17 Thread Eric Dumazet
On Wed, Nov 16, 2016 at 1:01 PM, Brian Starkey wrote: > On Wed, Nov 16, 2016 at 10:49:06AM -0800, Eric Dumazet wrote: >> >> On Wed, Nov 16, 2016 at 10:01 AM, Brian Starkey >> wrote: >> >>> >>> The smc91x driver does seem to have some trickiness around softirqs. >>> I'm not familiar with net drive

Re: Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let ksoftirqd do its job"

2016-11-16 Thread Brian Starkey
On Wed, Nov 16, 2016 at 10:49:06AM -0800, Eric Dumazet wrote: On Wed, Nov 16, 2016 at 10:01 AM, Brian Starkey wrote: The smc91x driver does seem to have some trickiness around softirqs. I'm not familiar with net drivers, but I'll see if I can figure anything out there. Oh this code looks ug

Re: Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let ksoftirqd do its job"

2016-11-16 Thread Eric Dumazet
On Wed, Nov 16, 2016 at 10:01 AM, Brian Starkey wrote: > > The smc91x driver does seem to have some trickiness around softirqs. > I'm not familiar with net drivers, but I'll see if I can figure > anything out there. Oh this code looks ugly :( Do you have CONFIG_SMP=y or not ?

Re: Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let ksoftirqd do its job"

2016-11-16 Thread Brian Starkey
Hi Eric, On Wed, Nov 16, 2016 at 07:52:42AM -0800, Eric Dumazet wrote: On Wed, Nov 16, 2016 at 5:55 AM, Brian Starkey wrote: Hi, I'm running an ARM FVP (virtual platform - simluated hardware), which is failing to reach a login prompt due to extremely slow progress during boot. systemd gives u

Re: Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let ksoftirqd do its job"

2016-11-16 Thread Eric Dumazet
On Wed, Nov 16, 2016 at 5:55 AM, Brian Starkey wrote: > Hi, > > I'm running an ARM FVP (virtual platform - simluated hardware), which > is failing to reach a login prompt due to extremely slow progress > during boot. systemd gives up waiting for the ttyAMA0 device to > appear, and never starts the