Re: Support Intel uncore event lists v4
> > Really only trivial changes at this point, so you only need to read > > the patches you didn't read and ack before. > > any chance you'd push the new branch out? I pushed git://git.kernel.org/pub/scm/linux/kernel/git/ak/linux-misc perf/builtin-json-23 to make it do something also need to merge the branch with the json files git://git.kernel.org/pub/scm/linux/kernel/git/ak/linux-misc perf/intel-uncore-json-files-3 -Andi
Re: Support Intel uncore event lists v4
On Wed, Jan 11, 2017 at 01:54:07PM -0800, Andi Kleen wrote: > On Wed, Jan 11, 2017 at 10:47:32PM +0100, Jiri Olsa wrote: > > On Wed, Jan 11, 2017 at 11:52:58AM -0800, Andi Kleen wrote: > > > > > v1: Initial post > > > > > v2: Address review feedback. See changelog in commits. > > > > > v3: Repost. Rebase to latest tree. > > > > > v4: Rebase. Change DividedBy to generic simple expression parser. > > > > > Fix refactoring problem that broke git bisect. > > > > > Address review feedback. > > > > > > > > > > > > > what's the difference to the post from Jan 03? > > > > > > Jan 03 was v3 I think? > > > > > > Also I addressed all your review comments (listed in the individual > > > patches) > > > > 6012 Jan 03 Andi Kleen (1.5K) Support Intel uncore event lists v4 > > 6421 r Jan 09 Andi Kleen (1.5K) Support Intel uncore event lists v4 > > > > the messages seem identical > > Hmm I messed up the version number then. This should be version number > 5 then. > > It was supposed to fix your review feedback for the earlier series > and add Acked-by. > > I listed the (minor) changes in the individual patches. > > perf, tools: Add support for parsing uncore json files > v3: Remove extra __maybe_unused > > perf, tools: Factor out scale conversion code > v3: Use ENOMEM, not -1. > > Really only trivial changes at this point, so you only need to read > the patches you didn't read and ack before. any chance you'd push the new branch out? thanks, jirka
Re: Support Intel uncore event lists v4
On Wed, Jan 11, 2017 at 10:47:32PM +0100, Jiri Olsa wrote: > On Wed, Jan 11, 2017 at 11:52:58AM -0800, Andi Kleen wrote: > > > > v1: Initial post > > > > v2: Address review feedback. See changelog in commits. > > > > v3: Repost. Rebase to latest tree. > > > > v4: Rebase. Change DividedBy to generic simple expression parser. > > > > Fix refactoring problem that broke git bisect. > > > > Address review feedback. > > > > > > > > > > what's the difference to the post from Jan 03? > > > > Jan 03 was v3 I think? > > > > Also I addressed all your review comments (listed in the individual > > patches) > > 6012 Jan 03 Andi Kleen (1.5K) Support Intel uncore event lists v4 > 6421 r Jan 09 Andi Kleen (1.5K) Support Intel uncore event lists v4 > > the messages seem identical Hmm I messed up the version number then. This should be version number 5 then. It was supposed to fix your review feedback for the earlier series and add Acked-by. I listed the (minor) changes in the individual patches. perf, tools: Add support for parsing uncore json files v3: Remove extra __maybe_unused perf, tools: Factor out scale conversion code v3: Use ENOMEM, not -1. Really only trivial changes at this point, so you only need to read the patches you didn't read and ack before. Thanks, -Andi
Re: Support Intel uncore event lists v4
On Wed, Jan 11, 2017 at 11:52:58AM -0800, Andi Kleen wrote: > > > v1: Initial post > > > v2: Address review feedback. See changelog in commits. > > > v3: Repost. Rebase to latest tree. > > > v4: Rebase. Change DividedBy to generic simple expression parser. > > > Fix refactoring problem that broke git bisect. > > > Address review feedback. > > > > > > > what's the difference to the post from Jan 03? > > Jan 03 was v3 I think? > > Also I addressed all your review comments (listed in the individual > patches) 6012 Jan 03 Andi Kleen (1.5K) Support Intel uncore event lists v4 6421 r Jan 09 Andi Kleen (1.5K) Support Intel uncore event lists v4 the messages seem identical jirka
Re: Support Intel uncore event lists v4
> > v1: Initial post > > v2: Address review feedback. See changelog in commits. > > v3: Repost. Rebase to latest tree. > > v4: Rebase. Change DividedBy to generic simple expression parser. > > Fix refactoring problem that broke git bisect. > > Address review feedback. > > > > what's the difference to the post from Jan 03? Jan 03 was v3 I think? Also I addressed all your review comments (listed in the individual patches) -Andi
Re: Support Intel uncore event lists v4
On Mon, Jan 09, 2017 at 05:33:26PM -0800, Andi Kleen wrote: > This adds uncore support on top of the recently merged JSON event list > infrastructure for core events. Uncore is everything outside the core, > including memory controllers, PCI, interconnect etc. > > Uncore is more complicated to handle than core events because it uses > many duplicated PMUs, which leads to long event lists and verbose duplicated > outputs. > > In fact previously it was nearly unusable for many cases without special > tools to generate event list and aggregate data (such as > https://github.com/andikleen/pmu-tools/tree/master/ucevent) > > With this patchkit we add: > - Basic support for uncore events in JSON events > - Support aliases that get duplicated over many PMUs transparently > - Support summing up duplicated PMUs per socket > - Support extending the perf stat builtin metrics with simple expressions > specified in the event list. > > So far mainly servers are supported. Also this is not using full event lists > (which are full of very obscure events) but only for a smaller subset of > curated useful and understandable metrics. > > The actual event lists are not posted, but available at > git://git.kernel.org/pub/scm/linux/kernel/git/ak/linux-misc > perf/intel-uncore-json-files-3 > > The code is available here > git://git.kernel.org/pub/scm/linux/kernel/git/ak/linux-misc > perf/builtin-json-22 > > v1: Initial post > v2: Address review feedback. See changelog in commits. > v3: Repost. Rebase to latest tree. > v4: Rebase. Change DividedBy to generic simple expression parser. > Fix refactoring problem that broke git bisect. > Address review feedback. > what's the difference to the post from Jan 03? jirka
Re: Support Intel uncore event lists
On Thu, Oct 13, 2016 at 02:15:22PM -0700, Andi Kleen wrote: > This adds uncore support on top of the recently merged JSON event list > infrastructure for core events. Uncore is everything outside the core, > including memory controllers, PCI, interconnect etc. > > Uncore is more complicated to handle than core events because it uses > many duplicated PMUs, which leads to long event lists and verbose duplicated > outputs. > > In fact previously it was nearly unusable for many cases without special > tools to generate event list and aggregate data (such as > https://github.com/andikleen/pmu-tools/tree/master/ucevent) > > With this patchkit we add: > - Basic support for uncore events in JSON events > - Support aliases that get duplicated over many PMUs transparently > - Support summing up duplicated PMUs per socket > - Support extending the perf stat builtin metrics with simple ratios > specified in the event list. This covers the vast majority of useful > metrics. > > So far mainly servers are supported. Also this is not using full event lists > (which are full of very obscure events) but only for a smaller subset of > curated useful and understandable metrics. > > The actual event lists are not posted, but available at > git://git.kernel.org/pub/scm/linux/kernel/git/ak/linux-misc > perf/intel-uncore-json-files-1 > > The code is available here > git://git.kernel.org/pub/scm/linux/kernel/git/ak/linux-misc > perf/builtin-json-15 perf test 5 is failing [jolsa@krava perf]$ sudo ./perf test 5 -v ... mem-loads -> cpu/event=0xcd,umask=0x1,ldlat=3/ failed to parse event 'mem-snp-hit:u,cpu/event=mem-snp-hit/u', err 1 test child finished with 1 end parse events tests: FAILED! jirka
