Re: Wrong module .text address in 4.16.0

2018-04-16 Thread Linus Torvalds
On Mon, Apr 16, 2018 at 6:43 AM, Jessica Yu wrote: > > So for users of /sys/module/*/sections, we will need to work around > this and possibly use %px for the real address. But perhaps we should > base the usage of %px on kptr_restrict? Maybe. I was hoping we would be able to get rid of it eventu

Re: Wrong module .text address in 4.16.0

2018-04-16 Thread Jessica Yu
+++ Christian Borntraeger [16/04/18 12:53 +0200]: Can this be related to commit ef0010a30935de4e0211cbc7bdffc30446cdee9b vsprintf: don't use 'restricted_pointer()' when not restricting and related commits? To me it looks like %pk is always printing the hash, but never the real pointer - no m

Re: Wrong module .text address in 4.16.0

2018-04-16 Thread Thomas-Mich Richter
On 04/16/2018 08:23 AM, Christian Borntraeger wrote: > FWIW, this breaks at least perf capability to resolve module symbols. > Adding some more CCs for perf and module. > > > On 04/16/2018 07:51 AM, Thomas-Mich Richter wrote: >> I just installed 4.16.0 and discovered the module .text address is >

Re: Wrong module .text address in 4.16.0

2018-04-16 Thread Christian Borntraeger
Can this be related to commit ef0010a30935de4e0211cbc7bdffc30446cdee9b vsprintf: don't use 'restricted_pointer()' when not restricting and related commits? To me it looks like %pk is always printing the hash, but never the real pointer - no matter what kernel.kptr_restrict says. On 04/1

Re: Wrong module .text address in 4.16.0

2018-04-15 Thread Christian Borntraeger
FWIW, this breaks at least perf capability to resolve module symbols. Adding some more CCs for perf and module. On 04/16/2018 07:51 AM, Thomas-Mich Richter wrote: > I just installed 4.16.0 and discovered the module .text address is > wrong. It happens on s390 and x86 platforms. I have not tested