Re: firmware: vpd: use memunmap instead of iounmap

2017-08-08 Thread Dmitry Torokhov
Hi Pan, On Tue, Aug 8, 2017 at 5:45 AM, Pan Bian wrote: > In functions vpd_sections_init() and vpd_section_init(), iounmap() is > used to unmap memory. However, in these cases, memunmap() is better. > > Signed-off-by: Pan Bian > --- > drivers/firmware/google/vpd.c | 6 +++--- > 1 file changed,

Re: firmware: vpd: use memunmap instead of iounmap

2017-08-08 Thread Guenter Roeck
On Tue, Aug 8, 2017 at 5:45 AM, Pan Bian wrote: > In functions vpd_sections_init() and vpd_section_init(), iounmap() is > used to unmap memory. However, in these cases, memunmap() is better. > > Signed-off-by: Pan Bian The code uses memremap(), so that seems reasonable. Reviewed-by: Guenter Roe