Re: hwmon: (asc7621): remove redundant assignment to newval

[Guenter Roeck]

On Wed, Oct 18, 2017 at 01:10:38PM +0100, Colin Ian King wrote:
> From: Colin Ian King 
> 
> The setting of newval to zero is redundant as the following if/else
> stanzas will always update newval to a new value. Remove the
> redundant setting, cleans up clang build warning:
> 
> drivers/hwmon/asc7621.c:582:2: warning: Value stored to 'newval' is
> never read
> 
> Signed-off-by: Colin Ian King 

Applied to hwmon-next.

Thanks,
Guenter

> ---
>  drivers/hwmon/asc7621.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/hwmon/asc7621.c b/drivers/hwmon/asc7621.c
> index 4875e99b59c9..6d34c05a4f83 100644
> --- a/drivers/hwmon/asc7621.c
> +++ b/drivers/hwmon/asc7621.c
> @@ -579,7 +579,6 @@ static ssize_t show_pwm_enable(struct device *dev,
>   mutex_unlock(>update_lock);
>  
>   val = config | (altbit << 3);
> - newval = 0;
>  
>   if (val == 3 || val >= 10)
>   newval = 255;

Re: hwmon: (asc7621): remove redundant assignment to newval

[Guenter Roeck]

On Wed, Oct 18, 2017 at 01:10:38PM +0100, Colin Ian King wrote:
> From: Colin Ian King 
> 
> The setting of newval to zero is redundant as the following if/else
> stanzas will always update newval to a new value. Remove the
> redundant setting, cleans up clang build warning:
> 
> drivers/hwmon/asc7621.c:582:2: warning: Value stored to 'newval' is
> never read
> 
> Signed-off-by: Colin Ian King 

Applied to hwmon-next.

Thanks,
Guenter

> ---
>  drivers/hwmon/asc7621.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/hwmon/asc7621.c b/drivers/hwmon/asc7621.c
> index 4875e99b59c9..6d34c05a4f83 100644
> --- a/drivers/hwmon/asc7621.c
> +++ b/drivers/hwmon/asc7621.c
> @@ -579,7 +579,6 @@ static ssize_t show_pwm_enable(struct device *dev,
>   mutex_unlock(>update_lock);
>  
>   val = config | (altbit << 3);
> - newval = 0;
>  
>   if (val == 3 || val >= 10)
>   newval = 255;