Re: kernel CI: printk loglevels in kernel boot logs?

2017-12-06 Thread Petr Mladek
On Tue 2017-12-05 15:54:09, Steven Rostedt wrote: > On Tue, 5 Dec 2017 16:55:37 +0100 > Petr Mladek wrote: > > > I would have agreed with this argument few weeks ago but I do not get > > it any longer. If there are tools depending on the message format > > and people enable the

Re: kernel CI: printk loglevels in kernel boot logs?

2017-12-06 Thread Petr Mladek
On Tue 2017-12-05 15:54:09, Steven Rostedt wrote: > On Tue, 5 Dec 2017 16:55:37 +0100 > Petr Mladek wrote: > > > I would have agreed with this argument few weeks ago but I do not get > > it any longer. If there are tools depending on the message format > > and people enable the extended format,

Re: kernel CI: printk loglevels in kernel boot logs?

2017-12-05 Thread Steven Rostedt
On Tue, 5 Dec 2017 16:55:37 +0100 Petr Mladek wrote: > I would have agreed with this argument few weeks ago but I do not get > it any longer. If there are tools depending on the message format > and people enable the extended format, the tools might stop working. > > You might

Re: kernel CI: printk loglevels in kernel boot logs?

2017-12-05 Thread Steven Rostedt
On Tue, 5 Dec 2017 16:55:37 +0100 Petr Mladek wrote: > I would have agreed with this argument few weeks ago but I do not get > it any longer. If there are tools depending on the message format > and people enable the extended format, the tools might stop working. > > You might argue that these

Re: kernel CI: printk loglevels in kernel boot logs?

2017-12-05 Thread Sergey Senozhatsky
On (12/05/17 16:55), Petr Mladek wrote: [..] > > Am I too paranoid? Steven? Linus? well, if there is a tool that believels that there will always be [ (part of timestamp marker) as the first symbol then that tool has a problem. there is no "guaranteed" format of console messages. one can print

Re: kernel CI: printk loglevels in kernel boot logs?

2017-12-05 Thread Sergey Senozhatsky
On (12/05/17 16:55), Petr Mladek wrote: [..] > > Am I too paranoid? Steven? Linus? well, if there is a tool that believels that there will always be [ (part of timestamp marker) as the first symbol then that tool has a problem. there is no "guaranteed" format of console messages. one can print

Re: kernel CI: printk loglevels in kernel boot logs?

2017-12-05 Thread Petr Mladek
On Wed 2017-11-22 22:10:58, Fengguang Wu wrote: > On Wed, Nov 22, 2017 at 12:34:48PM +0100, Petr Mladek wrote: > > On Wed 2017-11-22 11:27:02, Fengguang Wu wrote: > > > [CC LKML for possible printk improvements] > > > > > > On Wed, Nov 22, 2017 at 09:56:10AM +0800, Fengguang Wu wrote: > > > > Hi

Re: kernel CI: printk loglevels in kernel boot logs?

2017-12-05 Thread Petr Mladek
On Wed 2017-11-22 22:10:58, Fengguang Wu wrote: > On Wed, Nov 22, 2017 at 12:34:48PM +0100, Petr Mladek wrote: > > On Wed 2017-11-22 11:27:02, Fengguang Wu wrote: > > > [CC LKML for possible printk improvements] > > > > > > On Wed, Nov 22, 2017 at 09:56:10AM +0800, Fengguang Wu wrote: > > > > Hi

Re: kernel CI: printk loglevels in kernel boot logs?

2017-11-30 Thread Sergey Senozhatsky
Hello, On (11/30/17 09:45), Kevin Hilman wrote: [..] > >> For kernelCI (part of how this thread got started): > >> > >> Acked-by: Kevin Hilman > >> Reviewed-by: Kevin Hilman > >> > >> I also tested it on an arm64 platform with the new command-line

Re: kernel CI: printk loglevels in kernel boot logs?

2017-11-30 Thread Sergey Senozhatsky
Hello, On (11/30/17 09:45), Kevin Hilman wrote: [..] > >> For kernelCI (part of how this thread got started): > >> > >> Acked-by: Kevin Hilman > >> Reviewed-by: Kevin Hilman > >> > >> I also tested it on an arm64 platform with the new command-line arg: > >> > >> Tested-by: Kevin Hilman > > > >

Re: kernel CI: printk loglevels in kernel boot logs?

2017-11-30 Thread Kevin Hilman
Hi Sergey, On Tue, Nov 28, 2017 at 11:25 PM, Sergey Senozhatsky wrote: > On (11/28/17 16:13), Kevin Hilman wrote: > [..] >> > okay... who's going to send the patch? kernelCI folks? >> > >> > I have some sort of a patch. added console_msg_format= with the only

Re: kernel CI: printk loglevels in kernel boot logs?

2017-11-30 Thread Kevin Hilman
Hi Sergey, On Tue, Nov 28, 2017 at 11:25 PM, Sergey Senozhatsky wrote: > On (11/28/17 16:13), Kevin Hilman wrote: > [..] >> > okay... who's going to send the patch? kernelCI folks? >> > >> > I have some sort of a patch. added console_msg_format= with the only >> > available option so far -

Re: kernel CI: printk loglevels in kernel boot logs?

2017-11-28 Thread Sergey Senozhatsky
On (11/28/17 16:13), Kevin Hilman wrote: [..] > > okay... who's going to send the patch? kernelCI folks? > > > > I have some sort of a patch. added console_msg_format= with the only > > available option so far - "syslog". may be people would want to have > > boot time, etc. on their consoles. who

Re: kernel CI: printk loglevels in kernel boot logs?

2017-11-28 Thread Sergey Senozhatsky
On (11/28/17 16:13), Kevin Hilman wrote: [..] > > okay... who's going to send the patch? kernelCI folks? > > > > I have some sort of a patch. added console_msg_format= with the only > > available option so far - "syslog". may be people would want to have > > boot time, etc. on their consoles. who

Re: kernel CI: printk loglevels in kernel boot logs?

2017-11-28 Thread Kevin Hilman
Sergey Senozhatsky writes: > On (11/22/17 20:52), Fengguang Wu wrote: > [..] >> > well, I think that that "consoles_format=syslog" command line parameter >> > will be enabled only by those who actually want to have it - Fengguang's >> > build robot and kernelCI

Re: kernel CI: printk loglevels in kernel boot logs?

2017-11-28 Thread Kevin Hilman
Sergey Senozhatsky writes: > On (11/22/17 20:52), Fengguang Wu wrote: > [..] >> > well, I think that that "consoles_format=syslog" command line parameter >> > will be enabled only by those who actually want to have it - Fengguang's >> > build robot and kernelCI (+ may be more setups). so I'd

Re: kernel CI: printk loglevels in kernel boot logs?

2017-11-23 Thread Petr Mladek
On Wed 2017-11-22 20:52:45, Fengguang Wu wrote: > On Wed, Nov 22, 2017 at 09:38:21PM +0900, Sergey Senozhatsky wrote: > > On (11/22/17 12:34), Petr Mladek wrote: > > [..] > > > > > > This is espeically useful when ingesting kernel logs into advanced > > > > > > search/analytics frameworks (I'm

Re: kernel CI: printk loglevels in kernel boot logs?

2017-11-23 Thread Petr Mladek
On Wed 2017-11-22 20:52:45, Fengguang Wu wrote: > On Wed, Nov 22, 2017 at 09:38:21PM +0900, Sergey Senozhatsky wrote: > > On (11/22/17 12:34), Petr Mladek wrote: > > [..] > > > > > > This is espeically useful when ingesting kernel logs into advanced > > > > > > search/analytics frameworks (I'm

Re: kernel CI: printk loglevels in kernel boot logs?

2017-11-22 Thread Sergey Senozhatsky
Hello, On (11/23/17 11:14), Fengguang Wu wrote: > > > Thanks. Since the 0day scripts can already parse that format (code > > > is listed below), we should quickly benefit from that feature when > > > it's mainlined. > > > > okay... who's going to send the patch? kernelCI folks? > > > > I have

Re: kernel CI: printk loglevels in kernel boot logs?

2017-11-22 Thread Sergey Senozhatsky
Hello, On (11/23/17 11:14), Fengguang Wu wrote: > > > Thanks. Since the 0day scripts can already parse that format (code > > > is listed below), we should quickly benefit from that feature when > > > it's mainlined. > > > > okay... who's going to send the patch? kernelCI folks? > > > > I have

Re: kernel CI: printk loglevels in kernel boot logs?

2017-11-22 Thread Fengguang Wu
On Thu, Nov 23, 2017 at 11:59:57AM +0900, Sergey Senozhatsky wrote: On (11/22/17 20:52), Fengguang Wu wrote: [..] > well, I think that that "consoles_format=syslog" command line parameter > will be enabled only by those who actually want to have it - Fengguang's > build robot and kernelCI (+

Re: kernel CI: printk loglevels in kernel boot logs?

2017-11-22 Thread Fengguang Wu
On Thu, Nov 23, 2017 at 11:59:57AM +0900, Sergey Senozhatsky wrote: On (11/22/17 20:52), Fengguang Wu wrote: [..] > well, I think that that "consoles_format=syslog" command line parameter > will be enabled only by those who actually want to have it - Fengguang's > build robot and kernelCI (+

Re: kernel CI: printk loglevels in kernel boot logs?

2017-11-22 Thread Sergey Senozhatsky
On (11/22/17 20:52), Fengguang Wu wrote: [..] > > well, I think that that "consoles_format=syslog" command line parameter > > will be enabled only by those who actually want to have it - Fengguang's > > build robot and kernelCI (+ may be more setups). so I'd probably assume > > there are low

Re: kernel CI: printk loglevels in kernel boot logs?

2017-11-22 Thread Sergey Senozhatsky
On (11/22/17 20:52), Fengguang Wu wrote: [..] > > well, I think that that "consoles_format=syslog" command line parameter > > will be enabled only by those who actually want to have it - Fengguang's > > build robot and kernelCI (+ may be more setups). so I'd probably assume > > there are low

Re: kernel CI: printk loglevels in kernel boot logs?

2017-11-22 Thread Kevin Hilman
On Wed, Nov 22, 2017 at 4:38 AM, Sergey Senozhatsky wrote: > On (11/22/17 12:34), Petr Mladek wrote: > [..] >> > > > This is espeically useful when ingesting kernel logs into advanced >> > > > search/analytics frameworks (I'm playing with and ELK stack: Elastic

Re: kernel CI: printk loglevels in kernel boot logs?

2017-11-22 Thread Kevin Hilman
On Wed, Nov 22, 2017 at 4:38 AM, Sergey Senozhatsky wrote: > On (11/22/17 12:34), Petr Mladek wrote: > [..] >> > > > This is espeically useful when ingesting kernel logs into advanced >> > > > search/analytics frameworks (I'm playing with and ELK stack: Elastic >> > > > Search, Logstash, Kibana).

Re: kernel CI: printk loglevels in kernel boot logs?

2017-11-22 Thread Fengguang Wu
On Wed, Nov 22, 2017 at 12:34:48PM +0100, Petr Mladek wrote: On Wed 2017-11-22 11:27:02, Fengguang Wu wrote: [CC LKML for possible printk improvements] On Wed, Nov 22, 2017 at 09:56:10AM +0800, Fengguang Wu wrote: > Hi Kevin, > > On Tue, Nov 21, 2017 at 12:27:48PM -0800, Kevin Hilman wrote: >

Re: kernel CI: printk loglevels in kernel boot logs?

2017-11-22 Thread Fengguang Wu
On Wed, Nov 22, 2017 at 12:34:48PM +0100, Petr Mladek wrote: On Wed 2017-11-22 11:27:02, Fengguang Wu wrote: [CC LKML for possible printk improvements] On Wed, Nov 22, 2017 at 09:56:10AM +0800, Fengguang Wu wrote: > Hi Kevin, > > On Tue, Nov 21, 2017 at 12:27:48PM -0800, Kevin Hilman wrote: >

Re: kernel CI: printk loglevels in kernel boot logs?

2017-11-22 Thread Fengguang Wu
On Wed, Nov 22, 2017 at 09:38:21PM +0900, Sergey Senozhatsky wrote: On (11/22/17 12:34), Petr Mladek wrote: [..] > > > This is espeically useful when ingesting kernel logs into advanced > > > search/analytics frameworks (I'm playing with and ELK stack: Elastic > > > Search, Logstash, Kibana).

Re: kernel CI: printk loglevels in kernel boot logs?

2017-11-22 Thread Fengguang Wu
On Wed, Nov 22, 2017 at 09:38:21PM +0900, Sergey Senozhatsky wrote: On (11/22/17 12:34), Petr Mladek wrote: [..] > > > This is espeically useful when ingesting kernel logs into advanced > > > search/analytics frameworks (I'm playing with and ELK stack: Elastic > > > Search, Logstash, Kibana).

Re: kernel CI: printk loglevels in kernel boot logs?

2017-11-22 Thread Sergey Senozhatsky
On (11/22/17 12:34), Petr Mladek wrote: [..] > > > > This is espeically useful when ingesting kernel logs into advanced > > > > search/analytics frameworks (I'm playing with and ELK stack: Elastic > > > > Search, Logstash, Kibana). [..] > To make it clear. I understand that "show_loglevel" command

Re: kernel CI: printk loglevels in kernel boot logs?

2017-11-22 Thread Sergey Senozhatsky
On (11/22/17 12:34), Petr Mladek wrote: [..] > > > > This is espeically useful when ingesting kernel logs into advanced > > > > search/analytics frameworks (I'm playing with and ELK stack: Elastic > > > > Search, Logstash, Kibana). [..] > To make it clear. I understand that "show_loglevel" command

Re: kernel CI: printk loglevels in kernel boot logs?

2017-11-22 Thread Petr Mladek
On Wed 2017-11-22 11:27:02, Fengguang Wu wrote: > [CC LKML for possible printk improvements] > > On Wed, Nov 22, 2017 at 09:56:10AM +0800, Fengguang Wu wrote: > > Hi Kevin, > > > > On Tue, Nov 21, 2017 at 12:27:48PM -0800, Kevin Hilman wrote: > > > Hi Fenguang, > > > > > > In automated testing,

Re: kernel CI: printk loglevels in kernel boot logs?

2017-11-22 Thread Petr Mladek
On Wed 2017-11-22 11:27:02, Fengguang Wu wrote: > [CC LKML for possible printk improvements] > > On Wed, Nov 22, 2017 at 09:56:10AM +0800, Fengguang Wu wrote: > > Hi Kevin, > > > > On Tue, Nov 21, 2017 at 12:27:48PM -0800, Kevin Hilman wrote: > > > Hi Fenguang, > > > > > > In automated testing,

Re: kernel CI: printk loglevels in kernel boot logs?

2017-11-22 Thread Mark Brown
On Wed, Nov 22, 2017 at 02:26:30PM +0900, Sergey Senozhatsky wrote: > so may be we can add "syslog" mode for console drivers and do print_prefix() > in console_unlock() [unless have nr_ext_console_drivers]. if this is what > you guys are talking about. (frankly, I have no idea if there are tools

Re: kernel CI: printk loglevels in kernel boot logs?

2017-11-22 Thread Mark Brown
On Wed, Nov 22, 2017 at 02:26:30PM +0900, Sergey Senozhatsky wrote: > so may be we can add "syslog" mode for console drivers and do print_prefix() > in console_unlock() [unless have nr_ext_console_drivers]. if this is what > you guys are talking about. (frankly, I have no idea if there are tools

Re: kernel CI: printk loglevels in kernel boot logs?

2017-11-21 Thread Sergey Senozhatsky
Hello, On (11/22/17 11:27), Fengguang Wu wrote: > [CC LKML for possible printk improvements] [..] > > > In kernelCI, we're considering submitting a patch to add a > > > "show_loglevel" command-line argument to enable that option on kernel > > > boot. > > > > Thanks for doing that patch! It'll

Re: kernel CI: printk loglevels in kernel boot logs?

2017-11-21 Thread Sergey Senozhatsky
Hello, On (11/22/17 11:27), Fengguang Wu wrote: > [CC LKML for possible printk improvements] [..] > > > In kernelCI, we're considering submitting a patch to add a > > > "show_loglevel" command-line argument to enable that option on kernel > > > boot. > > > > Thanks for doing that patch! It'll

Re: kernel CI: printk loglevels in kernel boot logs?

2017-11-21 Thread Fengguang Wu
[CC LKML for possible printk improvements] On Wed, Nov 22, 2017 at 09:56:10AM +0800, Fengguang Wu wrote: Hi Kevin, On Tue, Nov 21, 2017 at 12:27:48PM -0800, Kevin Hilman wrote: Hi Fenguang, In automated testing, for ease of parsing kernel boot logs (especially separating warnings and errors

Re: kernel CI: printk loglevels in kernel boot logs?

2017-11-21 Thread Fengguang Wu
[CC LKML for possible printk improvements] On Wed, Nov 22, 2017 at 09:56:10AM +0800, Fengguang Wu wrote: Hi Kevin, On Tue, Nov 21, 2017 at 12:27:48PM -0800, Kevin Hilman wrote: Hi Fenguang, In automated testing, for ease of parsing kernel boot logs (especially separating warnings and errors