Re: linux-next: Signed-off-by missing for commit in the tip tree
On Thu, Dec 10, 2020 at 01:50:31PM +0100, Giovanni Gherdovich wrote:
> On Thu, 2020-12-10 at 21:52 +1100, Stephen Rothwell wrote:
> > Hi all,
> >
> > Commit
> >
> > 46609527577d ("x86, sched: Use midpoint of max_boost and max_P for
> > frequency invariance on AMD EPYC")
> >
> > is missing a Signed-off-by from its author.
> >
>
> Hello,
>
> I'm the author of that commit and the missing Signed-off-by is not
> intentional but
> due to a mistake I made. I used the string "" in the commit
> message and
> git interpreted it as "drop everything from here onwards", including the
> Signed-off-by.
>
> According to the maintainer's preference, I agree to either them adding
>
> Signed-off-by: Giovanni Gherdovich
Hurmph, I'd have to rebase that branch to fix this.. mingo?
Re: linux-next: Signed-off-by missing for commit in the tip tree
On Thu, 2020-12-10 at 21:52 +1100, Stephen Rothwell wrote:
> Hi all,
>
> Commit
>
> 46609527577d ("x86, sched: Use midpoint of max_boost and max_P for
> frequency invariance on AMD EPYC")
>
> is missing a Signed-off-by from its author.
>
Hello,
I'm the author of that commit and the missing Signed-off-by is not intentional
but
due to a mistake I made. I used the string "" in the commit message
and
git interpreted it as "drop everything from here onwards", including the
Signed-off-by.
According to the maintainer's preference, I agree to either them adding
Signed-off-by: Giovanni Gherdovich
or to resend them the patch with a better commit message if they prefer.
Sorry for the inconvenience,
Giovanni Gherdovich
Re: linux-next: Signed-off-by missing for commit in the tip tree
On Wed, 26 Jun 2019, Stephen Rothwell wrote:
>
> 53d87b37a2a4 ("arm64: compat: No need for pre-ARMv7 barriers on an ARMv8
> system")
> b4b12aca00d5 ("arm64: vdso: Remove unnecessary asm-offsets.c definitions")
> 4d33ebb02c45 ("vdso: Remove superfluous #ifdef __KERNEL__ in
> vdso/datapage.h")
>
> are missing a Signed-off-by from their committer.
Oops.
Re: linux-next: Signed-off-by missing for commit in the tip tree
On Fri, 7 Sep 2018, Stephen Rothwell wrote:
> Commit
>
> 760902b24960 ("clocksource: Revert "Remove kthread"")
>
> is missing a Signed-off-by from its committer. Reverts are commits, too.
Duh. Fixed.
Thanks for spotting!
tglx
Re: linux-next: Signed-off-by missing for commit in the tip tree
Em Sun, Feb 18, 2018 at 07:25:55PM +1100, Stephen Rothwell escreveu:
> Hi all,
>
> Commit
>
> f091f1d6a2b4 ("tools/headers: Synchronize kernel ABI headers, v4.16-rc1")
>
> is missing a Signed-off-by from its committer.
Argh, my bad, and it already made its way into v4.16-rc2 :-\
- Arnaldo
Re: linux-next: Signed-off-by missing for commit in the tip tree
* Stephen Rothwell wrote:
> Hi all,
>
> Commit
>
> 113702e96dc7 ("x86/insn-eval: Add utility functions to get segment
> selector")
>
> is missing a Signed-off-by from its author and committer.
>
> It's possible its author and committer were both changed by the
> cherry-pick ... Also, the commit message does not seem to describe what
> this patch does.
It's a partial cherry-pick of 32d0b95300db03c - I've updated the changelog and
fixed the SOB line.
Thanks,
Ingo
Re: linux-next: Signed-off-by missing for commit in the tip tree
Hi Thomas,
On Thu, 21 Dec 2017 11:25:18 +0100 (CET) Thomas Gleixner
wrote:
>
> On Wed, 20 Dec 2017, Stephen Rothwell wrote:
>
> > Hi all,
> >
> > Commit
> >
> > 44d5c715330c ("x86/mm: Create asm/invpcid.h")
> >
> > is missing a Signed-off-by from its committer.
>
> Yes. That's from the PTI work in progress branch. It was high flux so we
> did not care much about those details and the patches went back and forth
> between various people. So if we would have done that by the book we'd have
> something like.
>
> SOB: tglx
> SOB: peterz
> SOB: mingo
> SOB: tglx
> SOB: mingo
> SOB: tglx
>
> We'll clean that up for the final version
Then it should not be in linux-next ... linux-next is *not* a development tree.
--
Cheers,
Stephen Rothwell
Re: linux-next: Signed-off-by missing for commit in the tip tree
On Wed, 20 Dec 2017, Stephen Rothwell wrote:
> Hi all,
>
> Commit
>
> 44d5c715330c ("x86/mm: Create asm/invpcid.h")
>
> is missing a Signed-off-by from its committer.
Yes. That's from the PTI work in progress branch. It was high flux so we
did not care much about those details and the patches went back and forth
between various people. So if we would have done that by the book we'd have
something like.
SOB: tglx
SOB: peterz
SOB: mingo
SOB: tglx
SOB: mingo
SOB: tglx
We'll clean that up for the final version
Thanks,
tglx
Re: linux-next: Signed-off-by missing for commit in the tip tree
Em Thu, Dec 07, 2017 at 09:40:16AM +1100, Stephen Rothwell escreveu:
> Hi all,
>
> Commit
>
> 0b44cfb8e40f ("tools/headers: Synchronize kernel x86 UAPI headers")
>
> is missing a Signed-off-by from its committer.
oops, my bad :-\ I'll avoid this in the future with scripts before
pushing to Ingo.
- Arnaldo
commit 0b44cfb8e40f64cd72520be223414a7ef79c5d90
Author: Ingo Molnar
AuthorDate: Sat Nov 18 09:00:46 2017 +0100
Commit: Arnaldo Carvalho de Melo
CommitDate: Tue Nov 28 14:29:05 2017 -0300
tools/headers: Synchronize kernel x86 UAPI headers
Two x86 headers got modified in this merge window:
arch/x86/include/asm/cpufeatures.h
arch/x86/include/asm/disabled-features.h
To support x86 UMIP feature, to add new AVX instructions, plus
cleanups.
None of those changes have an effect on tooling, so do a plain copy.
Cc: Arnaldo Carvalho de Melo
Cc: Greg Kroah-Hartman
Cc: Linus Torvalds
Cc: Peter Zijlstra
Cc: Thomas Gleixner
Cc: Peter Zijlstra
Cc: Namhyung Kim
Cc: Jiri Olsa
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Ingo Molnar
