Re: linux-next: build failure after merge of the tty tree

[Greg KH]

On Thu, Jun 13, 2019 at 03:32:15PM +1000, Stephen Rothwell wrote:
> Hi Greg,
> 
> After merging the tty tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
> 
> drivers/tty/serial/stm32-usart.c: In function 'stm32_serial_suspend':
> drivers/tty/serial/stm32-usart.c:1298:2: error: implicit declaration of 
> function 'pinctrl_pm_select_sleep_state' 
> [-Werror=implicit-function-declaration]
>   pinctrl_pm_select_sleep_state(dev);
>   ^
> drivers/tty/serial/stm32-usart.c: In function 'stm32_serial_resume':
> drivers/tty/serial/stm32-usart.c:1307:2: error: implicit declaration of 
> function 'pinctrl_pm_select_default_state' 
> [-Werror=implicit-function-declaration]
>   pinctrl_pm_select_default_state(dev);
>   ^~~
> 
> Caused by commit
> 
>   c70669ecef4e ("serial: stm32: select pinctrl state in each suspend/resume 
> function")

Yeah, I think I need to just go revert that patch now, thanks.

greg k-h

Re: linux-next: build failure after merge of the tty tree

[Greg Kroah-Hartman]

A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

On Thu, Oct 04, 2018 at 08:13:39AM -1000, Steve Sakoman wrote:
> Hi Greg,
> 
> I sent the patch you requested to fix use of the "unused" struct
> member in samsung.c. If that looks OK to you I'll redo my
> "serial:serial_core: Allow use of CTS for PPS line discipline" patch.

I think it needs a bit of a rework, see my review comments on that
patch.

thanks,

greg k-h

Re: linux-next: build failure after merge of the tty tree

[Greg Kroah-Hartman]

A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

On Thu, Oct 04, 2018 at 08:13:39AM -1000, Steve Sakoman wrote:
> Hi Greg,
> 
> I sent the patch you requested to fix use of the "unused" struct
> member in samsung.c. If that looks OK to you I'll redo my
> "serial:serial_core: Allow use of CTS for PPS line discipline" patch.

I think it needs a bit of a rework, see my review comments on that
patch.

thanks,

greg k-h

Re: linux-next: build failure after merge of the tty tree

[Steve Sakoman]

Hi Greg,

I sent the patch you requested to fix use of the "unused" struct
member in samsung.c. If that looks OK to you I'll redo my
"serial:serial_core: Allow use of CTS for PPS line discipline" patch.

Thanks,

Steve
On Thu, Oct 4, 2018 at 7:00 AM Greg Kroah-Hartman  wrote:
>
> On Thu, Oct 04, 2018 at 06:34:31AM -1000, Steve Sakoman wrote:
> > Interesting indeed. Who would have thought someone would be using the
> > "unused" padding variable!
>
> Ugh :(
>
> > How would folks prefer we fix this, in the referenced patch or by
> > eliminating the use of "unused" in samsung.c?
>
> We should just get rid of the "unused" fields entirely.  They aren't
> needed here as this is not a structure that anyone really cares about.
> We can move things around a bit if the padding is an issue.
>
> I've reverted this patch first for now.  I suggest a patch to the uart
> core to drop the unused fields and fix up the samsung driver and then
> your patch can go on top of that.  Can you work on this?
>
> thanks,
>
> greg k-h

Re: linux-next: build failure after merge of the tty tree

[Steve Sakoman]

Hi Greg,

I sent the patch you requested to fix use of the "unused" struct
member in samsung.c. If that looks OK to you I'll redo my
"serial:serial_core: Allow use of CTS for PPS line discipline" patch.

Thanks,

Steve
On Thu, Oct 4, 2018 at 7:00 AM Greg Kroah-Hartman  wrote:
>
> On Thu, Oct 04, 2018 at 06:34:31AM -1000, Steve Sakoman wrote:
> > Interesting indeed. Who would have thought someone would be using the
> > "unused" padding variable!
>
> Ugh :(
>
> > How would folks prefer we fix this, in the referenced patch or by
> > eliminating the use of "unused" in samsung.c?
>
> We should just get rid of the "unused" fields entirely.  They aren't
> needed here as this is not a structure that anyone really cares about.
> We can move things around a bit if the padding is an issue.
>
> I've reverted this patch first for now.  I suggest a patch to the uart
> core to drop the unused fields and fix up the samsung driver and then
> your patch can go on top of that.  Can you work on this?
>
> thanks,
>
> greg k-h

Re: linux-next: build failure after merge of the tty tree

[Steve Sakoman]

On Thu, Oct 4, 2018 at 7:00 AM Greg Kroah-Hartman  wrote:

> We should just get rid of the "unused" fields entirely.  They aren't
> needed here as this is not a structure that anyone really cares about.
> We can move things around a bit if the padding is an issue.
>
> I've reverted this patch first for now.  I suggest a patch to the uart
> core to drop the unused fields and fix up the samsung driver and then
> your patch can go on top of that.  Can you work on this?

Yes I can. Stay tuned . . .

Steve

Re: linux-next: build failure after merge of the tty tree

[Steve Sakoman]

On Thu, Oct 4, 2018 at 7:00 AM Greg Kroah-Hartman  wrote:

> We should just get rid of the "unused" fields entirely.  They aren't
> needed here as this is not a structure that anyone really cares about.
> We can move things around a bit if the padding is an issue.
>
> I've reverted this patch first for now.  I suggest a patch to the uart
> core to drop the unused fields and fix up the samsung driver and then
> your patch can go on top of that.  Can you work on this?

Yes I can. Stay tuned . . .

Steve

Re: linux-next: build failure after merge of the tty tree

[Greg Kroah-Hartman]

On Thu, Oct 04, 2018 at 06:34:31AM -1000, Steve Sakoman wrote:
> Interesting indeed. Who would have thought someone would be using the
> "unused" padding variable!

Ugh :(

> How would folks prefer we fix this, in the referenced patch or by
> eliminating the use of "unused" in samsung.c?

We should just get rid of the "unused" fields entirely.  They aren't
needed here as this is not a structure that anyone really cares about.
We can move things around a bit if the padding is an issue.

I've reverted this patch first for now.  I suggest a patch to the uart
core to drop the unused fields and fix up the samsung driver and then
your patch can go on top of that.  Can you work on this?

thanks,

greg k-h

Re: linux-next: build failure after merge of the tty tree

[Greg Kroah-Hartman]

On Thu, Oct 04, 2018 at 06:34:31AM -1000, Steve Sakoman wrote:
> Interesting indeed. Who would have thought someone would be using the
> "unused" padding variable!

Ugh :(

> How would folks prefer we fix this, in the referenced patch or by
> eliminating the use of "unused" in samsung.c?

We should just get rid of the "unused" fields entirely.  They aren't
needed here as this is not a structure that anyone really cares about.
We can move things around a bit if the padding is an issue.

I've reverted this patch first for now.  I suggest a patch to the uart
core to drop the unused fields and fix up the samsung driver and then
your patch can go on top of that.  Can you work on this?

thanks,

greg k-h

Re: linux-next: build failure after merge of the tty tree

[Steve Sakoman]

Interesting indeed. Who would have thought someone would be using the
"unused" padding variable!

How would folks prefer we fix this, in the referenced patch or by
eliminating the use of "unused" in samsung.c?

Steve
On Wed, Oct 3, 2018 at 7:19 PM Stephen Rothwell  wrote:
>
> Hi all,
>
> After merging the tty tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
>
> drivers/tty/serial/samsung.c: In function 's3c24xx_serial_rx_enable':
> drivers/tty/serial/samsung.c:87:41: error: subscripted value is neither array 
> nor pointer nor vector
>  #define rx_enabled(port) ((port)->unused[1])
>  ^
> drivers/tty/serial/samsung.c:138:2: note: in expansion of macro 'rx_enabled'
>   rx_enabled(port) = 1;
>   ^~
> drivers/tty/serial/samsung.c: In function 's3c24xx_serial_rx_disable':
> drivers/tty/serial/samsung.c:87:41: error: subscripted value is neither array 
> nor pointer nor vector
>  #define rx_enabled(port) ((port)->unused[1])
>  ^
> drivers/tty/serial/samsung.c:153:2: note: in expansion of macro 'rx_enabled'
>   rx_enabled(port) = 0;
>   ^~
> drivers/tty/serial/samsung.c: In function 's3c24xx_serial_stop_tx':
> drivers/tty/serial/samsung.c:86:41: error: subscripted value is neither array 
> nor pointer nor vector
>  #define tx_enabled(port) ((port)->unused[0])
>  ^
> drivers/tty/serial/samsung.c:165:7: note: in expansion of macro 'tx_enabled'
>   if (!tx_enabled(port))
>^~
> drivers/tty/serial/samsung.c:86:41: error: subscripted value is neither array 
> nor pointer nor vector
>  #define tx_enabled(port) ((port)->unused[0])
>  ^
> drivers/tty/serial/samsung.c:185:2: note: in expansion of macro 'tx_enabled'
>   tx_enabled(port) = 0;
>   ^~
> drivers/tty/serial/samsung.c: In function 's3c24xx_serial_start_tx':
> drivers/tty/serial/samsung.c:86:41: error: subscripted value is neither array 
> nor pointer nor vector
>  #define tx_enabled(port) ((port)->unused[0])
>  ^
> drivers/tty/serial/samsung.c:343:7: note: in expansion of macro 'tx_enabled'
>   if (!tx_enabled(port)) {
>^~
> drivers/tty/serial/samsung.c:86:41: error: subscripted value is neither array 
> nor pointer nor vector
>  #define tx_enabled(port) ((port)->unused[0])
>  ^
> drivers/tty/serial/samsung.c:347:3: note: in expansion of macro 'tx_enabled'
>tx_enabled(port) = 1;
>^~
> drivers/tty/serial/samsung.c: In function 's3c24xx_serial_stop_rx':
> drivers/tty/serial/samsung.c:87:41: error: subscripted value is neither array 
> nor pointer nor vector
>  #define rx_enabled(port) ((port)->unused[1])
>  ^
> drivers/tty/serial/samsung.c:392:6: note: in expansion of macro 'rx_enabled'
>   if (rx_enabled(port)) {
>   ^~
> drivers/tty/serial/samsung.c:87:41: error: subscripted value is neither array 
> nor pointer nor vector
>  #define rx_enabled(port) ((port)->unused[1])
>  ^
> drivers/tty/serial/samsung.c:399:3: note: in expansion of macro 'rx_enabled'
>rx_enabled(port) = 0;
>^~
> drivers/tty/serial/samsung.c: In function 's3c24xx_serial_rx_drain_fifo':
> drivers/tty/serial/samsung.c:87:41: error: subscripted value is neither array 
> nor pointer nor vector
>  #define rx_enabled(port) ((port)->unused[1])
>  ^
> drivers/tty/serial/samsung.c:621:8: note: in expansion of macro 'rx_enabled'
> if (rx_enabled(port)) {
> ^~
> drivers/tty/serial/samsung.c:87:41: error: subscripted value is neither array 
> nor pointer nor vector
>  #define rx_enabled(port) ((port)->unused[1])
>  ^
> drivers/tty/serial/samsung.c:623:6: note: in expansion of macro 'rx_enabled'
>   rx_enabled(port) = 0;
>   ^~
> drivers/tty/serial/samsung.c:87:41: error: subscripted value is neither array 
> nor pointer nor vector
>  #define rx_enabled(port) ((port)->unused[1])
>  ^
> drivers/tty/serial/samsung.c:631:6: note: in expansion of macro 'rx_enabled'
>   rx_enabled(port) = 1;
>   ^~
> drivers/tty/serial/samsung.c: In function 's3c24xx_serial_shutdown':
> drivers/tty/serial/samsung.c:86:41: error: subscripted value is neither array 
> nor pointer nor vector
>  #define tx_enabled(port) ((port)->unused[0])
>  ^
> drivers/tty/serial/samsung.c:981:3: note: in expansion of macro 'tx_enabled'
>tx_enabled(port) = 0;
>^~
> drivers/tty/serial/samsung.c:87:41: error: subscripted value is neither array 
> nor pointer nor vector
>  #define rx_enabled(port) ((port)->unused[1])
>  ^
> 

Re: linux-next: build failure after merge of the tty tree

[Steve Sakoman]

Interesting indeed. Who would have thought someone would be using the
"unused" padding variable!

How would folks prefer we fix this, in the referenced patch or by
eliminating the use of "unused" in samsung.c?

Steve
On Wed, Oct 3, 2018 at 7:19 PM Stephen Rothwell  wrote:
>
> Hi all,
>
> After merging the tty tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
>
> drivers/tty/serial/samsung.c: In function 's3c24xx_serial_rx_enable':
> drivers/tty/serial/samsung.c:87:41: error: subscripted value is neither array 
> nor pointer nor vector
>  #define rx_enabled(port) ((port)->unused[1])
>  ^
> drivers/tty/serial/samsung.c:138:2: note: in expansion of macro 'rx_enabled'
>   rx_enabled(port) = 1;
>   ^~
> drivers/tty/serial/samsung.c: In function 's3c24xx_serial_rx_disable':
> drivers/tty/serial/samsung.c:87:41: error: subscripted value is neither array 
> nor pointer nor vector
>  #define rx_enabled(port) ((port)->unused[1])
>  ^
> drivers/tty/serial/samsung.c:153:2: note: in expansion of macro 'rx_enabled'
>   rx_enabled(port) = 0;
>   ^~
> drivers/tty/serial/samsung.c: In function 's3c24xx_serial_stop_tx':
> drivers/tty/serial/samsung.c:86:41: error: subscripted value is neither array 
> nor pointer nor vector
>  #define tx_enabled(port) ((port)->unused[0])
>  ^
> drivers/tty/serial/samsung.c:165:7: note: in expansion of macro 'tx_enabled'
>   if (!tx_enabled(port))
>^~
> drivers/tty/serial/samsung.c:86:41: error: subscripted value is neither array 
> nor pointer nor vector
>  #define tx_enabled(port) ((port)->unused[0])
>  ^
> drivers/tty/serial/samsung.c:185:2: note: in expansion of macro 'tx_enabled'
>   tx_enabled(port) = 0;
>   ^~
> drivers/tty/serial/samsung.c: In function 's3c24xx_serial_start_tx':
> drivers/tty/serial/samsung.c:86:41: error: subscripted value is neither array 
> nor pointer nor vector
>  #define tx_enabled(port) ((port)->unused[0])
>  ^
> drivers/tty/serial/samsung.c:343:7: note: in expansion of macro 'tx_enabled'
>   if (!tx_enabled(port)) {
>^~
> drivers/tty/serial/samsung.c:86:41: error: subscripted value is neither array 
> nor pointer nor vector
>  #define tx_enabled(port) ((port)->unused[0])
>  ^
> drivers/tty/serial/samsung.c:347:3: note: in expansion of macro 'tx_enabled'
>tx_enabled(port) = 1;
>^~
> drivers/tty/serial/samsung.c: In function 's3c24xx_serial_stop_rx':
> drivers/tty/serial/samsung.c:87:41: error: subscripted value is neither array 
> nor pointer nor vector
>  #define rx_enabled(port) ((port)->unused[1])
>  ^
> drivers/tty/serial/samsung.c:392:6: note: in expansion of macro 'rx_enabled'
>   if (rx_enabled(port)) {
>   ^~
> drivers/tty/serial/samsung.c:87:41: error: subscripted value is neither array 
> nor pointer nor vector
>  #define rx_enabled(port) ((port)->unused[1])
>  ^
> drivers/tty/serial/samsung.c:399:3: note: in expansion of macro 'rx_enabled'
>rx_enabled(port) = 0;
>^~
> drivers/tty/serial/samsung.c: In function 's3c24xx_serial_rx_drain_fifo':
> drivers/tty/serial/samsung.c:87:41: error: subscripted value is neither array 
> nor pointer nor vector
>  #define rx_enabled(port) ((port)->unused[1])
>  ^
> drivers/tty/serial/samsung.c:621:8: note: in expansion of macro 'rx_enabled'
> if (rx_enabled(port)) {
> ^~
> drivers/tty/serial/samsung.c:87:41: error: subscripted value is neither array 
> nor pointer nor vector
>  #define rx_enabled(port) ((port)->unused[1])
>  ^
> drivers/tty/serial/samsung.c:623:6: note: in expansion of macro 'rx_enabled'
>   rx_enabled(port) = 0;
>   ^~
> drivers/tty/serial/samsung.c:87:41: error: subscripted value is neither array 
> nor pointer nor vector
>  #define rx_enabled(port) ((port)->unused[1])
>  ^
> drivers/tty/serial/samsung.c:631:6: note: in expansion of macro 'rx_enabled'
>   rx_enabled(port) = 1;
>   ^~
> drivers/tty/serial/samsung.c: In function 's3c24xx_serial_shutdown':
> drivers/tty/serial/samsung.c:86:41: error: subscripted value is neither array 
> nor pointer nor vector
>  #define tx_enabled(port) ((port)->unused[0])
>  ^
> drivers/tty/serial/samsung.c:981:3: note: in expansion of macro 'tx_enabled'
>tx_enabled(port) = 0;
>^~
> drivers/tty/serial/samsung.c:87:41: error: subscripted value is neither array 
> nor pointer nor vector
>  #define rx_enabled(port) ((port)->unused[1])
>  ^
> 

Re: linux-next: build failure after merge of the tty tree

[Andy Shevchenko]

On Tue, Sep 11, 2018 at 11:43 AM Lee Jones  wrote:
> On Tue, 11 Sep 2018, Nicolas Ferre wrote:

> > Actually it is due to the missing of   as Stephen
> > suggested. It is due to the patch ac3167257b9f ("headers: separate
> > linux/mod_devicetable.h from linux/platform_device.h") merged in v4.19-rc1.
>
> Since this set uses Device Tree, it really should include the of.h.

I didn't remember the contents of the driver, but I would disagree on
a statement that
*using* of_device_id table implies necessity of linux/of.h inclusion.

>
> This solves the issue reported above.
>
> I will fix-up and re-send the pull-request.


-- 
With Best Regards,
Andy Shevchenko

Re: linux-next: build failure after merge of the tty tree

[Andy Shevchenko]

On Tue, Sep 11, 2018 at 11:43 AM Lee Jones  wrote:
> On Tue, 11 Sep 2018, Nicolas Ferre wrote:

> > Actually it is due to the missing of   as Stephen
> > suggested. It is due to the patch ac3167257b9f ("headers: separate
> > linux/mod_devicetable.h from linux/platform_device.h") merged in v4.19-rc1.
>
> Since this set uses Device Tree, it really should include the of.h.

I didn't remember the contents of the driver, but I would disagree on
a statement that
*using* of_device_id table implies necessity of linux/of.h inclusion.

>
> This solves the issue reported above.
>
> I will fix-up and re-send the pull-request.


-- 
With Best Regards,
Andy Shevchenko

Re: linux-next: build failure after merge of the tty tree

[Lee Jones]

On Tue, 11 Sep 2018, Nicolas Ferre wrote:

> On 11/09/2018 at 10:25, Lee Jones wrote:
> > On Tue, 11 Sep 2018, Stephen Rothwell wrote:
> > 
> > > Hi Greg,
> > > 
> > > After merging the tty tree, today's linux-next build (arm
> > > multi_v7_defconfig) failed like this:
> > > 
> > > drivers/mfd/at91-usart.c:51:34: error: array type has incomplete element 
> > > type 'struct of_device_id'
> > >   static const struct of_device_id at91_usart_mode_of_match[] = {
> > >^~~~
> > > drivers/mfd/at91-usart.c:52:4: error: field name not in record or union 
> > > initializer
> > >{ .compatible = "atmel,at91rm9200-usart" },
> > >  ^
> > > drivers/mfd/at91-usart.c:52:4: note: (near initialization for 
> > > 'at91_usart_mode_of_match')
> > > drivers/mfd/at91-usart.c:53:4: error: field name not in record or union 
> > > initializer
> > >{ .compatible = "atmel,at91sam9260-usart" },
> > >  ^
> > > drivers/mfd/at91-usart.c:53:4: note: (near initialization for 
> > > 'at91_usart_mode_of_match')
> > > drivers/mfd/at91-usart.c:51:34: warning: 'at91_usart_mode_of_match' 
> > > defined but not used [-Wunused-variable]
> > >   static const struct of_device_id at91_usart_mode_of_match[] = {
> > >^~~~
> > > 
> > > Caused by commit
> > > 
> > >7d3aa342cef7 ("mfd: at91-usart: Add MFD driver for USART")
> > > 
> > > Forgot to include ?
> > 
> > Looks like a missing Device Tree header .
> > 
> > Will chase this today and follow up with another PR.
> 
> Hi all,
> 
> Actually it is due to the missing of   as Stephen
> suggested. It is due to the patch ac3167257b9f ("headers: separate
> linux/mod_devicetable.h from linux/platform_device.h") merged in v4.19-rc1.

Since this set uses Device Tree, it really should include the of.h.

This solves the issue reported above.

I will fix-up and re-send the pull-request.

> because linux/platform_device.h was included by linux/mfd/core.h that is
> present in this driver. This is why the issue was not identified beforehand.
> 
> I'm building a tiny patch to address this right now.
> 
> Thanks for your help. Best regards,

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: linux-next: build failure after merge of the tty tree

[Lee Jones]

On Tue, 11 Sep 2018, Nicolas Ferre wrote:

> On 11/09/2018 at 10:25, Lee Jones wrote:
> > On Tue, 11 Sep 2018, Stephen Rothwell wrote:
> > 
> > > Hi Greg,
> > > 
> > > After merging the tty tree, today's linux-next build (arm
> > > multi_v7_defconfig) failed like this:
> > > 
> > > drivers/mfd/at91-usart.c:51:34: error: array type has incomplete element 
> > > type 'struct of_device_id'
> > >   static const struct of_device_id at91_usart_mode_of_match[] = {
> > >^~~~
> > > drivers/mfd/at91-usart.c:52:4: error: field name not in record or union 
> > > initializer
> > >{ .compatible = "atmel,at91rm9200-usart" },
> > >  ^
> > > drivers/mfd/at91-usart.c:52:4: note: (near initialization for 
> > > 'at91_usart_mode_of_match')
> > > drivers/mfd/at91-usart.c:53:4: error: field name not in record or union 
> > > initializer
> > >{ .compatible = "atmel,at91sam9260-usart" },
> > >  ^
> > > drivers/mfd/at91-usart.c:53:4: note: (near initialization for 
> > > 'at91_usart_mode_of_match')
> > > drivers/mfd/at91-usart.c:51:34: warning: 'at91_usart_mode_of_match' 
> > > defined but not used [-Wunused-variable]
> > >   static const struct of_device_id at91_usart_mode_of_match[] = {
> > >^~~~
> > > 
> > > Caused by commit
> > > 
> > >7d3aa342cef7 ("mfd: at91-usart: Add MFD driver for USART")
> > > 
> > > Forgot to include ?
> > 
> > Looks like a missing Device Tree header .
> > 
> > Will chase this today and follow up with another PR.
> 
> Hi all,
> 
> Actually it is due to the missing of   as Stephen
> suggested. It is due to the patch ac3167257b9f ("headers: separate
> linux/mod_devicetable.h from linux/platform_device.h") merged in v4.19-rc1.

Since this set uses Device Tree, it really should include the of.h.

This solves the issue reported above.

I will fix-up and re-send the pull-request.

> because linux/platform_device.h was included by linux/mfd/core.h that is
> present in this driver. This is why the issue was not identified beforehand.
> 
> I'm building a tiny patch to address this right now.
> 
> Thanks for your help. Best regards,

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: linux-next: build failure after merge of the tty tree

[Nicolas Ferre]

On 11/09/2018 at 10:25, Lee Jones wrote:

On Tue, 11 Sep 2018, Stephen Rothwell wrote:


Hi Greg,

After merging the tty tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

drivers/mfd/at91-usart.c:51:34: error: array type has incomplete element type 
'struct of_device_id'
  static const struct of_device_id at91_usart_mode_of_match[] = {
   ^~~~
drivers/mfd/at91-usart.c:52:4: error: field name not in record or union 
initializer
   { .compatible = "atmel,at91rm9200-usart" },
 ^
drivers/mfd/at91-usart.c:52:4: note: (near initialization for 
'at91_usart_mode_of_match')
drivers/mfd/at91-usart.c:53:4: error: field name not in record or union 
initializer
   { .compatible = "atmel,at91sam9260-usart" },
 ^
drivers/mfd/at91-usart.c:53:4: note: (near initialization for 
'at91_usart_mode_of_match')
drivers/mfd/at91-usart.c:51:34: warning: 'at91_usart_mode_of_match' defined but 
not used [-Wunused-variable]
  static const struct of_device_id at91_usart_mode_of_match[] = {
   ^~~~

Caused by commit

   7d3aa342cef7 ("mfd: at91-usart: Add MFD driver for USART")

Forgot to include ?


Looks like a missing Device Tree header .

Will chase this today and follow up with another PR.


Hi all,

Actually it is due to the missing of   as 
Stephen suggested. It is due to the patch ac3167257b9f ("headers: 
separate linux/mod_devicetable.h from linux/platform_device.h") merged 
in v4.19-rc1.


because linux/platform_device.h was included by linux/mfd/core.h that is 
present in this driver. This is why the issue was not identified beforehand.


I'm building a tiny patch to address this right now.

Thanks for your help. Best regards,
--
Nicolas Ferre

Re: linux-next: build failure after merge of the tty tree

[Nicolas Ferre]

On 11/09/2018 at 10:25, Lee Jones wrote:

On Tue, 11 Sep 2018, Stephen Rothwell wrote:


Hi Greg,

After merging the tty tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

drivers/mfd/at91-usart.c:51:34: error: array type has incomplete element type 
'struct of_device_id'
  static const struct of_device_id at91_usart_mode_of_match[] = {
   ^~~~
drivers/mfd/at91-usart.c:52:4: error: field name not in record or union 
initializer
   { .compatible = "atmel,at91rm9200-usart" },
 ^
drivers/mfd/at91-usart.c:52:4: note: (near initialization for 
'at91_usart_mode_of_match')
drivers/mfd/at91-usart.c:53:4: error: field name not in record or union 
initializer
   { .compatible = "atmel,at91sam9260-usart" },
 ^
drivers/mfd/at91-usart.c:53:4: note: (near initialization for 
'at91_usart_mode_of_match')
drivers/mfd/at91-usart.c:51:34: warning: 'at91_usart_mode_of_match' defined but 
not used [-Wunused-variable]
  static const struct of_device_id at91_usart_mode_of_match[] = {
   ^~~~

Caused by commit

   7d3aa342cef7 ("mfd: at91-usart: Add MFD driver for USART")

Forgot to include ?


Looks like a missing Device Tree header .

Will chase this today and follow up with another PR.


Hi all,

Actually it is due to the missing of   as 
Stephen suggested. It is due to the patch ac3167257b9f ("headers: 
separate linux/mod_devicetable.h from linux/platform_device.h") merged 
in v4.19-rc1.


because linux/platform_device.h was included by linux/mfd/core.h that is 
present in this driver. This is why the issue was not identified beforehand.


I'm building a tiny patch to address this right now.

Thanks for your help. Best regards,
--
Nicolas Ferre

Re: linux-next: build failure after merge of the tty tree

[Lee Jones]

On Tue, 11 Sep 2018, Stephen Rothwell wrote:

> Hi Greg,
> 
> After merging the tty tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
> 
> drivers/mfd/at91-usart.c:51:34: error: array type has incomplete element type 
> 'struct of_device_id'
>  static const struct of_device_id at91_usart_mode_of_match[] = {
>   ^~~~
> drivers/mfd/at91-usart.c:52:4: error: field name not in record or union 
> initializer
>   { .compatible = "atmel,at91rm9200-usart" },
> ^
> drivers/mfd/at91-usart.c:52:4: note: (near initialization for 
> 'at91_usart_mode_of_match')
> drivers/mfd/at91-usart.c:53:4: error: field name not in record or union 
> initializer
>   { .compatible = "atmel,at91sam9260-usart" },
> ^
> drivers/mfd/at91-usart.c:53:4: note: (near initialization for 
> 'at91_usart_mode_of_match')
> drivers/mfd/at91-usart.c:51:34: warning: 'at91_usart_mode_of_match' defined 
> but not used [-Wunused-variable]
>  static const struct of_device_id at91_usart_mode_of_match[] = {
>   ^~~~
> 
> Caused by commit
> 
>   7d3aa342cef7 ("mfd: at91-usart: Add MFD driver for USART")
> 
> Forgot to include ?

Looks like a missing Device Tree header .

Will chase this today and follow up with another PR.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: linux-next: build failure after merge of the tty tree

[Lee Jones]

On Tue, 11 Sep 2018, Stephen Rothwell wrote:

> Hi Greg,
> 
> After merging the tty tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
> 
> drivers/mfd/at91-usart.c:51:34: error: array type has incomplete element type 
> 'struct of_device_id'
>  static const struct of_device_id at91_usart_mode_of_match[] = {
>   ^~~~
> drivers/mfd/at91-usart.c:52:4: error: field name not in record or union 
> initializer
>   { .compatible = "atmel,at91rm9200-usart" },
> ^
> drivers/mfd/at91-usart.c:52:4: note: (near initialization for 
> 'at91_usart_mode_of_match')
> drivers/mfd/at91-usart.c:53:4: error: field name not in record or union 
> initializer
>   { .compatible = "atmel,at91sam9260-usart" },
> ^
> drivers/mfd/at91-usart.c:53:4: note: (near initialization for 
> 'at91_usart_mode_of_match')
> drivers/mfd/at91-usart.c:51:34: warning: 'at91_usart_mode_of_match' defined 
> but not used [-Wunused-variable]
>  static const struct of_device_id at91_usart_mode_of_match[] = {
>   ^~~~
> 
> Caused by commit
> 
>   7d3aa342cef7 ("mfd: at91-usart: Add MFD driver for USART")
> 
> Forgot to include ?

Looks like a missing Device Tree header .

Will chase this today and follow up with another PR.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: linux-next: build failure after merge of the tty tree

[Greg KH]

On Tue, Sep 11, 2018 at 12:58:57PM +1000, Stephen Rothwell wrote:
> Hi Greg,
> 
> After merging the tty tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
> 
> drivers/mfd/at91-usart.c:51:34: error: array type has incomplete element type 
> 'struct of_device_id'
>  static const struct of_device_id at91_usart_mode_of_match[] = {
>   ^~~~
> drivers/mfd/at91-usart.c:52:4: error: field name not in record or union 
> initializer
>   { .compatible = "atmel,at91rm9200-usart" },
> ^
> drivers/mfd/at91-usart.c:52:4: note: (near initialization for 
> 'at91_usart_mode_of_match')
> drivers/mfd/at91-usart.c:53:4: error: field name not in record or union 
> initializer
>   { .compatible = "atmel,at91sam9260-usart" },
> ^
> drivers/mfd/at91-usart.c:53:4: note: (near initialization for 
> 'at91_usart_mode_of_match')
> drivers/mfd/at91-usart.c:51:34: warning: 'at91_usart_mode_of_match' defined 
> but not used [-Wunused-variable]
>  static const struct of_device_id at91_usart_mode_of_match[] = {
>   ^~~~
> 
> Caused by commit
> 
>   7d3aa342cef7 ("mfd: at91-usart: Add MFD driver for USART")
> 
> Forgot to include ?
> 
> I used the version of the tty tree from next-20180910 for today.

Very odd, I just pulled in the "Immutable" branch from Lee here.

Lee, is there something I am missing to get this to build properly?

thanks,

greg k-h

Re: linux-next: build failure after merge of the tty tree

[Greg KH]

On Tue, Sep 11, 2018 at 12:58:57PM +1000, Stephen Rothwell wrote:
> Hi Greg,
> 
> After merging the tty tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
> 
> drivers/mfd/at91-usart.c:51:34: error: array type has incomplete element type 
> 'struct of_device_id'
>  static const struct of_device_id at91_usart_mode_of_match[] = {
>   ^~~~
> drivers/mfd/at91-usart.c:52:4: error: field name not in record or union 
> initializer
>   { .compatible = "atmel,at91rm9200-usart" },
> ^
> drivers/mfd/at91-usart.c:52:4: note: (near initialization for 
> 'at91_usart_mode_of_match')
> drivers/mfd/at91-usart.c:53:4: error: field name not in record or union 
> initializer
>   { .compatible = "atmel,at91sam9260-usart" },
> ^
> drivers/mfd/at91-usart.c:53:4: note: (near initialization for 
> 'at91_usart_mode_of_match')
> drivers/mfd/at91-usart.c:51:34: warning: 'at91_usart_mode_of_match' defined 
> but not used [-Wunused-variable]
>  static const struct of_device_id at91_usart_mode_of_match[] = {
>   ^~~~
> 
> Caused by commit
> 
>   7d3aa342cef7 ("mfd: at91-usart: Add MFD driver for USART")
> 
> Forgot to include ?
> 
> I used the version of the tty tree from next-20180910 for today.

Very odd, I just pulled in the "Immutable" branch from Lee here.

Lee, is there something I am missing to get this to build properly?

thanks,

greg k-h

Re: linux-next: build failure after merge of the tty tree

[Greg KH]

On Mon, Dec 18, 2017 at 10:02:08AM +0100, Greg KH wrote:
> On Mon, Dec 18, 2017 at 09:52:50AM +0100, Geert Uytterhoeven wrote:
> > Hi Stephen,
> > 
> > On Mon, Dec 18, 2017 at 4:28 AM, Stephen Rothwell  
> > wrote:
> > > After merging the tty tree, today's linux-next build (x86_64 allmodconfig)
> > > failed like this:
> > >
> > > .config:4300:warning: symbol value '' invalid for SERIAL_SH_SCI_NR_UARTS
> > > *
> > > * Restart config...
> > > *
> > > *
> > > * Serial drivers
> > > *
> > > 8250/16550 and compatible serial support (SERIAL_8250) [M/y/?] m
> > > .
> > > .
> > > .
> > > SuperH SCI(F) serial port support (SERIAL_SH_SCI) [M/n/y] m
> > >   Maximum number of SCI(F) serial ports (SERIAL_SH_SCI_NR_UARTS) [] (NEW) 
> > > aborted!
> > >
> > > Console input/output is redirected. Run 'make oldconfig' to update 
> > > configuration.
> > >
> > >
> > > Caused by commit
> > >
> > >   f6731485a519 ("tty: serial: sh-sci: Hide number of ports config 
> > > question")
> > >
> > > I have used the tty tree from next-20171215 for today.
> > 
> > Sorry, silly misunderstanding of Kconfig behavior on my side.
> > Patch sent.
> 
> Really?  I don't see the patch anywhere, can you resend it please?

Got it now, thanks!

greg k-h

Re: linux-next: build failure after merge of the tty tree

[Greg KH]

On Mon, Dec 18, 2017 at 10:02:08AM +0100, Greg KH wrote:
> On Mon, Dec 18, 2017 at 09:52:50AM +0100, Geert Uytterhoeven wrote:
> > Hi Stephen,
> > 
> > On Mon, Dec 18, 2017 at 4:28 AM, Stephen Rothwell  
> > wrote:
> > > After merging the tty tree, today's linux-next build (x86_64 allmodconfig)
> > > failed like this:
> > >
> > > .config:4300:warning: symbol value '' invalid for SERIAL_SH_SCI_NR_UARTS
> > > *
> > > * Restart config...
> > > *
> > > *
> > > * Serial drivers
> > > *
> > > 8250/16550 and compatible serial support (SERIAL_8250) [M/y/?] m
> > > .
> > > .
> > > .
> > > SuperH SCI(F) serial port support (SERIAL_SH_SCI) [M/n/y] m
> > >   Maximum number of SCI(F) serial ports (SERIAL_SH_SCI_NR_UARTS) [] (NEW) 
> > > aborted!
> > >
> > > Console input/output is redirected. Run 'make oldconfig' to update 
> > > configuration.
> > >
> > >
> > > Caused by commit
> > >
> > >   f6731485a519 ("tty: serial: sh-sci: Hide number of ports config 
> > > question")
> > >
> > > I have used the tty tree from next-20171215 for today.
> > 
> > Sorry, silly misunderstanding of Kconfig behavior on my side.
> > Patch sent.
> 
> Really?  I don't see the patch anywhere, can you resend it please?

Got it now, thanks!

greg k-h

Re: linux-next: build failure after merge of the tty tree

[Greg KH]

On Mon, Dec 18, 2017 at 09:52:50AM +0100, Geert Uytterhoeven wrote:
> Hi Stephen,
> 
> On Mon, Dec 18, 2017 at 4:28 AM, Stephen Rothwell  
> wrote:
> > After merging the tty tree, today's linux-next build (x86_64 allmodconfig)
> > failed like this:
> >
> > .config:4300:warning: symbol value '' invalid for SERIAL_SH_SCI_NR_UARTS
> > *
> > * Restart config...
> > *
> > *
> > * Serial drivers
> > *
> > 8250/16550 and compatible serial support (SERIAL_8250) [M/y/?] m
> > .
> > .
> > .
> > SuperH SCI(F) serial port support (SERIAL_SH_SCI) [M/n/y] m
> >   Maximum number of SCI(F) serial ports (SERIAL_SH_SCI_NR_UARTS) [] (NEW) 
> > aborted!
> >
> > Console input/output is redirected. Run 'make oldconfig' to update 
> > configuration.
> >
> >
> > Caused by commit
> >
> >   f6731485a519 ("tty: serial: sh-sci: Hide number of ports config question")
> >
> > I have used the tty tree from next-20171215 for today.
> 
> Sorry, silly misunderstanding of Kconfig behavior on my side.
> Patch sent.

Really?  I don't see the patch anywhere, can you resend it please?

thanks,

greg k-h

Re: linux-next: build failure after merge of the tty tree

[Greg KH]

On Mon, Dec 18, 2017 at 09:52:50AM +0100, Geert Uytterhoeven wrote:
> Hi Stephen,
> 
> On Mon, Dec 18, 2017 at 4:28 AM, Stephen Rothwell  
> wrote:
> > After merging the tty tree, today's linux-next build (x86_64 allmodconfig)
> > failed like this:
> >
> > .config:4300:warning: symbol value '' invalid for SERIAL_SH_SCI_NR_UARTS
> > *
> > * Restart config...
> > *
> > *
> > * Serial drivers
> > *
> > 8250/16550 and compatible serial support (SERIAL_8250) [M/y/?] m
> > .
> > .
> > .
> > SuperH SCI(F) serial port support (SERIAL_SH_SCI) [M/n/y] m
> >   Maximum number of SCI(F) serial ports (SERIAL_SH_SCI_NR_UARTS) [] (NEW) 
> > aborted!
> >
> > Console input/output is redirected. Run 'make oldconfig' to update 
> > configuration.
> >
> >
> > Caused by commit
> >
> >   f6731485a519 ("tty: serial: sh-sci: Hide number of ports config question")
> >
> > I have used the tty tree from next-20171215 for today.
> 
> Sorry, silly misunderstanding of Kconfig behavior on my side.
> Patch sent.

Really?  I don't see the patch anywhere, can you resend it please?

thanks,

greg k-h

Re: linux-next: build failure after merge of the tty tree

[Geert Uytterhoeven]

Hi Stephen,

On Mon, Dec 18, 2017 at 4:28 AM, Stephen Rothwell  wrote:
> After merging the tty tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
>
> .config:4300:warning: symbol value '' invalid for SERIAL_SH_SCI_NR_UARTS
> *
> * Restart config...
> *
> *
> * Serial drivers
> *
> 8250/16550 and compatible serial support (SERIAL_8250) [M/y/?] m
> .
> .
> .
> SuperH SCI(F) serial port support (SERIAL_SH_SCI) [M/n/y] m
>   Maximum number of SCI(F) serial ports (SERIAL_SH_SCI_NR_UARTS) [] (NEW) 
> aborted!
>
> Console input/output is redirected. Run 'make oldconfig' to update 
> configuration.
>
>
> Caused by commit
>
>   f6731485a519 ("tty: serial: sh-sci: Hide number of ports config question")
>
> I have used the tty tree from next-20171215 for today.

Sorry, silly misunderstanding of Kconfig behavior on my side.
Patch sent.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

Re: linux-next: build failure after merge of the tty tree

[Geert Uytterhoeven]

Hi Stephen,

On Mon, Dec 18, 2017 at 4:28 AM, Stephen Rothwell  wrote:
> After merging the tty tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
>
> .config:4300:warning: symbol value '' invalid for SERIAL_SH_SCI_NR_UARTS
> *
> * Restart config...
> *
> *
> * Serial drivers
> *
> 8250/16550 and compatible serial support (SERIAL_8250) [M/y/?] m
> .
> .
> .
> SuperH SCI(F) serial port support (SERIAL_SH_SCI) [M/n/y] m
>   Maximum number of SCI(F) serial ports (SERIAL_SH_SCI_NR_UARTS) [] (NEW) 
> aborted!
>
> Console input/output is redirected. Run 'make oldconfig' to update 
> configuration.
>
>
> Caused by commit
>
>   f6731485a519 ("tty: serial: sh-sci: Hide number of ports config question")
>
> I have used the tty tree from next-20171215 for today.

Sorry, silly misunderstanding of Kconfig behavior on my side.
Patch sent.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

Re: linux-next: build failure after merge of the tty tree

[Stephen Rothwell]

Hi Greg,

On Mon, 6 Feb 2017 16:18:22 +0100 Greg KH  wrote:
>
> On Mon, Feb 06, 2017 at 08:09:16AM -0600, Rob Herring wrote:
> > 
> > It didn't, but we happened to already have a fix queued up for 4.11.
> > The fix is in your usb-next branch:
> > 
> > commit 7a3b7cd332db08546f3cdd984f11773e0d1999e7
> > Author: Stephen Boyd 
> > Date:   Wed Dec 28 14:56:48 2016 -0800
> > 
> > of: device: Export of_device_{get_modalias, uvent_modalias} to modules
> > 
> > The ULPI bus can be built as a module, and it will soon be
> > calling these functions when it supports probing devices from DT.
> > Export them so they can be used by the ULPI module.
> > 
> > Acked-by: Rob Herring 
> > Cc: 
> > Signed-off-by: Stephen Boyd 
> > Signed-off-by: Peter Chen   
> 
> Ah, so the if this is pulled into linux-next at the same time, then
> there's no build error.
> 
> Stephen, do you need/want me to cherry-pick this into the tty branch, or
> is it ok as-is?

I will change things so that I merge the usb tree before the tty tree.
Please remember to tell Linus that they need to be merged in that order.

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build failure after merge of the tty tree

[Stephen Rothwell]

Hi Greg,

On Mon, 6 Feb 2017 16:18:22 +0100 Greg KH  wrote:
>
> On Mon, Feb 06, 2017 at 08:09:16AM -0600, Rob Herring wrote:
> > 
> > It didn't, but we happened to already have a fix queued up for 4.11.
> > The fix is in your usb-next branch:
> > 
> > commit 7a3b7cd332db08546f3cdd984f11773e0d1999e7
> > Author: Stephen Boyd 
> > Date:   Wed Dec 28 14:56:48 2016 -0800
> > 
> > of: device: Export of_device_{get_modalias, uvent_modalias} to modules
> > 
> > The ULPI bus can be built as a module, and it will soon be
> > calling these functions when it supports probing devices from DT.
> > Export them so they can be used by the ULPI module.
> > 
> > Acked-by: Rob Herring 
> > Cc: 
> > Signed-off-by: Stephen Boyd 
> > Signed-off-by: Peter Chen   
> 
> Ah, so the if this is pulled into linux-next at the same time, then
> there's no build error.
> 
> Stephen, do you need/want me to cherry-pick this into the tty branch, or
> is it ok as-is?

I will change things so that I merge the usb tree before the tty tree.
Please remember to tell Linus that they need to be merged in that order.

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build failure after merge of the tty tree

[Greg KH]

On Mon, Feb 06, 2017 at 08:09:16AM -0600, Rob Herring wrote:
> On Mon, Feb 6, 2017 at 2:51 AM, Greg KH  wrote:
> > On Mon, Feb 06, 2017 at 03:22:09PM +1100, Stephen Rothwell wrote:
> >> Hi Greg,
> >>
> >> After merging the tty tree, today's linux-next build (x86_64 allmodconfig)
> >> failed like this:
> >>
> >> ERROR: "of_device_uevent_modalias" [drivers/tty/serdev/serdev.ko] 
> >> undefined!
> >> ERROR: "of_device_get_modalias" [drivers/tty/serdev/serdev.ko] undefined!
> >>
> >> Caused by commit
> >>
> >>   cd6484e1830b ("serdev: Introduce new bus for serial attached devices")
> >>
> >> I have used the tty tree from next-20170203 for today.
> >
> > Ugh, how has this been passing the 0-day bot builds succesfully?
> >
> > Rob, any ideas?
> 
> It didn't, but we happened to already have a fix queued up for 4.11.
> The fix is in your usb-next branch:
> 
> commit 7a3b7cd332db08546f3cdd984f11773e0d1999e7
> Author: Stephen Boyd 
> Date:   Wed Dec 28 14:56:48 2016 -0800
> 
> of: device: Export of_device_{get_modalias, uvent_modalias} to modules
> 
> The ULPI bus can be built as a module, and it will soon be
> calling these functions when it supports probing devices from DT.
> Export them so they can be used by the ULPI module.
> 
> Acked-by: Rob Herring 
> Cc: 
> Signed-off-by: Stephen Boyd 
> Signed-off-by: Peter Chen 

Ah, so the if this is pulled into linux-next at the same time, then
there's no build error.

Stephen, do you need/want me to cherry-pick this into the tty branch, or
is it ok as-is?

thanks,

greg k-h

Re: linux-next: build failure after merge of the tty tree

[Greg KH]

On Mon, Feb 06, 2017 at 08:09:16AM -0600, Rob Herring wrote:
> On Mon, Feb 6, 2017 at 2:51 AM, Greg KH  wrote:
> > On Mon, Feb 06, 2017 at 03:22:09PM +1100, Stephen Rothwell wrote:
> >> Hi Greg,
> >>
> >> After merging the tty tree, today's linux-next build (x86_64 allmodconfig)
> >> failed like this:
> >>
> >> ERROR: "of_device_uevent_modalias" [drivers/tty/serdev/serdev.ko] 
> >> undefined!
> >> ERROR: "of_device_get_modalias" [drivers/tty/serdev/serdev.ko] undefined!
> >>
> >> Caused by commit
> >>
> >>   cd6484e1830b ("serdev: Introduce new bus for serial attached devices")
> >>
> >> I have used the tty tree from next-20170203 for today.
> >
> > Ugh, how has this been passing the 0-day bot builds succesfully?
> >
> > Rob, any ideas?
> 
> It didn't, but we happened to already have a fix queued up for 4.11.
> The fix is in your usb-next branch:
> 
> commit 7a3b7cd332db08546f3cdd984f11773e0d1999e7
> Author: Stephen Boyd 
> Date:   Wed Dec 28 14:56:48 2016 -0800
> 
> of: device: Export of_device_{get_modalias, uvent_modalias} to modules
> 
> The ULPI bus can be built as a module, and it will soon be
> calling these functions when it supports probing devices from DT.
> Export them so they can be used by the ULPI module.
> 
> Acked-by: Rob Herring 
> Cc: 
> Signed-off-by: Stephen Boyd 
> Signed-off-by: Peter Chen 

Ah, so the if this is pulled into linux-next at the same time, then
there's no build error.

Stephen, do you need/want me to cherry-pick this into the tty branch, or
is it ok as-is?

thanks,

greg k-h

Re: linux-next: build failure after merge of the tty tree

[Rob Herring]

On Mon, Feb 6, 2017 at 2:51 AM, Greg KH  wrote:
> On Mon, Feb 06, 2017 at 03:22:09PM +1100, Stephen Rothwell wrote:
>> Hi Greg,
>>
>> After merging the tty tree, today's linux-next build (x86_64 allmodconfig)
>> failed like this:
>>
>> ERROR: "of_device_uevent_modalias" [drivers/tty/serdev/serdev.ko] undefined!
>> ERROR: "of_device_get_modalias" [drivers/tty/serdev/serdev.ko] undefined!
>>
>> Caused by commit
>>
>>   cd6484e1830b ("serdev: Introduce new bus for serial attached devices")
>>
>> I have used the tty tree from next-20170203 for today.
>
> Ugh, how has this been passing the 0-day bot builds succesfully?
>
> Rob, any ideas?

It didn't, but we happened to already have a fix queued up for 4.11.
The fix is in your usb-next branch:

commit 7a3b7cd332db08546f3cdd984f11773e0d1999e7
Author: Stephen Boyd 
Date:   Wed Dec 28 14:56:48 2016 -0800

of: device: Export of_device_{get_modalias, uvent_modalias} to modules

The ULPI bus can be built as a module, and it will soon be
calling these functions when it supports probing devices from DT.
Export them so they can be used by the ULPI module.

Acked-by: Rob Herring 
Cc: 
Signed-off-by: Stephen Boyd 
Signed-off-by: Peter Chen 

Rob

Re: linux-next: build failure after merge of the tty tree

[Rob Herring]

On Mon, Feb 6, 2017 at 2:51 AM, Greg KH  wrote:
> On Mon, Feb 06, 2017 at 03:22:09PM +1100, Stephen Rothwell wrote:
>> Hi Greg,
>>
>> After merging the tty tree, today's linux-next build (x86_64 allmodconfig)
>> failed like this:
>>
>> ERROR: "of_device_uevent_modalias" [drivers/tty/serdev/serdev.ko] undefined!
>> ERROR: "of_device_get_modalias" [drivers/tty/serdev/serdev.ko] undefined!
>>
>> Caused by commit
>>
>>   cd6484e1830b ("serdev: Introduce new bus for serial attached devices")
>>
>> I have used the tty tree from next-20170203 for today.
>
> Ugh, how has this been passing the 0-day bot builds succesfully?
>
> Rob, any ideas?

It didn't, but we happened to already have a fix queued up for 4.11.
The fix is in your usb-next branch:

commit 7a3b7cd332db08546f3cdd984f11773e0d1999e7
Author: Stephen Boyd 
Date:   Wed Dec 28 14:56:48 2016 -0800

of: device: Export of_device_{get_modalias, uvent_modalias} to modules

The ULPI bus can be built as a module, and it will soon be
calling these functions when it supports probing devices from DT.
Export them so they can be used by the ULPI module.

Acked-by: Rob Herring 
Cc: 
Signed-off-by: Stephen Boyd 
Signed-off-by: Peter Chen 

Rob

Re: linux-next: build failure after merge of the tty tree

[Greg KH]

On Mon, Feb 06, 2017 at 03:22:09PM +1100, Stephen Rothwell wrote:
> Hi Greg,
> 
> After merging the tty tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
> 
> ERROR: "of_device_uevent_modalias" [drivers/tty/serdev/serdev.ko] undefined!
> ERROR: "of_device_get_modalias" [drivers/tty/serdev/serdev.ko] undefined!
> 
> Caused by commit
> 
>   cd6484e1830b ("serdev: Introduce new bus for serial attached devices")
> 
> I have used the tty tree from next-20170203 for today.

Ugh, how has this been passing the 0-day bot builds succesfully?

Rob, any ideas?

thanks,

greg k-h

Re: linux-next: build failure after merge of the tty tree

[Greg KH]

On Mon, Feb 06, 2017 at 03:22:09PM +1100, Stephen Rothwell wrote:
> Hi Greg,
> 
> After merging the tty tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
> 
> ERROR: "of_device_uevent_modalias" [drivers/tty/serdev/serdev.ko] undefined!
> ERROR: "of_device_get_modalias" [drivers/tty/serdev/serdev.ko] undefined!
> 
> Caused by commit
> 
>   cd6484e1830b ("serdev: Introduce new bus for serial attached devices")
> 
> I have used the tty tree from next-20170203 for today.

Ugh, how has this been passing the 0-day bot builds succesfully?

Rob, any ideas?

thanks,

greg k-h

Re: linux-next: build failure after merge of the tty tree

[Greg KH]

On Fri, Sep 30, 2016 at 01:54:37PM +1000, Stephen Rothwell wrote:
> Hi Greg,
> 
> After merging the tty tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
> 
> drivers/tty/serial/amba-pl011.c: In function 'pl011_console_match':
> drivers/tty/serial/amba-pl011.c:2346:44: error: passing argument 3 of 
> 'uart_parse_earlycon' from incompatible pointer type 
> [-Werror=incompatible-pointer-types]
>   if (uart_parse_earlycon(options, , , ))
> ^
> In file included from drivers/tty/serial/amba-pl011.c:45:0:
> include/linux/serial_core.h:384:5: note: expected 'resource_size_t * {aka 
> unsigned int *}' but argument is of type 'long unsigned int *'
>  int uart_parse_earlycon(char *p, unsigned char *iotype, resource_size_t 
> *addr,
>  ^
> 
> Caused by commit
> 
>   8b8f347d3a48 ("serial: pl011: add console matching function")
> 
> interacting with commit
> 
>   46e36683f433 ("serial: earlycon: Extend earlycon command line option to 
> support 64-bit addresses")
> 
> I have reverted commit 8b8f347d3a48 for today.

Ick, sorry about that.  I wonder why I'm not seeing that same build
failure here, odd.  I'll go revert the same patch in my tree now as
well.

thanks,

greg k-h

Re: linux-next: build failure after merge of the tty tree

[Greg KH]

On Fri, Sep 30, 2016 at 01:54:37PM +1000, Stephen Rothwell wrote:
> Hi Greg,
> 
> After merging the tty tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
> 
> drivers/tty/serial/amba-pl011.c: In function 'pl011_console_match':
> drivers/tty/serial/amba-pl011.c:2346:44: error: passing argument 3 of 
> 'uart_parse_earlycon' from incompatible pointer type 
> [-Werror=incompatible-pointer-types]
>   if (uart_parse_earlycon(options, , , ))
> ^
> In file included from drivers/tty/serial/amba-pl011.c:45:0:
> include/linux/serial_core.h:384:5: note: expected 'resource_size_t * {aka 
> unsigned int *}' but argument is of type 'long unsigned int *'
>  int uart_parse_earlycon(char *p, unsigned char *iotype, resource_size_t 
> *addr,
>  ^
> 
> Caused by commit
> 
>   8b8f347d3a48 ("serial: pl011: add console matching function")
> 
> interacting with commit
> 
>   46e36683f433 ("serial: earlycon: Extend earlycon command line option to 
> support 64-bit addresses")
> 
> I have reverted commit 8b8f347d3a48 for today.

Ick, sorry about that.  I wonder why I'm not seeing that same build
failure here, odd.  I'll go revert the same patch in my tree now as
well.

thanks,

greg k-h

Re: linux-next: build failure after merge of the tty tree

[Greg KH]

On Tue, Aug 18, 2015 at 04:01:16PM +1000, Stephen Rothwell wrote:
> Hi Greg,
> 
> After merging the tty tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
> 
> make[2]: *** No rule to make target 'arch/arm/boot/dts/imx6sl-fox-p1.dtb', 
> needed by '__build'.  Stop.
> 
> Caused by commit
> 
>   189550b8644e ("serial: imx: introduce serial_imx_enable_wakeup()")
> 
> I guess a file was missed.
> 
> I partially reverted that commit:
> 
> From: Stephen Rothwell 
> Date: Tue, 18 Aug 2015 15:56:40 +1000
> Subject: [PATCH] serial: imx: partial revert of "introduce
>  serial_imx_enable_wakeup()"
> 
> This reverts the part of commit 189550b8644e that affects
> arch/arm/boot/dts/Makefile
> 
> Signed-off-by: Stephen Rothwell 
> ---
>  arch/arm/boot/dts/Makefile | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index d3ee1f01ffc7..233159d2eaab 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -330,7 +330,6 @@ dtb-$(CONFIG_SOC_IMX6Q) += \
>   imx6q-wandboard-revb1.dtb
>  dtb-$(CONFIG_SOC_IMX6SL) += \
>   imx6sl-evk.dtb \
> - imx6sl-fox-p1.dtb \
>   imx6sl-warp.dtb
>  dtb-$(CONFIG_SOC_IMX6SX) += \
>   imx6sx-sabreauto.dtb \


Ugh, this sucks, Eduardo, what went wrong here?  I think I have to
revert the original commit now :(

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the tty tree

[Greg KH]

On Tue, Aug 18, 2015 at 04:01:16PM +1000, Stephen Rothwell wrote:
 Hi Greg,
 
 After merging the tty tree, today's linux-next build (arm
 multi_v7_defconfig) failed like this:
 
 make[2]: *** No rule to make target 'arch/arm/boot/dts/imx6sl-fox-p1.dtb', 
 needed by '__build'.  Stop.
 
 Caused by commit
 
   189550b8644e (serial: imx: introduce serial_imx_enable_wakeup())
 
 I guess a file was missed.
 
 I partially reverted that commit:
 
 From: Stephen Rothwell s...@canb.auug.org.au
 Date: Tue, 18 Aug 2015 15:56:40 +1000
 Subject: [PATCH] serial: imx: partial revert of introduce
  serial_imx_enable_wakeup()
 
 This reverts the part of commit 189550b8644e that affects
 arch/arm/boot/dts/Makefile
 
 Signed-off-by: Stephen Rothwell s...@canb.auug.org.au
 ---
  arch/arm/boot/dts/Makefile | 1 -
  1 file changed, 1 deletion(-)
 
 diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
 index d3ee1f01ffc7..233159d2eaab 100644
 --- a/arch/arm/boot/dts/Makefile
 +++ b/arch/arm/boot/dts/Makefile
 @@ -330,7 +330,6 @@ dtb-$(CONFIG_SOC_IMX6Q) += \
   imx6q-wandboard-revb1.dtb
  dtb-$(CONFIG_SOC_IMX6SL) += \
   imx6sl-evk.dtb \
 - imx6sl-fox-p1.dtb \
   imx6sl-warp.dtb
  dtb-$(CONFIG_SOC_IMX6SX) += \
   imx6sx-sabreauto.dtb \


Ugh, this sucks, Eduardo, what went wrong here?  I think I have to
revert the original commit now :(

thanks,

greg k-h
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the tty tree

[Dave Martin]

On Mon, May 11, 2015 at 06:16:26AM +0100, Stephen Rothwell wrote:
> Hi Greg,
> 
> After merging the tty tree, today's linux-next build (arm multi_v7_defconfig)
> failed like this:
> 
> drivers/tty/serial/amba-pl011.c: In function 'pl011_startup':
> drivers/tty/serial/amba-pl011.c:1582:5: error: 'struct uart_amba_port' has no 
> member named 'tx_irq_seen'
>   uap->tx_irq_seen = 0;
>  ^
> 
> Caused by a mismerge between patch "Revert "serial/amba-pl011: Leave
> the TX IRQ alone when the UART is not open" (that appears in Linus' tree
> and the tty tree) and commit 1e84d22322ce ("serial/amba-pl011: Refactor
> and simplify TX FIFO handling") from the tty tree.
> 
> I applied this merge fix patch:
> 
> From: Stephen Rothwell 
> Date: Mon, 11 May 2015 15:12:50 +1000
> Subject: [PATCH] serial/amba-pl011: fix mismerge
> 
> Signed-off-by: Stephen Rothwell 

Ack.  The revert should add those lines back in; then the "Refactor
and simplify" patch gets rid of them finally.

Cheers
---Dave

> ---
>  drivers/tty/serial/amba-pl011.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/tty/serial/amba-pl011.c b/drivers/tty/serial/amba-pl011.c
> index 6fabc059efed..f5bd8426fd75 100644
> --- a/drivers/tty/serial/amba-pl011.c
> +++ b/drivers/tty/serial/amba-pl011.c
> @@ -1578,9 +1578,6 @@ static int pl011_startup(struct uart_port *port)
>  
>   writew(uap->vendor->ifls, uap->port.membase + UART011_IFLS);
>  
> - /* Assume that TX IRQ doesn't work until we see one: */
> - uap->tx_irq_seen = 0;
> -
>   spin_lock_irq(>port.lock);
>  
>   /* restore RTS and DTR */
> -- 
> 2.1.4
> 
> -- 
> Cheers,
> Stephen Rothwells...@canb.auug.org.au


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the tty tree

[Dave Martin]

On Mon, May 11, 2015 at 06:16:26AM +0100, Stephen Rothwell wrote:
 Hi Greg,
 
 After merging the tty tree, today's linux-next build (arm multi_v7_defconfig)
 failed like this:
 
 drivers/tty/serial/amba-pl011.c: In function 'pl011_startup':
 drivers/tty/serial/amba-pl011.c:1582:5: error: 'struct uart_amba_port' has no 
 member named 'tx_irq_seen'
   uap-tx_irq_seen = 0;
  ^
 
 Caused by a mismerge between patch Revert serial/amba-pl011: Leave
 the TX IRQ alone when the UART is not open (that appears in Linus' tree
 and the tty tree) and commit 1e84d22322ce (serial/amba-pl011: Refactor
 and simplify TX FIFO handling) from the tty tree.
 
 I applied this merge fix patch:
 
 From: Stephen Rothwell s...@canb.auug.org.au
 Date: Mon, 11 May 2015 15:12:50 +1000
 Subject: [PATCH] serial/amba-pl011: fix mismerge
 
 Signed-off-by: Stephen Rothwell s...@canb.auug.org.au

Ack.  The revert should add those lines back in; then the Refactor
and simplify patch gets rid of them finally.

Cheers
---Dave

 ---
  drivers/tty/serial/amba-pl011.c | 3 ---
  1 file changed, 3 deletions(-)
 
 diff --git a/drivers/tty/serial/amba-pl011.c b/drivers/tty/serial/amba-pl011.c
 index 6fabc059efed..f5bd8426fd75 100644
 --- a/drivers/tty/serial/amba-pl011.c
 +++ b/drivers/tty/serial/amba-pl011.c
 @@ -1578,9 +1578,6 @@ static int pl011_startup(struct uart_port *port)
  
   writew(uap-vendor-ifls, uap-port.membase + UART011_IFLS);
  
 - /* Assume that TX IRQ doesn't work until we see one: */
 - uap-tx_irq_seen = 0;
 -
   spin_lock_irq(uap-port.lock);
  
   /* restore RTS and DTR */
 -- 
 2.1.4
 
 -- 
 Cheers,
 Stephen Rothwells...@canb.auug.org.au


--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the tty tree

[Stephen Rothwell]

Hi Sebastian,

On Tue, 30 Sep 2014 09:52:39 +0200 Sebastian Andrzej Siewior 
 wrote:
>
> this should have been fixed by commit baeb7ef34952f ("tty: serial: 8250:
> use 32bit variable for rpm_tx_active") in Greg's tty-next tree. Isn't
> this the case or did you fetch the tty tree before Greg pushed it?

Presumably the latter, in which case I will see the fix tomorrow.

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


signature.asc
Description: PGP signature

Re: linux-next: build failure after merge of the tty tree

[Sebastian Andrzej Siewior]

* Stephen Rothwell | 2014-09-30 17:39:00 [+1000]:

>Hi Greg,
Hi Stephen,

>After merging the tty tree, today's linux-next build (powerpc
>ppc64_defconfig) failed like this:
>
>
>drivers/built-in.o: In function `.serial8250_stop_tx':
>8250_core.c:(.text+0xda1f4): undefined reference to 
>`.__xchg_called_with_bad_pointer'
>drivers/built-in.o: In function `.serial8250_tx_chars':
>(.text+0xda42c): undefined reference to `.__xchg_called_with_bad_pointer'
>drivers/built-in.o: In function `.serial8250_start_tx':
>8250_core.c:(.text+0xda630): undefined reference to 
>`.__xchg_called_with_bad_pointer'
>
>Caused by commit d74d5d1b7288 ("tty: serial: 8250_core: add run time
>pm").  xchg is called with >rpm_tx_active and that is an unsigned
>char.  PowerPC (at least) only allows xchg with objects 4 (or 8 on 64
>bit) bytes long.
>
>I have used the version of the tty tree from next-20140926 for today.

this should have been fixed by commit baeb7ef34952f ("tty: serial: 8250:
use 32bit variable for rpm_tx_active") in Greg's tty-next tree. Isn't
this the case or did you fetch the tty tree before Greg pushed it?

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the tty tree

[Sebastian Andrzej Siewior]

* Stephen Rothwell | 2014-09-30 17:39:00 [+1000]:

Hi Greg,
Hi Stephen,

After merging the tty tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:


drivers/built-in.o: In function `.serial8250_stop_tx':
8250_core.c:(.text+0xda1f4): undefined reference to 
`.__xchg_called_with_bad_pointer'
drivers/built-in.o: In function `.serial8250_tx_chars':
(.text+0xda42c): undefined reference to `.__xchg_called_with_bad_pointer'
drivers/built-in.o: In function `.serial8250_start_tx':
8250_core.c:(.text+0xda630): undefined reference to 
`.__xchg_called_with_bad_pointer'

Caused by commit d74d5d1b7288 (tty: serial: 8250_core: add run time
pm).  xchg is called with p-rpm_tx_active and that is an unsigned
char.  PowerPC (at least) only allows xchg with objects 4 (or 8 on 64
bit) bytes long.

I have used the version of the tty tree from next-20140926 for today.

this should have been fixed by commit baeb7ef34952f (tty: serial: 8250:
use 32bit variable for rpm_tx_active) in Greg's tty-next tree. Isn't
this the case or did you fetch the tty tree before Greg pushed it?

Sebastian
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the tty tree

[Stephen Rothwell]

Hi Sebastian,

On Tue, 30 Sep 2014 09:52:39 +0200 Sebastian Andrzej Siewior 
bige...@linutronix.de wrote:

 this should have been fixed by commit baeb7ef34952f (tty: serial: 8250:
 use 32bit variable for rpm_tx_active) in Greg's tty-next tree. Isn't
 this the case or did you fetch the tty tree before Greg pushed it?

Presumably the latter, in which case I will see the fix tomorrow.

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


signature.asc
Description: PGP signature

Re: linux-next: build failure after merge of the tty tree

[Greg KH]

On Thu, Sep 25, 2014 at 04:30:36PM +1000, Stephen Rothwell wrote:
> Hi Greg,
> 
> After merging the tty tree, today's linux-next build (arm multi_v7_defconfig)
> failed like this:
> 
> In file included from init/do_mounts.c:15:0:
> include/linux/tty.h:267:9: error: width of 'unused' exceeds its type
>  unused:62;
>  ^
> include/linux/tty.h:271:9: error: width of 'unused_ctrl' exceeds its type
>  unused_ctrl:55;
>  ^
> In file included from init/main.c:28:0:
> include/linux/tty.h:267:9: error: width of 'unused' exceeds its type
>  unused:62;
>  ^
> include/linux/tty.h:271:9: error: width of 'unused_ctrl' exceeds its type
>  unused_ctrl:55;
>  ^
> In file included from include/linux/serial_core.h:29:0,
>  from include/linux/serial_s3c.h:236,
>  from arch/arm/mach-exynos/exynos.c:15:
> include/linux/tty.h:267:9: error: width of 'unused' exceeds its type
>  unused:62;
>  ^
> include/linux/tty.h:271:9: error: width of 'unused_ctrl' exceeds its type
>  unused_ctrl:55;
>  ^
> In file included from include/linux/serial_core.h:29:0,
>  from include/linux/platform_data/serial-omap.h:20,
>  from arch/arm/mach-omap2/serial.c:30:
> include/linux/tty.h:267:9: error: width of 'unused' exceeds its type
>  unused:62;
>  ^
> include/linux/tty.h:271:9: error: width of 'unused_ctrl' exceeds its type
>  unused_ctrl:55;
>  ^
> 
> Caused by commits c545b66c6922 ("tty: Serialize tcflow() with other tty
> flow control changes") and 99416322dd16 ("tty: Workaround Alpha
> non-atomic byte storage in tty_struct").  There are still 32 bit
> architectures out there!  ;-)

Sorry about that, a fix for this is now in my tree.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the tty tree

[Greg KH]

On Thu, Sep 25, 2014 at 04:30:36PM +1000, Stephen Rothwell wrote:
 Hi Greg,
 
 After merging the tty tree, today's linux-next build (arm multi_v7_defconfig)
 failed like this:
 
 In file included from init/do_mounts.c:15:0:
 include/linux/tty.h:267:9: error: width of 'unused' exceeds its type
  unused:62;
  ^
 include/linux/tty.h:271:9: error: width of 'unused_ctrl' exceeds its type
  unused_ctrl:55;
  ^
 In file included from init/main.c:28:0:
 include/linux/tty.h:267:9: error: width of 'unused' exceeds its type
  unused:62;
  ^
 include/linux/tty.h:271:9: error: width of 'unused_ctrl' exceeds its type
  unused_ctrl:55;
  ^
 In file included from include/linux/serial_core.h:29:0,
  from include/linux/serial_s3c.h:236,
  from arch/arm/mach-exynos/exynos.c:15:
 include/linux/tty.h:267:9: error: width of 'unused' exceeds its type
  unused:62;
  ^
 include/linux/tty.h:271:9: error: width of 'unused_ctrl' exceeds its type
  unused_ctrl:55;
  ^
 In file included from include/linux/serial_core.h:29:0,
  from include/linux/platform_data/serial-omap.h:20,
  from arch/arm/mach-omap2/serial.c:30:
 include/linux/tty.h:267:9: error: width of 'unused' exceeds its type
  unused:62;
  ^
 include/linux/tty.h:271:9: error: width of 'unused_ctrl' exceeds its type
  unused_ctrl:55;
  ^
 
 Caused by commits c545b66c6922 (tty: Serialize tcflow() with other tty
 flow control changes) and 99416322dd16 (tty: Workaround Alpha
 non-atomic byte storage in tty_struct).  There are still 32 bit
 architectures out there!  ;-)

Sorry about that, a fix for this is now in my tree.

greg k-h
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the tty tree

[Barry Song]

2014-05-29 20:18 GMT+08:00 Barry Song :
> From: Stephen Rothwell [s...@canb.auug.org.au]
> Sent: Thursday, May 29, 2014 15:28
> To: Greg KH
> Cc: linux-n...@vger.kernel.org; linux-kernel@vger.kernel.org; Qipan Li; Barry 
> Song
> Subject: linux-next: build failure after merge of the tty tree
>
> Hi Greg,
>
> After merging the tty tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
>
> drivers/tty/serial/sirfsoc_uart.c: In function 
> 'sirfsoc_uart_rx_dma_complete_tl':
> drivers/tty/serial/sirfsoc_uart.c:707:2: error: 'struct uart_port' has no 
> member named 'rx_lock'
>
> Caused by commit 07d410e06463 ("serial: sirf: fix spinlock deadlock
> issue").  Did anyone even build test this? Much less test that it fixed
> the deadlock ... :-(
>

Stephen, it is my fault. qipan did a strange mis-operation when he
prepared this patch and i didn't double-confirm it.
but the patch did have been tested on real hardware to fix the
deadlock issue. it is not a patch without test.

the build issue has been fixed in another thread: [PATCH tty-next]
serial: sirf: Fix compilation failure
https://lkml.org/lkml/2014/5/29/476

i am very sorry for this as the related platform maintainer. i didn't
control this well and missed to do a double build for this. again, i
am very sorry!

> I have used the tty tree from next-20140528 for today.
> --
> Cheers,
> Stephen Rothwells...@canb.auug.org.au
>

-barry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the tty tree

[Barry Song]

2014-05-29 20:18 GMT+08:00 Barry Song barry.s...@csr.com:
 From: Stephen Rothwell [s...@canb.auug.org.au]
 Sent: Thursday, May 29, 2014 15:28
 To: Greg KH
 Cc: linux-n...@vger.kernel.org; linux-kernel@vger.kernel.org; Qipan Li; Barry 
 Song
 Subject: linux-next: build failure after merge of the tty tree

 Hi Greg,

 After merging the tty tree, today's linux-next build (arm
 multi_v7_defconfig) failed like this:

 drivers/tty/serial/sirfsoc_uart.c: In function 
 'sirfsoc_uart_rx_dma_complete_tl':
 drivers/tty/serial/sirfsoc_uart.c:707:2: error: 'struct uart_port' has no 
 member named 'rx_lock'

 Caused by commit 07d410e06463 (serial: sirf: fix spinlock deadlock
 issue).  Did anyone even build test this? Much less test that it fixed
 the deadlock ... :-(


Stephen, it is my fault. qipan did a strange mis-operation when he
prepared this patch and i didn't double-confirm it.
but the patch did have been tested on real hardware to fix the
deadlock issue. it is not a patch without test.

the build issue has been fixed in another thread: [PATCH tty-next]
serial: sirf: Fix compilation failure
https://lkml.org/lkml/2014/5/29/476

i am very sorry for this as the related platform maintainer. i didn't
control this well and missed to do a double build for this. again, i
am very sorry!

 I have used the tty tree from next-20140528 for today.
 --
 Cheers,
 Stephen Rothwells...@canb.auug.org.au


-barry
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the tty tree

[Greg KH]

On Thu, Oct 31, 2013 at 09:09:51AM -0400, Philippe Proulx wrote:
> - Original Message -
> > From: "Sedat Dilek" 
> > To: "Stephen Rothwell" , "Philippe Proulx" 
> > 
> > Cc: "Greg KH" , "linux-next" , 
> > "LKML" ,
> > linux-ser...@vger.kernel.org
> > Sent: Thursday, 31 October, 2013 6:35:23 AM
> > Subject: Re: linux-next: build failure after merge of the tty tree
> > 
> > On Thu, Oct 31, 2013 at 8:40 AM, Stephen Rothwell
> >  wrote:
> > > Hi Greg,
> > >
> > > After merging the tty tree, today's linux-next build (arm
> > > multi_v7_defconfig) failed like this:
> > >
> > > drivers/tty/serial/omap-serial.c: In function 'serial_omap_probe':
> > > drivers/tty/serial/omap-serial.c:1724:22: error: expected ')'
> > > before numeric constant
> > > drivers/tty/serial/omap-serial.c:1724:22: warning: format '%d'
> > > expects a matching 'int' argument [-Wformat]
> > >
> > > Caused by commit e5f9bf72efbc ("serial: omap: fix a few checkpatch
> > > warnings").  There is a missing ',' in the dev_warn() ...
> > >
> > > I have used the version of the tty tree from next-20131030 for
> > > today.
> > >
> > 
> > [ Add CC to linux-serial ML ]
> > 
> > Happy HelloWien and WelcomeBackStephen!
> > 
> > That was only checkpatch-tested, eh :-)?
> > 
> > @@ -1724,8 +1722,9 @@ static int serial_omap_probe(struct
> > platform_device *pdev)
> > up->port.uartclk = omap_up_info->uartclk;
> > if (!up->port.uartclk) {
> > up->port.uartclk = DEFAULT_CLK_SPEED;
> > - dev_warn(>dev, "No clock speed specified: using default:"
> > - "%d\n", DEFAULT_CLK_SPEED);
> > + dev_warn(>dev,
> > + "No clock speed specified: using default: %d\n" <--- Comma missing
> > here!
> 
> Oops, something obviously went wrong in my process. Sorry about this.
> 
> Do you want me to fix this commit?

Please send me a patch that I can apply.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the tty tree

[Philippe Proulx]

- Original Message -
> From: "Sedat Dilek" 
> To: "Stephen Rothwell" , "Philippe Proulx" 
> 
> Cc: "Greg KH" , "linux-next" , 
> "LKML" ,
> linux-ser...@vger.kernel.org
> Sent: Thursday, 31 October, 2013 6:35:23 AM
> Subject: Re: linux-next: build failure after merge of the tty tree
> 
> On Thu, Oct 31, 2013 at 8:40 AM, Stephen Rothwell
>  wrote:
> > Hi Greg,
> >
> > After merging the tty tree, today's linux-next build (arm
> > multi_v7_defconfig) failed like this:
> >
> > drivers/tty/serial/omap-serial.c: In function 'serial_omap_probe':
> > drivers/tty/serial/omap-serial.c:1724:22: error: expected ')'
> > before numeric constant
> > drivers/tty/serial/omap-serial.c:1724:22: warning: format '%d'
> > expects a matching 'int' argument [-Wformat]
> >
> > Caused by commit e5f9bf72efbc ("serial: omap: fix a few checkpatch
> > warnings").  There is a missing ',' in the dev_warn() ...
> >
> > I have used the version of the tty tree from next-20131030 for
> > today.
> >
> 
> [ Add CC to linux-serial ML ]
> 
> Happy HelloWien and WelcomeBackStephen!
> 
> That was only checkpatch-tested, eh :-)?
> 
> @@ -1724,8 +1722,9 @@ static int serial_omap_probe(struct
> platform_device *pdev)
> up->port.uartclk = omap_up_info->uartclk;
> if (!up->port.uartclk) {
> up->port.uartclk = DEFAULT_CLK_SPEED;
> - dev_warn(>dev, "No clock speed specified: using default:"
> - "%d\n", DEFAULT_CLK_SPEED);
> + dev_warn(>dev,
> + "No clock speed specified: using default: %d\n" <--- Comma missing
> here!

Oops, something obviously went wrong in my process. Sorry about this.

Do you want me to fix this commit?

> + DEFAULT_CLK_SPEED);
> }
> 
> - Sedat -
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the tty tree

[Sedat Dilek]

On Thu, Oct 31, 2013 at 8:40 AM, Stephen Rothwell  wrote:
> Hi Greg,
>
> After merging the tty tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
>
> drivers/tty/serial/omap-serial.c: In function 'serial_omap_probe':
> drivers/tty/serial/omap-serial.c:1724:22: error: expected ')' before numeric 
> constant
> drivers/tty/serial/omap-serial.c:1724:22: warning: format '%d' expects a 
> matching 'int' argument [-Wformat]
>
> Caused by commit e5f9bf72efbc ("serial: omap: fix a few checkpatch
> warnings").  There is a missing ',' in the dev_warn() ...
>
> I have used the version of the tty tree from next-20131030 for today.
>

[ Add CC to linux-serial ML ]

Happy HelloWien and WelcomeBackStephen!

That was only checkpatch-tested, eh :-)?

@@ -1724,8 +1722,9 @@ static int serial_omap_probe(struct platform_device *pdev)
up->port.uartclk = omap_up_info->uartclk;
if (!up->port.uartclk) {
up->port.uartclk = DEFAULT_CLK_SPEED;
- dev_warn(>dev, "No clock speed specified: using default:"
- "%d\n", DEFAULT_CLK_SPEED);
+ dev_warn(>dev,
+ "No clock speed specified: using default: %d\n" <--- Comma missing here!
+ DEFAULT_CLK_SPEED);
}

- Sedat -
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the tty tree

[Sedat Dilek]

On Thu, Oct 31, 2013 at 8:40 AM, Stephen Rothwell s...@canb.auug.org.au wrote:
 Hi Greg,

 After merging the tty tree, today's linux-next build (arm
 multi_v7_defconfig) failed like this:

 drivers/tty/serial/omap-serial.c: In function 'serial_omap_probe':
 drivers/tty/serial/omap-serial.c:1724:22: error: expected ')' before numeric 
 constant
 drivers/tty/serial/omap-serial.c:1724:22: warning: format '%d' expects a 
 matching 'int' argument [-Wformat]

 Caused by commit e5f9bf72efbc (serial: omap: fix a few checkpatch
 warnings).  There is a missing ',' in the dev_warn() ...

 I have used the version of the tty tree from next-20131030 for today.


[ Add CC to linux-serial ML ]

Happy HelloWien and WelcomeBackStephen!

That was only checkpatch-tested, eh :-)?

@@ -1724,8 +1722,9 @@ static int serial_omap_probe(struct platform_device *pdev)
up-port.uartclk = omap_up_info-uartclk;
if (!up-port.uartclk) {
up-port.uartclk = DEFAULT_CLK_SPEED;
- dev_warn(pdev-dev, No clock speed specified: using default:
- %d\n, DEFAULT_CLK_SPEED);
+ dev_warn(pdev-dev,
+ No clock speed specified: using default: %d\n --- Comma missing here!
+ DEFAULT_CLK_SPEED);
}

- Sedat -
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the tty tree

[Philippe Proulx]

- Original Message -
 From: Sedat Dilek sedat.di...@gmail.com
 To: Stephen Rothwell s...@canb.auug.org.au, Philippe Proulx 
 philippe.pro...@savoirfairelinux.com
 Cc: Greg KH g...@kroah.com, linux-next linux-n...@vger.kernel.org, 
 LKML linux-kernel@vger.kernel.org,
 linux-ser...@vger.kernel.org
 Sent: Thursday, 31 October, 2013 6:35:23 AM
 Subject: Re: linux-next: build failure after merge of the tty tree
 
 On Thu, Oct 31, 2013 at 8:40 AM, Stephen Rothwell
 s...@canb.auug.org.au wrote:
  Hi Greg,
 
  After merging the tty tree, today's linux-next build (arm
  multi_v7_defconfig) failed like this:
 
  drivers/tty/serial/omap-serial.c: In function 'serial_omap_probe':
  drivers/tty/serial/omap-serial.c:1724:22: error: expected ')'
  before numeric constant
  drivers/tty/serial/omap-serial.c:1724:22: warning: format '%d'
  expects a matching 'int' argument [-Wformat]
 
  Caused by commit e5f9bf72efbc (serial: omap: fix a few checkpatch
  warnings).  There is a missing ',' in the dev_warn() ...
 
  I have used the version of the tty tree from next-20131030 for
  today.
 
 
 [ Add CC to linux-serial ML ]
 
 Happy HelloWien and WelcomeBackStephen!
 
 That was only checkpatch-tested, eh :-)?
 
 @@ -1724,8 +1722,9 @@ static int serial_omap_probe(struct
 platform_device *pdev)
 up-port.uartclk = omap_up_info-uartclk;
 if (!up-port.uartclk) {
 up-port.uartclk = DEFAULT_CLK_SPEED;
 - dev_warn(pdev-dev, No clock speed specified: using default:
 - %d\n, DEFAULT_CLK_SPEED);
 + dev_warn(pdev-dev,
 + No clock speed specified: using default: %d\n --- Comma missing
 here!

Oops, something obviously went wrong in my process. Sorry about this.

Do you want me to fix this commit?

 + DEFAULT_CLK_SPEED);
 }
 
 - Sedat -
 
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the tty tree

[Greg KH]

On Thu, Oct 31, 2013 at 09:09:51AM -0400, Philippe Proulx wrote:
 - Original Message -
  From: Sedat Dilek sedat.di...@gmail.com
  To: Stephen Rothwell s...@canb.auug.org.au, Philippe Proulx 
  philippe.pro...@savoirfairelinux.com
  Cc: Greg KH g...@kroah.com, linux-next linux-n...@vger.kernel.org, 
  LKML linux-kernel@vger.kernel.org,
  linux-ser...@vger.kernel.org
  Sent: Thursday, 31 October, 2013 6:35:23 AM
  Subject: Re: linux-next: build failure after merge of the tty tree
  
  On Thu, Oct 31, 2013 at 8:40 AM, Stephen Rothwell
  s...@canb.auug.org.au wrote:
   Hi Greg,
  
   After merging the tty tree, today's linux-next build (arm
   multi_v7_defconfig) failed like this:
  
   drivers/tty/serial/omap-serial.c: In function 'serial_omap_probe':
   drivers/tty/serial/omap-serial.c:1724:22: error: expected ')'
   before numeric constant
   drivers/tty/serial/omap-serial.c:1724:22: warning: format '%d'
   expects a matching 'int' argument [-Wformat]
  
   Caused by commit e5f9bf72efbc (serial: omap: fix a few checkpatch
   warnings).  There is a missing ',' in the dev_warn() ...
  
   I have used the version of the tty tree from next-20131030 for
   today.
  
  
  [ Add CC to linux-serial ML ]
  
  Happy HelloWien and WelcomeBackStephen!
  
  That was only checkpatch-tested, eh :-)?
  
  @@ -1724,8 +1722,9 @@ static int serial_omap_probe(struct
  platform_device *pdev)
  up-port.uartclk = omap_up_info-uartclk;
  if (!up-port.uartclk) {
  up-port.uartclk = DEFAULT_CLK_SPEED;
  - dev_warn(pdev-dev, No clock speed specified: using default:
  - %d\n, DEFAULT_CLK_SPEED);
  + dev_warn(pdev-dev,
  + No clock speed specified: using default: %d\n --- Comma missing
  here!
 
 Oops, something obviously went wrong in my process. Sorry about this.
 
 Do you want me to fix this commit?

Please send me a patch that I can apply.

greg k-h
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the tty tree

[Peter Hurley]

On 07/24/2013 12:42 AM, Stephen Rothwell wrote:

Hi Greg,

After merging the tty tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:


Sorry. Patch coming.

Regards,
Peter Hurley

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the tty tree

[Peter Hurley]

On 07/24/2013 12:42 AM, Stephen Rothwell wrote:

Hi Greg,

After merging the tty tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:


Sorry. Patch coming.

Regards,
Peter Hurley

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the tty tree

[Stephen Rothwell]

Hi Greg,

On Thu, 21 Mar 2013 16:47:24 -0700 Greg KH  wrote:
>
> On Fri, Mar 22, 2013 at 10:28:08AM +1100, Stephen Rothwell wrote:
> > 
> > Except, of course, commit 27b351c is not in your tty tree :-(
> 
> Which was causing me lots of confusion :)
> 
> I've merged it in there now, and reverted it, so all should be good.

Thanks.

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgp_qUp_BmzMI.pgp
Description: PGP signature

Re: linux-next: build failure after merge of the tty tree

[Greg KH]

On Fri, Mar 22, 2013 at 10:28:08AM +1100, Stephen Rothwell wrote:
> Hi Greg,
> 
> On Fri, 22 Mar 2013 09:54:23 +1100 Stephen Rothwell  
> wrote:
> >
> > On Wed, 20 Mar 2013 17:16:28 -0700 Greg KH  wrote:
> > >
> > > On Wed, Mar 20, 2013 at 11:15:11AM -0400, Bill Pemberton wrote:
> > > > Jiri Slaby writes:
> > > > > 
> > > > > On 03/20/2013 03:42 PM, Bill Pemberton wrote:
> > > > > 
> > > > > Asking Greg to revert should suffice. I commented on that patch, but 
> > > > > in
> > > > > a different thread, so Greg missed the comment the patch is not needed
> > > > > IIRC. What was the title of the patch, I cannot find it immediately 
> > > > > :/?
> > > > 
> > > > "USB: quatech2: only write to the tty if the port is open." (commit
> > > > 27b351c in v3.9-rc3).
> > > 
> > > I've now reverted this, so it should be ok.
> > 
> > That patch needed to be reverted in your tty tree, not your usb tree
> > since it breaks a patch added to your tty tree (see Subject).
> 
> Except, of course, commit 27b351c is not in your tty tree :-(

Which was causing me lots of confusion :)

I've merged it in there now, and reverted it, so all should be good.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the tty tree

[Greg KH]

On Fri, Mar 22, 2013 at 09:54:23AM +1100, Stephen Rothwell wrote:
> Hi Greg,
> 
> On Wed, 20 Mar 2013 17:16:28 -0700 Greg KH  wrote:
> >
> > On Wed, Mar 20, 2013 at 11:15:11AM -0400, Bill Pemberton wrote:
> > > Jiri Slaby writes:
> > > > 
> > > > On 03/20/2013 03:42 PM, Bill Pemberton wrote:
> > > > 
> > > > Asking Greg to revert should suffice. I commented on that patch, but in
> > > > a different thread, so Greg missed the comment the patch is not needed
> > > > IIRC. What was the title of the patch, I cannot find it immediately :/?
> > > 
> > > "USB: quatech2: only write to the tty if the port is open." (commit
> > > 27b351c in v3.9-rc3).
> > 
> > I've now reverted this, so it should be ok.
> 
> That patch needed to be reverted in your tty tree, not your usb tree
> since it breaks a patch added to your tty tree (see Subject).

Ah, ok, I've done that now, sorry for the confusion.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the tty tree

[Stephen Rothwell]

Hi Greg,

On Fri, 22 Mar 2013 09:54:23 +1100 Stephen Rothwell  
wrote:
>
> On Wed, 20 Mar 2013 17:16:28 -0700 Greg KH  wrote:
> >
> > On Wed, Mar 20, 2013 at 11:15:11AM -0400, Bill Pemberton wrote:
> > > Jiri Slaby writes:
> > > > 
> > > > On 03/20/2013 03:42 PM, Bill Pemberton wrote:
> > > > 
> > > > Asking Greg to revert should suffice. I commented on that patch, but in
> > > > a different thread, so Greg missed the comment the patch is not needed
> > > > IIRC. What was the title of the patch, I cannot find it immediately :/?
> > > 
> > > "USB: quatech2: only write to the tty if the port is open." (commit
> > > 27b351c in v3.9-rc3).
> > 
> > I've now reverted this, so it should be ok.
> 
> That patch needed to be reverted in your tty tree, not your usb tree
> since it breaks a patch added to your tty tree (see Subject).

Except, of course, commit 27b351c is not in your tty tree :-(

I will continue to carry a revert of 27b351c as a merge fix for when I
merge the tty tree.

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgptDKzvAElmL.pgp
Description: PGP signature

Re: linux-next: build failure after merge of the tty tree

[Stephen Rothwell]

Hi Greg,

On Wed, 20 Mar 2013 17:16:28 -0700 Greg KH  wrote:
>
> On Wed, Mar 20, 2013 at 11:15:11AM -0400, Bill Pemberton wrote:
> > Jiri Slaby writes:
> > > 
> > > On 03/20/2013 03:42 PM, Bill Pemberton wrote:
> > > 
> > > Asking Greg to revert should suffice. I commented on that patch, but in
> > > a different thread, so Greg missed the comment the patch is not needed
> > > IIRC. What was the title of the patch, I cannot find it immediately :/?
> > 
> > "USB: quatech2: only write to the tty if the port is open." (commit
> > 27b351c in v3.9-rc3).
> 
> I've now reverted this, so it should be ok.

That patch needed to be reverted in your tty tree, not your usb tree
since it breaks a patch added to your tty tree (see Subject).

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgpeFanvubnhx.pgp
Description: PGP signature

Re: linux-next: build failure after merge of the tty tree

[Stephen Rothwell]

Hi Greg,

On Wed, 20 Mar 2013 17:16:28 -0700 Greg KH g...@kroah.com wrote:

 On Wed, Mar 20, 2013 at 11:15:11AM -0400, Bill Pemberton wrote:
  Jiri Slaby writes:
   
   On 03/20/2013 03:42 PM, Bill Pemberton wrote:
   
   Asking Greg to revert should suffice. I commented on that patch, but in
   a different thread, so Greg missed the comment the patch is not needed
   IIRC. What was the title of the patch, I cannot find it immediately :/?
  
  USB: quatech2: only write to the tty if the port is open. (commit
  27b351c in v3.9-rc3).
 
 I've now reverted this, so it should be ok.

That patch needed to be reverted in your tty tree, not your usb tree
since it breaks a patch added to your tty tree (see Subject).

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgpeFanvubnhx.pgp
Description: PGP signature

Re: linux-next: build failure after merge of the tty tree

[Stephen Rothwell]

Hi Greg,

On Fri, 22 Mar 2013 09:54:23 +1100 Stephen Rothwell s...@canb.auug.org.au 
wrote:

 On Wed, 20 Mar 2013 17:16:28 -0700 Greg KH g...@kroah.com wrote:
 
  On Wed, Mar 20, 2013 at 11:15:11AM -0400, Bill Pemberton wrote:
   Jiri Slaby writes:

On 03/20/2013 03:42 PM, Bill Pemberton wrote:

Asking Greg to revert should suffice. I commented on that patch, but in
a different thread, so Greg missed the comment the patch is not needed
IIRC. What was the title of the patch, I cannot find it immediately :/?
   
   USB: quatech2: only write to the tty if the port is open. (commit
   27b351c in v3.9-rc3).
  
  I've now reverted this, so it should be ok.
 
 That patch needed to be reverted in your tty tree, not your usb tree
 since it breaks a patch added to your tty tree (see Subject).

Except, of course, commit 27b351c is not in your tty tree :-(

I will continue to carry a revert of 27b351c as a merge fix for when I
merge the tty tree.

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgptDKzvAElmL.pgp
Description: PGP signature

Re: linux-next: build failure after merge of the tty tree

[Greg KH]

On Fri, Mar 22, 2013 at 09:54:23AM +1100, Stephen Rothwell wrote:
 Hi Greg,
 
 On Wed, 20 Mar 2013 17:16:28 -0700 Greg KH g...@kroah.com wrote:
 
  On Wed, Mar 20, 2013 at 11:15:11AM -0400, Bill Pemberton wrote:
   Jiri Slaby writes:

On 03/20/2013 03:42 PM, Bill Pemberton wrote:

Asking Greg to revert should suffice. I commented on that patch, but in
a different thread, so Greg missed the comment the patch is not needed
IIRC. What was the title of the patch, I cannot find it immediately :/?
   
   USB: quatech2: only write to the tty if the port is open. (commit
   27b351c in v3.9-rc3).
  
  I've now reverted this, so it should be ok.
 
 That patch needed to be reverted in your tty tree, not your usb tree
 since it breaks a patch added to your tty tree (see Subject).

Ah, ok, I've done that now, sorry for the confusion.

greg k-h
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the tty tree

[Greg KH]

On Fri, Mar 22, 2013 at 10:28:08AM +1100, Stephen Rothwell wrote:
 Hi Greg,
 
 On Fri, 22 Mar 2013 09:54:23 +1100 Stephen Rothwell s...@canb.auug.org.au 
 wrote:
 
  On Wed, 20 Mar 2013 17:16:28 -0700 Greg KH g...@kroah.com wrote:
  
   On Wed, Mar 20, 2013 at 11:15:11AM -0400, Bill Pemberton wrote:
Jiri Slaby writes:
 
 On 03/20/2013 03:42 PM, Bill Pemberton wrote:
 
 Asking Greg to revert should suffice. I commented on that patch, but 
 in
 a different thread, so Greg missed the comment the patch is not needed
 IIRC. What was the title of the patch, I cannot find it immediately 
 :/?

USB: quatech2: only write to the tty if the port is open. (commit
27b351c in v3.9-rc3).
   
   I've now reverted this, so it should be ok.
  
  That patch needed to be reverted in your tty tree, not your usb tree
  since it breaks a patch added to your tty tree (see Subject).
 
 Except, of course, commit 27b351c is not in your tty tree :-(

Which was causing me lots of confusion :)

I've merged it in there now, and reverted it, so all should be good.

greg k-h
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the tty tree

[Stephen Rothwell]

Hi Greg,

On Thu, 21 Mar 2013 16:47:24 -0700 Greg KH g...@kroah.com wrote:

 On Fri, Mar 22, 2013 at 10:28:08AM +1100, Stephen Rothwell wrote:
  
  Except, of course, commit 27b351c is not in your tty tree :-(
 
 Which was causing me lots of confusion :)
 
 I've merged it in there now, and reverted it, so all should be good.

Thanks.

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgp_qUp_BmzMI.pgp
Description: PGP signature

Re: linux-next: build failure after merge of the tty tree

[Stephen Rothwell]

Hi Greg,

On Wed, 20 Mar 2013 14:12:11 +1100 Stephen Rothwell  
wrote:
>
> After merging the tty tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
> 
> drivers/net/caif/caif_serial.c: In function 'update_tty_status':
> drivers/net/caif/caif_serial.c:94:11: error: 'struct tty_struct' has no 
> member named 'warned'
> 
> Caused by commit 6865ff222cca ("TTY: do not warn about setting speed via
> SPD_*").

I still have this error today so have still used the tty tree from
next-20130319.

> drivers/usb/serial/quatech2.c: In function 'qt2_process_read_urb':
> drivers/usb/serial/quatech2.c:661:18: error: 'struct qt2_port_private' has no 
> member named 'is_open'
> drivers/usb/serial/quatech2.c:705:15: error: 'struct qt2_port_private' has no 
> member named 'is_open'
> 
> Caused by commit e4408ce3c23f ("TTY: quatech2, remove unneeded
> is_open").  grep is your friend (or searching while editting the file).

As has been reported, this one is fixed by reverting commit 27b351c "USB:
quatech2: only write to the tty if the port is open".

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgp88YMzQvpxD.pgp
Description: PGP signature

Re: linux-next: build failure after merge of the tty tree

[Greg KH]

On Wed, Mar 20, 2013 at 11:15:11AM -0400, Bill Pemberton wrote:
> Jiri Slaby writes:
> > 
> > On 03/20/2013 03:42 PM, Bill Pemberton wrote:
> > > Ok, for the unopened ports there *should* never be any actual data to
> > > push so the push is really doing nothing anyhow in these cases.  It's
> > > coming from the device sending an initial change port command.
> > > 
> > > Anyhow, so my patch adding more is_open logic can be dropped and then
> > > yours will apply fine.  What's the best way for me to handle this?
> > > Send a revert for my patch so yours will apply or send an updated
> > > version of your patch that removes my additions?
> > 
> > Asking Greg to revert should suffice. I commented on that patch, but in
> > a different thread, so Greg missed the comment the patch is not needed
> > IIRC. What was the title of the patch, I cannot find it immediately :/?
> > 
> 
> "USB: quatech2: only write to the tty if the port is open." (commit
> 27b351c in v3.9-rc3).

I've now reverted this, so it should be ok.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the tty tree

[Jiri Slaby]

On 03/20/2013 03:42 PM, Bill Pemberton wrote:
> Ok, for the unopened ports there *should* never be any actual data to
> push so the push is really doing nothing anyhow in these cases.  It's
> coming from the device sending an initial change port command.
> 
> Anyhow, so my patch adding more is_open logic can be dropped and then
> yours will apply fine.  What's the best way for me to handle this?
> Send a revert for my patch so yours will apply or send an updated
> version of your patch that removes my additions?

Asking Greg to revert should suffice. I commented on that patch, but in
a different thread, so Greg missed the comment the patch is not needed
IIRC. What was the title of the patch, I cannot find it immediately :/?


-- 
js
suse labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the tty tree

[Bill Pemberton]

Jiri Slaby writes:
> 
> On 03/20/2013 03:42 PM, Bill Pemberton wrote:
> > Ok, for the unopened ports there *should* never be any actual data to
> > push so the push is really doing nothing anyhow in these cases.  It's
> > coming from the device sending an initial change port command.
> > 
> > Anyhow, so my patch adding more is_open logic can be dropped and then
> > yours will apply fine.  What's the best way for me to handle this?
> > Send a revert for my patch so yours will apply or send an updated
> > version of your patch that removes my additions?
> 
> Asking Greg to revert should suffice. I commented on that patch, but in
> a different thread, so Greg missed the comment the patch is not needed
> IIRC. What was the title of the patch, I cannot find it immediately :/?
> 

"USB: quatech2: only write to the tty if the port is open." (commit
27b351c in v3.9-rc3).

-- 
Bill
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the tty tree

[Bill Pemberton]

Jiri Slaby writes:
> 
> On 03/20/2013 01:51 PM, Bill Pemberton wrote:
> > Jiri Slaby writes:
> >>
> >>> drivers/usb/serial/quatech2.c: In function 'qt2_process_read_urb': 
> >>> drivers/usb/serial/quatech2.c:661:18: error: 'struct
> >>> qt2_port_private' has no member named 'is_open' 
> >>> drivers/usb/serial/quatech2.c:705:15: error: 'struct
> >>> qt2_port_private' has no member named 'is_open'
> >>>
> >>> Caused by commit e4408ce3c23f ("TTY: quatech2, remove unneeded 
> >>> is_open").  grep is your friend (or searching while editting the
> >>> file).
> >>
> >> I think this is caused by another commit. Bill added a check for
> >> is_open meanwhile I removed that member completely. Bill, could you
> >> fix that up, please?
> >>
> > 
> > Is it legal to call tty_flip_buffer_push() without an open tty?  If
> > so, I can get rid of the is_open logic completely.  Otherwise, I need
> > to either keep is_open or otherwise check for a valid tty before
> > calling tty_flip_buffer_push().
> 
> Yeah, it is legal to call that, as long as you have a valid tty_port.
> Now, the data are queued and later flushed. The plan is to throw the
> data directly on ingress in a way the drivers don't need to care.
> 

Ok, for the unopened ports there *should* never be any actual data to
push so the push is really doing nothing anyhow in these cases.  It's
coming from the device sending an initial change port command.

Anyhow, so my patch adding more is_open logic can be dropped and then
yours will apply fine.  What's the best way for me to handle this?
Send a revert for my patch so yours will apply or send an updated
version of your patch that removes my additions?


-- 
Bill
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the tty tree

[Jiri Slaby]

On 03/20/2013 01:51 PM, Bill Pemberton wrote:
> Jiri Slaby writes:
>>
>>> drivers/usb/serial/quatech2.c: In function 'qt2_process_read_urb': 
>>> drivers/usb/serial/quatech2.c:661:18: error: 'struct
>>> qt2_port_private' has no member named 'is_open' 
>>> drivers/usb/serial/quatech2.c:705:15: error: 'struct
>>> qt2_port_private' has no member named 'is_open'
>>>
>>> Caused by commit e4408ce3c23f ("TTY: quatech2, remove unneeded 
>>> is_open").  grep is your friend (or searching while editting the
>>> file).
>>
>> I think this is caused by another commit. Bill added a check for
>> is_open meanwhile I removed that member completely. Bill, could you
>> fix that up, please?
>>
> 
> Is it legal to call tty_flip_buffer_push() without an open tty?  If
> so, I can get rid of the is_open logic completely.  Otherwise, I need
> to either keep is_open or otherwise check for a valid tty before
> calling tty_flip_buffer_push().

Yeah, it is legal to call that, as long as you have a valid tty_port.
Now, the data are queued and later flushed. The plan is to throw the
data directly on ingress in a way the drivers don't need to care.

thanks,
-- 
js
suse labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the tty tree

[Bill Pemberton]

Jiri Slaby writes:
> 
> > drivers/usb/serial/quatech2.c: In function 'qt2_process_read_urb': 
> > drivers/usb/serial/quatech2.c:661:18: error: 'struct
> > qt2_port_private' has no member named 'is_open' 
> > drivers/usb/serial/quatech2.c:705:15: error: 'struct
> > qt2_port_private' has no member named 'is_open'
> > 
> > Caused by commit e4408ce3c23f ("TTY: quatech2, remove unneeded 
> > is_open").  grep is your friend (or searching while editting the
> > file).
> 
> I think this is caused by another commit. Bill added a check for
> is_open meanwhile I removed that member completely. Bill, could you
> fix that up, please?
> 

Is it legal to call tty_flip_buffer_push() without an open tty?  If
so, I can get rid of the is_open logic completely.  Otherwise, I need
to either keep is_open or otherwise check for a valid tty before
calling tty_flip_buffer_push().

-- 
Bill
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the tty tree

[Jiri Slaby]

Hi,

On 03/20/2013 04:12 AM, Stephen Rothwell wrote:
> drivers/net/caif/caif_serial.c: In function 'update_tty_status': 
> drivers/net/caif/caif_serial.c:94:11: error: 'struct tty_struct'
> has no member named 'warned'
> 
> Caused by commit 6865ff222cca ("TTY: do not warn about setting
> speed via SPD_*").

I wonder why this didn't trigger locally. I have to check if I have
debugfs enabled. In any way, I will send a patch to fix this later today.

> drivers/usb/serial/quatech2.c: In function 'qt2_process_read_urb': 
> drivers/usb/serial/quatech2.c:661:18: error: 'struct
> qt2_port_private' has no member named 'is_open' 
> drivers/usb/serial/quatech2.c:705:15: error: 'struct
> qt2_port_private' has no member named 'is_open'
> 
> Caused by commit e4408ce3c23f ("TTY: quatech2, remove unneeded 
> is_open").  grep is your friend (or searching while editting the
> file).

I think this is caused by another commit. Bill added a check for
is_open meanwhile I removed that member completely. Bill, could you
fix that up, please?

thanks,
-- 
js
suse labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the tty tree

[Jiri Slaby]

Hi,

On 03/20/2013 04:12 AM, Stephen Rothwell wrote:
 drivers/net/caif/caif_serial.c: In function 'update_tty_status': 
 drivers/net/caif/caif_serial.c:94:11: error: 'struct tty_struct'
 has no member named 'warned'
 
 Caused by commit 6865ff222cca (TTY: do not warn about setting
 speed via SPD_*).

I wonder why this didn't trigger locally. I have to check if I have
debugfs enabled. In any way, I will send a patch to fix this later today.

 drivers/usb/serial/quatech2.c: In function 'qt2_process_read_urb': 
 drivers/usb/serial/quatech2.c:661:18: error: 'struct
 qt2_port_private' has no member named 'is_open' 
 drivers/usb/serial/quatech2.c:705:15: error: 'struct
 qt2_port_private' has no member named 'is_open'
 
 Caused by commit e4408ce3c23f (TTY: quatech2, remove unneeded 
 is_open).  grep is your friend (or searching while editting the
 file).

I think this is caused by another commit. Bill added a check for
is_open meanwhile I removed that member completely. Bill, could you
fix that up, please?

thanks,
-- 
js
suse labs
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the tty tree

[Bill Pemberton]

Jiri Slaby writes:
 
  drivers/usb/serial/quatech2.c: In function 'qt2_process_read_urb': 
  drivers/usb/serial/quatech2.c:661:18: error: 'struct
  qt2_port_private' has no member named 'is_open' 
  drivers/usb/serial/quatech2.c:705:15: error: 'struct
  qt2_port_private' has no member named 'is_open'
  
  Caused by commit e4408ce3c23f (TTY: quatech2, remove unneeded 
  is_open).  grep is your friend (or searching while editting the
  file).
 
 I think this is caused by another commit. Bill added a check for
 is_open meanwhile I removed that member completely. Bill, could you
 fix that up, please?
 

Is it legal to call tty_flip_buffer_push() without an open tty?  If
so, I can get rid of the is_open logic completely.  Otherwise, I need
to either keep is_open or otherwise check for a valid tty before
calling tty_flip_buffer_push().

-- 
Bill
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the tty tree

[Jiri Slaby]

On 03/20/2013 01:51 PM, Bill Pemberton wrote:
 Jiri Slaby writes:

 drivers/usb/serial/quatech2.c: In function 'qt2_process_read_urb': 
 drivers/usb/serial/quatech2.c:661:18: error: 'struct
 qt2_port_private' has no member named 'is_open' 
 drivers/usb/serial/quatech2.c:705:15: error: 'struct
 qt2_port_private' has no member named 'is_open'

 Caused by commit e4408ce3c23f (TTY: quatech2, remove unneeded 
 is_open).  grep is your friend (or searching while editting the
 file).

 I think this is caused by another commit. Bill added a check for
 is_open meanwhile I removed that member completely. Bill, could you
 fix that up, please?

 
 Is it legal to call tty_flip_buffer_push() without an open tty?  If
 so, I can get rid of the is_open logic completely.  Otherwise, I need
 to either keep is_open or otherwise check for a valid tty before
 calling tty_flip_buffer_push().

Yeah, it is legal to call that, as long as you have a valid tty_port.
Now, the data are queued and later flushed. The plan is to throw the
data directly on ingress in a way the drivers don't need to care.

thanks,
-- 
js
suse labs
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the tty tree

[Bill Pemberton]

Jiri Slaby writes:
 
 On 03/20/2013 01:51 PM, Bill Pemberton wrote:
  Jiri Slaby writes:
 
  drivers/usb/serial/quatech2.c: In function 'qt2_process_read_urb': 
  drivers/usb/serial/quatech2.c:661:18: error: 'struct
  qt2_port_private' has no member named 'is_open' 
  drivers/usb/serial/quatech2.c:705:15: error: 'struct
  qt2_port_private' has no member named 'is_open'
 
  Caused by commit e4408ce3c23f (TTY: quatech2, remove unneeded 
  is_open).  grep is your friend (or searching while editting the
  file).
 
  I think this is caused by another commit. Bill added a check for
  is_open meanwhile I removed that member completely. Bill, could you
  fix that up, please?
 
  
  Is it legal to call tty_flip_buffer_push() without an open tty?  If
  so, I can get rid of the is_open logic completely.  Otherwise, I need
  to either keep is_open or otherwise check for a valid tty before
  calling tty_flip_buffer_push().
 
 Yeah, it is legal to call that, as long as you have a valid tty_port.
 Now, the data are queued and later flushed. The plan is to throw the
 data directly on ingress in a way the drivers don't need to care.
 

Ok, for the unopened ports there *should* never be any actual data to
push so the push is really doing nothing anyhow in these cases.  It's
coming from the device sending an initial change port command.

Anyhow, so my patch adding more is_open logic can be dropped and then
yours will apply fine.  What's the best way for me to handle this?
Send a revert for my patch so yours will apply or send an updated
version of your patch that removes my additions?


-- 
Bill
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the tty tree

[Bill Pemberton]

Jiri Slaby writes:
 
 On 03/20/2013 03:42 PM, Bill Pemberton wrote:
  Ok, for the unopened ports there *should* never be any actual data to
  push so the push is really doing nothing anyhow in these cases.  It's
  coming from the device sending an initial change port command.
  
  Anyhow, so my patch adding more is_open logic can be dropped and then
  yours will apply fine.  What's the best way for me to handle this?
  Send a revert for my patch so yours will apply or send an updated
  version of your patch that removes my additions?
 
 Asking Greg to revert should suffice. I commented on that patch, but in
 a different thread, so Greg missed the comment the patch is not needed
 IIRC. What was the title of the patch, I cannot find it immediately :/?
 

USB: quatech2: only write to the tty if the port is open. (commit
27b351c in v3.9-rc3).

-- 
Bill
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the tty tree

[Jiri Slaby]

On 03/20/2013 03:42 PM, Bill Pemberton wrote:
 Ok, for the unopened ports there *should* never be any actual data to
 push so the push is really doing nothing anyhow in these cases.  It's
 coming from the device sending an initial change port command.
 
 Anyhow, so my patch adding more is_open logic can be dropped and then
 yours will apply fine.  What's the best way for me to handle this?
 Send a revert for my patch so yours will apply or send an updated
 version of your patch that removes my additions?

Asking Greg to revert should suffice. I commented on that patch, but in
a different thread, so Greg missed the comment the patch is not needed
IIRC. What was the title of the patch, I cannot find it immediately :/?


-- 
js
suse labs
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the tty tree

[Greg KH]

On Wed, Mar 20, 2013 at 11:15:11AM -0400, Bill Pemberton wrote:
 Jiri Slaby writes:
  
  On 03/20/2013 03:42 PM, Bill Pemberton wrote:
   Ok, for the unopened ports there *should* never be any actual data to
   push so the push is really doing nothing anyhow in these cases.  It's
   coming from the device sending an initial change port command.
   
   Anyhow, so my patch adding more is_open logic can be dropped and then
   yours will apply fine.  What's the best way for me to handle this?
   Send a revert for my patch so yours will apply or send an updated
   version of your patch that removes my additions?
  
  Asking Greg to revert should suffice. I commented on that patch, but in
  a different thread, so Greg missed the comment the patch is not needed
  IIRC. What was the title of the patch, I cannot find it immediately :/?
  
 
 USB: quatech2: only write to the tty if the port is open. (commit
 27b351c in v3.9-rc3).

I've now reverted this, so it should be ok.

greg k-h
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the tty tree

[Stephen Rothwell]

Hi Greg,

On Wed, 20 Mar 2013 14:12:11 +1100 Stephen Rothwell s...@canb.auug.org.au 
wrote:

 After merging the tty tree, today's linux-next build (x86_64 allmodconfig)
 failed like this:
 
 drivers/net/caif/caif_serial.c: In function 'update_tty_status':
 drivers/net/caif/caif_serial.c:94:11: error: 'struct tty_struct' has no 
 member named 'warned'
 
 Caused by commit 6865ff222cca (TTY: do not warn about setting speed via
 SPD_*).

I still have this error today so have still used the tty tree from
next-20130319.

 drivers/usb/serial/quatech2.c: In function 'qt2_process_read_urb':
 drivers/usb/serial/quatech2.c:661:18: error: 'struct qt2_port_private' has no 
 member named 'is_open'
 drivers/usb/serial/quatech2.c:705:15: error: 'struct qt2_port_private' has no 
 member named 'is_open'
 
 Caused by commit e4408ce3c23f (TTY: quatech2, remove unneeded
 is_open).  grep is your friend (or searching while editting the file).

As has been reported, this one is fixed by reverting commit 27b351c USB:
quatech2: only write to the tty if the port is open.

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgp88YMzQvpxD.pgp
Description: PGP signature

Re: linux-next: build failure after merge of the tty tree

[Greg KH]

On Wed, Oct 24, 2012 at 01:28:27PM +1100, Stephen Rothwell wrote:
> Hi Greg,
> 
> After merging the tty tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
> 
> drivers/staging/dgrp/dgrp_net_ops.c: In function 'dgrp_input':
> drivers/staging/dgrp/dgrp_net_ops.c:216:27: error: 'struct tty_struct' has no 
> member named 'real_raw'
> drivers/staging/dgrp/dgrp_net_ops.c:229:8: error: 'struct tty_struct' has no 
> member named 'read_cnt'
> drivers/staging/dgrp/dgrp_net_ops.c:229:8: error: 'struct tty_struct' has no 
> member named 'read_cnt'
> drivers/staging/dgrp/dgrp_net_ops.c:261:30: error: 'struct tty_struct' has no 
> member named 'real_raw'
> drivers/staging/dgrp/dgrp_net_ops.c:276:28: error: 'struct tty_struct' has no 
> member named 'real_raw'
> 
> Caused by commits 53c5ee2cfb4d ("TTY: move ldisc data from tty_struct:
> simple members") and ba2e68ac6157 ("TTY: move ldisc data from tty_struct:
> read_* and echo_* and canon_* stuff") interacting with commit
> 0b52b7497271 ("staging: Add dgrp driver for Digi Realport devices") now
> in Linus' tree.
> 
> I disabled building of the dgrp driver for now using this merge fix patch:
> 
> From: Stephen Rothwell 
> Date: Wed, 24 Oct 2012 13:25:29 +1100
> Subject: [PATCH] staging: disable dgrp driver since it is broken by tty
>  changes
> 
> drivers/staging/dgrp/dgrp_net_ops.c: In function 'dgrp_input':
> drivers/staging/dgrp/dgrp_net_ops.c:216:27: error: 'struct tty_struct' has no 
> member named 'real_raw'
> drivers/staging/dgrp/dgrp_net_ops.c:229:8: error: 'struct tty_struct' has no 
> member named 'read_cnt'
> drivers/staging/dgrp/dgrp_net_ops.c:229:8: error: 'struct tty_struct' has no 
> member named 'read_cnt'
> drivers/staging/dgrp/dgrp_net_ops.c:261:30: error: 'struct tty_struct' has no 
> member named 'real_raw'
> drivers/staging/dgrp/dgrp_net_ops.c:276:28: error: 'struct tty_struct' has no 
> member named 'real_raw'
> 
> Signed-off-by: Stephen Rothwell 
> ---
>  drivers/staging/dgrp/Kconfig |1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/dgrp/Kconfig b/drivers/staging/dgrp/Kconfig
> index 39f4bb6..7d378c2 100644
> --- a/drivers/staging/dgrp/Kconfig
> +++ b/drivers/staging/dgrp/Kconfig
> @@ -2,6 +2,7 @@ config DGRP
> tristate "Digi Realport driver"
> default n
> depends on SYSFS
> + depends on BROKEN

Thanks, that makes sense for now, hopefully Jiri will return from his
conference and fix this driver up.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the tty tree

[Greg KH]

On Wed, Oct 24, 2012 at 01:28:27PM +1100, Stephen Rothwell wrote:
 Hi Greg,
 
 After merging the tty tree, today's linux-next build (x86_64 allmodconfig)
 failed like this:
 
 drivers/staging/dgrp/dgrp_net_ops.c: In function 'dgrp_input':
 drivers/staging/dgrp/dgrp_net_ops.c:216:27: error: 'struct tty_struct' has no 
 member named 'real_raw'
 drivers/staging/dgrp/dgrp_net_ops.c:229:8: error: 'struct tty_struct' has no 
 member named 'read_cnt'
 drivers/staging/dgrp/dgrp_net_ops.c:229:8: error: 'struct tty_struct' has no 
 member named 'read_cnt'
 drivers/staging/dgrp/dgrp_net_ops.c:261:30: error: 'struct tty_struct' has no 
 member named 'real_raw'
 drivers/staging/dgrp/dgrp_net_ops.c:276:28: error: 'struct tty_struct' has no 
 member named 'real_raw'
 
 Caused by commits 53c5ee2cfb4d (TTY: move ldisc data from tty_struct:
 simple members) and ba2e68ac6157 (TTY: move ldisc data from tty_struct:
 read_* and echo_* and canon_* stuff) interacting with commit
 0b52b7497271 (staging: Add dgrp driver for Digi Realport devices) now
 in Linus' tree.
 
 I disabled building of the dgrp driver for now using this merge fix patch:
 
 From: Stephen Rothwell s...@canb.auug.org.au
 Date: Wed, 24 Oct 2012 13:25:29 +1100
 Subject: [PATCH] staging: disable dgrp driver since it is broken by tty
  changes
 
 drivers/staging/dgrp/dgrp_net_ops.c: In function 'dgrp_input':
 drivers/staging/dgrp/dgrp_net_ops.c:216:27: error: 'struct tty_struct' has no 
 member named 'real_raw'
 drivers/staging/dgrp/dgrp_net_ops.c:229:8: error: 'struct tty_struct' has no 
 member named 'read_cnt'
 drivers/staging/dgrp/dgrp_net_ops.c:229:8: error: 'struct tty_struct' has no 
 member named 'read_cnt'
 drivers/staging/dgrp/dgrp_net_ops.c:261:30: error: 'struct tty_struct' has no 
 member named 'real_raw'
 drivers/staging/dgrp/dgrp_net_ops.c:276:28: error: 'struct tty_struct' has no 
 member named 'real_raw'
 
 Signed-off-by: Stephen Rothwell s...@canb.auug.org.au
 ---
  drivers/staging/dgrp/Kconfig |1 +
  1 file changed, 1 insertion(+)
 
 diff --git a/drivers/staging/dgrp/Kconfig b/drivers/staging/dgrp/Kconfig
 index 39f4bb6..7d378c2 100644
 --- a/drivers/staging/dgrp/Kconfig
 +++ b/drivers/staging/dgrp/Kconfig
 @@ -2,6 +2,7 @@ config DGRP
 tristate Digi Realport driver
 default n
 depends on SYSFS
 + depends on BROKEN

Thanks, that makes sense for now, hopefully Jiri will return from his
conference and fix this driver up.

greg k-h
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the tty tree

[Alan Cox]

On Thu, 6 Sep 2012 15:10:14 +1000
Stephen Rothwell  wrote:

> Hi Greg,
> 
> After merging the tty tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> In file included from drivers/tty/serial/sccnxp.c:20:0:
> include/linux/serial_core.h: In function 'uart_handle_break':
> include/linux/serial_core.h:543:30: error: dereferencing pointer to
> incomplete type
> 
> Caused by commit 1d65c0b12656 ("serial: New serial driver SCCNXP").
> This seems to be just exposing a preexisting problem with
> linux/serial_core.h: when SUPPORT_SYSRQ is defined, this header
> depends on linux/console.h.  I can only imagein that every other use
> of serial_core.h pre-includes (maybe indirectly) console.h (or
> doesn't define SUPPORT_SYSRQ).
> 
> I have applied the following patch, but a better solution should be
> figured out.


I think thats actually probably the right patch. Better to keep the
header explicit than try and build some tangled mess of recursive
includes.

Acked-by: Alan Cox 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the tty tree

[Alan Cox]

On Thu, 6 Sep 2012 15:10:14 +1000
Stephen Rothwell s...@canb.auug.org.au wrote:

 Hi Greg,
 
 After merging the tty tree, today's linux-next build (x86_64
 allmodconfig) failed like this:
 
 In file included from drivers/tty/serial/sccnxp.c:20:0:
 include/linux/serial_core.h: In function 'uart_handle_break':
 include/linux/serial_core.h:543:30: error: dereferencing pointer to
 incomplete type
 
 Caused by commit 1d65c0b12656 (serial: New serial driver SCCNXP).
 This seems to be just exposing a preexisting problem with
 linux/serial_core.h: when SUPPORT_SYSRQ is defined, this header
 depends on linux/console.h.  I can only imagein that every other use
 of serial_core.h pre-includes (maybe indirectly) console.h (or
 doesn't define SUPPORT_SYSRQ).
 
 I have applied the following patch, but a better solution should be
 figured out.


I think thats actually probably the right patch. Better to keep the
header explicit than try and build some tangled mess of recursive
includes.

Acked-by: Alan Cox a...@linux.intel.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the tty tree

[Alan Cox]

On Thu, 26 Jul 2012 08:51:27 +1000
Stephen Rothwell  wrote:

> Hi Greg, Alan,
> 
> [Sorry, Alan, I forgot to cc you the first time around.]
> 
> On Fri, 20 Jul 2012 13:33:49 +1000 Stephen Rothwell
>  wrote:
> >
> > After merging the tty tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> > 
> > drivers/staging/serqt_usb2/serqt_usb2.c: In function
> > 'qt_set_termios': drivers/staging/serqt_usb2/serqt_usb2.c:1198:29:
> > error: incompatible types when initializing type 'struct ktermios
> > *' using type 'struct ktermios'
> > drivers/staging/serqt_usb2/serqt_usb2.c:1304:14: error: invalid
> > type argument of '->' (have 'struct ktermios')
> > 

I sent you a fix for that one (I've not done the ipoctal one yet)

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the tty tree

[Stephen Rothwell]

Hi Greg, Alan,

[Sorry, Alan, I forgot to cc you the first time around.]

On Fri, 20 Jul 2012 13:33:49 +1000 Stephen Rothwell  
wrote:
>
> After merging the tty tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
> 
> drivers/staging/serqt_usb2/serqt_usb2.c: In function 'qt_set_termios':
> drivers/staging/serqt_usb2/serqt_usb2.c:1198:29: error: incompatible types 
> when initializing type 'struct ktermios *' using type 'struct ktermios'
> drivers/staging/serqt_usb2/serqt_usb2.c:1304:14: error: invalid type argument 
> of '->' (have 'struct ktermios')
> 
> Presumably caused by commit adc8d746caa6 ("tty: move the termios object
> into the tty").
> 
> Under previous instructions about staging drivers, I have added the
> following patch for today:
> 
> From: Stephen Rothwell 
> Date: Fri, 20 Jul 2012 13:31:39 +1000
> Subject: [PATCH] disable USB_SERIAL_QUATECH2 broken by tty update
> 
> Signed-off-by: Stephen Rothwell 
> ---
>  drivers/staging/serqt_usb2/Kconfig |1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/serqt_usb2/Kconfig 
> b/drivers/staging/serqt_usb2/Kconfig
> index f4fed40..dc624a4 100644
> --- a/drivers/staging/serqt_usb2/Kconfig
> +++ b/drivers/staging/serqt_usb2/Kconfig
> @@ -1,6 +1,7 @@
>  config USB_SERIAL_QUATECH2
>   tristate "USB Quatech ESU-100 8 Port Serial Driver"
>   depends on USB_SERIAL
> + depends on BROKEN
>   help
> Say Y here if you want to use the Quatech ESU-100 8 port usb to
> serial adapter.
> -- 
> 1.7.10.280.gaa39

Ping?
-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgpjwMuwUshdw.pgp
Description: PGP signature

Re: linux-next: build failure after merge of the tty tree

[Stephen Rothwell]

Hi Greg, Alan,

On Fri, 20 Jul 2012 13:28:40 +1000 Stephen Rothwell  
wrote:
>
> After merging the tty tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
> 
> drivers/staging/ipack/devices/ipoctal.c: In function 'ipoctal_set_termios':
> drivers/staging/ipack/devices/ipoctal.c:614:22: error: invalid type argument 
> of '->' (have 'struct ktermios')
> drivers/staging/ipack/devices/ipoctal.c:640:15: error: invalid type argument 
> of '->' (have 'struct ktermios')
> drivers/staging/ipack/devices/ipoctal.c:654:14: error: invalid type argument 
> of '->' (have 'struct ktermios')
> drivers/staging/ipack/devices/ipoctal.c:691:2: error: incompatible type for 
> argument 1 of 'tty_termios_encode_baud_rate'
> include/linux/tty.h:449:13: note: expected 'struct ktermios *' but argument 
> is of type 'struct ktermios'
> drivers/staging/ipack/devices/ipoctal.c:694:22: error: invalid type argument 
> of '->' (have 'struct ktermios')
> drivers/staging/ipack/devices/ipoctal.c:735:3: error: incompatible type for 
> argument 1 of 'tty_termios_encode_baud_rate'
> include/linux/tty.h:449:13: note: expected 'struct ktermios *' but argument 
> is of type 'struct ktermios'
> 
> Presumably caused by commit adc8d746caa6 ("tty: move the termios object
> into the tty").
> 
> Under previous instructions about staging drivers, I have added the
> following patch for today:
> 
> From c4bc70a8fc9cc687690aaf51865561ffcd6190f9 Mon Sep 17 00:00:00 2001
> From: Stephen Rothwell 
> Date: Fri, 20 Jul 2012 13:25:12 +1000
> Subject: [PATCH] disable SERIAL_IPOCTAL broken by tty updates
> 
> Signed-off-by: Stephen Rothwell 
> ---
>  drivers/staging/ipack/devices/Kconfig |1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/ipack/devices/Kconfig 
> b/drivers/staging/ipack/devices/Kconfig
> index 39f7188..8d69ce3 100644
> --- a/drivers/staging/ipack/devices/Kconfig
> +++ b/drivers/staging/ipack/devices/Kconfig
> @@ -1,6 +1,7 @@
>  config SERIAL_IPOCTAL
>   tristate "IndustryPack IP-OCTAL uart support"
>   depends on IPACK_BUS
> + depends on BROKEN
>   help
> This driver supports the IPOCTAL serial port device for the 
> IndustryPack bus.
>   default n
> -- 
> 1.7.10.280.gaa39

Ping?
-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgpdxJkFNRecm.pgp
Description: PGP signature

Re: linux-next: build failure after merge of the tty tree

[Greg KH]

On Fri, Jul 20, 2012 at 01:28:40PM +1000, Stephen Rothwell wrote:
> Hi Greg,
> 
> After merging the tty tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
> 
> drivers/staging/ipack/devices/ipoctal.c: In function 'ipoctal_set_termios':
> drivers/staging/ipack/devices/ipoctal.c:614:22: error: invalid type argument 
> of '->' (have 'struct ktermios')
> drivers/staging/ipack/devices/ipoctal.c:640:15: error: invalid type argument 
> of '->' (have 'struct ktermios')
> drivers/staging/ipack/devices/ipoctal.c:654:14: error: invalid type argument 
> of '->' (have 'struct ktermios')
> drivers/staging/ipack/devices/ipoctal.c:691:2: error: incompatible type for 
> argument 1 of 'tty_termios_encode_baud_rate'
> include/linux/tty.h:449:13: note: expected 'struct ktermios *' but argument 
> is of type 'struct ktermios'
> drivers/staging/ipack/devices/ipoctal.c:694:22: error: invalid type argument 
> of '->' (have 'struct ktermios')
> drivers/staging/ipack/devices/ipoctal.c:735:3: error: incompatible type for 
> argument 1 of 'tty_termios_encode_baud_rate'
> include/linux/tty.h:449:13: note: expected 'struct ktermios *' but argument 
> is of type 'struct ktermios'
> 
> Presumably caused by commit adc8d746caa6 ("tty: move the termios object
> into the tty").
> 
> Under previous instructions about staging drivers, I have added the
> following patch for today:
> 
> From c4bc70a8fc9cc687690aaf51865561ffcd6190f9 Mon Sep 17 00:00:00 2001
> From: Stephen Rothwell 
> Date: Fri, 20 Jul 2012 13:25:12 +1000
> Subject: [PATCH] disable SERIAL_IPOCTAL broken by tty updates
> 
> Signed-off-by: Stephen Rothwell 
> ---
>  drivers/staging/ipack/devices/Kconfig |1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/ipack/devices/Kconfig 
> b/drivers/staging/ipack/devices/Kconfig
> index 39f7188..8d69ce3 100644
> --- a/drivers/staging/ipack/devices/Kconfig
> +++ b/drivers/staging/ipack/devices/Kconfig
> @@ -1,6 +1,7 @@
>  config SERIAL_IPOCTAL
>   tristate "IndustryPack IP-OCTAL uart support"
>   depends on IPACK_BUS
> + depends on BROKEN
>   help
> This driver supports the IPOCTAL serial port device for the 
> IndustryPack bus.
>   default n

Alan, care to send me a patch for this?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the tty tree

[Greg KH]

On Fri, Jul 20, 2012 at 01:28:40PM +1000, Stephen Rothwell wrote:
 Hi Greg,
 
 After merging the tty tree, today's linux-next build (x86_64 allmodconfig)
 failed like this:
 
 drivers/staging/ipack/devices/ipoctal.c: In function 'ipoctal_set_termios':
 drivers/staging/ipack/devices/ipoctal.c:614:22: error: invalid type argument 
 of '-' (have 'struct ktermios')
 drivers/staging/ipack/devices/ipoctal.c:640:15: error: invalid type argument 
 of '-' (have 'struct ktermios')
 drivers/staging/ipack/devices/ipoctal.c:654:14: error: invalid type argument 
 of '-' (have 'struct ktermios')
 drivers/staging/ipack/devices/ipoctal.c:691:2: error: incompatible type for 
 argument 1 of 'tty_termios_encode_baud_rate'
 include/linux/tty.h:449:13: note: expected 'struct ktermios *' but argument 
 is of type 'struct ktermios'
 drivers/staging/ipack/devices/ipoctal.c:694:22: error: invalid type argument 
 of '-' (have 'struct ktermios')
 drivers/staging/ipack/devices/ipoctal.c:735:3: error: incompatible type for 
 argument 1 of 'tty_termios_encode_baud_rate'
 include/linux/tty.h:449:13: note: expected 'struct ktermios *' but argument 
 is of type 'struct ktermios'
 
 Presumably caused by commit adc8d746caa6 (tty: move the termios object
 into the tty).
 
 Under previous instructions about staging drivers, I have added the
 following patch for today:
 
 From c4bc70a8fc9cc687690aaf51865561ffcd6190f9 Mon Sep 17 00:00:00 2001
 From: Stephen Rothwell s...@canb.auug.org.au
 Date: Fri, 20 Jul 2012 13:25:12 +1000
 Subject: [PATCH] disable SERIAL_IPOCTAL broken by tty updates
 
 Signed-off-by: Stephen Rothwell s...@canb.auug.org.au
 ---
  drivers/staging/ipack/devices/Kconfig |1 +
  1 file changed, 1 insertion(+)
 
 diff --git a/drivers/staging/ipack/devices/Kconfig 
 b/drivers/staging/ipack/devices/Kconfig
 index 39f7188..8d69ce3 100644
 --- a/drivers/staging/ipack/devices/Kconfig
 +++ b/drivers/staging/ipack/devices/Kconfig
 @@ -1,6 +1,7 @@
  config SERIAL_IPOCTAL
   tristate IndustryPack IP-OCTAL uart support
   depends on IPACK_BUS
 + depends on BROKEN
   help
 This driver supports the IPOCTAL serial port device for the 
 IndustryPack bus.
   default n

Alan, care to send me a patch for this?

thanks,

greg k-h
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the tty tree

[Stephen Rothwell]

Hi Greg, Alan,

On Fri, 20 Jul 2012 13:28:40 +1000 Stephen Rothwell s...@canb.auug.org.au 
wrote:

 After merging the tty tree, today's linux-next build (x86_64 allmodconfig)
 failed like this:
 
 drivers/staging/ipack/devices/ipoctal.c: In function 'ipoctal_set_termios':
 drivers/staging/ipack/devices/ipoctal.c:614:22: error: invalid type argument 
 of '-' (have 'struct ktermios')
 drivers/staging/ipack/devices/ipoctal.c:640:15: error: invalid type argument 
 of '-' (have 'struct ktermios')
 drivers/staging/ipack/devices/ipoctal.c:654:14: error: invalid type argument 
 of '-' (have 'struct ktermios')
 drivers/staging/ipack/devices/ipoctal.c:691:2: error: incompatible type for 
 argument 1 of 'tty_termios_encode_baud_rate'
 include/linux/tty.h:449:13: note: expected 'struct ktermios *' but argument 
 is of type 'struct ktermios'
 drivers/staging/ipack/devices/ipoctal.c:694:22: error: invalid type argument 
 of '-' (have 'struct ktermios')
 drivers/staging/ipack/devices/ipoctal.c:735:3: error: incompatible type for 
 argument 1 of 'tty_termios_encode_baud_rate'
 include/linux/tty.h:449:13: note: expected 'struct ktermios *' but argument 
 is of type 'struct ktermios'
 
 Presumably caused by commit adc8d746caa6 (tty: move the termios object
 into the tty).
 
 Under previous instructions about staging drivers, I have added the
 following patch for today:
 
 From c4bc70a8fc9cc687690aaf51865561ffcd6190f9 Mon Sep 17 00:00:00 2001
 From: Stephen Rothwell s...@canb.auug.org.au
 Date: Fri, 20 Jul 2012 13:25:12 +1000
 Subject: [PATCH] disable SERIAL_IPOCTAL broken by tty updates
 
 Signed-off-by: Stephen Rothwell s...@canb.auug.org.au
 ---
  drivers/staging/ipack/devices/Kconfig |1 +
  1 file changed, 1 insertion(+)
 
 diff --git a/drivers/staging/ipack/devices/Kconfig 
 b/drivers/staging/ipack/devices/Kconfig
 index 39f7188..8d69ce3 100644
 --- a/drivers/staging/ipack/devices/Kconfig
 +++ b/drivers/staging/ipack/devices/Kconfig
 @@ -1,6 +1,7 @@
  config SERIAL_IPOCTAL
   tristate IndustryPack IP-OCTAL uart support
   depends on IPACK_BUS
 + depends on BROKEN
   help
 This driver supports the IPOCTAL serial port device for the 
 IndustryPack bus.
   default n
 -- 
 1.7.10.280.gaa39

Ping?
-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgpdxJkFNRecm.pgp
Description: PGP signature

Re: linux-next: build failure after merge of the tty tree

[Stephen Rothwell]

Hi Greg, Alan,

[Sorry, Alan, I forgot to cc you the first time around.]

On Fri, 20 Jul 2012 13:33:49 +1000 Stephen Rothwell s...@canb.auug.org.au 
wrote:

 After merging the tty tree, today's linux-next build (x86_64 allmodconfig)
 failed like this:
 
 drivers/staging/serqt_usb2/serqt_usb2.c: In function 'qt_set_termios':
 drivers/staging/serqt_usb2/serqt_usb2.c:1198:29: error: incompatible types 
 when initializing type 'struct ktermios *' using type 'struct ktermios'
 drivers/staging/serqt_usb2/serqt_usb2.c:1304:14: error: invalid type argument 
 of '-' (have 'struct ktermios')
 
 Presumably caused by commit adc8d746caa6 (tty: move the termios object
 into the tty).
 
 Under previous instructions about staging drivers, I have added the
 following patch for today:
 
 From: Stephen Rothwell s...@canb.auug.org.au
 Date: Fri, 20 Jul 2012 13:31:39 +1000
 Subject: [PATCH] disable USB_SERIAL_QUATECH2 broken by tty update
 
 Signed-off-by: Stephen Rothwell s...@canb.auug.org.au
 ---
  drivers/staging/serqt_usb2/Kconfig |1 +
  1 file changed, 1 insertion(+)
 
 diff --git a/drivers/staging/serqt_usb2/Kconfig 
 b/drivers/staging/serqt_usb2/Kconfig
 index f4fed40..dc624a4 100644
 --- a/drivers/staging/serqt_usb2/Kconfig
 +++ b/drivers/staging/serqt_usb2/Kconfig
 @@ -1,6 +1,7 @@
  config USB_SERIAL_QUATECH2
   tristate USB Quatech ESU-100 8 Port Serial Driver
   depends on USB_SERIAL
 + depends on BROKEN
   help
 Say Y here if you want to use the Quatech ESU-100 8 port usb to
 serial adapter.
 -- 
 1.7.10.280.gaa39

Ping?
-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgpjwMuwUshdw.pgp
Description: PGP signature

Re: linux-next: build failure after merge of the tty tree

[Alan Cox]

On Thu, 26 Jul 2012 08:51:27 +1000
Stephen Rothwell s...@canb.auug.org.au wrote:

 Hi Greg, Alan,
 
 [Sorry, Alan, I forgot to cc you the first time around.]
 
 On Fri, 20 Jul 2012 13:33:49 +1000 Stephen Rothwell
 s...@canb.auug.org.au wrote:
 
  After merging the tty tree, today's linux-next build (x86_64
  allmodconfig) failed like this:
  
  drivers/staging/serqt_usb2/serqt_usb2.c: In function
  'qt_set_termios': drivers/staging/serqt_usb2/serqt_usb2.c:1198:29:
  error: incompatible types when initializing type 'struct ktermios
  *' using type 'struct ktermios'
  drivers/staging/serqt_usb2/serqt_usb2.c:1304:14: error: invalid
  type argument of '-' (have 'struct ktermios')
  

I sent you a fix for that one (I've not done the ipoctal one yet)

Alan
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the tty tree

[Geert Uytterhoeven]

Hi Alan,

On Fri, Jul 20, 2012 at 10:55 PM, Alan Cox  wrote:
>> Today's build failed because there's a new user in the MIPS tree:
>> arch/mips/cavium-octeon/serial.c
>>
>> http://kisskb.ellerman.id.au/kisskb/buildresult/6739341/
>
> The version in the tree I have registers a platform device rather than
> calling into 8250 directly. That appears to be rather better mannered
> than whatever you are building.
>
> If someone has moved from the platform device could they kindly explain
> *why* ?

commit 7c507e6fe36d8e8f67a06d1f81ddde4d8ecf739f ("MIPS: Octeon: Use
device tree to register serial ports.") in linux-next.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the tty tree

[Alan Cox]

> Today's build failed because there's a new user in the MIPS tree:
> arch/mips/cavium-octeon/serial.c
> 
> http://kisskb.ellerman.id.au/kisskb/buildresult/6739341/

The version in the tree I have registers a platform device rather than
calling into 8250 directly. That appears to be rather better mannered
than whatever you are building.

If someone has moved from the platform device could they kindly explain
*why* ?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the tty tree

[Geert Uytterhoeven]

Hi Alan, David,

On Fri, Jul 13, 2012 at 1:10 PM, Alan Cox  wrote:
> On Fri, 13 Jul 2012 14:13:45 +1000
> Stephen Rothwell  wrote:
>> After merging the tty tree, today's linux-next build (x86_64 allmodconfig)
>> failed like this:
>>
>> drivers/char/mwave/mwavedd.c: In function 'register_serial_portandirq':
>> drivers/char/mwave/mwavedd.c:472:2: error: implicit declaration of function 
>> 'serial8250_register_port' [-Werror=implicit-function-declaration]
>> cc1: some warnings being treated as errors
>> drivers/misc/ibmasm/uart.c: In function 'ibmasm_register_uart':
>> drivers/misc/ibmasm/uart.c:57:2: error: implicit declaration of function 
>> 'serial8250_register_port' [-Werror=implicit-function-declaration]
>> cc1: some warnings being treated as errors
>>
>> Caused by commit 2655a2c76f80 ("8250: use the 8250 register interface not
>> the legacy one").  Grep is your friend.
>
> My fault on that one not GregKH's. I'll wrap that into the updated patch
> series. I thought I had them all but I forgot to grep off in drivers/misc.

Today's build failed because there's a new user in the MIPS tree:
arch/mips/cavium-octeon/serial.c

http://kisskb.ellerman.id.au/kisskb/buildresult/6739341/

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the tty tree

[Geert Uytterhoeven]

Hi Alan, David,

On Fri, Jul 13, 2012 at 1:10 PM, Alan Cox a...@lxorguk.ukuu.org.uk wrote:
 On Fri, 13 Jul 2012 14:13:45 +1000
 Stephen Rothwell s...@canb.auug.org.au wrote:
 After merging the tty tree, today's linux-next build (x86_64 allmodconfig)
 failed like this:

 drivers/char/mwave/mwavedd.c: In function 'register_serial_portandirq':
 drivers/char/mwave/mwavedd.c:472:2: error: implicit declaration of function 
 'serial8250_register_port' [-Werror=implicit-function-declaration]
 cc1: some warnings being treated as errors
 drivers/misc/ibmasm/uart.c: In function 'ibmasm_register_uart':
 drivers/misc/ibmasm/uart.c:57:2: error: implicit declaration of function 
 'serial8250_register_port' [-Werror=implicit-function-declaration]
 cc1: some warnings being treated as errors

 Caused by commit 2655a2c76f80 (8250: use the 8250 register interface not
 the legacy one).  Grep is your friend.

 My fault on that one not GregKH's. I'll wrap that into the updated patch
 series. I thought I had them all but I forgot to grep off in drivers/misc.

Today's build failed because there's a new user in the MIPS tree:
arch/mips/cavium-octeon/serial.c

http://kisskb.ellerman.id.au/kisskb/buildresult/6739341/

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say programmer or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the tty tree

[Alan Cox]

 Today's build failed because there's a new user in the MIPS tree:
 arch/mips/cavium-octeon/serial.c
 
 http://kisskb.ellerman.id.au/kisskb/buildresult/6739341/

The version in the tree I have registers a platform device rather than
calling into 8250 directly. That appears to be rather better mannered
than whatever you are building.

If someone has moved from the platform device could they kindly explain
*why* ?
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/