Re: linux-next: build warning after merge of the pidfd tree

2021-01-26 Thread Christoph Hellwig
On Wed, Jan 27, 2021 at 09:41:01AM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the pidfd tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
> 
> fs/xfs/xfs_ioctl32.c: In function 'xfs_file_compat_ioctl':
> fs/xfs/xfs_ioctl32.c:441:20: warning: unused variable 'mp' [-Wunused-variable]
>   441 |  struct xfs_mount *mp = ip->i_mount;
>   |^~

So this is only used in an x86-specific section of the function.
Let me think what we can do about this.


Re: linux-next: build warning after merge of the pidfd tree

2020-07-10 Thread Christian Brauner
On Fri, Jul 10, 2020 at 04:32:04PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the pidfd tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
> 
> fs/nsfs.c: In function 'ns_ioctl':
> fs/nsfs.c:195:14: warning: unused variable 'pid_struct' [-Wunused-variable]
>   195 |  struct pid *pid_struct;
>   |  ^~
> fs/nsfs.c:194:22: warning: unused variable 'child_reaper' [-Wunused-variable]
>   194 |  struct task_struct *child_reaper;
>   |  ^~~~
> 
> Introduced by commit
> 
>   a57927d2dce2 ("nsfs: add NS_GET_INIT_PID ioctl")

Hm, I wonder how that didn't get caught during a git rebase -x "make" v5.8-rc4 
build...
Sorry about that!

Thanks!
Christian