RE: net/usb/ax88179_178a driver broken in linux-3.12

2013-11-19 Thread David Laight
> From: Eric Dumazet [mailto:eric.duma...@gmail.com] > On Tue, 2013-11-19 at 14:43 +, David Laight wrote: > > > It isn't directly a TSO problem. > > There has always been a bug in the xhci driver for fragmented buffers. > > TSO just means it is given a lot of fragmented buffers. > > > > As

RE: net/usb/ax88179_178a driver broken in linux-3.12

2013-11-19 Thread Eric Dumazet
On Tue, 2013-11-19 at 14:43 +, David Laight wrote: > It isn't directly a TSO problem. > There has always been a bug in the xhci driver for fragmented buffers. > TSO just means it is given a lot of fragmented buffers. > > As well as user-supplied fragmented buffers, the bug affects > internal

RE: net/usb/ax88179_178a driver broken in linux-3.12

2013-11-19 Thread David Laight
> From: Eric Dumazet [mailto:eric.duma...@gmail.com] > On Tue, 2013-11-19 at 09:02 -0500, Mark Lord wrote: > > On 13-11-19 05:04 AM, David Laight wrote: > > >> From: Mark Lord > > .. > > >> except the ax88179_178a driver still does not work in linux-3.12, > > >> whereas it works fine in all

Re: net/usb/ax88179_178a driver broken in linux-3.12

2013-11-19 Thread Mark Lord
On 13-11-19 09:15 AM, Eric Dumazet wrote: > On Tue, 2013-11-19 at 09:02 -0500, Mark Lord wrote: >> On 13-11-19 05:04 AM, David Laight wrote: From: Mark Lord >> .. except the ax88179_178a driver still does not work in linux-3.12, whereas it works fine in all earlier kernels.

Re: net/usb/ax88179_178a driver broken in linux-3.12

2013-11-19 Thread Mark Lord
On 13-11-19 05:04 AM, David Laight wrote: >> From: Mark Lord .. >> except the ax88179_178a driver still does not work in linux-3.12, >> whereas it works fine in all earlier kernels. >> >> That's a regression. >> And a simple revert (earlier in this thread) fixes it. >> So.. let's revert it for

Re: net/usb/ax88179_178a driver broken in linux-3.12

2013-11-19 Thread Eric Dumazet
On Tue, 2013-11-19 at 09:02 -0500, Mark Lord wrote: > On 13-11-19 05:04 AM, David Laight wrote: > >> From: Mark Lord > .. > >> except the ax88179_178a driver still does not work in linux-3.12, > >> whereas it works fine in all earlier kernels. > >> > >> That's a regression. > >> And a simple

Re: net/usb/ax88179_178a driver broken in linux-3.12

2013-11-19 Thread Eric Dumazet
On Tue, 2013-11-19 at 09:02 -0500, Mark Lord wrote: On 13-11-19 05:04 AM, David Laight wrote: From: Mark Lord .. except the ax88179_178a driver still does not work in linux-3.12, whereas it works fine in all earlier kernels. That's a regression. And a simple revert (earlier in this

Re: net/usb/ax88179_178a driver broken in linux-3.12

2013-11-19 Thread Mark Lord
On 13-11-19 05:04 AM, David Laight wrote: From: Mark Lord .. except the ax88179_178a driver still does not work in linux-3.12, whereas it works fine in all earlier kernels. That's a regression. And a simple revert (earlier in this thread) fixes it. So.. let's revert it for now, until a

Re: net/usb/ax88179_178a driver broken in linux-3.12

2013-11-19 Thread Mark Lord
On 13-11-19 09:15 AM, Eric Dumazet wrote: On Tue, 2013-11-19 at 09:02 -0500, Mark Lord wrote: On 13-11-19 05:04 AM, David Laight wrote: From: Mark Lord .. except the ax88179_178a driver still does not work in linux-3.12, whereas it works fine in all earlier kernels. That's a regression.

RE: net/usb/ax88179_178a driver broken in linux-3.12

2013-11-19 Thread David Laight
From: Eric Dumazet [mailto:eric.duma...@gmail.com] On Tue, 2013-11-19 at 09:02 -0500, Mark Lord wrote: On 13-11-19 05:04 AM, David Laight wrote: From: Mark Lord .. except the ax88179_178a driver still does not work in linux-3.12, whereas it works fine in all earlier kernels. I've

RE: net/usb/ax88179_178a driver broken in linux-3.12

2013-11-19 Thread Eric Dumazet
On Tue, 2013-11-19 at 14:43 +, David Laight wrote: It isn't directly a TSO problem. There has always been a bug in the xhci driver for fragmented buffers. TSO just means it is given a lot of fragmented buffers. As well as user-supplied fragmented buffers, the bug affects internal

RE: net/usb/ax88179_178a driver broken in linux-3.12

2013-11-19 Thread David Laight
From: Eric Dumazet [mailto:eric.duma...@gmail.com] On Tue, 2013-11-19 at 14:43 +, David Laight wrote: It isn't directly a TSO problem. There has always been a bug in the xhci driver for fragmented buffers. TSO just means it is given a lot of fragmented buffers. As well as