Re: new patchset to eliminate DM's use of BIOSET_NEED_RESCUER

On Tue, Nov 21 2017 at 11:28pm -0500, Mike Snitzer wrote: > > I'll work through your patches tomorrow. Please see the top 3 patches on this branch: https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git/log/?h=dm-4.16 This rebased dm-4.16 branch seems

Re: new patchset to eliminate DM's use of BIOSET_NEED_RESCUER

On Tue, Nov 21 2017 at 11:28pm -0500, Mike Snitzer wrote: > > I'll work through your patches tomorrow. Please see the top 3 patches on this branch: https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git/log/?h=dm-4.16 This rebased dm-4.16 branch seems to be working well so

Re: new patchset to eliminate DM's use of BIOSET_NEED_RESCUER

On Wed, Nov 22 2017 at 1:24pm -0500, Mikulas Patocka wrote: > Another problem is this: > > struct bio *b = bio_clone_bioset(bio, GFP_NOIO, md->queue->bio_split); > bio_advance(b, (bio_sectors(b) - ci.sector_count) << 9); > bio_chain(b, bio); > > What if it blocks because

Re: new patchset to eliminate DM's use of BIOSET_NEED_RESCUER

On Wed, Nov 22 2017 at 1:24pm -0500, Mikulas Patocka wrote: > Another problem is this: > > struct bio *b = bio_clone_bioset(bio, GFP_NOIO, md->queue->bio_split); > bio_advance(b, (bio_sectors(b) - ci.sector_count) << 9); > bio_chain(b, bio); > > What if it blocks because the bioset is

Re: new patchset to eliminate DM's use of BIOSET_NEED_RESCUER

On Tue, Nov 21 2017 at 11:00pm -0500, NeilBrown wrote: > On Tue, Nov 21 2017, Mikulas Patocka wrote: > > > On Tue, 21 Nov 2017, Mike Snitzer wrote: > > > >> On Tue, Nov 21 2017 at 4:23pm -0500, > >> Mikulas Patocka wrote: > >> > >> > This is not correct:

Re: new patchset to eliminate DM's use of BIOSET_NEED_RESCUER

On Tue, Nov 21 2017 at 11:00pm -0500, NeilBrown wrote: > On Tue, Nov 21 2017, Mikulas Patocka wrote: > > > On Tue, 21 Nov 2017, Mike Snitzer wrote: > > > >> On Tue, Nov 21 2017 at 4:23pm -0500, > >> Mikulas Patocka wrote: > >> > >> > This is not correct: > >> > > >> >2206 static void

Re: new patchset to eliminate DM's use of BIOSET_NEED_RESCUER

On Tue, Nov 21 2017 at 8:21pm -0500, Mikulas Patocka wrote: > > > On Tue, 21 Nov 2017, Mike Snitzer wrote: > > > On Tue, Nov 21 2017 at 4:23pm -0500, > > Mikulas Patocka wrote: > > > > > This is not correct: > > > > > >2206 static void

Re: new patchset to eliminate DM's use of BIOSET_NEED_RESCUER

On Tue, Nov 21 2017 at 8:21pm -0500, Mikulas Patocka wrote: > > > On Tue, 21 Nov 2017, Mike Snitzer wrote: > > > On Tue, Nov 21 2017 at 4:23pm -0500, > > Mikulas Patocka wrote: > > > > > This is not correct: > > > > > >2206 static void dm_wq_work(struct work_struct *work) > > >

Re: new patchset to eliminate DM's use of BIOSET_NEED_RESCUER

On Tue, 21 Nov 2017, Mike Snitzer wrote: > On Tue, Nov 21 2017 at 4:23pm -0500, > Mikulas Patocka wrote: > > > This is not correct: > > > >2206 static void dm_wq_work(struct work_struct *work) > >2207 { > >2208 struct mapped_device *md =

Re: new patchset to eliminate DM's use of BIOSET_NEED_RESCUER

On Tue, 21 Nov 2017, Mike Snitzer wrote: > On Tue, Nov 21 2017 at 4:23pm -0500, > Mikulas Patocka wrote: > > > This is not correct: > > > >2206 static void dm_wq_work(struct work_struct *work) > >2207 { > >2208 struct mapped_device *md = container_of(work, struct > >

Re: new patchset to eliminate DM's use of BIOSET_NEED_RESCUER

On Tue, Nov 21 2017 at 4:23pm -0500, Mikulas Patocka wrote: > > > On Tue, 21 Nov 2017, Mike Snitzer wrote: > > > On Tue, Nov 21 2017 at 7:43am -0500, > > Mike Snitzer wrote: > > > > > Decided it a better use of my time to review and then hopefully

Re: new patchset to eliminate DM's use of BIOSET_NEED_RESCUER

On Tue, Nov 21 2017 at 4:23pm -0500, Mikulas Patocka wrote: > > > On Tue, 21 Nov 2017, Mike Snitzer wrote: > > > On Tue, Nov 21 2017 at 7:43am -0500, > > Mike Snitzer wrote: > > > > > Decided it a better use of my time to review and then hopefully use the > > > block-core's bio splitting