Re: powerpc/nvram: Fix an incorrect partition merge

2016-09-20 Thread Michael Ellerman
On Thu, 2015-10-12 at 07:30:02 UTC, xinhui wrote: > From: Pan Xinhui > > When we merge two contiguous partitions whose signatures are marked > NVRAM_SIG_FREE, We need update prev's length and checksum, then write it > to nvram, not cur's. So lets fix this mistake

Re: powerpc/nvram: Fix an incorrect partition merge

2016-09-20 Thread Michael Ellerman
On Thu, 2015-10-12 at 07:30:02 UTC, xinhui wrote: > From: Pan Xinhui > > When we merge two contiguous partitions whose signatures are marked > NVRAM_SIG_FREE, We need update prev's length and checksum, then write it > to nvram, not cur's. So lets fix this mistake now. > > Also use memset

Re: powerpc/nvram: Fix an incorrect partition merge

2016-06-13 Thread xinhui
On 2016年06月07日 19:39, Michael Ellerman wrote: On Mon, 2016-06-06 at 13:31 +0800, xinhui wrote: On 2016年06月03日 19:47, Michael Ellerman wrote: On Thu, 2015-10-12 at 07:30:02 UTC, xinhui wrote: From: Pan Xinhui When we merge two contiguous partitions whose

Re: powerpc/nvram: Fix an incorrect partition merge

2016-06-13 Thread xinhui
On 2016年06月07日 19:39, Michael Ellerman wrote: On Mon, 2016-06-06 at 13:31 +0800, xinhui wrote: On 2016年06月03日 19:47, Michael Ellerman wrote: On Thu, 2015-10-12 at 07:30:02 UTC, xinhui wrote: From: Pan Xinhui When we merge two contiguous partitions whose signatures are marked

Re: powerpc/nvram: Fix an incorrect partition merge

2016-06-07 Thread Michael Ellerman
On Mon, 2016-06-06 at 13:31 +0800, xinhui wrote: > On 2016年06月03日 19:47, Michael Ellerman wrote: > > On Thu, 2015-10-12 at 07:30:02 UTC, xinhui wrote: > > > From: Pan Xinhui > > > > > > When we merge two contiguous partitions whose signatures are marked > > >

Re: powerpc/nvram: Fix an incorrect partition merge

2016-06-07 Thread Michael Ellerman
On Mon, 2016-06-06 at 13:31 +0800, xinhui wrote: > On 2016年06月03日 19:47, Michael Ellerman wrote: > > On Thu, 2015-10-12 at 07:30:02 UTC, xinhui wrote: > > > From: Pan Xinhui > > > > > > When we merge two contiguous partitions whose signatures are marked > > > NVRAM_SIG_FREE, We need update

Re: powerpc/nvram: Fix an incorrect partition merge

2016-06-06 Thread Stewart Smith
xinhui writes: >> Has it always been broken? >> > > no. after nvram partition corruption hit, all nvram partitions will be > erased and re-alloc after the second machine reboot. > I don't know who does it but i guess it is the firmware. :) It is. PAPR says we

Re: powerpc/nvram: Fix an incorrect partition merge

2016-06-06 Thread Stewart Smith
xinhui writes: >> Has it always been broken? >> > > no. after nvram partition corruption hit, all nvram partitions will be > erased and re-alloc after the second machine reboot. > I don't know who does it but i guess it is the firmware. :) It is. PAPR says we format NVRAM when it's corrupted.

Re: powerpc/nvram: Fix an incorrect partition merge

2016-06-05 Thread xinhui
On 2016年06月03日 19:47, Michael Ellerman wrote: On Thu, 2015-10-12 at 07:30:02 UTC, xinhui wrote: From: Pan Xinhui When we merge two contiguous partitions whose signatures are marked NVRAM_SIG_FREE, We need update prev's length and checksum, then write it to

Re: powerpc/nvram: Fix an incorrect partition merge

2016-06-05 Thread xinhui
On 2016年06月03日 19:47, Michael Ellerman wrote: On Thu, 2015-10-12 at 07:30:02 UTC, xinhui wrote: From: Pan Xinhui When we merge two contiguous partitions whose signatures are marked NVRAM_SIG_FREE, We need update prev's length and checksum, then write it to nvram, not cur's. So lets fix this

Re: powerpc/nvram: Fix an incorrect partition merge

2016-06-03 Thread Michael Ellerman
On Thu, 2015-10-12 at 07:30:02 UTC, xinhui wrote: > From: Pan Xinhui > > When we merge two contiguous partitions whose signatures are marked > NVRAM_SIG_FREE, We need update prev's length and checksum, then write it > to nvram, not cur's. So lets fix this mistake

Re: powerpc/nvram: Fix an incorrect partition merge

2016-06-03 Thread Michael Ellerman
On Thu, 2015-10-12 at 07:30:02 UTC, xinhui wrote: > From: Pan Xinhui > > When we merge two contiguous partitions whose signatures are marked > NVRAM_SIG_FREE, We need update prev's length and checksum, then write it > to nvram, not cur's. So lets fix this mistake now. > > Also use memset