Re: recent nfs change causes autofs regression

2007-09-05 Thread Ian Kent
On Wed, 2007-09-05 at 16:50 +0100, Trond Myklebust wrote: > On Wed, 2007-09-05 at 16:37 +0100, David Howells wrote: > > Ian Kent <[EMAIL PROTECTED]> wrote: > > > > > But what about mounting with different protocol, tcp vs udp for example. > > > > I was referring specifically to the R/O / R/W

Re: recent nfs change causes autofs regression

2007-09-05 Thread Trond Myklebust
On Wed, 2007-09-05 at 20:44 +0800, Ian Kent wrote: > On Tue, 2007-09-04 at 08:54 +0100, David Howells wrote: > > Bill Davidsen <[EMAIL PROTECTED]> wrote: > > > > > mount /base on point1 - rw[ hopefully really r/w ] > > > mount /base on point2 - ro[ hopefully r/o ] > > > > I think

Re: recent nfs change causes autofs regression

2007-09-05 Thread Trond Myklebust
On Wed, 2007-09-05 at 16:37 +0100, David Howells wrote: > Ian Kent <[EMAIL PROTECTED]> wrote: > > > But what about mounting with different protocol, tcp vs udp for example. > > I was referring specifically to the R/O / R/W variants of the same mount. Any > flag variation that varies the way the

Re: recent nfs change causes autofs regression

2007-09-05 Thread David Howells
Ian Kent <[EMAIL PROTECTED]> wrote: > But what about mounting with different protocol, tcp vs udp for example. I was referring specifically to the R/O / R/W variants of the same mount. Any flag variation that varies the way the NFS client talks to the NFS server must either result in a new

Re: recent nfs change causes autofs regression

2007-09-05 Thread David Howells
Bill Davidsen <[EMAIL PROTECTED]> wrote: > I think Al had a good idea there, that is nice and clean. What about bind > mounts, will that just fall out? I don't see that it should be a problem since the vfsmount is copied. David - To unsubscribe from this list: send the line "unsubscribe

Re: recent nfs change causes autofs regression

2007-09-05 Thread Ian Kent
On Tue, 2007-09-04 at 08:54 +0100, David Howells wrote: > Bill Davidsen <[EMAIL PROTECTED]> wrote: > > > mount /base on point1 - rw [ hopefully really r/w ] > > mount /base on point2 - ro [ hopefully r/o ] > > I think Al Viro probably has the right idea as to how to fix this: Move the > R/O

Re: recent nfs change causes autofs regression

2007-09-05 Thread Bill Davidsen
David Howells wrote: Bill Davidsen <[EMAIL PROTECTED]> wrote: mount /base on point1 - rw [ hopefully really r/w ] mount /base on point2 - ro [ hopefully r/o ] I think Al Viro probably has the right idea as to how to fix this: Move the R/O R/W flag into vfsmount and count

Re: recent nfs change causes autofs regression

2007-09-05 Thread Bill Davidsen
David Howells wrote: Bill Davidsen [EMAIL PROTECTED] wrote: mount /base on point1 - rw [ hopefully really r/w ] mount /base on point2 - ro [ hopefully r/o ] I think Al Viro probably has the right idea as to how to fix this: Move the R/O R/W flag into vfsmount and count the

Re: recent nfs change causes autofs regression

2007-09-05 Thread Ian Kent
On Tue, 2007-09-04 at 08:54 +0100, David Howells wrote: Bill Davidsen [EMAIL PROTECTED] wrote: mount /base on point1 - rw [ hopefully really r/w ] mount /base on point2 - ro [ hopefully r/o ] I think Al Viro probably has the right idea as to how to fix this: Move the R/O R/W flag into

Re: recent nfs change causes autofs regression

2007-09-05 Thread David Howells
Bill Davidsen [EMAIL PROTECTED] wrote: I think Al had a good idea there, that is nice and clean. What about bind mounts, will that just fall out? I don't see that it should be a problem since the vfsmount is copied. David - To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: recent nfs change causes autofs regression

2007-09-05 Thread David Howells
Ian Kent [EMAIL PROTECTED] wrote: But what about mounting with different protocol, tcp vs udp for example. I was referring specifically to the R/O / R/W variants of the same mount. Any flag variation that varies the way the NFS client talks to the NFS server must either result in a new

Re: recent nfs change causes autofs regression

2007-09-05 Thread Trond Myklebust
On Wed, 2007-09-05 at 16:37 +0100, David Howells wrote: Ian Kent [EMAIL PROTECTED] wrote: But what about mounting with different protocol, tcp vs udp for example. I was referring specifically to the R/O / R/W variants of the same mount. Any flag variation that varies the way the NFS

Re: recent nfs change causes autofs regression

2007-09-05 Thread Trond Myklebust
On Wed, 2007-09-05 at 20:44 +0800, Ian Kent wrote: On Tue, 2007-09-04 at 08:54 +0100, David Howells wrote: Bill Davidsen [EMAIL PROTECTED] wrote: mount /base on point1 - rw[ hopefully really r/w ] mount /base on point2 - ro[ hopefully r/o ] I think Al Viro probably

Re: recent nfs change causes autofs regression

2007-09-04 Thread Linus Torvalds
On Tue, 4 Sep 2007, David Howells wrote: > > That helps one case, yes, but what about a superset? What about two sets that > might intersect but for which you don't have the common root to hand? Sure. In which case bind mounts don't work. Fair enough. > The case I came up with was this: > >

Re: recent nfs change causes autofs regression

2007-09-04 Thread David Howells
Linus Torvalds <[EMAIL PROTECTED]> wrote: > In other words, let's assume that the user has /some/nfs/mount mounted > over NFS, and wants to re-mount it (or even just a subset of it) somewhere > else, the sane thing to do is not to mount it again, but to just do That helps one case, yes, but

Re: recent nfs change causes autofs regression

2007-09-04 Thread David Howells
Linus Torvalds <[EMAIL PROTECTED]> wrote: > In other words, let's assume that the user has /some/nfs/mount mounted > over NFS, and wants to re-mount it (or even just a subset of it) somewhere > else, the sane thing to do is not to mount it again, but to just do What about a superset? What

Re: recent nfs change causes autofs regression

2007-09-04 Thread David Howells
Bill Davidsen <[EMAIL PROTECTED]> wrote: > mount /base on point1 - rw[ hopefully really r/w ] > mount /base on point2 - ro[ hopefully r/o ] I think Al Viro probably has the right idea as to how to fix this: Move the R/O R/W flag into vfsmount and count the number of R/W vfsmounts in the

Re: recent nfs change causes autofs regression

2007-09-04 Thread David Howells
Trond Myklebust <[EMAIL PROTECTED]> wrote: > - the NFSv4 delegation model breaks: the client will be using > OPEN when it could use cached opens. More importantly, when > performing an operation that requires it to return the > delegation on the aliased file, it

Re: recent nfs change causes autofs regression

2007-09-04 Thread David Howells
Trond Myklebust [EMAIL PROTECTED] wrote: - the NFSv4 delegation model breaks: the client will be using OPEN when it could use cached opens. More importantly, when performing an operation that requires it to return the delegation on the aliased file, it won't

Re: recent nfs change causes autofs regression

2007-09-04 Thread David Howells
Bill Davidsen [EMAIL PROTECTED] wrote: mount /base on point1 - rw[ hopefully really r/w ] mount /base on point2 - ro[ hopefully r/o ] I think Al Viro probably has the right idea as to how to fix this: Move the R/O R/W flag into vfsmount and count the number of R/W vfsmounts in the

Re: recent nfs change causes autofs regression

2007-09-04 Thread David Howells
Linus Torvalds [EMAIL PROTECTED] wrote: In other words, let's assume that the user has /some/nfs/mount mounted over NFS, and wants to re-mount it (or even just a subset of it) somewhere else, the sane thing to do is not to mount it again, but to just do What about a superset? What about

Re: recent nfs change causes autofs regression

2007-09-04 Thread David Howells
Linus Torvalds [EMAIL PROTECTED] wrote: In other words, let's assume that the user has /some/nfs/mount mounted over NFS, and wants to re-mount it (or even just a subset of it) somewhere else, the sane thing to do is not to mount it again, but to just do That helps one case, yes, but what

Re: recent nfs change causes autofs regression

2007-09-04 Thread Linus Torvalds
On Tue, 4 Sep 2007, David Howells wrote: That helps one case, yes, but what about a superset? What about two sets that might intersect but for which you don't have the common root to hand? Sure. In which case bind mounts don't work. Fair enough. The case I came up with was this:

Re: recent nfs change causes autofs regression

2007-09-03 Thread Martin Knoblauch
--- Jakob Oestergaard <[EMAIL PROTECTED]> wrote: > On Fri, Aug 31, 2007 at 09:43:29AM -0700, Linus Torvalds wrote: > ... > > This is *not* a security hole. In order to make it a security hole, > you > > need to be root in the first place. > > Non-root users can write to places where root might

Re: recent nfs change causes autofs regression

2007-09-03 Thread Jakob Oestergaard
On Fri, Aug 31, 2007 at 09:43:29AM -0700, Linus Torvalds wrote: ... > This is *not* a security hole. In order to make it a security hole, you > need to be root in the first place. Non-root users can write to places where root might believe they cannot write because he might be under the mistaken

Re: recent nfs change causes autofs regression

2007-09-03 Thread Jakob Oestergaard
On Fri, Aug 31, 2007 at 09:43:29AM -0700, Linus Torvalds wrote: ... This is *not* a security hole. In order to make it a security hole, you need to be root in the first place. Non-root users can write to places where root might believe they cannot write because he might be under the mistaken

Re: recent nfs change causes autofs regression

2007-09-03 Thread Martin Knoblauch
--- Jakob Oestergaard [EMAIL PROTECTED] wrote: On Fri, Aug 31, 2007 at 09:43:29AM -0700, Linus Torvalds wrote: ... This is *not* a security hole. In order to make it a security hole, you need to be root in the first place. Non-root users can write to places where root might believe

Re: recent nfs change causes autofs regression

2007-09-01 Thread Bill Davidsen
Trond Myklebust wrote: On Thu, 2007-08-30 at 20:49 -0700, Linus Torvalds wrote: Please send in a fix. If the fix involves making "nosharecache" the default, then that is better than making policy decisions like this in the kernel. The kernel should do what the user asks and not put in

Re: recent nfs change causes autofs regression

2007-09-01 Thread Bill Davidsen
Trond Myklebust wrote: On Thu, 2007-08-30 at 20:49 -0700, Linus Torvalds wrote: Please send in a fix. If the fix involves making nosharecache the default, then that is better than making policy decisions like this in the kernel. The kernel should do what the user asks and not put in

RE: recent nfs change causes autofs regression

2007-08-31 Thread Hua Zhong
> It's not about default (for which backward compatibility is most > important and this patch is perfectly fine), but user explicitly asks > for "sharecache". In this case if for any reason the cache cannot be > shared, I am not sure if he should get an error back. > > I for one agree with Ian

RE: recent nfs change causes autofs regression

2007-08-31 Thread Hua Zhong
> On Fri, 2007-08-31 at 11:47 -0700, Hua Zhong wrote: > > This patch fixes the problem for me, thanks. > > > > Is this patch changing the behavior of "sharecache" to > > "try-to-share-cache-if-possible", or adding a third behavior? If the > > user explicitly asks for "-o sharecache", does he get

RE: recent nfs change causes autofs regression

2007-08-31 Thread Trond Myklebust
On Fri, 2007-08-31 at 11:47 -0700, Hua Zhong wrote: > This patch fixes the problem for me, thanks. > > Is this patch changing the behavior of "sharecache" to > "try-to-share-cache-if-possible", or adding a third behavior? If the user > explicitly asks for "-o sharecache", does he get an error

Re: recent nfs change causes autofs regression

2007-08-31 Thread Trond Myklebust
On Fri, 2007-08-31 at 10:01 -0700, Linus Torvalds wrote: > > On Fri, 31 Aug 2007, Trond Myklebust wrote: > > > > The best I can do given the constraints appears to be to have the kernel > > first look for a superblock that matches both the fsid and the > > user-specified mount options, and then

RE: recent nfs change causes autofs regression

2007-08-31 Thread Hua Zhong
This patch fixes the problem for me, thanks. Is this patch changing the behavior of "sharecache" to "try-to-share-cache-if-possible", or adding a third behavior? If the user explicitly asks for "-o sharecache", does he get an error back if the mount options mismatch? > The best I can do given

Re: recent nfs change causes autofs regression

2007-08-31 Thread Linus Torvalds
On Fri, 31 Aug 2007, Trond Myklebust wrote: > > The best I can do given the constraints appears to be to have the kernel > first look for a superblock that matches both the fsid and the > user-specified mount options, and then spawn off a new superblock if > that search fails. I think this is

Re: recent nfs change causes autofs regression

2007-08-31 Thread Linus Torvalds
On Fri, 31 Aug 2007, Jakob Oestergaard wrote: > > > The fact that he may *also* have broken insane setups is totally > > irrelevant. Don't go off on some tangent that has nothing to do with the > > regression in question! > > It does not have "nothing" to do with the regression. > > Some

Re: recent nfs change causes autofs regression

2007-08-31 Thread Trond Myklebust
On Thu, 2007-08-30 at 20:49 -0700, Linus Torvalds wrote: > Please send in a fix. If the fix involves making "nosharecache" the > default, then that is better than making policy decisions like this in the > kernel. The kernel should do what the user asks and not put in unnecessary > roadblocks.

Re: recent nfs change causes autofs regression

2007-08-31 Thread Frank van Maarseveen
On Fri, Aug 31, 2007 at 09:50:12AM -0400, Trond Myklebust wrote: > On Fri, 2007-08-31 at 15:12 +0200, Frank van Maarseveen wrote: > > > IMHO I'd only consider returning EBUSY when trying to mount _exactly_ > > the same directory with different flags, not for arbitrary subtrees. The > > client

Re: recent nfs change causes autofs regression

2007-08-31 Thread Trond Myklebust
On Fri, 2007-08-31 at 15:12 +0200, Frank van Maarseveen wrote: > IMHO I'd only consider returning EBUSY when trying to mount _exactly_ > the same directory with different flags, not for arbitrary subtrees. The > client should preferably not be bothered with server side disk > partitioning (at

Re: recent nfs change causes autofs regression

2007-08-31 Thread Frank van Maarseveen
On Fri, Aug 31, 2007 at 08:11:38AM -0400, Trond Myklebust wrote: > On Fri, 2007-08-31 at 01:07 -0700, Linus Torvalds wrote: > > > > > If you want new behaviour, you add a new flag saying you want new > > behaviour. You don't just start behaving differently from what you've > > always done

Re: recent nfs change causes autofs regression

2007-08-31 Thread Trond Myklebust
On Fri, 2007-08-31 at 01:07 -0700, Linus Torvalds wrote: > > If you want new behaviour, you add a new flag saying you want new > behaviour. You don't just start behaving differently from what you've > always done before (and what *other* UNIXes do, for that matter). > > Besides, even *if* it

Re: recent nfs change causes autofs regression

2007-08-31 Thread Ian Kent
On Fri, 31 Aug 2007, Frank van Maarseveen wrote: > On Thu, Aug 30, 2007 at 02:07:43PM -0700, Hua Zhong wrote: > > I am re-sending this after help from Ian and git-bisect. To me it's a > > show-stopper: I cannot find an acceptable workaround that I can implement. > > > > The problem: upgrading to

Re: recent nfs change causes autofs regression

2007-08-31 Thread Martin Knoblauch
--- Ian Kent <[EMAIL PROTECTED]> wrote: > On Thu, 30 Aug 2007, Linus Torvalds wrote: > > > > > > On Fri, 31 Aug 2007, Trond Myklebust wrote: > > > > > > It did not. The previous behaviour was to always silently > override the > > > user mount options. > > > > ..so it still worked for any

Re: recent nfs change causes autofs regression

2007-08-31 Thread Jakob Oestergaard
On Fri, Aug 31, 2007 at 01:07:56AM -0700, Linus Torvalds wrote: ... > When we add NEW BEHAVIOUR, we don't add it to old interfaces when that > breaks old user mode! We add a new flag saying "I want the new behaviour". > > This is not rocket science, guys. This is very basic kernel behaviour. The

Re: recent nfs change causes autofs regression

2007-08-31 Thread Frank van Maarseveen
On Thu, Aug 30, 2007 at 02:07:43PM -0700, Hua Zhong wrote: > I am re-sending this after help from Ian and git-bisect. To me it's a > show-stopper: I cannot find an acceptable workaround that I can implement. > > The problem: upgrading to 2.6.23-rc4 from 2.6.22 causes several autofs > mounts to

Re: recent nfs change causes autofs regression

2007-08-31 Thread Frank van Maarseveen
On Fri, Aug 31, 2007 at 09:40:28AM +0200, Jakob Oestergaard wrote: > On Thu, Aug 30, 2007 at 10:16:37PM -0700, Linus Torvalds wrote: > > > ... > > > Why aren't we doing that for any other filesystem than NFS? > > > > How hard is it to acknowledge the following little word: > > > >

Re: recent nfs change causes autofs regression

2007-08-31 Thread Matthias Schniedermeyer
> > It's not very conservative to suddenly change default behavior and break > > autofs mounts. There is not even one kernel message that "_tells_ user why > > it thinks it's wrong". It just silently fails. > > No it doesn't. It reports an error code to the caller. If autofs is > failing

Re: recent nfs change causes autofs regression

2007-08-31 Thread Linus Torvalds
On Fri, 31 Aug 2007, Jakob Oestergaard wrote: > > Trond has a point Linus. I don't dispute that the new code does somethign good. But it changes existing behaviour. When we add NEW BEHAVIOUR, we don't add it to old interfaces when that breaks old user mode! We add a new flag saying "I want

Re: recent nfs change causes autofs regression

2007-08-31 Thread Jakob Oestergaard
On Thu, Aug 30, 2007 at 10:16:37PM -0700, Linus Torvalds wrote: > ... > > Why aren't we doing that for any other filesystem than NFS? > > How hard is it to acknowledge the following little word: > > "regression" > > It's simple. You broke things. You may want to fix them, but you need to

Re: recent nfs change causes autofs regression

2007-08-31 Thread Frank van Maarseveen
On Fri, Aug 31, 2007 at 09:50:12AM -0400, Trond Myklebust wrote: On Fri, 2007-08-31 at 15:12 +0200, Frank van Maarseveen wrote: IMHO I'd only consider returning EBUSY when trying to mount _exactly_ the same directory with different flags, not for arbitrary subtrees. The client should

Re: recent nfs change causes autofs regression

2007-08-31 Thread Trond Myklebust
On Thu, 2007-08-30 at 20:49 -0700, Linus Torvalds wrote: Please send in a fix. If the fix involves making nosharecache the default, then that is better than making policy decisions like this in the kernel. The kernel should do what the user asks and not put in unnecessary roadblocks. The

Re: recent nfs change causes autofs regression

2007-08-31 Thread Linus Torvalds
On Fri, 31 Aug 2007, Jakob Oestergaard wrote: The fact that he may *also* have broken insane setups is totally irrelevant. Don't go off on some tangent that has nothing to do with the regression in question! It does not have nothing to do with the regression. Some setups which

Re: recent nfs change causes autofs regression

2007-08-31 Thread Linus Torvalds
On Fri, 31 Aug 2007, Trond Myklebust wrote: The best I can do given the constraints appears to be to have the kernel first look for a superblock that matches both the fsid and the user-specified mount options, and then spawn off a new superblock if that search fails. I think this is

RE: recent nfs change causes autofs regression

2007-08-31 Thread Hua Zhong
This patch fixes the problem for me, thanks. Is this patch changing the behavior of sharecache to try-to-share-cache-if-possible, or adding a third behavior? If the user explicitly asks for -o sharecache, does he get an error back if the mount options mismatch? The best I can do given the

Re: recent nfs change causes autofs regression

2007-08-31 Thread Trond Myklebust
On Fri, 2007-08-31 at 10:01 -0700, Linus Torvalds wrote: On Fri, 31 Aug 2007, Trond Myklebust wrote: The best I can do given the constraints appears to be to have the kernel first look for a superblock that matches both the fsid and the user-specified mount options, and then spawn off a

RE: recent nfs change causes autofs regression

2007-08-31 Thread Trond Myklebust
On Fri, 2007-08-31 at 11:47 -0700, Hua Zhong wrote: This patch fixes the problem for me, thanks. Is this patch changing the behavior of sharecache to try-to-share-cache-if-possible, or adding a third behavior? If the user explicitly asks for -o sharecache, does he get an error back if the

RE: recent nfs change causes autofs regression

2007-08-31 Thread Hua Zhong
On Fri, 2007-08-31 at 11:47 -0700, Hua Zhong wrote: This patch fixes the problem for me, thanks. Is this patch changing the behavior of sharecache to try-to-share-cache-if-possible, or adding a third behavior? If the user explicitly asks for -o sharecache, does he get an error back if

RE: recent nfs change causes autofs regression

2007-08-31 Thread Hua Zhong
It's not about default (for which backward compatibility is most important and this patch is perfectly fine), but user explicitly asks for sharecache. In this case if for any reason the cache cannot be shared, I am not sure if he should get an error back. I for one agree with Ian and Linus

Re: recent nfs change causes autofs regression

2007-08-31 Thread Jakob Oestergaard
On Thu, Aug 30, 2007 at 10:16:37PM -0700, Linus Torvalds wrote: ... Why aren't we doing that for any other filesystem than NFS? How hard is it to acknowledge the following little word: regression It's simple. You broke things. You may want to fix them, but you need to fix them

Re: recent nfs change causes autofs regression

2007-08-31 Thread Linus Torvalds
On Fri, 31 Aug 2007, Jakob Oestergaard wrote: Trond has a point Linus. I don't dispute that the new code does somethign good. But it changes existing behaviour. When we add NEW BEHAVIOUR, we don't add it to old interfaces when that breaks old user mode! We add a new flag saying I want the

Re: recent nfs change causes autofs regression

2007-08-31 Thread Matthias Schniedermeyer
It's not very conservative to suddenly change default behavior and break autofs mounts. There is not even one kernel message that _tells_ user why it thinks it's wrong. It just silently fails. No it doesn't. It reports an error code to the caller. If autofs is failing silently, then that

Re: recent nfs change causes autofs regression

2007-08-31 Thread Frank van Maarseveen
On Fri, Aug 31, 2007 at 09:40:28AM +0200, Jakob Oestergaard wrote: On Thu, Aug 30, 2007 at 10:16:37PM -0700, Linus Torvalds wrote: ... Why aren't we doing that for any other filesystem than NFS? How hard is it to acknowledge the following little word: regression It's

Re: recent nfs change causes autofs regression

2007-08-31 Thread Frank van Maarseveen
On Thu, Aug 30, 2007 at 02:07:43PM -0700, Hua Zhong wrote: I am re-sending this after help from Ian and git-bisect. To me it's a show-stopper: I cannot find an acceptable workaround that I can implement. The problem: upgrading to 2.6.23-rc4 from 2.6.22 causes several autofs mounts to fail

Re: recent nfs change causes autofs regression

2007-08-31 Thread Jakob Oestergaard
On Fri, Aug 31, 2007 at 01:07:56AM -0700, Linus Torvalds wrote: ... When we add NEW BEHAVIOUR, we don't add it to old interfaces when that breaks old user mode! We add a new flag saying I want the new behaviour. This is not rocket science, guys. This is very basic kernel behaviour. The

Re: recent nfs change causes autofs regression

2007-08-31 Thread Martin Knoblauch
--- Ian Kent [EMAIL PROTECTED] wrote: On Thu, 30 Aug 2007, Linus Torvalds wrote: On Fri, 31 Aug 2007, Trond Myklebust wrote: It did not. The previous behaviour was to always silently override the user mount options. ..so it still worked for any sane setup, at least.

Re: recent nfs change causes autofs regression

2007-08-31 Thread Ian Kent
On Fri, 31 Aug 2007, Frank van Maarseveen wrote: On Thu, Aug 30, 2007 at 02:07:43PM -0700, Hua Zhong wrote: I am re-sending this after help from Ian and git-bisect. To me it's a show-stopper: I cannot find an acceptable workaround that I can implement. The problem: upgrading to

Re: recent nfs change causes autofs regression

2007-08-31 Thread Trond Myklebust
On Fri, 2007-08-31 at 01:07 -0700, Linus Torvalds wrote: If you want new behaviour, you add a new flag saying you want new behaviour. You don't just start behaving differently from what you've always done before (and what *other* UNIXes do, for that matter). Besides, even *if* it was a

Re: recent nfs change causes autofs regression

2007-08-31 Thread Frank van Maarseveen
On Fri, Aug 31, 2007 at 08:11:38AM -0400, Trond Myklebust wrote: On Fri, 2007-08-31 at 01:07 -0700, Linus Torvalds wrote: If you want new behaviour, you add a new flag saying you want new behaviour. You don't just start behaving differently from what you've always done before (and

Re: recent nfs change causes autofs regression

2007-08-31 Thread Trond Myklebust
On Fri, 2007-08-31 at 15:12 +0200, Frank van Maarseveen wrote: IMHO I'd only consider returning EBUSY when trying to mount _exactly_ the same directory with different flags, not for arbitrary subtrees. The client should preferably not be bothered with server side disk partitioning (at least

Re: recent nfs change causes autofs regression

2007-08-30 Thread Ian Kent
On Thu, 30 Aug 2007, Linus Torvalds wrote: > > > On Fri, 31 Aug 2007, Trond Myklebust wrote: > > > > It did not. The previous behaviour was to always silently override the > > user mount options. > > ..so it still worked for any sane setup, at least. > > You broke that. Hua gave good reasons

RE: recent nfs change causes autofs regression

2007-08-30 Thread Hua Zhong
Trond, > So you are saying that it is acceptable for the kernel to decide > unilaterally to override mount options? Why aren't we doing that for > any other filesystem than NFS? I think there are two reasons. First, I have no problem with the new behavior if it didn't cause a regression. I am

Re: recent nfs change causes autofs regression

2007-08-30 Thread Linus Torvalds
On Fri, 31 Aug 2007, Trond Myklebust wrote: > > So you are saying that it is acceptable for the kernel to decide > unilaterally to override mount options? IT'S WHAT WE'VE APPARENTLY ALWAYS DONE! > Why aren't we doing that for any other filesystem than NFS? How hard is it to acknowledge the

RE: recent nfs change causes autofs regression

2007-08-30 Thread Ian Kent
On Fri, 31 Aug 2007, Trond Myklebust wrote: > On Thu, 2007-08-30 at 16:44 -0700, Hua Zhong wrote: > > > How is the NFS client to know that these directories are disjoint, or > > > that no-one will ever create a hard link from one directory to another? > > > To my knowledge, the only way to ensure

Re: recent nfs change causes autofs regression

2007-08-30 Thread Trond Myklebust
On Thu, 2007-08-30 at 21:59 -0700, Linus Torvalds wrote: > > On Fri, 31 Aug 2007, Trond Myklebust wrote: > > > > It did not. The previous behaviour was to always silently override the > > user mount options. > > ..so it still worked for any sane setup, at least. > > You broke that. Hua gave

Re: recent nfs change causes autofs regression

2007-08-30 Thread Linus Torvalds
On Fri, 31 Aug 2007, Trond Myklebust wrote: > > It did not. The previous behaviour was to always silently override the > user mount options. ..so it still worked for any sane setup, at least. You broke that. Hua gave good reasons for why he cannot use the current kernel. It's a regression.

RE: recent nfs change causes autofs regression

2007-08-30 Thread Trond Myklebust
On Thu, 2007-08-30 at 21:38 -0700, Linus Torvalds wrote: > > On Fri, 31 Aug 2007, Trond Myklebust wrote: > > > > No. Solaris defaults to breaking cache consistency. > > If so, and since that's obviously what people _expect_ to happen, why not > make that the default, with the "consistent"

RE: recent nfs change causes autofs regression

2007-08-30 Thread Hua Zhong
> On Fri, 31 Aug 2007, Trond Myklebust wrote: > > > > No. Solaris defaults to breaking cache consistency. > > If so, and since that's obviously what people _expect_ to happen, why > not make that the default, with the "consistent" behaviour being the > one that needs an explicit option. > >

Re: recent nfs change causes autofs regression

2007-08-30 Thread Trond Myklebust
On Thu, 2007-08-30 at 20:49 -0700, Linus Torvalds wrote: > > On Thu, 30 Aug 2007, Trond Myklebust wrote: > > > > Which is better than having it fail silently, or giving you a mount with > > the wrong mount options. > > No, Trond. > > That commit gets reverted or fixed. It's a regression, and

RE: recent nfs change causes autofs regression

2007-08-30 Thread Linus Torvalds
On Fri, 31 Aug 2007, Trond Myklebust wrote: > > No. Solaris defaults to breaking cache consistency. If so, and since that's obviously what people _expect_ to happen, why not make that the default, with the "consistent" behaviour being the one that needs an explicit option. Just out of

RE: recent nfs change causes autofs regression

2007-08-30 Thread Trond Myklebust
On Thu, 2007-08-30 at 16:44 -0700, Hua Zhong wrote: > > How is the NFS client to know that these directories are disjoint, or > > that no-one will ever create a hard link from one directory to another? > > To my knowledge, the only way to ensure this is to put them on > > different disk

Re: recent nfs change causes autofs regression

2007-08-30 Thread Trond Myklebust
On Thu, 2007-08-30 at 18:24 -0700, Andrew Morton wrote: > On Thu, 30 Aug 2007 18:37:13 -0400 Trond Myklebust <[EMAIL PROTECTED]> wrote: > > > On Thu, 2007-08-30 at 14:07 -0700, Hua Zhong wrote: > > > I am re-sending this after help from Ian and git-bisect. To me it's a > > > show-stopper: I

RE: recent nfs change causes autofs regression

2007-08-30 Thread Hua Zhong
Hi Linus, > Hua - that said, I don't actually see why the commit you bisected to > has anything to do with the issue being discussed. Can you double-check > that it's literally that particular commit that breaks for you (you could > try just reverting that commit). I will double check that

Re: recent nfs change causes autofs regression

2007-08-30 Thread Linus Torvalds
On Thu, 30 Aug 2007, Trond Myklebust wrote: > > Which is better than having it fail silently, or giving you a mount with > the wrong mount options. No, Trond. That commit gets reverted or fixed. It's a regression, and your theories that it's "better" that way are obviously broken. It's

Re: recent nfs change causes autofs regression

2007-08-30 Thread Andrew Morton
On Thu, 30 Aug 2007 18:37:13 -0400 Trond Myklebust <[EMAIL PROTECTED]> wrote: > On Thu, 2007-08-30 at 14:07 -0700, Hua Zhong wrote: > > I am re-sending this after help from Ian and git-bisect. To me it's a > > show-stopper: I cannot find an acceptable workaround that I can implement. > > > > The

RE: recent nfs change causes autofs regression

2007-08-30 Thread Hua Zhong
> How is the NFS client to know that these directories are disjoint, or > that no-one will ever create a hard link from one directory to another? > To my knowledge, the only way to ensure this is to put them on > different disk partitions. > > I don't know if all Unix systems have this issue, but

RE: recent nfs change causes autofs regression

2007-08-30 Thread Trond Myklebust
On Thu, 2007-08-30 at 16:30 -0700, Hua Zhong wrote: > There are two disjoint directories. I am wondering why there would be cache > coherency issues in this case? Is this Linus nfs implementation specific or > all other Unix systems all have the same issue? How is the NFS client to know that

RE: recent nfs change causes autofs regression

2007-08-30 Thread Hua Zhong
> On Thu, 2007-08-30 at 15:47 -0700, Hua Zhong wrote: > > > > > > Which is better than having it fail silently, or giving you a mount > > > with the wrong mount options. > > > > Well, it depends on how you define "better". > > "better" as in: "I now have a chance to notice, when my 'read-only >

RE: recent nfs change causes autofs regression

2007-08-30 Thread Trond Myklebust
On Thu, 2007-08-30 at 15:47 -0700, Hua Zhong wrote: > Hi Trond, > > > On Thu, 2007-08-30 at 14:07 -0700, Hua Zhong wrote: > > > I am re-sending this after help from Ian and git-bisect. To me it's a > > > show-stopper: I cannot find an acceptable workaround that I can > > > implement. The problem:

RE: recent nfs change causes autofs regression

2007-08-30 Thread Hua Zhong
Hi Trond, > On Thu, 2007-08-30 at 14:07 -0700, Hua Zhong wrote: > > I am re-sending this after help from Ian and git-bisect. To me it's a > > show-stopper: I cannot find an acceptable workaround that I can > > implement. The problem: upgrading to 2.6.23-rc4 from 2.6.22 causes > > several autofs

Re: recent nfs change causes autofs regression

2007-08-30 Thread Trond Myklebust
On Thu, 2007-08-30 at 14:07 -0700, Hua Zhong wrote: > I am re-sending this after help from Ian and git-bisect. To me it's a > show-stopper: I cannot find an acceptable workaround that I can implement. > > The problem: upgrading to 2.6.23-rc4 from 2.6.22 causes several autofs > mounts to fail

Re: recent nfs change causes autofs regression

2007-08-30 Thread Trond Myklebust
On Thu, 2007-08-30 at 14:07 -0700, Hua Zhong wrote: I am re-sending this after help from Ian and git-bisect. To me it's a show-stopper: I cannot find an acceptable workaround that I can implement. The problem: upgrading to 2.6.23-rc4 from 2.6.22 causes several autofs mounts to fail silently

RE: recent nfs change causes autofs regression

2007-08-30 Thread Hua Zhong
Hi Trond, On Thu, 2007-08-30 at 14:07 -0700, Hua Zhong wrote: I am re-sending this after help from Ian and git-bisect. To me it's a show-stopper: I cannot find an acceptable workaround that I can implement. The problem: upgrading to 2.6.23-rc4 from 2.6.22 causes several autofs mounts to

RE: recent nfs change causes autofs regression

2007-08-30 Thread Trond Myklebust
On Thu, 2007-08-30 at 15:47 -0700, Hua Zhong wrote: Hi Trond, On Thu, 2007-08-30 at 14:07 -0700, Hua Zhong wrote: I am re-sending this after help from Ian and git-bisect. To me it's a show-stopper: I cannot find an acceptable workaround that I can implement. The problem: upgrading to

RE: recent nfs change causes autofs regression

2007-08-30 Thread Hua Zhong
On Thu, 2007-08-30 at 15:47 -0700, Hua Zhong wrote: Which is better than having it fail silently, or giving you a mount with the wrong mount options. Well, it depends on how you define better. better as in: I now have a chance to notice, when my 'read-only mount' is actually

RE: recent nfs change causes autofs regression

2007-08-30 Thread Hua Zhong
How is the NFS client to know that these directories are disjoint, or that no-one will ever create a hard link from one directory to another? To my knowledge, the only way to ensure this is to put them on different disk partitions. I don't know if all Unix systems have this issue, but I

RE: recent nfs change causes autofs regression

2007-08-30 Thread Trond Myklebust
On Thu, 2007-08-30 at 16:30 -0700, Hua Zhong wrote: There are two disjoint directories. I am wondering why there would be cache coherency issues in this case? Is this Linus nfs implementation specific or all other Unix systems all have the same issue? How is the NFS client to know that these

Re: recent nfs change causes autofs regression

2007-08-30 Thread Andrew Morton
On Thu, 30 Aug 2007 18:37:13 -0400 Trond Myklebust [EMAIL PROTECTED] wrote: On Thu, 2007-08-30 at 14:07 -0700, Hua Zhong wrote: I am re-sending this after help from Ian and git-bisect. To me it's a show-stopper: I cannot find an acceptable workaround that I can implement. The problem:

Re: recent nfs change causes autofs regression

2007-08-30 Thread Linus Torvalds
On Thu, 30 Aug 2007, Trond Myklebust wrote: Which is better than having it fail silently, or giving you a mount with the wrong mount options. No, Trond. That commit gets reverted or fixed. It's a regression, and your theories that it's better that way are obviously broken. It's obviously

RE: recent nfs change causes autofs regression

2007-08-30 Thread Hua Zhong
Hi Linus, Hua - that said, I don't actually see why the commit you bisected to has anything to do with the issue being discussed. Can you double-check that it's literally that particular commit that breaks for you (you could try just reverting that commit). I will double check that tomorrow.

RE: recent nfs change causes autofs regression

2007-08-30 Thread Trond Myklebust
On Thu, 2007-08-30 at 16:44 -0700, Hua Zhong wrote: How is the NFS client to know that these directories are disjoint, or that no-one will ever create a hard link from one directory to another? To my knowledge, the only way to ensure this is to put them on different disk partitions. I

  1   2   >