Re: sk_buff destructor in 2.2.18

2001-05-23 Thread Andi Kleen
On Wed, May 23, 2001 at 05:02:15PM +0200, christophe barbé wrote: > I believe you and It's sure that I have not tested all cases. > So do you see a way to use a private data buffer ? The only way I know currently is to keep skb->users >= 1 and use a timer that collects such buffers from a global

Re: sk_buff destructor in 2.2.18

2001-05-23 Thread christophe barbé
I believe you and It's sure that I have not tested all cases. So do you see a way to use a private data buffer ? Christophe On Wed, 23 May 2001 16:55:57 Andi Kleen wrote: > On Wed, May 23, 2001 at 04:50:28PM +0200, christophe barbé wrote: > > I don't know about socket but I allocate myself the

Re: sk_buff destructor in 2.2.18

2001-05-23 Thread Andi Kleen
On Wed, May 23, 2001 at 04:50:28PM +0200, christophe barbé wrote: > I don't know about socket but I allocate myself the skbuff and I set the > destructor (and previously the pointer value is NULL). So I don't overwrite > a destructor. That just means you didn't test all cases; e.g. not TCP or

Re: sk_buff destructor in 2.2.18

2001-05-23 Thread christophe barbé
I don't know about socket but I allocate myself the skbuff and I set the destructor (and previously the pointer value is NULL). So I don't overwrite a destructor. I believe net/core/sock.c is not involved in my problem but I can be wrong. What is worrying me is that I don't know who clones my

Re: sk_buff destructor in 2.2.18

2001-05-23 Thread Andi Kleen
On Wed, May 23, 2001 at 04:37:58PM +0200, christophe barbé wrote: > It seems to not be the case, because my destructor is called. It is called, but you overwrote the kernel destructor and therefore broke the socket memory accounting completely; causing all kinds of problems. > Could you point

Re: sk_buff destructor in 2.2.18

2001-05-23 Thread christophe barbé
It seems to not be the case, because my destructor is called. Could you point me the code where you think this method is already used? Thank you for your answer, Christophe On Wed, 23 May 2001 16:27:39 Andi Kleen wrote: > On Wed, May 23, 2001 at 04:16:54PM +0200, christophe barbé wrote: > > Hi

Re: sk_buff destructor in 2.2.18

2001-05-23 Thread Andi Kleen
On Wed, May 23, 2001 at 04:16:54PM +0200, christophe barbé wrote: > Hi all, > > I'm trying to figure out how to use the destructor function in the skbuff > object. > I've read (the source code and) the alan cox's article from linuxjournal > but it refers to linux 2.0. > Perhaps someone can tell

Re: sk_buff destructor in 2.2.18

2001-05-23 Thread Andi Kleen
On Wed, May 23, 2001 at 04:16:54PM +0200, christophe barbé wrote: Hi all, I'm trying to figure out how to use the destructor function in the skbuff object. I've read (the source code and) the alan cox's article from linuxjournal but it refers to linux 2.0. Perhaps someone can tell me

Re: sk_buff destructor in 2.2.18

2001-05-23 Thread christophe barbé
It seems to not be the case, because my destructor is called. Could you point me the code where you think this method is already used? Thank you for your answer, Christophe On Wed, 23 May 2001 16:27:39 Andi Kleen wrote: On Wed, May 23, 2001 at 04:16:54PM +0200, christophe barbé wrote: Hi

Re: sk_buff destructor in 2.2.18

2001-05-23 Thread Andi Kleen
On Wed, May 23, 2001 at 04:37:58PM +0200, christophe barbé wrote: It seems to not be the case, because my destructor is called. It is called, but you overwrote the kernel destructor and therefore broke the socket memory accounting completely; causing all kinds of problems. Could you point me

Re: sk_buff destructor in 2.2.18

2001-05-23 Thread christophe barbé
I don't know about socket but I allocate myself the skbuff and I set the destructor (and previously the pointer value is NULL). So I don't overwrite a destructor. I believe net/core/sock.c is not involved in my problem but I can be wrong. What is worrying me is that I don't know who clones my

Re: sk_buff destructor in 2.2.18

2001-05-23 Thread Andi Kleen
On Wed, May 23, 2001 at 04:50:28PM +0200, christophe barbé wrote: I don't know about socket but I allocate myself the skbuff and I set the destructor (and previously the pointer value is NULL). So I don't overwrite a destructor. That just means you didn't test all cases; e.g. not TCP or UDP

Re: sk_buff destructor in 2.2.18

2001-05-23 Thread christophe barbé
I believe you and It's sure that I have not tested all cases. So do you see a way to use a private data buffer ? Christophe On Wed, 23 May 2001 16:55:57 Andi Kleen wrote: On Wed, May 23, 2001 at 04:50:28PM +0200, christophe barbé wrote: I don't know about socket but I allocate myself the

Re: sk_buff destructor in 2.2.18

2001-05-23 Thread Andi Kleen
On Wed, May 23, 2001 at 05:02:15PM +0200, christophe barbé wrote: I believe you and It's sure that I have not tested all cases. So do you see a way to use a private data buffer ? The only way I know currently is to keep skb-users = 1 and use a timer that collects such buffers from a global