Re: staging: lustre: One function call less in class_register_type() after error detection

2016-07-27 Thread SF Markus Elfring
> This function is called several times during lustre module insert. > Namely it's called 5 times for 5 types: > osc, mdc, lov, lmv, mgc. Will any extra memory accesses matter for the successful execution in this use case? > It's not called any more than that, so it's not exactly a super

Re: staging: lustre: One function call less in class_register_type() after error detection

2016-07-27 Thread SF Markus Elfring
> This function is called several times during lustre module insert. > Namely it's called 5 times for 5 types: > osc, mdc, lov, lmv, mgc. Will any extra memory accesses matter for the successful execution in this use case? > It's not called any more than that, so it's not exactly a super

Re: staging: lustre: One function call less in class_register_type() after error detection

2016-07-26 Thread Oleg Drokin
On Jul 26, 2016, at 3:56 PM, SF Markus Elfring wrote: >> But kobject_put() already checks for NULL, right? > > Yes. - Such an input parameter validation is performed by the > function implementation. > > >> you just submitted another batch about that in other area. > > I sent update

Re: staging: lustre: One function call less in class_register_type() after error detection

2016-07-26 Thread Oleg Drokin
On Jul 26, 2016, at 3:56 PM, SF Markus Elfring wrote: >> But kobject_put() already checks for NULL, right? > > Yes. - Such an input parameter validation is performed by the > function implementation. > > >> you just submitted another batch about that in other area. > > I sent update

Re: staging: lustre: One function call less in class_register_type() after error detection

2016-07-26 Thread SF Markus Elfring
> But kobject_put() already checks for NULL, right? Yes. - Such an input parameter validation is performed by the function implementation. > you just submitted another batch about that in other area. I sent update suggestions because of this function property for two Linux software modules in

Re: staging: lustre: One function call less in class_register_type() after error detection

2016-07-26 Thread SF Markus Elfring
> But kobject_put() already checks for NULL, right? Yes. - Such an input parameter validation is performed by the function implementation. > you just submitted another batch about that in other area. I sent update suggestions because of this function property for two Linux software modules in