Re: uprobes: memory leak in enable/disable loop

2016-08-16 Thread Johannes Weiner
On Tue, Aug 16, 2016 at 04:34:08PM +0200, Oleg Nesterov wrote: > @@ -172,8 +172,10 @@ static int __replace_page(struct vm_area > mmu_notifier_invalidate_range_start(mm, mmun_start, mmun_end); > err = -EAGAIN; > ptep = page_check_address(page, mm, addr, , 0); > - if (!ptep) >

Re: uprobes: memory leak in enable/disable loop

2016-08-16 Thread Johannes Weiner
On Tue, Aug 16, 2016 at 04:34:08PM +0200, Oleg Nesterov wrote: > @@ -172,8 +172,10 @@ static int __replace_page(struct vm_area > mmu_notifier_invalidate_range_start(mm, mmun_start, mmun_end); > err = -EAGAIN; > ptep = page_check_address(page, mm, addr, , 0); > - if (!ptep) >

Re: uprobes: memory leak in enable/disable loop

2016-08-16 Thread Brenden Blanco
On Tue, Aug 16, 2016 at 04:34:08PM +0200, Oleg Nesterov wrote: > On 08/16, Oleg Nesterov wrote: > > > > On 08/16, Oleg Nesterov wrote: > > > > > > On 08/15, Brenden Blanco wrote: > > > > > > > > Hi folks, > > > > > > > > I think I have come across a memory leak in uprobes, which is fairly > > > >

Re: uprobes: memory leak in enable/disable loop

2016-08-16 Thread Brenden Blanco
On Tue, Aug 16, 2016 at 04:34:08PM +0200, Oleg Nesterov wrote: > On 08/16, Oleg Nesterov wrote: > > > > On 08/16, Oleg Nesterov wrote: > > > > > > On 08/15, Brenden Blanco wrote: > > > > > > > > Hi folks, > > > > > > > > I think I have come across a memory leak in uprobes, which is fairly > > > >

Re: uprobes: memory leak in enable/disable loop

2016-08-16 Thread Michal Hocko
On Tue 16-08-16 16:25:12, Oleg Nesterov wrote: > On 08/16, Oleg Nesterov wrote: > > > > On 08/15, Brenden Blanco wrote: > > > > > > Hi folks, > > > > > > I think I have come across a memory leak in uprobes, which is fairly easy > > > to > > > reproduce. > > > > At first glance this looks as a

Re: uprobes: memory leak in enable/disable loop

2016-08-16 Thread Michal Hocko
On Tue 16-08-16 16:25:12, Oleg Nesterov wrote: > On 08/16, Oleg Nesterov wrote: > > > > On 08/15, Brenden Blanco wrote: > > > > > > Hi folks, > > > > > > I think I have come across a memory leak in uprobes, which is fairly easy > > > to > > > reproduce. > > > > At first glance this looks as a

Re: uprobes: memory leak in enable/disable loop

2016-08-16 Thread Oleg Nesterov
On 08/16, Oleg Nesterov wrote: > > On 08/16, Oleg Nesterov wrote: > > > > On 08/15, Brenden Blanco wrote: > > > > > > Hi folks, > > > > > > I think I have come across a memory leak in uprobes, which is fairly easy > > > to > > > reproduce. > > > > At first glance this looks as a problem in memcg,

Re: uprobes: memory leak in enable/disable loop

2016-08-16 Thread Oleg Nesterov
On 08/16, Oleg Nesterov wrote: > > On 08/16, Oleg Nesterov wrote: > > > > On 08/15, Brenden Blanco wrote: > > > > > > Hi folks, > > > > > > I think I have come across a memory leak in uprobes, which is fairly easy > > > to > > > reproduce. > > > > At first glance this looks as a problem in memcg,

Re: uprobes: memory leak in enable/disable loop

2016-08-16 Thread Oleg Nesterov
On 08/16, Oleg Nesterov wrote: > > On 08/15, Brenden Blanco wrote: > > > > Hi folks, > > > > I think I have come across a memory leak in uprobes, which is fairly easy to > > reproduce. > > At first glance this looks as a problem in memcg, add CC's... > > put_page(old_page) looks properly balanced,

Re: uprobes: memory leak in enable/disable loop

2016-08-16 Thread Oleg Nesterov
On 08/16, Oleg Nesterov wrote: > > On 08/15, Brenden Blanco wrote: > > > > Hi folks, > > > > I think I have come across a memory leak in uprobes, which is fairly easy to > > reproduce. > > At first glance this looks as a problem in memcg, add CC's... > > put_page(old_page) looks properly balanced,

Re: uprobes: memory leak in enable/disable loop

2016-08-16 Thread Oleg Nesterov
On 08/15, Brenden Blanco wrote: > > Hi folks, > > I think I have come across a memory leak in uprobes, which is fairly easy to > reproduce. At first glance this looks as a problem in memcg, add CC's... put_page(old_page) looks properly balanced, and I assume we do not need the additional

Re: uprobes: memory leak in enable/disable loop

2016-08-16 Thread Oleg Nesterov
On 08/15, Brenden Blanco wrote: > > Hi folks, > > I think I have come across a memory leak in uprobes, which is fairly easy to > reproduce. At first glance this looks as a problem in memcg, add CC's... put_page(old_page) looks properly balanced, and I assume we do not need the additional