Re: v4.16+ seeing many unaligned access in dequeue_task_fair() on IA64

2018-04-05 Thread Ingo Molnar
* Peter Zijlstra wrote: > On Wed, Apr 04, 2018 at 06:53:10PM +0200, Peter Zijlstra wrote: > > Awesome, I'll go get it merged, even though I don't understand where it > > went wobbly. > > Ingo, could you magic this in? > > --- > Subject: sched: Force alignment of struct util_est > From: Peter Z

Re: v4.16+ seeing many unaligned access in dequeue_task_fair() on IA64

2018-04-05 Thread Peter Zijlstra
On Wed, Apr 04, 2018 at 06:53:10PM +0200, Peter Zijlstra wrote: > Awesome, I'll go get it merged, even though I don't understand where it > went wobbly. Ingo, could you magic this in? --- Subject: sched: Force alignment of struct util_est From: Peter Zijlstra Date: Thu Apr 5 09:56:16 CEST 2018

Re: v4.16+ seeing many unaligned access in dequeue_task_fair() on IA64

2018-04-04 Thread Peter Zijlstra
On Wed, Apr 04, 2018 at 09:38:56AM -0700, Luck, Tony wrote: > On Wed, Apr 04, 2018 at 09:25:13AM +0200, Peter Zijlstra wrote: > > Right, I remember being careful with that. Which again brings me to the > > RANDSTRUCT thing, which will mess that up. > > No RANDSTRUCT config options set for my build

Re: v4.16+ seeing many unaligned access in dequeue_task_fair() on IA64

2018-04-04 Thread Luck, Tony
On Wed, Apr 04, 2018 at 09:25:13AM +0200, Peter Zijlstra wrote: > Right, I remember being careful with that. Which again brings me to the > RANDSTRUCT thing, which will mess that up. No RANDSTRUCT config options set for my build. > Does the below cure things? It makes absolutely no difference for

Re: v4.16+ seeing many unaligned access in dequeue_task_fair() on IA64

2018-04-04 Thread Peter Zijlstra
On Wed, Apr 04, 2018 at 12:04:00AM +, Luck, Tony wrote: > > bisect says: > > > > d519329f72a6 ("sched/fair: Update util_est only on util_avg updates") > > > > Reverting just this commit makes the problem go away. > > The unaligned read and write seem to come from: > > struct util_est ue = RE

RE: v4.16+ seeing many unaligned access in dequeue_task_fair() on IA64

2018-04-03 Thread Luck, Tony
> bisect says: > > d519329f72a6 ("sched/fair: Update util_est only on util_avg updates") > > Reverting just this commit makes the problem go away. The unaligned read and write seem to come from: struct util_est ue = READ_ONCE(p->se.avg.util_est); WRITE_ONCE(p->se.avg.util_est, ue); which is puz

Re: v4.16+ seeing many unaligned access in dequeue_task_fair() on IA64

2018-04-03 Thread Luck, Tony
On Tue, Apr 03, 2018 at 09:37:06AM +0200, Peter Zijlstra wrote: > On Mon, Apr 02, 2018 at 04:24:49PM -0700, Luck, Tony wrote: > > Any guesses before I start to bisect? > > That doesn't sound good. The only guess I have at this moment is you > accidentially enabled RANDSTRUCT_PLUGIN and that messes

Re: v4.16+ seeing many unaligned access in dequeue_task_fair() on IA64

2018-04-03 Thread Peter Zijlstra
On Mon, Apr 02, 2018 at 04:24:49PM -0700, Luck, Tony wrote: > v4.16 boots cleanly. But with the first bunch of merges > (Linus HEAD = 46e0d28bdb8e6d00e27a0fe9e1d15df6098f0ffb) > I see a bunch of: > > ia64_handle_unaligned: 4863 callbacks suppressed > kernel unaligned access to 0xe0031660fd74,

RE: v4.16+ seeing many unaligned access in dequeue_task_fair() on IA64

2018-04-02 Thread Luck, Tony
> kernel unaligned access to 0xe0031660fd74, ip=0xa001000f23e0 > kernel unaligned access to 0xe0033bdffbcc, ip=0xa001000f2370 Here's the disassembly of dequeu_task_fair() in case it would help to see which two instructions are getting all the faults: a001000f21c0 : a001000