Re: ext4 iomap SEEK broken [was: [GIT PULL] ext4 updates for 4.15]

2018-02-12 Thread Theodore Ts'o
On Mon, Feb 12, 2018 at 01:14:07PM +0100, Jiri Slaby wrote: > On 02/12/2018, 11:02 AM, Jiri Slaby wrote: > > Given this happens only on 32bit kernel, I assume some 32bit overflow. > > But I am unable to see it (yet). > > Just to add, a diff of strace in good and bad kernels: > @@ -655,14 +655,4

Re: ext4 iomap SEEK broken [was: [GIT PULL] ext4 updates for 4.15]

2018-02-12 Thread Theodore Ts'o
On Mon, Feb 12, 2018 at 01:14:07PM +0100, Jiri Slaby wrote: > On 02/12/2018, 11:02 AM, Jiri Slaby wrote: > > Given this happens only on 32bit kernel, I assume some 32bit overflow. > > But I am unable to see it (yet). > > Just to add, a diff of strace in good and bad kernels: > @@ -655,14 +655,4

Re: ext4 iomap SEEK broken [was: [GIT PULL] ext4 updates for 4.15]

2018-02-12 Thread Jiri Slaby
On 02/12/2018, 02:34 PM, Jiri Slaby wrote: > @@ -3523,7 +3523,7 @@ static int ext4_iomap_begin(struct inode *inode, > loff_t offset, loff_t length, > iomap->flags |= IOMAP_F_DIRTY; > iomap->bdev = inode->i_sb->s_bdev; > iomap->dax_dev = sbi->s_daxdev; > -

Re: ext4 iomap SEEK broken [was: [GIT PULL] ext4 updates for 4.15]

2018-02-12 Thread Jiri Slaby
On 02/12/2018, 02:34 PM, Jiri Slaby wrote: > @@ -3523,7 +3523,7 @@ static int ext4_iomap_begin(struct inode *inode, > loff_t offset, loff_t length, > iomap->flags |= IOMAP_F_DIRTY; > iomap->bdev = inode->i_sb->s_bdev; > iomap->dax_dev = sbi->s_daxdev; > -

Re: ext4 iomap SEEK broken [was: [GIT PULL] ext4 updates for 4.15]

2018-02-12 Thread Jiri Slaby
On 02/12/2018, 01:14 PM, Jiri Slaby wrote: > On 02/12/2018, 11:02 AM, Jiri Slaby wrote: >> Given this happens only on 32bit kernel, I assume some 32bit overflow. >> But I am unable to see it (yet). > > Just to add, a diff of strace in good and bad kernels: > @@ -655,14 +655,4 @@ > _llseek(3,

Re: ext4 iomap SEEK broken [was: [GIT PULL] ext4 updates for 4.15]

2018-02-12 Thread Jiri Slaby
On 02/12/2018, 01:14 PM, Jiri Slaby wrote: > On 02/12/2018, 11:02 AM, Jiri Slaby wrote: >> Given this happens only on 32bit kernel, I assume some 32bit overflow. >> But I am unable to see it (yet). > > Just to add, a diff of strace in good and bad kernels: > @@ -655,14 +655,4 @@ > _llseek(3,

Re: ext4 iomap SEEK broken [was: [GIT PULL] ext4 updates for 4.15]

2018-02-12 Thread Jiri Slaby
On 02/12/2018, 11:02 AM, Jiri Slaby wrote: > Given this happens only on 32bit kernel, I assume some 32bit overflow. > But I am unable to see it (yet). Just to add, a diff of strace in good and bad kernels: @@ -655,14 +655,4 @@ _llseek(3, 4275568640, [4286054400], SEEK_DATA) = 0 _llseek(3,

Re: ext4 iomap SEEK broken [was: [GIT PULL] ext4 updates for 4.15]

2018-02-12 Thread Jiri Slaby
On 02/12/2018, 11:02 AM, Jiri Slaby wrote: > Given this happens only on 32bit kernel, I assume some 32bit overflow. > But I am unable to see it (yet). Just to add, a diff of strace in good and bad kernels: @@ -655,14 +655,4 @@ _llseek(3, 4275568640, [4286054400], SEEK_DATA) = 0 _llseek(3,

ext4 iomap SEEK broken [was: [GIT PULL] ext4 updates for 4.15]

2018-02-12 Thread Jiri Slaby
Hi, On 11/13/2017, 04:15 AM, Theodore Ts'o wrote: > The following changes since commit 9e66317d3c92ddaab330c125dfe9d06eee268aff: > > Linux 4.14-rc3 (2017-10-01 14:54:54 -0700) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git >

ext4 iomap SEEK broken [was: [GIT PULL] ext4 updates for 4.15]

2018-02-12 Thread Jiri Slaby
Hi, On 11/13/2017, 04:15 AM, Theodore Ts'o wrote: > The following changes since commit 9e66317d3c92ddaab330c125dfe9d06eee268aff: > > Linux 4.14-rc3 (2017-10-01 14:54:54 -0700) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git >