Re: linux-next: Fixes tag needs some work in the scsi-mkp tree

2020-08-17 Thread Can Guo 

Hi Stephen,

On 2020-08-18 14:11, Stephen Rothwell wrote:

Hi all,

In commit

  35afe60929ab ("scsi: ufs: Properly release resources if a task is
aborted successfully")

Fixes tag

  Fixes: 5a0b0cb9bee7 ("ufs: Add support for clock gating")

has these problem(s):

  - Subject does not match target commit subject
Just use
git log -1 --format='Fixes: %h ("%s")'

Did you mean

Fixes: 5a0b0cb9bee7 ("[SCSI] ufs: Add support for sending NOP OUT 
UPIU")


or

Fixes: 1ab27c9cf8b6 ("ufs: Add support for clock gating")


Thanks for pointing it out, it should be below one, something
might go wrong with my copy-paste.

Fixes: 1ab27c9cf8b6 ("ufs: Add support for clock gating")

Regards,

Can Guo.

linux-next: Fixes tag needs some work in the scsi-mkp tree

2020-08-17 Thread Stephen Rothwell 
Hi all,

In commit

  35afe60929ab ("scsi: ufs: Properly release resources if a task is aborted 
successfully")

Fixes tag

  Fixes: 5a0b0cb9bee7 ("ufs: Add support for clock gating")

has these problem(s):

  - Subject does not match target commit subject
Just use
git log -1 --format='Fixes: %h ("%s")'

Did you mean

Fixes: 5a0b0cb9bee7 ("[SCSI] ufs: Add support for sending NOP OUT UPIU")

or

Fixes: 1ab27c9cf8b6 ("ufs: Add support for clock gating")

-- 
Cheers,
Stephen Rothwell


pgpWp2Pa1u5tf.pgp
Description: OpenPGP digital signature

linux-next: Fixes tag needs some work in the scsi-mkp tree

2019-08-29 Thread Stephen Rothwell 
Hi all,

In commit

  f18b30a01e21 ("scsi: fnic: print port speed only at driver init or speed 
change")

Fixes tag

  Fixes: commit d948e6383ec3 ("scsi: fnic: Add port speed stat to fnic debug 
stats")

has these problem(s):

  - leading word 'commit' unexpected

-- 
Cheers,
Stephen Rothwell


pgpDzYYqHiba1.pgp
Description: OpenPGP digital signature

Re: linux-next: Fixes tag needs some work in the scsi-mkp tree

2019-08-19 Thread Martin K. Petersen 


Stephen,

> In commit
>
>   cff1191553d9 ("scsi: qla2xxx: cleanup trace buffer initialization")
>
> Fixes tag
>
>   Fixes: ad0a0b01f088 ("scsi: qla2xxx: Fix Firmware dump size for Extended
>
> has these problem(s):
>
>   - Subject has leading but no trailing parentheses
>   - Subject has leading but no trailing quotes
>
> Please don't split Fixes tags over more than one line.
>
> Fixes tag
>
>   Fixes: (a28d9e4ef997 "scsi: qla2xxx: Add support for multiple fwdump
>
> has these problem(s):
>
>   - No SHA1 recognised

Fixed these up. Thanks!

-- 
Martin K. Petersen  Oracle Linux Engineering

linux-next: Fixes tag needs some work in the scsi-mkp tree

2019-08-15 Thread Stephen Rothwell 
Hi all,

In commit

  cff1191553d9 ("scsi: qla2xxx: cleanup trace buffer initialization")

Fixes tag

  Fixes: ad0a0b01f088 ("scsi: qla2xxx: Fix Firmware dump size for Extended

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please don't split Fixes tags over more than one line.

Fixes tag

  Fixes: (a28d9e4ef997 "scsi: qla2xxx: Add support for multiple fwdump

has these problem(s):

  - No SHA1 recognised

-- 
Cheers,
Stephen Rothwell


pgpjr3drGXMJm.pgp
Description: OpenPGP digital signature

linux-next: Fixes tag needs some work in the scsi-mkp tree

2019-07-30 Thread Stephen Rothwell 
Hi all,

In commit

  d31ca849b04a ("scsi: qla2xxx: Fix Relogin to prevent modifying scan_state 
flag")

Fixes tag

  Fixes: 79140e2f4fa7 ("scsi: qla2xxx: Fix login state machine freeze")

has these problem(s):

  - Target SHA1 does not exist

Did you mean

Fixes: 2dee5521028c ("scsi: qla2xxx: Fix login state machine freeze")

-- 
Cheers,
Stephen Rothwell


pgp41NQn5U3aZ.pgp
Description: OpenPGP digital signature