Re: linux-next: build warnings after merge of the staging tree

[Jonathan Cameron]

On Tue, 5 Feb 2019 14:22:17 +1100
Stephen Rothwell  wrote:

> Hi Greg,
> 
> After merging the staging tree, today's linux-next build (x86_64
> allmodconfig) produced these warnings:
> 
> drivers/iio/chemical/sps30.c: In function 'sps30_read_raw':
> drivers/iio/chemical/sps30.c:289:4: warning: this statement may fall through 
> [-Wimplicit-fallthrough=]
> switch (chan->channel2) {
> ^~
> drivers/iio/chemical/sps30.c:299:3: note: here
>default:
>^~~
> drivers/iio/chemical/sps30.c: In function 'sps30_do_cmd':
> drivers/iio/chemical/sps30.c:120:10: warning: this statement may fall through 
> [-Wimplicit-fallthrough=]
>buf[1] = (u8)SPS30_AUTO_CLEANING_PERIOD;
>   ^
> drivers/iio/chemical/sps30.c:121:2: note: here
>   case SPS30_READ_DATA_READY_FLAG:
>   ^~~~
> 
> Introduced by commits
> 
>   232e0f6ddeae ("iio: chemical: add support for Sensirion SPS30 sensor")
>   62129a0849d2 ("iio: chemical: sps30: allow changing self cleaning period")
> 
> I get this warning because I am building with -Wimplicit-fallthrough
> in attempt to catch new additions early.  The gcc warning can be turned
> off by adding a /* fall through */ comment at the point the fall through
> happens (assuming that the fall through is intentional).
> 

These both should both be marked - certainly look to be intentional.
The second one might be better handled with an additional return of the -EINVAL.

Thomasz, could you send me a patch tidying this up.

Thanks Stephen!

Jonathan

linux-next: build warnings after merge of the staging tree

[Stephen Rothwell]

Hi Greg,

After merging the staging tree, today's linux-next build (x86_64
allmodconfig) produced these warnings:

drivers/iio/chemical/sps30.c: In function 'sps30_read_raw':
drivers/iio/chemical/sps30.c:289:4: warning: this statement may fall through 
[-Wimplicit-fallthrough=]
switch (chan->channel2) {
^~
drivers/iio/chemical/sps30.c:299:3: note: here
   default:
   ^~~
drivers/iio/chemical/sps30.c: In function 'sps30_do_cmd':
drivers/iio/chemical/sps30.c:120:10: warning: this statement may fall through 
[-Wimplicit-fallthrough=]
   buf[1] = (u8)SPS30_AUTO_CLEANING_PERIOD;
  ^
drivers/iio/chemical/sps30.c:121:2: note: here
  case SPS30_READ_DATA_READY_FLAG:
  ^~~~

Introduced by commits

  232e0f6ddeae ("iio: chemical: add support for Sensirion SPS30 sensor")
  62129a0849d2 ("iio: chemical: sps30: allow changing self cleaning period")

I get this warning because I am building with -Wimplicit-fallthrough
in attempt to catch new additions early.  The gcc warning can be turned
off by adding a /* fall through */ comment at the point the fall through
happens (assuming that the fall through is intentional).

-- 
Cheers,
Stephen Rothwell


pgpT33P1MWZL4.pgp
Description: OpenPGP digital signature

Re: linux-next: build warnings after merge of the staging tree

[Greg KH]

On Mon, May 14, 2018 at 02:34:04PM +1000, Stephen Rothwell wrote:
> Hi Greg,
> 
> After merging the staging tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> drivers/staging/most/video/video.c: In function 'vidioc_enum_fmt_vid_cap':
> drivers/staging/most/video/video.c:265:25: warning: unused variable 'mdev' 
> [-Wunused-variable]
>   struct most_video_dev *mdev = fh->mdev;
>  ^~~~
> drivers/staging/most/video/video.c: In function 'vidioc_g_fmt_vid_cap':
> drivers/staging/most/video/video.c:282:25: warning: unused variable 'mdev' 
> [-Wunused-variable]
>   struct most_video_dev *mdev = fh->mdev;
>  ^~~~
> drivers/staging/most/video/video.c: In function 'vidioc_g_std':
> drivers/staging/most/video/video.c:309:25: warning: unused variable 'mdev' 
> [-Wunused-variable]
>   struct most_video_dev *mdev = fh->mdev;
>  ^~~~
> 
> Introduced by commit
> 
>   7d7cdb4fa552 ("staging: most: video: remove debugging code")

Sorry about this.  This warning, and the other one in the staging tree,
were not noticed by me due to my system updating to gcc-8 and the huge
numbers of warnings it produced.  Then 0-day went on a bender and didn't
spit out anything for a few days...

I'll go fix this up now, thanks for the report.

greg k-h

Re: linux-next: build warnings after merge of the staging tree

[Greg KH]

On Mon, May 14, 2018 at 02:34:04PM +1000, Stephen Rothwell wrote:
> Hi Greg,
> 
> After merging the staging tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> drivers/staging/most/video/video.c: In function 'vidioc_enum_fmt_vid_cap':
> drivers/staging/most/video/video.c:265:25: warning: unused variable 'mdev' 
> [-Wunused-variable]
>   struct most_video_dev *mdev = fh->mdev;
>  ^~~~
> drivers/staging/most/video/video.c: In function 'vidioc_g_fmt_vid_cap':
> drivers/staging/most/video/video.c:282:25: warning: unused variable 'mdev' 
> [-Wunused-variable]
>   struct most_video_dev *mdev = fh->mdev;
>  ^~~~
> drivers/staging/most/video/video.c: In function 'vidioc_g_std':
> drivers/staging/most/video/video.c:309:25: warning: unused variable 'mdev' 
> [-Wunused-variable]
>   struct most_video_dev *mdev = fh->mdev;
>  ^~~~
> 
> Introduced by commit
> 
>   7d7cdb4fa552 ("staging: most: video: remove debugging code")

Sorry about this.  This warning, and the other one in the staging tree,
were not noticed by me due to my system updating to gcc-8 and the huge
numbers of warnings it produced.  Then 0-day went on a bender and didn't
spit out anything for a few days...

I'll go fix this up now, thanks for the report.

greg k-h

linux-next: build warnings after merge of the staging tree

[Stephen Rothwell]

Hi Greg,

After merging the staging tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/staging/most/video/video.c: In function 'vidioc_enum_fmt_vid_cap':
drivers/staging/most/video/video.c:265:25: warning: unused variable 'mdev' 
[-Wunused-variable]
  struct most_video_dev *mdev = fh->mdev;
 ^~~~
drivers/staging/most/video/video.c: In function 'vidioc_g_fmt_vid_cap':
drivers/staging/most/video/video.c:282:25: warning: unused variable 'mdev' 
[-Wunused-variable]
  struct most_video_dev *mdev = fh->mdev;
 ^~~~
drivers/staging/most/video/video.c: In function 'vidioc_g_std':
drivers/staging/most/video/video.c:309:25: warning: unused variable 'mdev' 
[-Wunused-variable]
  struct most_video_dev *mdev = fh->mdev;
 ^~~~

Introduced by commit

  7d7cdb4fa552 ("staging: most: video: remove debugging code")

-- 
Cheers,
Stephen Rothwell


pgp684TdcDKZd.pgp
Description: OpenPGP digital signature

linux-next: build warnings after merge of the staging tree

[Stephen Rothwell]

Hi Greg,

After merging the staging tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/staging/most/video/video.c: In function 'vidioc_enum_fmt_vid_cap':
drivers/staging/most/video/video.c:265:25: warning: unused variable 'mdev' 
[-Wunused-variable]
  struct most_video_dev *mdev = fh->mdev;
 ^~~~
drivers/staging/most/video/video.c: In function 'vidioc_g_fmt_vid_cap':
drivers/staging/most/video/video.c:282:25: warning: unused variable 'mdev' 
[-Wunused-variable]
  struct most_video_dev *mdev = fh->mdev;
 ^~~~
drivers/staging/most/video/video.c: In function 'vidioc_g_std':
drivers/staging/most/video/video.c:309:25: warning: unused variable 'mdev' 
[-Wunused-variable]
  struct most_video_dev *mdev = fh->mdev;
 ^~~~

Introduced by commit

  7d7cdb4fa552 ("staging: most: video: remove debugging code")

-- 
Cheers,
Stephen Rothwell


pgp684TdcDKZd.pgp
Description: OpenPGP digital signature

linux-next: build warnings after merge of the staging tree

[Stephen Rothwell]

Hi Greg,

After merging the staging tree, today's linux-next build (x86_64
allmodconfig) produced these warnings:

drivers/staging/rtlwifi/base.c: In function 'rtl_watch_dog_timer_callback':
drivers/staging/rtlwifi/base.c:2167:23: warning: unused variable 'hw' 
[-Wunused-variable]
  struct ieee80211_hw *hw = rtlpriv->hw;
   ^
drivers/staging/rtl8723bs/hal/hal_btcoex.c: In function 'hal_btcoex_Initialize':
drivers/staging/rtl8723bs/hal/hal_btcoex.c:1415:5: warning: unused variable 
'ret2' [-Wunused-variable]
  u8 ret2;
 ^
drivers/staging/rtl8723bs/hal/hal_btcoex.c:1414:5: warning: unused variable 
'ret1' [-Wunused-variable]
  u8 ret1;
 ^

Introduced by commits

  f8af6a323368 ("staging: rtlwifi: Convert timers to use timer_setup()")
  95b3b4238581 ("staging: rtl8723bs: remove ternary operators in assignmet 
statments")

-- 
Cheers,
Stephen Rothwell

linux-next: build warnings after merge of the staging tree

[Stephen Rothwell]

Hi Greg,

After merging the staging tree, today's linux-next build (x86_64
allmodconfig) produced these warnings:

drivers/staging/rtlwifi/base.c: In function 'rtl_watch_dog_timer_callback':
drivers/staging/rtlwifi/base.c:2167:23: warning: unused variable 'hw' 
[-Wunused-variable]
  struct ieee80211_hw *hw = rtlpriv->hw;
   ^
drivers/staging/rtl8723bs/hal/hal_btcoex.c: In function 'hal_btcoex_Initialize':
drivers/staging/rtl8723bs/hal/hal_btcoex.c:1415:5: warning: unused variable 
'ret2' [-Wunused-variable]
  u8 ret2;
 ^
drivers/staging/rtl8723bs/hal/hal_btcoex.c:1414:5: warning: unused variable 
'ret1' [-Wunused-variable]
  u8 ret1;
 ^

Introduced by commits

  f8af6a323368 ("staging: rtlwifi: Convert timers to use timer_setup()")
  95b3b4238581 ("staging: rtl8723bs: remove ternary operators in assignmet 
statments")

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warnings after merge of the staging tree

[Stephen Rothwell]

Hi Mauro,

On Wed, 9 Aug 2017 11:25:22 +1000 Stephen Rothwell  
wrote:
>
> On Mon, 31 Jul 2017 15:02:27 +1000 Stephen Rothwell  
> wrote:
> >
> > After merging the staging tree, today's linux-next build (x86_64
> > allmodconfig) produced this warning:
> > 
> > drivers/staging/media/atomisp/i2c/imx/imx.c:1087:12: warning: 
> > 'imx_vcm_power_up' defined but not used [-Wunused-function]
> >  static int imx_vcm_power_up(struct v4l2_subdev *sd)
> > ^
> > drivers/staging/media/atomisp/i2c/imx/imx.c:1095:12: warning: 
> > 'imx_vcm_power_down' defined but not used [-Wunused-function]
> >  static int imx_vcm_power_down(struct v4l2_subdev *sd)
> > ^
> > drivers/staging/media/atomisp/i2c/imx/imx.c:1103:12: warning: 
> > 'imx_vcm_init' defined but not used [-Wunused-function]
> >  static int imx_vcm_init(struct v4l2_subdev *sd)
> > ^
> > drivers/staging/media/atomisp/i2c/imx/imx.c::12: warning: 
> > 'imx_t_focus_vcm' defined but not used [-Wunused-function]
> >  static int imx_t_focus_vcm(struct v4l2_subdev *sd, u16 val)
> > ^
> > 
> > Introduced by commit
> > 
> >   9a5a6911aa3f ("staging: imx: fix non-static declarations")  
> 
> There is now another copy of this commit in the v4l-dvb tree producing
> the same warnings :-(

Any chance this will be fixed in the v4l-dvb tree?
-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warnings after merge of the staging tree

[Stephen Rothwell]

Hi Mauro,

On Wed, 9 Aug 2017 11:25:22 +1000 Stephen Rothwell  
wrote:
>
> On Mon, 31 Jul 2017 15:02:27 +1000 Stephen Rothwell  
> wrote:
> >
> > After merging the staging tree, today's linux-next build (x86_64
> > allmodconfig) produced this warning:
> > 
> > drivers/staging/media/atomisp/i2c/imx/imx.c:1087:12: warning: 
> > 'imx_vcm_power_up' defined but not used [-Wunused-function]
> >  static int imx_vcm_power_up(struct v4l2_subdev *sd)
> > ^
> > drivers/staging/media/atomisp/i2c/imx/imx.c:1095:12: warning: 
> > 'imx_vcm_power_down' defined but not used [-Wunused-function]
> >  static int imx_vcm_power_down(struct v4l2_subdev *sd)
> > ^
> > drivers/staging/media/atomisp/i2c/imx/imx.c:1103:12: warning: 
> > 'imx_vcm_init' defined but not used [-Wunused-function]
> >  static int imx_vcm_init(struct v4l2_subdev *sd)
> > ^
> > drivers/staging/media/atomisp/i2c/imx/imx.c::12: warning: 
> > 'imx_t_focus_vcm' defined but not used [-Wunused-function]
> >  static int imx_t_focus_vcm(struct v4l2_subdev *sd, u16 val)
> > ^
> > 
> > Introduced by commit
> > 
> >   9a5a6911aa3f ("staging: imx: fix non-static declarations")  
> 
> There is now another copy of this commit in the v4l-dvb tree producing
> the same warnings :-(

Any chance this will be fixed in the v4l-dvb tree?
-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warnings after merge of the staging tree

[JB Van Puyvelde]

On Thu, 17 Aug 2017 10:57:43 -0700
Greg KH  wrote:

> On Mon, Jul 31, 2017 at 03:02:27PM +1000, Stephen Rothwell wrote:
> > Hi Greg,
> > 
> > After merging the staging tree, today's linux-next build (x86_64
> > allmodconfig) produced this warning:
> > 
> > drivers/staging/media/atomisp/i2c/imx/imx.c:1087:12: warning: 
> > 'imx_vcm_power_up' defined but not used [-Wunused-function]
> >  static int imx_vcm_power_up(struct v4l2_subdev *sd)
> > ^
> > drivers/staging/media/atomisp/i2c/imx/imx.c:1095:12: warning: 
> > 'imx_vcm_power_down' defined but not used [-Wunused-function]
> >  static int imx_vcm_power_down(struct v4l2_subdev *sd)
> > ^
> > drivers/staging/media/atomisp/i2c/imx/imx.c:1103:12: warning: 
> > 'imx_vcm_init' defined but not used [-Wunused-function]
> >  static int imx_vcm_init(struct v4l2_subdev *sd)
> > ^
> > drivers/staging/media/atomisp/i2c/imx/imx.c::12: warning: 
> > 'imx_t_focus_vcm' defined but not used [-Wunused-function]
> >  static int imx_t_focus_vcm(struct v4l2_subdev *sd, u16 val)
> > ^
> > 
> > Introduced by commit
> > 
> >   9a5a6911aa3f ("staging: imx: fix non-static declarations")  
> 
> Sorry for the delay, now dropped from my tree, I shouldn't have taken it
> in the first place :(
> 
> greg k-h

Hi,

Sorry about that. I will be more careful next time.

JB

Re: linux-next: build warnings after merge of the staging tree

[JB Van Puyvelde]

On Thu, 17 Aug 2017 10:57:43 -0700
Greg KH  wrote:

> On Mon, Jul 31, 2017 at 03:02:27PM +1000, Stephen Rothwell wrote:
> > Hi Greg,
> > 
> > After merging the staging tree, today's linux-next build (x86_64
> > allmodconfig) produced this warning:
> > 
> > drivers/staging/media/atomisp/i2c/imx/imx.c:1087:12: warning: 
> > 'imx_vcm_power_up' defined but not used [-Wunused-function]
> >  static int imx_vcm_power_up(struct v4l2_subdev *sd)
> > ^
> > drivers/staging/media/atomisp/i2c/imx/imx.c:1095:12: warning: 
> > 'imx_vcm_power_down' defined but not used [-Wunused-function]
> >  static int imx_vcm_power_down(struct v4l2_subdev *sd)
> > ^
> > drivers/staging/media/atomisp/i2c/imx/imx.c:1103:12: warning: 
> > 'imx_vcm_init' defined but not used [-Wunused-function]
> >  static int imx_vcm_init(struct v4l2_subdev *sd)
> > ^
> > drivers/staging/media/atomisp/i2c/imx/imx.c::12: warning: 
> > 'imx_t_focus_vcm' defined but not used [-Wunused-function]
> >  static int imx_t_focus_vcm(struct v4l2_subdev *sd, u16 val)
> > ^
> > 
> > Introduced by commit
> > 
> >   9a5a6911aa3f ("staging: imx: fix non-static declarations")  
> 
> Sorry for the delay, now dropped from my tree, I shouldn't have taken it
> in the first place :(
> 
> greg k-h

Hi,

Sorry about that. I will be more careful next time.

JB

Re: linux-next: build warnings after merge of the staging tree

[Greg KH]

On Mon, Jul 31, 2017 at 03:02:27PM +1000, Stephen Rothwell wrote:
> Hi Greg,
> 
> After merging the staging tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> drivers/staging/media/atomisp/i2c/imx/imx.c:1087:12: warning: 
> 'imx_vcm_power_up' defined but not used [-Wunused-function]
>  static int imx_vcm_power_up(struct v4l2_subdev *sd)
> ^
> drivers/staging/media/atomisp/i2c/imx/imx.c:1095:12: warning: 
> 'imx_vcm_power_down' defined but not used [-Wunused-function]
>  static int imx_vcm_power_down(struct v4l2_subdev *sd)
> ^
> drivers/staging/media/atomisp/i2c/imx/imx.c:1103:12: warning: 'imx_vcm_init' 
> defined but not used [-Wunused-function]
>  static int imx_vcm_init(struct v4l2_subdev *sd)
> ^
> drivers/staging/media/atomisp/i2c/imx/imx.c::12: warning: 
> 'imx_t_focus_vcm' defined but not used [-Wunused-function]
>  static int imx_t_focus_vcm(struct v4l2_subdev *sd, u16 val)
> ^
> 
> Introduced by commit
> 
>   9a5a6911aa3f ("staging: imx: fix non-static declarations")

Sorry for the delay, now dropped from my tree, I shouldn't have taken it
in the first place :(

greg k-h

Re: linux-next: build warnings after merge of the staging tree

[Greg KH]

On Mon, Jul 31, 2017 at 03:02:27PM +1000, Stephen Rothwell wrote:
> Hi Greg,
> 
> After merging the staging tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> drivers/staging/media/atomisp/i2c/imx/imx.c:1087:12: warning: 
> 'imx_vcm_power_up' defined but not used [-Wunused-function]
>  static int imx_vcm_power_up(struct v4l2_subdev *sd)
> ^
> drivers/staging/media/atomisp/i2c/imx/imx.c:1095:12: warning: 
> 'imx_vcm_power_down' defined but not used [-Wunused-function]
>  static int imx_vcm_power_down(struct v4l2_subdev *sd)
> ^
> drivers/staging/media/atomisp/i2c/imx/imx.c:1103:12: warning: 'imx_vcm_init' 
> defined but not used [-Wunused-function]
>  static int imx_vcm_init(struct v4l2_subdev *sd)
> ^
> drivers/staging/media/atomisp/i2c/imx/imx.c::12: warning: 
> 'imx_t_focus_vcm' defined but not used [-Wunused-function]
>  static int imx_t_focus_vcm(struct v4l2_subdev *sd, u16 val)
> ^
> 
> Introduced by commit
> 
>   9a5a6911aa3f ("staging: imx: fix non-static declarations")

Sorry for the delay, now dropped from my tree, I shouldn't have taken it
in the first place :(

greg k-h

Re: linux-next: build warnings after merge of the staging tree

[Stephen Rothwell]

Hi all,

On Mon, 31 Jul 2017 15:02:27 +1000 Stephen Rothwell  
wrote:
>
> After merging the staging tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> drivers/staging/media/atomisp/i2c/imx/imx.c:1087:12: warning: 
> 'imx_vcm_power_up' defined but not used [-Wunused-function]
>  static int imx_vcm_power_up(struct v4l2_subdev *sd)
> ^
> drivers/staging/media/atomisp/i2c/imx/imx.c:1095:12: warning: 
> 'imx_vcm_power_down' defined but not used [-Wunused-function]
>  static int imx_vcm_power_down(struct v4l2_subdev *sd)
> ^
> drivers/staging/media/atomisp/i2c/imx/imx.c:1103:12: warning: 'imx_vcm_init' 
> defined but not used [-Wunused-function]
>  static int imx_vcm_init(struct v4l2_subdev *sd)
> ^
> drivers/staging/media/atomisp/i2c/imx/imx.c::12: warning: 
> 'imx_t_focus_vcm' defined but not used [-Wunused-function]
>  static int imx_t_focus_vcm(struct v4l2_subdev *sd, u16 val)
> ^
> 
> Introduced by commit
> 
>   9a5a6911aa3f ("staging: imx: fix non-static declarations")

There is now another copy of this commit in the v4l-dvb tree producing
the same warnings :-(

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warnings after merge of the staging tree

[Stephen Rothwell]

Hi all,

On Mon, 31 Jul 2017 15:02:27 +1000 Stephen Rothwell  
wrote:
>
> After merging the staging tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> drivers/staging/media/atomisp/i2c/imx/imx.c:1087:12: warning: 
> 'imx_vcm_power_up' defined but not used [-Wunused-function]
>  static int imx_vcm_power_up(struct v4l2_subdev *sd)
> ^
> drivers/staging/media/atomisp/i2c/imx/imx.c:1095:12: warning: 
> 'imx_vcm_power_down' defined but not used [-Wunused-function]
>  static int imx_vcm_power_down(struct v4l2_subdev *sd)
> ^
> drivers/staging/media/atomisp/i2c/imx/imx.c:1103:12: warning: 'imx_vcm_init' 
> defined but not used [-Wunused-function]
>  static int imx_vcm_init(struct v4l2_subdev *sd)
> ^
> drivers/staging/media/atomisp/i2c/imx/imx.c::12: warning: 
> 'imx_t_focus_vcm' defined but not used [-Wunused-function]
>  static int imx_t_focus_vcm(struct v4l2_subdev *sd, u16 val)
> ^
> 
> Introduced by commit
> 
>   9a5a6911aa3f ("staging: imx: fix non-static declarations")

There is now another copy of this commit in the v4l-dvb tree producing
the same warnings :-(

-- 
Cheers,
Stephen Rothwell

linux-next: build warnings after merge of the staging tree

[Stephen Rothwell]

Hi Greg,

After merging the staging tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/staging/media/atomisp/i2c/imx/imx.c:1087:12: warning: 
'imx_vcm_power_up' defined but not used [-Wunused-function]
 static int imx_vcm_power_up(struct v4l2_subdev *sd)
^
drivers/staging/media/atomisp/i2c/imx/imx.c:1095:12: warning: 
'imx_vcm_power_down' defined but not used [-Wunused-function]
 static int imx_vcm_power_down(struct v4l2_subdev *sd)
^
drivers/staging/media/atomisp/i2c/imx/imx.c:1103:12: warning: 'imx_vcm_init' 
defined but not used [-Wunused-function]
 static int imx_vcm_init(struct v4l2_subdev *sd)
^
drivers/staging/media/atomisp/i2c/imx/imx.c::12: warning: 'imx_t_focus_vcm' 
defined but not used [-Wunused-function]
 static int imx_t_focus_vcm(struct v4l2_subdev *sd, u16 val)
^

Introduced by commit

  9a5a6911aa3f ("staging: imx: fix non-static declarations")

-- 
Cheers,
Stephen Rothwell

linux-next: build warnings after merge of the staging tree

[Stephen Rothwell]

Hi Greg,

After merging the staging tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/staging/media/atomisp/i2c/imx/imx.c:1087:12: warning: 
'imx_vcm_power_up' defined but not used [-Wunused-function]
 static int imx_vcm_power_up(struct v4l2_subdev *sd)
^
drivers/staging/media/atomisp/i2c/imx/imx.c:1095:12: warning: 
'imx_vcm_power_down' defined but not used [-Wunused-function]
 static int imx_vcm_power_down(struct v4l2_subdev *sd)
^
drivers/staging/media/atomisp/i2c/imx/imx.c:1103:12: warning: 'imx_vcm_init' 
defined but not used [-Wunused-function]
 static int imx_vcm_init(struct v4l2_subdev *sd)
^
drivers/staging/media/atomisp/i2c/imx/imx.c::12: warning: 'imx_t_focus_vcm' 
defined but not used [-Wunused-function]
 static int imx_t_focus_vcm(struct v4l2_subdev *sd, u16 val)
^

Introduced by commit

  9a5a6911aa3f ("staging: imx: fix non-static declarations")

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warnings after merge of the staging tree

[Greg KH]

On Sat, Jun 20, 2015 at 08:48:26PM +1000, Stephen Rothwell wrote:
> Hi Greg,
> 
> On Mon, 1 Jun 2015 18:50:12 +1000 Stephen Rothwell  
> wrote:
> >
> > On Fri, 29 May 2015 20:40:02 +1000 Stephen Rothwell  
> > wrote:
> > >
> > > After merging the staging tree, today's linux-next build (x86_64
> > > allmodconfig) produced a large number of warnings in
> > > drivers/staging/wilc1000.
> > 
> > Since there are so many warnings, I have disabled the driver for now.
> 
> I tried building this with the driver enabled but it still produces and
> inordinate number of warnings, so I have disabled it again.  Please
> either get them sorted out or disable this driver before asking Linus
> to merge it.

Yeah, I know, I keep asking the driver authors for fixes, but nothing
has shown up yet except cosmetic changes.  I'm going to disable it as no
one seems willing to do the work, which is sad.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build warnings after merge of the staging tree

[Stephen Rothwell]

Hi Greg,

On Mon, 1 Jun 2015 18:50:12 +1000 Stephen Rothwell  
wrote:
>
> On Fri, 29 May 2015 20:40:02 +1000 Stephen Rothwell  
> wrote:
> >
> > After merging the staging tree, today's linux-next build (x86_64
> > allmodconfig) produced a large number of warnings in
> > drivers/staging/wilc1000.
> 
> Since there are so many warnings, I have disabled the driver for now.

I tried building this with the driver enabled but it still produces and
inordinate number of warnings, so I have disabled it again.  Please
either get them sorted out or disable this driver before asking Linus
to merge it.

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgps9Yu1C6XLd.pgp
Description: OpenPGP digital signature

Re: linux-next: build warnings after merge of the staging tree

[Stephen Rothwell]

Hi Greg,

On Mon, 1 Jun 2015 18:50:12 +1000 Stephen Rothwell s...@canb.auug.org.au 
wrote:

 On Fri, 29 May 2015 20:40:02 +1000 Stephen Rothwell s...@canb.auug.org.au 
 wrote:
 
  After merging the staging tree, today's linux-next build (x86_64
  allmodconfig) produced a large number of warnings in
  drivers/staging/wilc1000.
 
 Since there are so many warnings, I have disabled the driver for now.

I tried building this with the driver enabled but it still produces and
inordinate number of warnings, so I have disabled it again.  Please
either get them sorted out or disable this driver before asking Linus
to merge it.

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgps9Yu1C6XLd.pgp
Description: OpenPGP digital signature

Re: linux-next: build warnings after merge of the staging tree

[Greg KH]

On Sat, Jun 20, 2015 at 08:48:26PM +1000, Stephen Rothwell wrote:
 Hi Greg,
 
 On Mon, 1 Jun 2015 18:50:12 +1000 Stephen Rothwell s...@canb.auug.org.au 
 wrote:
 
  On Fri, 29 May 2015 20:40:02 +1000 Stephen Rothwell s...@canb.auug.org.au 
  wrote:
  
   After merging the staging tree, today's linux-next build (x86_64
   allmodconfig) produced a large number of warnings in
   drivers/staging/wilc1000.
  
  Since there are so many warnings, I have disabled the driver for now.
 
 I tried building this with the driver enabled but it still produces and
 inordinate number of warnings, so I have disabled it again.  Please
 either get them sorted out or disable this driver before asking Linus
 to merge it.

Yeah, I know, I keep asking the driver authors for fixes, but nothing
has shown up yet except cosmetic changes.  I'm going to disable it as no
one seems willing to do the work, which is sad.

greg k-h
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build warnings after merge of the staging tree

[Stephen Rothwell]

Hi Greg,

On Fri, 29 May 2015 20:40:02 +1000 Stephen Rothwell  
wrote:
>
> After merging the staging tree, today's linux-next build (x86_64
> allmodconfig) produced a large number of warnings in
> drivers/staging/wilc1000.

Since there are so many warnings, I have disabled the driver for now.
-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgpTVuH_w3GSq.pgp
Description: OpenPGP digital signature

Re: linux-next: build warnings after merge of the staging tree

[Stephen Rothwell]

Hi Greg,

On Fri, 29 May 2015 20:40:02 +1000 Stephen Rothwell s...@canb.auug.org.au 
wrote:

 After merging the staging tree, today's linux-next build (x86_64
 allmodconfig) produced a large number of warnings in
 drivers/staging/wilc1000.

Since there are so many warnings, I have disabled the driver for now.
-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgpTVuH_w3GSq.pgp
Description: OpenPGP digital signature

linux-next: build warnings after merge of the staging tree

[Stephen Rothwell]

Hi Greg,

After merging the staging tree, today's linux-next build (x86_64
allmodconfig) produced a large number of warnings in
drivers/staging/wilc1000.

like:

drivers/staging/wilc1000/wilc_wfi_cfgoperations.c: At top level:
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c:4184:2: warning: 
initialization from incompatible pointer type
  .add_station = WILC_WFI_add_station,
  ^
drivers/staging/wilc1000/linux_wlan.c: In function 'mac_open':
drivers/staging/wilc1000/linux_wlan.c:2140:51: warning: cast from pointer to 
integer of different size [-Wpointer-to-int-cast]
g_linux_wlan->strInterfaceInfo[i].drvHandler = 
(WILC_Uint32)priv->hWILCWFIDrv;
   ^
drivers/staging/wilc1000/host_interface.c:708:59: warning: cast from pointer to 
integer of different size [-Wpointer-to-int-cast]
  s32Error = SendConfigPkt(SET_CFG, , 1, WILC_TRUE, 
(WILC_Uint32)pstrWFIDrv);
   ^

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgpiVnkPB9nir.pgp
Description: OpenPGP digital signature

linux-next: build warnings after merge of the staging tree

[Stephen Rothwell]

Hi Greg,

After merging the staging tree, today's linux-next build (x86_64
allmodconfig) produced a large number of warnings in
drivers/staging/wilc1000.

like:

drivers/staging/wilc1000/wilc_wfi_cfgoperations.c: At top level:
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c:4184:2: warning: 
initialization from incompatible pointer type
  .add_station = WILC_WFI_add_station,
  ^
drivers/staging/wilc1000/linux_wlan.c: In function 'mac_open':
drivers/staging/wilc1000/linux_wlan.c:2140:51: warning: cast from pointer to 
integer of different size [-Wpointer-to-int-cast]
g_linux_wlan-strInterfaceInfo[i].drvHandler = 
(WILC_Uint32)priv-hWILCWFIDrv;
   ^
drivers/staging/wilc1000/host_interface.c:708:59: warning: cast from pointer to 
integer of different size [-Wpointer-to-int-cast]
  s32Error = SendConfigPkt(SET_CFG, strWID, 1, WILC_TRUE, 
(WILC_Uint32)pstrWFIDrv);
   ^

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgpiVnkPB9nir.pgp
Description: OpenPGP digital signature

Re: linux-next: build warnings after merge of the staging tree

[Julia Lawall]

On Wed, 6 May 2015, Stephen Rothwell wrote:

> Hi Greg,
>
> After merging the staging tree, today's linux-next build (x86_64
> allmodconfig) produced these warnings:
>
> drivers/staging/lustre/lustre/llite/file.c: In function 
> 'll_iocontrol_unregister':
> drivers/staging/lustre/lustre/llite/file.c:3249:17: warning: unused variable 
> 'size' [-Wunused-variable]
> unsigned int size = tmp->iocd_size;
>  ^
> drivers/staging/lustre/lustre/llite/llite_lib.c: In function 'll_fill_super':
> drivers/staging/lustre/lustre/llite/llite_lib.c:912:12: warning: unused 
> variable 'instlen' [-Wunused-variable]
>   const int instlen = sizeof(cfg->cfg_instance) * 2 + 2;
> ^
>
> Introduced by commit 97903a26fcfc ("staging: lustre: llite: drop uses
> of OBD free functions").

Sorry for not having noticed.  I will take care of it as soon as possible.

julia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build warnings after merge of the staging tree

[Julia Lawall]

On Wed, 6 May 2015, Stephen Rothwell wrote:

 Hi Greg,

 After merging the staging tree, today's linux-next build (x86_64
 allmodconfig) produced these warnings:

 drivers/staging/lustre/lustre/llite/file.c: In function 
 'll_iocontrol_unregister':
 drivers/staging/lustre/lustre/llite/file.c:3249:17: warning: unused variable 
 'size' [-Wunused-variable]
 unsigned int size = tmp-iocd_size;
  ^
 drivers/staging/lustre/lustre/llite/llite_lib.c: In function 'll_fill_super':
 drivers/staging/lustre/lustre/llite/llite_lib.c:912:12: warning: unused 
 variable 'instlen' [-Wunused-variable]
   const int instlen = sizeof(cfg-cfg_instance) * 2 + 2;
 ^

 Introduced by commit 97903a26fcfc (staging: lustre: llite: drop uses
 of OBD free functions).

Sorry for not having noticed.  I will take care of it as soon as possible.

julia
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

linux-next: build warnings after merge of the staging tree

[Stephen Rothwell]

Hi Greg,

After merging the staging tree, today's linux-next build (x86_64
allmodconfig) produced these warnings:

drivers/staging/lustre/lustre/llite/file.c: In function 
'll_iocontrol_unregister':
drivers/staging/lustre/lustre/llite/file.c:3249:17: warning: unused variable 
'size' [-Wunused-variable]
unsigned int size = tmp->iocd_size;
 ^
drivers/staging/lustre/lustre/llite/llite_lib.c: In function 'll_fill_super':
drivers/staging/lustre/lustre/llite/llite_lib.c:912:12: warning: unused 
variable 'instlen' [-Wunused-variable]
  const int instlen = sizeof(cfg->cfg_instance) * 2 + 2;
^

Introduced by commit 97903a26fcfc ("staging: lustre: llite: drop uses
of OBD free functions").

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgpjFbNBtYPW1.pgp
Description: OpenPGP digital signature

linux-next: build warnings after merge of the staging tree

[Stephen Rothwell]

Hi Greg,

After merging the staging tree, today's linux-next build (x86_64
allmodconfig) produced these warnings:

drivers/staging/lustre/lustre/llite/file.c: In function 
'll_iocontrol_unregister':
drivers/staging/lustre/lustre/llite/file.c:3249:17: warning: unused variable 
'size' [-Wunused-variable]
unsigned int size = tmp-iocd_size;
 ^
drivers/staging/lustre/lustre/llite/llite_lib.c: In function 'll_fill_super':
drivers/staging/lustre/lustre/llite/llite_lib.c:912:12: warning: unused 
variable 'instlen' [-Wunused-variable]
  const int instlen = sizeof(cfg-cfg_instance) * 2 + 2;
^

Introduced by commit 97903a26fcfc (staging: lustre: llite: drop uses
of OBD free functions).

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgpjFbNBtYPW1.pgp
Description: OpenPGP digital signature