On 29/08/2019 10:14:18+0800, Biwen Li wrote:
> Issue:
> - # hwclock -w
> hwclock: RTC_SET_TIME: Invalid argument
>
> Why:
> - Relative commit: 8b9f9d4dc511309918c4f6793bae7387c0c638af, this patch
> will always check for unwritable registers, it will compare reg
> with max
On 8/29/19 5:14 AM, Biwen Li wrote:
Issue:
- # hwclock -w
hwclock: RTC_SET_TIME: Invalid argument
Why:
- Relative commit: 8b9f9d4dc511309918c4f6793bae7387c0c638af, this patch
will always check for unwritable registers, it will compare reg
with max_register in regma
Issue:
- # hwclock -w
hwclock: RTC_SET_TIME: Invalid argument
Why:
- Relative commit: 8b9f9d4dc511309918c4f6793bae7387c0c638af, this patch
will always check for unwritable registers, it will compare reg
with max_register in regmap_writeable.
- The pcf85363/pcf85263 h
>
> On 8/27/19 7:37 AM, Biwen Li wrote:
> > - In drivers/rtc/rtc-pcf85363.c, CTRL_STOP_EN is 0x2e, but DT_100THS
> >is 0, max_regiter is 0x2f, then reg will be equal to 0x30,
> >'0x30 < 0x2f' is false,so regmap_writeable will return false.
> >
> > - The pcf85363/pcf85263 has
On 8/27/19 7:37 AM, Biwen Li wrote:
- In drivers/rtc/rtc-pcf85363.c, CTRL_STOP_EN is 0x2e, but DT_100THS
is 0, max_regiter is 0x2f, then reg will be equal to 0x30,
'0x30 < 0x2f' is false,so regmap_writeable will return false.
- The pcf85363/pcf85263 has the capability of add
Issue:
- # hwclock -w
hwclock: RTC_SET_TIME: Invalid argument
Why:
- Relative commit: 8b9f9d4dc511309918c4f6793bae7387c0c638af, this patch
will always check for unwritable registers, it will compare reg
with max_register in regmap_writeable.
- In drivers/rtc/rtc-pcf8
>
> Hi,
>
> On 26/08/2019 09:49:49+, Biwen Li wrote:
> > >
> > > On 8/26/19 7:29 AM, Biwen Li wrote:
> > > >>
> > > >> On 8/16/19 10:40 PM, Li Yang wrote:
> > > >>> On Fri, Aug 16, 2019 at 11:30 AM Alexandre Belloni
> > > >>> wrote:
> > >
> > > On 16/08/2019 10:50:49-0500, Li Yang
Hi,
On 26/08/2019 09:49:49+, Biwen Li wrote:
> >
> > On 8/26/19 7:29 AM, Biwen Li wrote:
> > >>
> > >> On 8/16/19 10:40 PM, Li Yang wrote:
> > >>> On Fri, Aug 16, 2019 at 11:30 AM Alexandre Belloni
> > >>> wrote:
> >
> > On 16/08/2019 10:50:49-0500, Li Yang wrote:
> > > On Fri,
>
> On 8/26/19 7:29 AM, Biwen Li wrote:
> >>
> >> On 8/16/19 10:40 PM, Li Yang wrote:
> >>> On Fri, Aug 16, 2019 at 11:30 AM Alexandre Belloni
> >>> wrote:
>
> On 16/08/2019 10:50:49-0500, Li Yang wrote:
> > On Fri, Aug 16, 2019 at 3:05 AM Alexandre Belloni
> > wrote:
> >>
On 8/26/19 7:29 AM, Biwen Li wrote:
On 8/16/19 10:40 PM, Li Yang wrote:
On Fri, Aug 16, 2019 at 11:30 AM Alexandre Belloni
wrote:
On 16/08/2019 10:50:49-0500, Li Yang wrote:
On Fri, Aug 16, 2019 at 3:05 AM Alexandre Belloni
wrote:
On 16/08/2019 10:46:36+0800, Biwen Li wrote:
Issue:
Issue:
- hwclock -w
hwclock: RTC_SET_TIME: Invalid argument
Why:
- Relative patch: https://lkml.org/lkml/2019/4/3/55 , this patch
will always check for unwritable registers, it will compare reg
with max_register in regmap_writeable.
- In drivers/rtc/rtc-pcf85363.c, CT
>
> On 8/16/19 10:40 PM, Li Yang wrote:
> > On Fri, Aug 16, 2019 at 11:30 AM Alexandre Belloni
> > wrote:
> >>
> >> On 16/08/2019 10:50:49-0500, Li Yang wrote:
> >>> On Fri, Aug 16, 2019 at 3:05 AM Alexandre Belloni
> >>> wrote:
>
> On 16/08/2019 10:46:36+0800, Biwen Li wrote:
> >
On Wed, Aug 21, 2019 at 01:38:56PM +0200, Alexandre Belloni wrote:
> On 21/08/2019 12:30:29+0100, Mark Brown wrote:
> > What's the mechanism here? It's a very strange thing to require.
> The clock control is on the first register, then you have sec, min,
> hour, day, mon, year.
> To be able to
On 21/08/2019 12:30:29+0100, Mark Brown wrote:
> On Wed, Aug 21, 2019 at 01:24:13PM +0200, Alexandre Belloni wrote:
> > On 21/08/2019 12:21:42+0100, Mark Brown wrote:
> > > On Tue, Aug 20, 2019 at 01:33:14PM -0500, Li Yang wrote:
>
> > > > violation check of regmap rejects such access. According
On Wed, Aug 21, 2019 at 01:24:13PM +0200, Alexandre Belloni wrote:
> On 21/08/2019 12:21:42+0100, Mark Brown wrote:
> > On Tue, Aug 20, 2019 at 01:33:14PM -0500, Li Yang wrote:
> > > violation check of regmap rejects such access. According to
> > > Alexcandre, the address wrapping is essential to
On 21/08/2019 12:21:42+0100, Mark Brown wrote:
> On Tue, Aug 20, 2019 at 01:33:14PM -0500, Li Yang wrote:
>
> > Some of the RTC hardware has the capability of address wrapping which
> > means if you access a continuous address range across a certain
> > boundary(could be the boundary of a regmap r
On Tue, Aug 20, 2019 at 01:33:14PM -0500, Li Yang wrote:
> Some of the RTC hardware has the capability of address wrapping which
> means if you access a continuous address range across a certain
> boundary(could be the boundary of a regmap region) the hardware
> actually wrap the access to a lower
On 8/16/19 10:40 PM, Li Yang wrote:
On Fri, Aug 16, 2019 at 11:30 AM Alexandre Belloni
wrote:
On 16/08/2019 10:50:49-0500, Li Yang wrote:
On Fri, Aug 16, 2019 at 3:05 AM Alexandre Belloni
wrote:
On 16/08/2019 10:46:36+0800, Biwen Li wrote:
Issue:
- # hwclock -w
hwclock: RTC_SE
On Tue, Aug 20, 2019 at 1:24 PM Mark Brown wrote:
>
> On Fri, Aug 16, 2019 at 02:40:47PM -0500, Li Yang wrote:
> > On Fri, Aug 16, 2019 at 11:30 AM Alexandre Belloni
>
> > > Most of the i2c RTCs do address wrapping which is sometimes the only way
> > > to properly set the time.
>
> > Adding Mark a
On Fri, Aug 16, 2019 at 02:40:47PM -0500, Li Yang wrote:
> On Fri, Aug 16, 2019 at 11:30 AM Alexandre Belloni
> > Most of the i2c RTCs do address wrapping which is sometimes the only way
> > to properly set the time.
> Adding Mark and Nandor to the loop.
Is there a specific question or something
On Fri, Aug 16, 2019 at 11:30 AM Alexandre Belloni
wrote:
>
> On 16/08/2019 10:50:49-0500, Li Yang wrote:
> > On Fri, Aug 16, 2019 at 3:05 AM Alexandre Belloni
> > wrote:
> > >
> > > On 16/08/2019 10:46:36+0800, Biwen Li wrote:
> > > > Issue:
> > > > - # hwclock -w
> > > > hwclock: RTC_
On 16/08/2019 10:50:49-0500, Li Yang wrote:
> On Fri, Aug 16, 2019 at 3:05 AM Alexandre Belloni
> wrote:
> >
> > On 16/08/2019 10:46:36+0800, Biwen Li wrote:
> > > Issue:
> > > - # hwclock -w
> > > hwclock: RTC_SET_TIME: Invalid argument
> > >
> > > Why:
> > > - Relative patch: https
On Fri, Aug 16, 2019 at 3:05 AM Alexandre Belloni
wrote:
>
> On 16/08/2019 10:46:36+0800, Biwen Li wrote:
> > Issue:
> > - # hwclock -w
> > hwclock: RTC_SET_TIME: Invalid argument
> >
> > Why:
> > - Relative patch: https://lkml.org/lkml/2019/4/3/55 , this patch
> > will always
On 16/08/2019 10:46:36+0800, Biwen Li wrote:
> Issue:
> - # hwclock -w
> hwclock: RTC_SET_TIME: Invalid argument
>
> Why:
> - Relative patch: https://lkml.org/lkml/2019/4/3/55 , this patch
> will always check for unwritable registers, it will compare reg
> with max_regist
Issue:
- # hwclock -w
hwclock: RTC_SET_TIME: Invalid argument
Why:
- Relative patch: https://lkml.org/lkml/2019/4/3/55 , this patch
will always check for unwritable registers, it will compare reg
with max_register in regmap_writeable.
- In drivers/rtc/rtc-pcf85363.c,
> > > > Subject: rtc: pcf85363/pcf85263: fix error that failed to run
> > > > hwclock -w
> > > >
> > > > Issue:
> > > > # hwclock -w
> > > > hwclock: RTC_SET_TIME: Invalid argument
> > > >
> >
or that failed to run hwclock -w
>
> > > Subject: rtc: pcf85363/pcf85263: fix error that failed to run
> > > hwclock -w
> > >
> > > Issue:
> > > # hwclock -w
> > > hwclock: RTC_SET_TIME: Invalid argument
> > >
> > > Th
> Caution: EXT Email
>
> Hi,
>
> On 14/08/2019 17:32:49+0800, Biwen Li wrote:
> > Issue:
> > # hwclock -w
> > hwclock: RTC_SET_TIME: Invalid argument
> >
> > The patch fixes error when run command hwclock -w with rtc
> > pcf85363/pcf85263
> >
>
> Could you describe a bit more the issue a
> > Subject: rtc: pcf85363/pcf85263: fix error that failed to run hwclock
> > -w
> >
> > Issue:
> > # hwclock -w
> > hwclock: RTC_SET_TIME: Invalid argument
> >
> > The patch fixes error when run command hwclock -w with rtc
> > pcf85
> -Original Message-
> From: Biwen Li
> Sent: Wednesday, August 14, 2019 4:33 AM
> To: a.zu...@towertech.it; alexandre.bell...@bootlin.com; Leo Li
>
> Cc: linux-...@vger.kernel.org; linux-kernel@vger.kernel.org; Biwen Li
>
> Subject: rtc: pcf85363/pcf85263:
Hi,
On 14/08/2019 17:32:49+0800, Biwen Li wrote:
> Issue:
> # hwclock -w
> hwclock: RTC_SET_TIME: Invalid argument
>
> The patch fixes error when run command hwclock -w
> with rtc pcf85363/pcf85263
>
Could you describe a bit more the issue and what causes it?
IIRC I wrote that code and
Issue:
# hwclock -w
hwclock: RTC_SET_TIME: Invalid argument
The patch fixes error when run command hwclock -w
with rtc pcf85363/pcf85263
Signed-off-by: Biwen Li
---
drivers/rtc/rtc-pcf85363.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/rtc/rtc-pcf85
32 matches
Mail list logo