Re: stmmac: turn coalescing / NAPI off in stmmac

2016-12-05 Thread Pavel Machek
Hi! > >>>So patch currently looks like this (hand edited, can't be > >>>applied, got it working few hours ago). Does it look acceptable? > >>> > >>>I'd prefer this to go after the patch that pulls common code to single > >>>place, so that single place needs to be patched. Plus I guess I should > >

Re: stmmac: turn coalescing / NAPI off in stmmac

2016-12-02 Thread Giuseppe CAVALLARO
Hi Pavel On 12/2/2016 11:42 AM, Pavel Machek wrote: Hi! Anyway... since you asked. I belive I have way to disable NAPI / tx coalescing in the driver. Unfortunately, locking is missing on the rx path, and needs to be extended to _irqsave variant on tx path. I have just replied to a previous t

Re: stmmac: turn coalescing / NAPI off in stmmac

2016-12-02 Thread Pavel Machek
Hi! > >Anyway... since you asked. I belive I have way to disable NAPI / tx > >coalescing in the driver. Unfortunately, locking is missing on the rx > >path, and needs to be extended to _irqsave variant on tx path. > > I have just replied to a previous thread about that... Yeah, please reply to D

Re: stmmac: turn coalescing / NAPI off in stmmac

2016-12-02 Thread Giuseppe CAVALLARO
On 12/1/2016 11:48 PM, Pavel Machek wrote: @@ -2771,12 +2771,8 @@ static netdev_features_t stmmac_fix_features(struct net_device *dev, features &= ~NETIF_F_CSUM_MASK; /* Disable tso if asked by ethtool */ - if ((priv->plat->tso_en) && (priv->dma_cap.tsoen)) { -

stmmac: turn coalescing / NAPI off in stmmac

2016-12-01 Thread Pavel Machek
> > @@ -2771,12 +2771,8 @@ static netdev_features_t stmmac_fix_features(struct > > net_device *dev, > > features &= ~NETIF_F_CSUM_MASK; > > > > /* Disable tso if asked by ethtool */ > > - if ((priv->plat->tso_en) && (priv->dma_cap.tsoen)) { > > - if (features & NETIF