kselftest/next build: 6 builds: 0 failed, 6 passed, 1 warning (v6.9-8287-g31a59b76b978)

2024-05-16 Thread kernelci.org bot
kselftest/next build: 6 builds: 0 failed, 6 passed, 1 warning (v6.9-8287-g31a59b76b978) This legacy KernelCI providing this report will shutdown sometime soon in favor of our new KernelCI infra. Not all tests are being migrated. If you are still using this report and want us to prioritize your

Re: [PATCH v4 08/66] selftests/cgroup: Drop define _GNU_SOURCE

2024-05-16 Thread Shuah Khan
On 5/16/24 12:05, Shuah Khan wrote: On 5/16/24 11:45, Tejun Heo wrote: Hello, On Thu, May 16, 2024 at 10:31:13AM -0600, Shuah Khan wrote: I am exploring options and leaning towards reverting the patch daef47b89efd ("selftests: Compile kselftest headers with -D_GNU_SOURCE") Your amending the

Re: -D_GNU_SOURCE kselftest breakage in mainline

2024-05-16 Thread Shuah Khan
nding in mitigation fixes. I will hold off on your alsa patch: kselftest/alsa: Ensure _GNU_SOURCE is defined https://patchwork.kernel.org/project/linux-kselftest/patch/20240516-kselftest-fix-gnu-source-v1-1-e482ca6bf...@kernel.org/ There is no need to for the following patch kselftest:

Re: [PATCH net] selftests/net: reduce xfrm_policy test time

2024-05-16 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski : On Tue, 14 May 2024 17:52:27 +0800 you wrote: > The check_random_order test add/get plenty of xfrm rules, which consume > a lot time on debug kernel and always TIMEOUT. Let's reduce the test > loop and see if it works. >

[PATCH] selftest: rtc: Add to check rtc alarm status for alarm related test

2024-05-16 Thread Joseph Jang
In alarm_wkalm_set and alarm_wkalm_set_minute test, they use different ioctl (RTC_ALM_SET/RTC_WKALM_SET) for alarm feature detection. They will skip testing if RTC_ALM_SET/RTC_WKALM_SET ioctl returns an EINVAL error code. This design may miss detecting real problems when the efi.set_wakeup_time()

[PATCHv2 net] selftests/net: use tc rule to filter the na packet

2024-05-16 Thread Hangbin Liu
Test arp_ndisc_untracked_subnets use tcpdump to filter the unsolicited and untracked na messages. It set -e before calling tcpdump. But if tcpdump filters 0 packet, it will return none zero, and cause the script to exit. Instead of using slow tcpdump to capture packets, let's using tc rule to

Re: [PATCH v4 00/10] clk: Add kunit tests for fixed rate and parent data

2024-05-16 Thread Stephen Boyd
Quoting Rob Herring (2024-05-15 15:08:47) > On Wed, May 15, 2024 at 4:15 PM Stephen Boyd wrote: > > diff --git a/drivers/of/platform.c b/drivers/of/platform.c > > index 389d4ea6bfc1..acecefcfdba7 100644 > > --- a/drivers/of/platform.c > > +++ b/drivers/of/platform.c > > @@ -421,6 +421,7 @@ int

Re: [PATCH] kselftest: Desecalate reporting of missing _GNU_SOURCE

2024-05-16 Thread Kees Cook
On Thu, May 16, 2024 at 04:28:48PM +0100, Mark Brown wrote: > Commit daef47b89efd0b7 ("selftests: Compile kselftest headers with > -D_GNU_SOURCE") adds a static_assert() which means that things which > would be warnings about undeclared functions get escalated into build > failures. While we do

[PATCH v5] kunit: Cover 'assert.c' with tests

2024-05-16 Thread Ivan Orlov
There are multiple assertion formatting functions in the `assert.c` file, which are not covered with tests yet. Implement the KUnit test for these functions. The test consists of 11 test cases for the following functions: 1) 'is_literal' 2) 'is_str_literal' 3) 'kunit_assert_prologue', test case

Re: [PATCH v6 03/17] riscv: vector: Use vlenb from DT

2024-05-16 Thread Conor Dooley
On Thu, May 16, 2024 at 01:28:45PM -0700, Charlie Jenkins wrote: > On Thu, May 16, 2024 at 05:24:25PM +0100, Conor Dooley wrote: > > On Thu, May 16, 2024 at 10:00:12PM +0800, Andy Chiu wrote: > > > On Sat, May 4, 2024 at 2:21 AM Charlie Jenkins > > > wrote: > > > > > > + if

Re: [PATCH v6 03/17] riscv: vector: Use vlenb from DT

2024-05-16 Thread Charlie Jenkins
On Thu, May 16, 2024 at 05:24:25PM +0100, Conor Dooley wrote: > On Thu, May 16, 2024 at 10:00:12PM +0800, Andy Chiu wrote: > > On Sat, May 4, 2024 at 2:21 AM Charlie Jenkins wrote: > > > > + if (elf_hwcap & COMPAT_HWCAP_ISA_V && > > > has_riscv_homogeneous_vlenb() < 0) { > > > +

Re: [PATCH v4] kunit: Cover 'assert.c' with tests

2024-05-16 Thread Ivan Orlov
On 5/16/24 19:57, Rae Moar wrote: On Wed, May 15, 2024 at 10:20 AM Ivan Orlov wrote: There are multiple assertion formatting functions in the `assert.c` file, which are not covered with tests yet. Implement the KUnit test for these functions. The test consists of 11 test cases for the

Re: [PATCH v1 7/7] selftest: test system-wide workingset reporting

2024-05-16 Thread Muhammad Usama Anjum
On 5/4/24 1:30 AM, Yuanchu Xie wrote: > A basic test that verifies the working set size of a simple memory > accessor. It should work with or without the aging thread. > > Question: I don't know how to best test file memory in selftests. Is > there a place where I should put the temporary file?

[PATCH] kunit: tool: Build compile_commands.json

2024-05-16 Thread Brendan Jackman
end(make_options) if self._cross_compile: --- base-commit: 3c999d1ae3c75991902a1a7dad0cb62c2a3008b4 change-id: 20240516-kunit-compile-commands-d994074fc2be Best regards, -- Brendan Jackman

[PATCH] kunit: tool: Build compile_commands.json

2024-05-16 Thread Brendan Jackman
elf._linux_arch, + 'O=' + build_dir, '--jobs=' + str(jobs)] if make_options: command.extend(make_options) if self._cross_compile: --- base-commit: 3c999d1ae3c75991902a1a7dad0cb62c2a3008b4 change-id: 20240516-kunit-comp

Re: [PATCH v4] kunit: Cover 'assert.c' with tests

2024-05-16 Thread Rae Moar
On Wed, May 15, 2024 at 10:20 AM Ivan Orlov wrote: > > There are multiple assertion formatting functions in the `assert.c` > file, which are not covered with tests yet. Implement the KUnit test > for these functions. > > The test consists of 11 test cases for the following functions: > > 1)

Re: [PATCH v4 08/66] selftests/cgroup: Drop define _GNU_SOURCE

2024-05-16 Thread Shuah Khan
On 5/16/24 11:45, Tejun Heo wrote: Hello, On Thu, May 16, 2024 at 10:31:13AM -0600, Shuah Khan wrote: I am exploring options and leaning towards reverting the patch daef47b89efd ("selftests: Compile kselftest headers with -D_GNU_SOURCE") Your amending the PR helps me if I have to send

Re: [PATCH v4 08/66] selftests/cgroup: Drop define _GNU_SOURCE

2024-05-16 Thread Tejun Heo
Hello, On Thu, May 16, 2024 at 10:31:13AM -0600, Shuah Khan wrote: > I am exploring options and leaning towards reverting the patch > > daef47b89efd ("selftests: Compile kselftest headers with -D_GNU_SOURCE") > > Your amending the PR helps me if I have to send revert. I am sorry > for the

Re: [PATCH v4 08/66] selftests/cgroup: Drop define _GNU_SOURCE

2024-05-16 Thread Shuah Khan
On 5/16/24 10:21, Tejun Heo wrote: On Thu, May 16, 2024 at 09:50:06AM -0600, Shuah Khan wrote: On 5/13/24 11:02, Tejun Heo wrote: On Fri, May 10, 2024 at 12:06:25AM +, Edward Liaw wrote: _GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent redefinition warnings.

Re: [PATCH v6 03/17] riscv: vector: Use vlenb from DT

2024-05-16 Thread Conor Dooley
On Thu, May 16, 2024 at 10:00:12PM +0800, Andy Chiu wrote: > On Sat, May 4, 2024 at 2:21 AM Charlie Jenkins wrote: > > + if (elf_hwcap & COMPAT_HWCAP_ISA_V && > > has_riscv_homogeneous_vlenb() < 0) { > > + pr_warn("Unsupported heterogeneous vlen detected, >

Re: [PATCH v4 08/66] selftests/cgroup: Drop define _GNU_SOURCE

2024-05-16 Thread Tejun Heo
On Thu, May 16, 2024 at 09:50:06AM -0600, Shuah Khan wrote: > On 5/13/24 11:02, Tejun Heo wrote: > > On Fri, May 10, 2024 at 12:06:25AM +, Edward Liaw wrote: > > > _GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent > > > redefinition warnings. > > > > > > Signed-off-by:

Re: [PATCH] kselftest/alsa: Ensure _GNU_SOURCE is defined

2024-05-16 Thread Muhammad Usama Anjum
icense-Identifier: GPL-2.0 > # > > -CFLAGS += $(shell pkg-config --cflags alsa) > +CFLAGS += $(shell pkg-config --cflags alsa) $(KHDR_INCLUDES) > LDLIBS += $(shell pkg-config --libs alsa) > ifeq ($(LDLIBS),) > LDLIBS += -lasound > > --- > base-commit: 3c999d1ae3c75

Re: [PATCH v4 00/66] Define _GNU_SOURCE for sources using

2024-05-16 Thread Shuah Khan
On 5/9/24 18:06, Edward Liaw wrote: Centralizes the definition of _GNU_SOURCE into KHDR_INCLUDES and removes redefinitions of _GNU_SOURCE from source code. 809216233555 ("selftests/harness: remove use of LINE_MAX") introduced asprintf into kselftest_harness.h, which is a GNU extension and needs

Re: [PATCH v4 08/66] selftests/cgroup: Drop define _GNU_SOURCE

2024-05-16 Thread Shuah Khan
On 5/13/24 11:02, Tejun Heo wrote: On Fri, May 10, 2024 at 12:06:25AM +, Edward Liaw wrote: _GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent redefinition warnings. Signed-off-by: Edward Liaw Applied to cgroup/for-6.10. Thanks. Hi Tejun, Please don't include

Re: [PATCH net] selftests/net: use tc rule to filter the na packet

2024-05-16 Thread Jakub Kicinski
On Tue, 14 May 2024 15:11:30 +0800 Hangbin Liu wrote: > Hi Jakub, would you please help check if this fix the > arp_ndisc_untracked_subnets flake issue on debug kernel? It didn't get ingested by the CI because there's a conflict with something else that got merged into lib.sh. Could you rebase /

[PATCH] kselftest: Desecalate reporting of missing _GNU_SOURCE

2024-05-16 Thread Mark Brown
de --- base-commit: 3c999d1ae3c75991902a1a7dad0cb62c2a3008b4 change-id: 20240516-kselftest-mitigate-gnu-source-b41b2d2cb8a1 Best regards, -- Mark Brown

[PATCH] kselftest/alsa: Ensure _GNU_SOURCE is defined

2024-05-16 Thread Mark Brown
-libs alsa) ifeq ($(LDLIBS),) LDLIBS += -lasound --- base-commit: 3c999d1ae3c75991902a1a7dad0cb62c2a3008b4 change-id: 20240516-kselftest-fix-gnu-source-81ddd00870a8 Best regards, -- Mark Brown

[PATCH net v3] selftests: net: local_termination: annotate the expected failures

2024-05-16 Thread Jakub Kicinski
Vladimir said when adding this test: The bridge driver fares particularly badly [...] mainly because it does not implement IFF_UNICAST_FLT. See commit 90b9566aa5cd ("selftests: forwarding: add a test for local_termination.sh"). We don't want to hide the known gaps, but having a test which

Re: [PATCH v6] lib: add basic KUnit test for lib/math

2024-05-16 Thread Daniel Latypov
On Thu, May 16, 2024 at 3:19 AM Devarsh Thakkar wrote: > > Hi Daniel, Andy, > > On 16/04/21 23:34, Daniel Latypov wrote: > > Add basic test coverage for files that don't require any config options: > > * part of math.h (what seem to be the most commonly used macros) > > * gcd.c > > * lcm.c > > *

Re: -D_GNU_SOURCE kselftest breakage in mainline

2024-05-16 Thread Mark Brown
On Thu, May 16, 2024 at 08:53:52AM -0600, Shuah Khan wrote: > On 5/16/24 08:02, Mark Brown wrote: > > I'm seeing quite a lot of breakage in mainline as a result of > > daef47b89efd0b7 ("selftests: Compile kselftest headers with > > -D_GNU_SOURCE") and daef47b89efd0 ("selftests: Compile kselftest

Re: -D_GNU_SOURCE kselftest breakage in mainline

2024-05-16 Thread Shuah Khan
On 5/16/24 08:02, Mark Brown wrote: Hi, I'm seeing quite a lot of breakage in mainline as a result of daef47b89efd0b7 ("selftests: Compile kselftest headers with -D_GNU_SOURCE") and daef47b89efd0 ("selftests: Compile kselftest headers with -D_GNU_SOURCE") - thus far I've found that the use of

Re: [PATCH 0/8] selftests: x86: build suite with clang

2024-05-16 Thread Muhammad Usama Anjum
On 5/1/24 6:29 AM, Muhammad Usama Anjum wrote: > This series fixes build errors found by clang to allow the x86 suite to > get built with the clang. > > Unfortunately, there is one bug [1] in the clang becuase of which > extended asm isn't handled correctly by it and build fails for >

-D_GNU_SOURCE kselftest breakage in mainline

2024-05-16 Thread Mark Brown
Hi, I'm seeing quite a lot of breakage in mainline as a result of daef47b89efd0b7 ("selftests: Compile kselftest headers with -D_GNU_SOURCE") and daef47b89efd0 ("selftests: Compile kselftest headers with -D_GNU_SOURCE") - thus far I've found that the use of static_assert() is triggering build

Re: [PATCH v6 03/17] riscv: vector: Use vlenb from DT

2024-05-16 Thread Andy Chiu
Sorry Charlie, I forgot to include the mailing list. Here is the same as what I sent in the private message. On Sat, May 4, 2024 at 2:21 AM Charlie Jenkins wrote: > > If vlenb is provided in the device tree, prefer that over reading the > vlenb csr. > > Signed-off-by: Charlie Jenkins > --- >

Re: [PATCH v6 03/17] riscv: vector: Use vlenb from DT

2024-05-16 Thread Andy Chiu
On Sat, May 4, 2024 at 2:21 AM Charlie Jenkins wrote: > > If vlenb is provided in the device tree, prefer that over reading the > vlenb csr. > > Signed-off-by: Charlie Jenkins I agree with Conor that we need a mechanism to turn off v and all depending extensions with

Re: [PATCH v6 02/17] dt-bindings: riscv: cpus: add a vlen register length property

2024-05-16 Thread Andy Chiu
On Sat, May 4, 2024 at 3:33 AM Charlie Jenkins wrote: > > From: Conor Dooley > > Add a property analogous to the vlenb CSR so that software can detect > the vector length of each CPU prior to it being brought online. > Currently software has to assume that the vector length read from the > boot

Re: [PATCH v6 01/17] dt-bindings: riscv: Add xtheadvector ISA extension description

2024-05-16 Thread Andy Chiu
On Sat, May 4, 2024 at 3:33 AM Charlie Jenkins wrote: > > The xtheadvector ISA extension is described on the T-Head extension spec > Github page [1] at commit 95358cb2cca9. > > Link: >

Re: [PATCH net-next] selftests: net: local_termination: annotate the expected failures

2024-05-16 Thread Petr Machata
Jakub Kicinski writes: > On Wed, 15 May 2024 11:02:28 +0200 Petr Machata wrote: >> >> And then either replace the existing xfail_on_veth's (there are just a >> >> handful) or convert xfail_on_veth to a wrapper around xfail_on_kind. >> > >> > I think the bridge thing we can workaround by just

Re: [PATCH v6] lib: add basic KUnit test for lib/math

2024-05-16 Thread Andy Shevchenko
On Thu, May 16, 2024 at 03:49:44PM +0530, Devarsh Thakkar wrote: > Hi Daniel, Andy, > > On 16/04/21 23:34, Daniel Latypov wrote: > > Add basic test coverage for files that don't require any config options: > > * part of math.h (what seem to be the most commonly used macros) > > * gcd.c > > *

Re: [PATCH v6] lib: add basic KUnit test for lib/math

2024-05-16 Thread Devarsh Thakkar
Hi Daniel, Andy, On 16/04/21 23:34, Daniel Latypov wrote: > Add basic test coverage for files that don't require any config options: > * part of math.h (what seem to be the most commonly used macros) > * gcd.c > * lcm.c > * int_sqrt.c > * reciprocal_div.c > (Ignored int_pow.c since it's a simple

[PATCH v6 8/8] selftests/pcie_bwctrl: Create selftests

2024-05-16 Thread Ilpo Järvinen
Create selftests for PCIe BW control through the PCIe cooling device sysfs interface. First, the BW control selftest finds the PCIe Port to test with. By default, the PCIe Port with the highest Link Speed is selected but another PCIe Port can be provided with -d parameter. The actual test steps

Re: [PATCH net] selftests/net/lib: no need to record ns name if it already exist

2024-05-16 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (main) by David S. Miller : On Tue, 14 May 2024 10:33:59 +0800 you wrote: > There is no need to add the name to ns_list again if the netns already > recoreded. > > Fixes: 25ae948b4478 ("selftests/net: add lib.sh") > Signed-off-by: Hangbin Liu >

Re: [PATCH v1] memfd: `MFD_NOEXEC_SEAL` should not imply `MFD_ALLOW_SEALING`

2024-05-16 Thread Jeff Xu
On Mon, May 13, 2024 at 12:15 PM Barnabás Pőcze wrote: > > `MFD_NOEXEC_SEAL` should remove the executable bits and set > `F_SEAL_EXEC` to prevent further modifications to the executable > bits as per the comment in the uapi header file: > > not executable and sealed to prevent changing to

Re: [PATCH v2 1/2] selftests/resctrl: Adjust effective L3 cache size with SNC enabled

2024-05-16 Thread Maciej Wieczor-Retman
On 2024-05-15 at 16:48:44 +, Luck, Tony wrote: >If/when my SNC patches go upstream the SNC check could become: > >snc_ways=$(ls -d /sys/fs/resctrl/mon_data/mon_L3_00/mon_sub_L3_* 2>/dev/null | >wc -l) But this won't work without your kernel patches right? If they are already in the kernel