Shuah,
Can you take this through your tree?
Thanks,
-- Steve
On Wed, 15 May 2024 01:36:20 -0400
Steven Rostedt wrote:
> From: "Steven Rostedt (Google)"
>
> The function "scheduler_tick" was renamed to "sched_tick" and a selftest
> that use
Shuah,
Can you take this through your tree?
-- Steve
On Thu, 23 May 2024 12:45:41 -0400
Steven Rostedt wrote:
> From: "Steven Rostedt (Google)"
>
> A regression happened where running the ownership test passes on the first
> iteration but fails running it a second
On Thu, 30 May 2024 20:16:05 +
Mina Almasry wrote:
> @@ -42,51 +42,52 @@ TRACE_EVENT(page_pool_release,
> TRACE_EVENT(page_pool_state_release,
>
> TP_PROTO(const struct page_pool *pool,
> - const struct page *page, u32 release),
> + netmem_ref netmem, u32
On Wed, 5 Jun 2024 02:52:29 +0200
Andrew Lunn wrote:
> > How is a compiler going to know that?
>
> It might have some heuristics to try to guess unlikely/likely, but
> that is not what we are talking about here.
>
> How much difference did 'always_inline' and 'noinline' make? Hopefully
> the
On Wed, 5 Jun 2024 01:44:37 +0200
Andrew Lunn wrote:
> > Interesting, as I sped up the ftrace ring buffer by a substantial amount by
> > adding strategic __always_inline, noinline, likely() and unlikely()
> > throughout the code. It had to do with what was considered the fast path
> > and slow
On Tue, 4 Jun 2024 13:31:58 -0300
Jason Gunthorpe wrote:
> On Tue, Jun 04, 2024 at 12:15:51PM -0400, Steven Rostedt wrote:
> > On Tue, 04 Jun 2024 12:13:15 +0200
> > Paolo Abeni wrote:
> >
> > > On Thu, 2024-05-30 at 20:16 +, Mina Almasry wrote:
> >
On Tue, 04 Jun 2024 12:13:15 +0200
Paolo Abeni wrote:
> On Thu, 2024-05-30 at 20:16 +, Mina Almasry wrote:
> > diff --git a/net/core/devmem.c b/net/core/devmem.c
> > index d82f92d7cf9ce..d5fac8edf621d 100644
> > --- a/net/core/devmem.c
> > +++ b/net/core/devmem.c
> > @@ -32,6 +32,14 @@
From: "Steven Rostedt (Google)"
Add a test that creates 3 instances and enables function_graph tracer in
each as well as the top instance, where each will enable a filter (but one
that traces all functions) and check that they are filtering properly.
Cc: linux-kselftest@vger.kernel.
From: "Steven Rostedt (Google)"
The function tracer is tested to see if pid filtering works. Add a test to
test function_graph tracer as well, but only if the function_graph tracer
is enabled for the top level or instance.
Cc: linux-kselftest@vger.kernel.org
Signed-off-by: Stev
From: "Steven Rostedt (Google)"
A regression happened where running the ownership test passes on the first
iteration but fails running it a second time. This was caught and fixed,
but a later change brought it back. The regression was missed because the
automated tests only run the
On Tue, 21 May 2024 10:49:19 +0900
Masami Hiramatsu (Google) wrote:
> > It is listed twice. This causes the attached kprobe to it to fail which in
> > turn fails the test. Instead of just picking the function function that is
> > found in available_filter_functions, pick the first one that is
From: "Steven Rostedt (Google)"
The kprobe_eventname.tc test checks if a function with .isra. can have a
kprobe attached to it. It loops through the kallsyms file for all the
functions that have the .isra. name, and checks if it exists in the
available_filter_functions file, and
From: "Steven Rostedt (Google)"
The function "scheduler_tick" was renamed to "sched_tick" and a selftest
that used that function for testing function trace filtering used that
function as part of the test.
But the change causes it to fail when run on older ker
...@google.com
Cc: Shuah Khan
Cc: Shuah Khan
Cc: linux-kselftest@vger.kernel.org
Acked-by: Muhammad Usama Anjum
Signed-off-by: Vincent Donnefort
Signed-off-by: Steven Rostedt (Google)
---
.../testing/selftests/ring-buffer/.gitignore | 1 +
tools/testing/selftests/ring-buffer/Makefile | 8
On Fri, 10 May 2024 14:44:36 -0400
Steven Rostedt wrote:
> On Fri, 10 May 2024 12:04:31 +0100
> Vincent Donnefort wrote:
>
> > > Can you address Shuah's concerns. I'm starting to test patches 1-4 so
> > > you only need to send an update to this one, unless of c
On Fri, 10 May 2024 12:04:31 +0100
Vincent Donnefort wrote:
> > Can you address Shuah's concerns. I'm starting to test patches 1-4 so
> > you only need to send an update to this one, unless of course I find an
> > issue with one of the others.
>
> I will do, as well as with the VM_ flags
On Fri, 3 May 2024 13:12:56 -0600
Shuah Khan wrote:
> On 4/30/24 05:13, Vincent Donnefort wrote:
> > This test maps a ring-buffer and validate the meta-page after reset and
> > after emitting few events.
> >
>
> Changelog needs to be imperative - refer to the following:
>
>
On Mon, 1 Apr 2024 10:28:17 +0800
梦龙董 wrote:
> On Sun, Mar 31, 2024 at 3:34 AM Steven Rostedt wrote:
> >
> > On Sat, 30 Mar 2024 11:18:29 +0800
> > 梦龙董 wrote:
> >
> > > > If you really want to have thousands of functions, why not just
> &g
On Sat, 30 Mar 2024 11:18:29 +0800
梦龙董 wrote:
> > If you really want to have thousands of functions, why not just register it
> > with ftrace itself. It will give you the arguments via the ftrace_regs
> > structure. Can't you just register a program as the callback?
> >
>
> Ennn...I don't
On Fri, 29 Mar 2024 16:28:33 -0700
Andrii Nakryiko wrote:
> I thought I'll just ask instead of digging through code, sorry for
> being lazy :) Is there any way to pass pt_regs/ftrace_regs captured
> before function execution to a return probe (fexit/kretprobe)? I.e.,
> how hard is it to pass
On Thu, 28 Mar 2024 22:43:46 +0800
梦龙董 wrote:
> I have done a simple benchmark on creating 1000
> trampolines. It is slow, quite slow, which consume up to
> 60s. We can't do it this way.
>
> Now, I have a bad idea. How about we introduce
> a "dynamic trampoline"? The basic logic of it can be:
>
Shuah,
If Masami is OK with this, can you take this through your tree?
Acked-by: Steven Rostedt (Google)
-- Steve
On Mon, 25 Mar 2024 16:15:49 +
Mark Brown wrote:
> This series aims to improve the usability of the ftrace selftests when
> running as part of the kselftest
On Thu, 29 Feb 2024 17:52:16 +0900
Masami Hiramatsu (Google) wrote:
> Lol, I haven't allocate the entry data size when initialize rethook.
> That's a bug.
> Please try below.
I'll wait to review patches 5,6,7 as I'm guessing this will have a v3?
-- Steve
On Mon, 26 Feb 2024 12:58:33 +0900
"Masami Hiramatsu (Google)" wrote:
> From: Masami Hiramatsu (Google)
>
> Remove redundant #else block for BTF args from README message.
> This is a cleanup, so no change on the message.
Reviewed-by: Steven Rostedt (Google)
--
, but the change log does not say why this was done.
Reviewed-by: Steven Rostedt (Google)
-- Steve
>
> Signed-off-by: Masami Hiramatsu (Google)
> ---
Signed-off-by: Masami Hiramatsu (Google)
Reviewed-by: Steven Rostedt (Google)
-- Steve
> ---
> kernel/trace/trace_probe.c | 230
> ++--
> 1 file changed, 137 insertions(+), 93 deletions(-)
On Mon, 26 Feb 2024 12:58:03 +0900
"Masami Hiramatsu (Google)" wrote:
> From: Masami Hiramatsu (Google)
>
> Despite the fprobe event, "Kretprobe" was commented. So fix it.
>
> Signed-off-by: Masami Hiramatsu (Google)
Reviewed-by: Steven Rostedt (Google
e)
>
> Hi Shuah, can you pick this as a fix?
>
Yes please.
Acked-by: Steven Rostedt (Google)
-- Steve
-off-by: Vincent Donnefort
Signed-off-by: Steven Rostedt (Google)
---
tools/testing/selftests/ring-buffer/Makefile | 8 +
tools/testing/selftests/ring-buffer/config| 2 +
.../testing/selftests/ring-buffer/map_test.c | 273 ++
3 files changed, 283 insertions(+)
create
On Tue, 20 Feb 2024 16:41:01 -0700
Shuah Khan wrote:
> Steve,
>
> I picked this up fpr next for Linux 6.9-rc1
Sure, and you can add my:
Acked-by: Steven Rostedt (Google)
Thanks Shuah,
-- Steve
ot;powerpc/ftrace: Fix stack teardown in ftrace_no_trace").
>
> Signed-off-by: Naveen N Rao
> Acked-by: Masami Hiramatsu (Google)
Acked-by: Steven Rostedt (Google)
Shuah, can you take this?
Thanks,
-- Steve
> ---
> .../ftrace/test.d/ftrace/func_hotplug.tc | 42
output would be enough to judge whether
> there are more than 3 types of sched events.
It's not that it never stops but on some slower systems it does seem to
take forever.
Acked-by: Steven Rostedt (Google)
Shuah,
Can you take this through your tree?
Thanks,
-- Steve
>
On Sun, 14 Jan 2024 23:17:11 +0900
Masami Hiramatsu (Google) wrote:
> >
> > Looks good to me and tested.
> >
> > Reviewed-by: Masami Hiramatsu (Google)
> > Tested-by: Masami Hiramatsu (Google)
>
> Sorry, I should cancel these. I found this test did not pass if I set
> the function tracer
On Fri, 22 Dec 2023 11:28:31 -0500
Steven Rostedt wrote:
> > -- this file has executable permission set unlike the existing
> > .tc files in the same directory
>
> Oh, I forgot to disable that. When developing a new test I make it
> standalone as it's ea
From: "Steven Rostedt (Google)"
As there were bugs found with the ownership of eventfs dynamic file
creation. Add a test to test it.
It will remount tracefs with a different gid and check the ownership of
the eventfs directory, as well as the system and event directories. It
will
On Fri, 22 Dec 2023 09:15:42 -0700
Shuah Khan wrote:
> On 12/21/23 19:16, Steven Rostedt wrote:
> >
> > Shuah,
> >
> > This patch has no dependencies. You can take it through your tree for the
> > next merge window if you want. If not, I can take it.
> &
Shuah,
This patch has no dependencies. You can take it through your tree for the
next merge window if you want. If not, I can take it.
Thanks,
-- Steve
On Thu, 21 Dec 2023 21:12:29 -0500
Steven Rostedt wrote:
> From: "Steven Rostedt (Google)"
>
> As th
From: "Steven Rostedt (Google)"
As there were bugs found with the ownership of eventfs dynamic file
creation. Add a test to test it.
It will remount tracefs with a different gid and check the ownership of
the eventfs directory, as well as the system and event directories. It
will
On Fri, 22 Dec 2023 10:52:00 +0900
Masami Hiramatsu (Google) wrote:
> On Fri, 22 Dec 2023 10:48:41 +0900
> Masami Hiramatsu (Google) wrote:
> And I confirmed that this test passed on v6.5.13 with that change.
>
I just ran it on 6.5.13 and it took *forever*!
But I do have a bit of debug, and
On Fri, 22 Dec 2023 10:52:00 +0900
Masami Hiramatsu (Google) wrote:
> > +instance="foo-$(mktemp -u X)"
> >
> > This doesn't work. it needs XX (6 times X). And this is
> > somewhat wrong usage of mktemp because it can not check there is
> > foo-.
> > What about change it as
> >
> >
On Fri, 22 Dec 2023 10:21:48 +0900
Masami Hiramatsu (Google) wrote:
> The testcase itself is OK but is there any way to identify the system
> supports eventfs or not? I ran this test on v6.5.13 for checking then
> it failed. We may need to skip (unsupported) this test for such case.
Hmm,
From: "Steven Rostedt (Google)"
As there were bugs found with the ownership of eventfs dynamic file
creation. Add a test to test it.
It will remount tracefs with a different gid and check the ownership of
the eventfs directory, as well as the system and event directories. It
will
On Thu, 21 Dec 2023 19:35:51 -0500
Steven Rostedt wrote:
> +
> +# find another owner and group that is not the original
> +other_group=`tac /etc/group | grep -v ":$original_group:" | head -1 | cut
> -d: -f3`
> +other_owner=`tac /etc/passwd | grep -v ":$original
From: "Steven Rostedt (Google)"
As there were bugs found with the ownership of eventfs dynamic file
creation. Add a test to test it.
It will remount tracefs with a different gid and check the ownership of
the eventfs directory, as well as the system and event directories. It
will
On Mon, 18 Dec 2023 13:49:22 -0700
Shuah Khan wrote:
> On 12/13/23 15:59, Masami Hiramatsu (Google) wrote:
> > On Wed, 13 Dec 2023 11:15:27 -0500
> > Steven Rostedt wrote:
> >
> >> From: "Steven Rostedt (Google)"
> >>
> >> Add a tes
From: "Steven Rostedt (Google)"
Add a test that writes longs strings, some over the size of the sub buffer
and make sure that the entire content is there.
Signed-off-by: Steven Rostedt (Google)
---
Changes since v3:
https://lore.kernel.org/linux-trace-kernel/2023121219
On Wed, 13 Dec 2023 21:54:50 +0900
Masami Hiramatsu (Google) wrote:
> On Wed, 13 Dec 2023 17:08:02 +0530
> Naveen N Rao wrote:
>
> > Add a test to exercize cpu hotplug with the function tracer active to
> > ensure that sensitive functions in idle path are excluded from being
> > traced. This
On Wed, 13 Dec 2023 10:09:50 +0200
Alexander Kapshuk wrote:
> The REs used in the sed commands below may be simplified as shown if desired.
>
> On Wed, Dec 13, 2023 at 2:22 AM Steven Rostedt wrote:
> >
> > From: "Steven Rostedt (Google)"
> >
> > Add
On Wed, 13 Dec 2023 09:33:18 +0900
Masami Hiramatsu (Google) wrote:
> On Tue, 12 Dec 2023 15:16:32 -0500
> Steven Rostedt wrote:
>
> > From: "Steven Rostedt (Google)"
> >
> > Now that the trace_marker can write up to the max size of the sub buffer.
>
From: "Steven Rostedt (Google)"
Add a test that writes longs strings, some over the size of the sub buffer
and make sure that the entire content is there.
Signed-off-by: Steven Rostedt (Google)
---
Changes since v2:
https://lore.kernel.org/linux-trace-kernel/2023121215
From: "Steven Rostedt (Google)"
Now that the trace_marker can write up to the max size of the sub buffer.
Add a test to see if it actually can happen.
The README is updated to state that the trace_marker writes can be broken
up, and the test checks the README for that statement so th
From: "Steven Rostedt (Google)"
Now that the trace_marker can write up to the max size of the sub buffer.
Add a test to see if it actually can happen.
The README is updated to state that the trace_marker writes can be broken
up, and the test checks the README for that statement so th
[ Adding Masami and stable ]
On Tue, 31 Oct 2023 00:27:07 +
Beau Belgrave wrote:
> On Mon, Oct 30, 2023 at 05:31:51PM -0400, Steven Rostedt wrote:
> > On Mon, 30 Oct 2023 12:42:23 -0400
> > Steven Rostedt wrote:
> >
> > > > I still get the splat about
On Mon, 30 Oct 2023 12:42:23 -0400
Steven Rostedt wrote:
> > I still get the splat about the trace_array_put when running
> > user_event's ftrace selftest:
> >
> > [ 26.665931] [ cut here ]
> > [ 26.63] WARNING: CPU: 12 PID: 2
On Mon, 30 Oct 2023 09:31:02 -0700
Beau Belgrave wrote:
> I applied both [1][2] patches, and I no longer get any panics. However,
Great! Can I add "Tested-by" from you on those patches?
> I still get the splat about the trace_array_put when running
> user_event's ftrace selftest:
>
> [
On Fri, 27 Oct 2023 14:55:14 +0200
"Arnd Bergmann" wrote:
> This lock is part of the dentry passed to d_invalidate()
>
> > [ 1402.609170] ? lock_release (kernel/locking/lockdep.c:5429
> > kernel/locking/lockdep.c:5773)
> > [ 1402.612923] ? create_dir_dentry.part.0
On Fri, 27 Oct 2023 18:36:40 -0400
Steven Rostedt wrote:
> On Fri, 27 Oct 2023 12:20:11 -0700
> Beau Belgrave wrote:
>
> > On Fri, Oct 27, 2023 at 05:38:41PM +0530, Naresh Kamboju wrote:
> > > Following kernel crash noticed on x86_64 while running selft
On Fri, 27 Oct 2023 12:20:11 -0700
Beau Belgrave wrote:
> On Fri, Oct 27, 2023 at 05:38:41PM +0530, Naresh Kamboju wrote:
> > Following kernel crash noticed on x86_64 while running selftests:
> > user_events:
> > ftrace_test running 6.6.0-rc7-next-20231026.
> >
> > Reported-by: Linux Kernel
ix missing cast in clone_check().
>
> V2 Changes:
> Rebase to linux-kselftest/fixes.
Shuah,
Can you take this patch?
Acked-by: Steven Rostedt (Google)
-- Steve
>
> tools/testing/selftests/user_events/abi_test.c | 16 +---
> 1 file changed, 9 insertions(+), 7
ernel.org (which I did here).
Shuah,
Can you add this? You can also add:
Acked-by: Steven Rostedt (Google)
-- Steve
On Thu, 5 Oct 2023 09:52:30 -0700
Beau Belgrave wrote:
> It was based on tracing/for-next.
>
> I'll get a v2 out rebased upon linux-kselftest, does that work?
Hmm, then it should have applied to my tree. I didn't look too deep.
Can you see if it applies to:
On Thu, 5 Oct 2023 08:48:14 -0600
Shuah Khan wrote:
> Hmm. Which tree is this patch based on? This doesn't apply to
> linux-kselftest fixes - I thought this was based on top of fixes
> since I sent in a fix for Linux 6.6-rc4 for user_events
>
> Beau, Please rebase to the correct tree/branch and
On Wed, 4 Oct 2023 09:10:52 -0600
Shuah Khan wrote:
> On 10/3/23 18:59, Steven Rostedt wrote:
> >
> > Note, this doesn't seem to apply to my tree so I only added the first
> > patch. I think this needs to go through Shuah's tree.
> >
> > -- Steve
> >
&
Note, this doesn't seem to apply to my tree so I only added the first
patch. I think this needs to go through Shuah's tree.
-- Steve
On Mon, 25 Sep 2023 23:08:29 +
Beau Belgrave wrote:
> The abi_test currently uses a long sized test value for enablement
> checks. On LE this works fine,
On Tue, 12 Sep 2023 10:12:34 -0700
Beau Belgrave wrote:
> > I guess I was wrong and some people do care ;-)
> >
> > -- Steve
>
> It looks like this change got applied [1] to the fixes branch of
> linux-kselftest. I can either send a V3 with this addressed or build a
> patch based upon the
On Tue, 12 Sep 2023 09:54:57 +0900
Masami Hiramatsu (Google) wrote:
> > Shouldn't the above be:
> >
> > if [ ! -z "${UNMOUNT_DIR}" ]; then
> >
> > ?
>
> I think both are good.
> What about using '-n' explictly?
>
> [ -n "${UNMOUNT_DIR}" ]
Even better. Heh, I never even knew about
gt; ---
> Changes in v2:
>- use -n option explictly for testing the string is non-zero.
> ---
> tool
Reviewed-by: Steven Rostedt (Google)
-- Steve
On Mon, 11 Sep 2023 09:21:05 +0900
Masami Hiramatsu (Google) wrote:
> On Fri, 8 Sep 2023 18:17:21 -0400
> Steven Rostedt wrote:
>
> > From: Steven Rostedt (Google)
> >
> > When I'm debugging something with the ftrace selftests and need to look at
> > the log
68 matches
Mail list logo
