Re: [PATCH net-next v2 09/11] selftests: net: lib: Rename ip_link_master() to ip_link_set_master()

2024-12-06 Thread Nikolay Aleksandrov
On 12/5/24 17:40, Petr Machata wrote:
> Let's have a verb in that function name to make it clearer what's going on.
> 
> Signed-off-by: Petr Machata 
> Reviewed-by: Ido Schimmel 
> ---
> 
> Notes:
> CC: Shuah Khan 
> CC: Benjamin Poirier 
> CC: Hangbin Liu 
> CC: Vladimir Oltean 
> CC: linux-kselftest@vger.kernel.org
> 

Reviewed-by: Nikolay Aleksandrov 




[PATCH net-next v2 09/11] selftests: net: lib: Rename ip_link_master() to ip_link_set_master()

2024-12-05 Thread Petr Machata
Let's have a verb in that function name to make it clearer what's going on.

Signed-off-by: Petr Machata 
Reviewed-by: Ido Schimmel 
---

Notes:
CC: Shuah Khan 
CC: Benjamin Poirier 
CC: Hangbin Liu 
CC: Vladimir Oltean 
CC: linux-kselftest@vger.kernel.org

 tools/testing/selftests/net/fdb_notify.sh | 6 +++---
 tools/testing/selftests/net/lib.sh| 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/tools/testing/selftests/net/fdb_notify.sh 
b/tools/testing/selftests/net/fdb_notify.sh
index c03151e7791c..c159230c9b62 100755
--- a/tools/testing/selftests/net/fdb_notify.sh
+++ b/tools/testing/selftests/net/fdb_notify.sh
@@ -49,7 +49,7 @@ test_dup_vxlan_self()
 {
ip_link_add br up type bridge vlan_filtering 1
ip_link_add vx up type vxlan id 2000 dstport 4789
-   ip_link_master vx br
+   ip_link_set_master vx br
 
do_test_dup add "vxlan" dev vx self dst 192.0.2.1
do_test_dup del "vxlan" dev vx self dst 192.0.2.1
@@ -59,7 +59,7 @@ test_dup_vxlan_master()
 {
ip_link_add br up type bridge vlan_filtering 1
ip_link_add vx up type vxlan id 2000 dstport 4789
-   ip_link_master vx br
+   ip_link_set_master vx br
 
do_test_dup add "vxlan master" dev vx master
do_test_dup del "vxlan master" dev vx master
@@ -79,7 +79,7 @@ test_dup_macvlan_master()
ip_link_add br up type bridge vlan_filtering 1
ip_link_add dd up type dummy
ip_link_add mv up link dd type macvlan mode passthru
-   ip_link_master mv br
+   ip_link_set_master mv br
 
do_test_dup add "macvlan master" dev mv self
do_test_dup del "macvlan master" dev mv self
diff --git a/tools/testing/selftests/net/lib.sh 
b/tools/testing/selftests/net/lib.sh
index 8994fec1c38f..5ea6537acd2b 100644
--- a/tools/testing/selftests/net/lib.sh
+++ b/tools/testing/selftests/net/lib.sh
@@ -451,7 +451,7 @@ ip_link_add()
defer ip link del dev "$name"
 }
 
-ip_link_master()
+ip_link_set_master()
 {
local member=$1; shift
local master=$1; shift
-- 
2.47.0