Eliminate duplicated debug code by moving it into the core driver.
Don't log the only valid silicon revision number (it's in the source).
Cc: Thomas Bogendoerfer
Cc: Chris Zankel
Tested-by: Stan Johnson
Signed-off-by: Finn Thain
Add missing printk severity levels by adopting pr_foo() calls for the
platform_driver and dev_foo() calls for the nubus_driver.
Avoid KERN_CONT usage as per advice from checkpatch.
Avoid #ifdef around printk calls.
Don't log driver probe messages after calling register_netdev().
Cc: Thomas
This resolves an old issue preventing any NuBus SONIC NICs from
working in a Mac with an on-board SONIC device.
Tested-by: Stan Johnson
Signed-off-by: Finn Thain
---
drivers/net/ethernet/natsemi/macsonic.c | 173 ++--
1
Changes since v4 of combined patch series:
- Removed redundant and non-portable MACH_IS_MAC tests.
- Omitted patches unrelated to SONIC drivers.
- Dropped changes to the 'version_printed' logic and debug message text.
Finn Thain (4):
net/macsonic: Convert to nubus_driver
net/macsonic: Drop
The MACH_IS_MAC test is redundant here because the platform device
won't get registered unless MACH_IS_MAC.
Cc: Geert Uytterhoeven
Signed-off-by: Finn Thain
---
drivers/net/ethernet/natsemi/macsonic.c | 3 ---
1 file changed, 3 deletions(-)