Re: [PATCH v2] m68k/amiga - zorro.c: set up z->dev.dma_mask for the DMA API

Hi Michael, On Tue, Mar 6, 2018 at 2:06 AM, Michael Schmitz wrote: > thanks for explaining - I had forgotten that the SCSI adapter in elgar > is probably on the CPU accelerator card. > > 00: Phase 5 Digital Products CyberSCSI/Blizzard 1220 > Type: Zorro II >

Re: [PATCH 2/2] m68k/amiga - Zorro ESP: new zorro_esp.c

Hi Michael, On Tue, Mar 6, 2018 at 2:33 AM, Michael Schmitz wrote: > On Tue, Mar 6, 2018 at 12:29 AM, Geert Uytterhoeven > wrote: >>> +static unsigned char ctrl_data;/* Keep backup of the stuff written >>> +*

Re: [PATCH 2/2] m68k/amiga - Zorro ESP: new zorro_esp.c

Hi Michael, On Tue, Mar 6, 2018 at 2:11 AM, Michael Schmitz wrote: > Index 1 should have been ZORRO_PROD_PHASE5_CYBERSTORM_MK_II, I've > corrected that in the meantime. > > Fastlane / Blizzard 1230_II distinction is something I an not quite > sure about - does the probe

Re: [PATCH 2/2] m68k/amiga - Zorro ESP: new zorro_esp.c

Hi Finn, Am 06.03.2018 um 16:04 schrieb Finn Thain: > On Tue, 6 Mar 2018, Michael Schmitz wrote: > +static void zorro_esp_send_pio_cmd(struct esp *esp, u32 addr, u32 esp_count, +u32 dma_count, int write, u8 cmd) +{ + struct

Re: [PATCH 2/2] m68k/amiga - Zorro ESP: new zorro_esp.c

On Tue, 6 Mar 2018, Michael Schmitz wrote: > >> +static void zorro_esp_send_pio_cmd(struct esp *esp, u32 addr, u32 > >> esp_count, > >> +u32 dma_count, int write, u8 cmd) > >> +{ > >> + struct zorro_esp_priv *zep = ZORRO_ESP_GET_PRIV(esp); > >> + u8

Re: [RFC] m68k: Fix dead code in bus_error030()

On Mon, 5 Mar 2018, I wrote: > The only sensible place for the !(mmusr & MMU_I) test is inside the > (mmusr & (MMU_I | MMU_WP)) branch. It is redundant when used in the > else branch. > > Moreover, when used in the else branch it defeats the remaining > conditionals. Hence the (mmusr &

Re: [PATCH 2/2] m68k/amiga - Zorro ESP: new zorro_esp.c

Hi Geert, thanks, will comment on a few points that were not already raised by Finn below. On Tue, Mar 6, 2018 at 12:29 AM, Geert Uytterhoeven wrote: >> +static struct zorro_driver_data { >> + const char *name; >> + unsigned long offset; >> + unsigned

Re: [PATCH 2/2] m68k/amiga - Zorro ESP: new zorro_esp.c

Hi Kars, Index 1 should have been ZORRO_PROD_PHASE5_CYBERSTORM_MK_II, I've corrected that in the meantime. Fastlane / Blizzard 1230_II distinction is something I an not quite sure about - does the probe function get called twice if the device table contains the same ID twice but with different

Re: [PATCH v2] m68k/amiga - zorro.c: set up z->dev.dma_mask for the DMA API

Hi Geert, thanks for explaining - I had forgotten that the SCSI adapter in elgar is probably on the CPU accelerator card. 00: Phase 5 Digital Products CyberSCSI/Blizzard 1220 Type: Zorro II Address: 00e9 (0001 bytes) Serial number: Slot address:

Re: [PATCH v3 2/2] m68k: mmu: fix IO access endianness for ColdFire family

Hi Greg, On Mon, Mar 05, 2018 at 11:30:32PM +1000, Greg Ungerer wrote: > Hi Angelo, > > On 02/03/18 22:24, Angelo Dureghello wrote: > > On Fri, Mar 02, 2018 at 09:28:57AM +1000, Greg Ungerer wrote: > > > On 01/03/18 22:32, Angelo Dureghello wrote: > > > > This patch fixes IO access endianness,

Re: [PATCH 2/2] m68k/amiga - Zorro ESP: new zorro_esp.c

On 05.03.2018 03:11, Michael Schmitz wrote: Hi Finn, On Mon, Mar 5, 2018 at 2:01 PM, Finn Thain wrote: On Mon, 5 Mar 2018, Michael Schmitz wrote: +fail_unmap_dma_regs: + if (ioaddr > 0xff) + iounmap(esp->dma_regs); I think you need to test

Re: [PATCH v3 2/2] m68k: mmu: fix IO access endianness for ColdFire family

Hi Angelo, On 02/03/18 22:24, Angelo Dureghello wrote: On Fri, Mar 02, 2018 at 09:28:57AM +1000, Greg Ungerer wrote: On 01/03/18 22:32, Angelo Dureghello wrote: This patch fixes IO access endianness, that should be big endian. If any little endian peripheral may be connected, bytes should be

Re: [PATCH 2/2] m68k/amiga - Zorro ESP: new zorro_esp.c

Hi Michael, On Sun, Mar 4, 2018 at 12:54 AM, Michael Schmitz wrote: > From: Michael Schmitz > > New combined SCSI driver for all ESP based Zorro SCSI boards for > m68k Amiga. Thanks for your patch! > --- /dev/null > +++ b/drivers/scsi/zorro_esp.c > @@

Re: [PATCH v2] m68k/amiga - zorro.c: set up z->dev.dma_mask for the DMA API

Hi Michael, On Sun, Mar 4, 2018 at 1:21 AM, Michael Schmitz wrote: > that's odd - the DMA setup code in the old ESP drivers does program the > full 32 bit addresses on DMA set-up. No masking off to 24 bit. > > All boards except for the Fastlane are ZorroII. Writes to the

Re: [RFC] m68k: Fix dead code in bus_error030()

On Mon, 5 Mar 2018, Michael Schmitz wrote: > About evading a signal - as the code is now, any faults that are not > write protect or invalid MMU descriptor faults would end up in that > branch. In particular, for anything that should have been caught by the > branch below, we'd expect to see

Re: [PATCH 2/2] m68k/amiga - Zorro ESP: new zorro_esp.c

2018-03-04 0:54 GMT+01:00 Michael Schmitz : > +static struct zorro_device_id zorro_esp_zorro_tbl[] = { > + { > + .id = ZORRO_PROD_PHASE5_BLIZZARD_1220_CYBERSTORM, > + .driver_data = (unsigned long)_esp_driver_data[0], > + }, > + {