Re: [PATCH 2/2] m68k/amiga - Zorro ESP: new zorro_esp.c

2018-03-06 Thread Michael Schmitz
Hi Geert, OK, in that case I'll need to work out something similar to the test for optional SCSI function on the Blizzard 1230/1260 to find out what board I have when dealing with the duplicate Fastlane/Blizzard1230II ID. Is the board base address as returned by zorro_resource_start() reliable

Re: [PATCH v2] m68k/amiga - zorro.c: set up z->dev.dma_mask for the DMA API

2018-03-06 Thread Michael Schmitz
Hi Geert, thanks. will add the necessary DMA mask fixup to the ESP driver now. Cheers, Michael Am 06.03.2018 um 20:56 schrieb Geert Uytterhoeven: > Hi Michael, > > On Tue, Mar 6, 2018 at 2:06 AM, Michael Schmitz wrote: >> thanks for explaining - I had forgotten

Re: [PATCH 2/2] m68k/amiga - Zorro ESP: new zorro_esp.c

2018-03-06 Thread Michael Schmitz
Hi Finn, Am 07.03.2018 um 13:54 schrieb Finn Thain: > On Wed, 7 Mar 2018, Michael Schmitz wrote: > >> The major obstacle now seems to be dynamic allocation of the driver >> private data and storing a pointer to that in a way that it can be >> retrieved using just the esp pointer.

Re: [PATCH 2/2] m68k/amiga - Zorro ESP: new zorro_esp.c

2018-03-06 Thread Michael Schmitz
Hi Geert, On Tue, Mar 6, 2018 at 8:48 PM, Geert Uytterhoeven wrote: > BTW, please call the probe/remove functions zorro_esp_probe() resp. > zorro_esp_remove(). Fair enough. + if (!host) { + pr_err(PFX "No host detected; board configuration

Re: [PATCH 2/2] m68k/amiga - Zorro ESP: new zorro_esp.c

2018-03-06 Thread Michael Schmitz
Hi Finn, I'll leave the unused !write branch in the original condition. I'd rather keep the address conversion inside the PIO code than duplicating it in each DMA setup routine though. You had asked what manual I had used a while ago: it's

Re: [PATCH v3 2/2] m68k: mmu: fix IO access endianness for ColdFire family

2018-03-06 Thread Greg Ungerer
Hi Angelo, On 06/03/18 09:13, Angelo Dureghello wrote: On Mon, Mar 05, 2018 at 11:30:32PM +1000, Greg Ungerer wrote: On 02/03/18 22:24, Angelo Dureghello wrote: On Fri, Mar 02, 2018 at 09:28:57AM +1000, Greg Ungerer wrote: On 01/03/18 22:32, Angelo Dureghello wrote: This patch fixes IO

Re: [PATCH 2/2] m68k/amiga - Zorro ESP: new zorro_esp.c

2018-03-06 Thread Finn Thain
On Tue, 6 Mar 2018, Michael Schmitz wrote: > The whole !write branch will never be executed, and I could just omit it > entirely for now, or leave it as it was in the Mac driver. > We could make use of the !write branch in zorro_esp, even if it was only to figure out the SELAS/MSG OUT issue