Re: [PATCH v3 00/10] New network driver for Amiga X-Surf 100 (m68k)

On Wed, 18 Apr 2018, Michael Schmitz wrote: > All, > > just noticed belatedly that the Makefile hunk of patch 9 does no > longer apply cleanly in 4.17-rc1, sorry. My series was based on 4.16. > I'll resend that one, OK? > I might end up simpler to resend the whole series -- > Cheers, > >

Re: [PATCH v3 00/10] New network driver for Amiga X-Surf 100 (m68k)

All, just noticed belatedly that the Makefile hunk of patch 9 does no longer apply cleanly in 4.17-rc1, sorry. My series was based on 4.16. I'll resend that one, OK? Cheers, Michael On Wed, Apr 18, 2018 at 4:26 PM, Michael Schmitz wrote: > This patch series adds

Re: [PATCH 10/10] net: New ax88796 platform driver for Amiga X-Surf 100 Zorro board (m68k)

Hi Geert, On Wed, Apr 18, 2018 at 1:53 AM, Geert Uytterhoeven wrote: >> --- /dev/null >> +++ b/drivers/net/ethernet/8390/xsurf100.c >> @@ -0,0 +1,411 @@ >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> + >> +#define

[PATCH v3 00/10] New network driver for Amiga X-Surf 100 (m68k)

This patch series adds support for the Individual Computers X-Surf 100 network card for m68k Amiga, a network adapter based on the AX88796 chip set. The driver was originally written for kernel version 3.19 by Michael Karcher (see CC:), and adapted to 4.16 for submission to netdev by me.

[PATCH v3 1/9] net: phy: new Asix Electronics PHY driver

The Asix Electronics PHY found on the X-Surf 100 Amiga Zorro network card by Individual Computers is buggy, and needs the reset bit toggled as workaround to make a PHY soft reset succed. Add workaround driver just for this special case. Export phy_poll_reset() from core phy_device driver to avoid

[PATCH v3 2/9] net: ax88796: Fix MAC address reading

From: Michael Karcher To read the MAC address from the (virtual) SAprom, the remote DMA unit needs to be set up like for every other process access to card-local memory. Signed-off-by: Michael Karcher Signed-off-by:

[PATCH v3 5/9] net: ax88796: Add block_input/output hooks to ax_plat_data

From: Michael Karcher Add platform specific hooks for block transfer reads/writes of packet buffer data, superseding the default provided ax_block_input/output. Currently used for m68k Amiga XSurf100. Signed-off-by: Michael Karcher

[PATCH v3 7/9] net: ax88796: set IRQF_SHARED flag when IRQ resource is marked as shareable

From: Michael Karcher On the Amiga X-Surf100, the network card interrupt is shared with many other interrupt sources, so requires the IRQF_SHARED flag to register. Signed-off-by: Michael Karcher Signed-off-by: Michael

[PATCH v3 3/9] net: ax88796: Attach MII bus only when open

From: Michael Karcher Call ax_mii_init in ax_open(), and unregister/remove mdiobus resources in ax_close(). This is needed to be able to unload the module, as the module is busy while the MII bus is attached. Signed-off-by: Michael Karcher

[PATCH v3 6/9] net: ax88796: add interrupt status callback to platform data

From: Michael Karcher To be able to tell the ax88796 driver whether it is sensible to enter the 8390 interrupt handler, an "is this interrupt caused by the 88796" callback has been added to the ax_plat_data structure (with NULL being compatible to the

[PATCH v3 8/9] net: ax88796: release platform device drvdata on probe error and module remove

The net device struct pointer is stored as platform device drvdata on module probe - clear the drvdata entry on probe fail there, as well as when unloading the module. Signed-off-by: Michael Schmitz --- drivers/net/ethernet/8390/ax88796.c |2 ++ 1 files changed, 2

Re: [PATCH 04/10] net: ax88796: Add block_input/output hooks to ax_plat_data

eers, >> >> Michael >> >> >> On Wed, Apr 18, 2018 at 6:46 AM, kbuild test robot <l...@intel.com> wrote: >> > Hi Michael, >> > >> > I love your patch! Perhaps something to improve: >> > >> > [auto build test WARNING on v4.16

Re: [PATCH 04/10] net: ax88796: Add block_input/output hooks to ax_plat_data

Hi Andrew, ax88796 includes it via linux/netdevice.h. mac-anubis.c doesn't. Michael Karcher's patches have added forward derclarations for struct netdevice and struct platform_data already - I'll add struct sk_buff as suggested by Finn. Cheers, Michael On Wed, Apr 18, 2018 at 1:19 PM,

Re: [PATCH 04/10] net: ax88796: Add block_input/output hooks to ax_plat_data

itespace change. -- > Cheers, > > Michael > > > On Wed, Apr 18, 2018 at 6:46 AM, kbuild test robot <l...@intel.com> wrote: > > Hi Michael, > > > > I love your patch! Perhaps something to improve: > > > > [auto build test WARNING on v4.16] &g

Re: [PATCH 04/10] net: ax88796: Add block_input/output hooks to ax_plat_data

On Wed, Apr 18, 2018 at 12:53:21PM +1200, Michael Schmitz wrote: > I think this is a false positive - we're encouraged to provide the > full parameter list for functions, so the sreuct sk_buff* can't be > avoided. Hi Michael How is being included? You probably want to build using the .config

Re: [PATCH 04/10] net: ax88796: Add block_input/output hooks to ax_plat_data

rhaps something to improve: > > [auto build test WARNING on v4.16] > [cannot apply to net-next/master net/master v4.17-rc1 next-20180417] > [if your patch is applied to the wrong git tree, please drop us a note to > help improve the system] > > url: > https://github.com/0d

Re: [PATCH v2 00/10] SWIM driver fixes

Hi Geert, On Tue, 17 Apr 2018, I wrote: > On Wed, 11 Apr 2018, I wrote: > > > This patch series has fixes for bugs in the SWIM floppy disk > > controller driver, including an oops and a soft lockup. > > > > Apparently no-one is authorized to push this series intact. > > Geert, would you

Re: [PATCH 01/15] m68k: move *_relaxed macros into io_no.h and io_mm.h

Hi Angelo, On 18/04/18 06:53, Angelo Dureghello wrote: > thanks for this great job. :-) > On patch 10, PIC is PCI, right ? Yes, typo on my part. I even managed to get it wrong twice! I'll fix that. > In case you hae some time, am interested in understanding how those > guards > > #define

Re: [PATCH v2 8/8] net: New ax88796 platform driver for Amiga X-Surf 100 Zorro board (m68k)

Hi Andrew, On Wed, Apr 18, 2018 at 1:26 AM, Andrew Lunn wrote: > On Tue, Apr 17, 2018 at 02:08:15PM +1200, Michael Schmitz wrote: >> Add platform device driver to populate the ax88796 platform data from >> information provided by the XSurf100 zorro device driver. >> This driver

Re: [PATCH 10/10] net: New ax88796 platform driver for Amiga X-Surf 100 Zorro board (m68k)

Hi Geert, thanks for your suggestions! On Wed, Apr 18, 2018 at 1:53 AM, Geert Uytterhoeven wrote: > Hi Michael, > > Thanks for your patch! > > On Tue, Apr 17, 2018 at 12:04 AM, Michael Schmitz > wrote: >> Add platform device driver to populate the

Re: [PATCH v2 3/8] net: ax88796: Do not free IRQ in ax_remove() (already freed in ax_close()).

Hi Andrew, thanks, that's what I was looking for. The next version will have all but one patch correctly attributed to Michael Karcher. Cheers, Michael On Wed, Apr 18, 2018 at 9:13 AM, Andrew Lunn wrote: > On Wed, Apr 18, 2018 at 08:32:25AM +1200, Michael Schmitz wrote: >>

Re: [PATCH v2 3/8] net: ax88796: Do not free IRQ in ax_remove() (already freed in ax_close()).

On Wed, Apr 18, 2018 at 08:32:25AM +1200, Michael Schmitz wrote: > Hi Adrian, > > On Tue, Apr 17, 2018 at 11:40 PM, John Paul Adrian Glaubitz > wrote: > > On 04/17/2018 04:08 AM, Michael Schmitz wrote: > >> > >> From: John Paul Adrian Glaubitz

Re: [PATCH 01/15] m68k: move *_relaxed macros into io_no.h and io_mm.h

Hi Greg, thanks for this great job. On patch 10, PIC is PCI, right ? In case you hae some time, am interested in understanding how those guards #define xxx xxx works. Is it ok to test the patch now in my mcf54415 based board ? Reviewed-by: Angelo Dureghello On Wed, Apr

Re: [PATCH v2 3/8] net: ax88796: Do not free IRQ in ax_remove() (already freed in ax_close()).

On 04/17/2018 10:32 PM, Michael Schmitz wrote: >> From: Michael Karcher > > I haven't found a way to change that in my tree yet, sorry. Unless > someone has a simple way to fix patch authorship after a merge, I may > have to reimport from scratch. I guess

Re: [PATCH v2 3/8] net: ax88796: Do not free IRQ in ax_remove() (already freed in ax_close()).

Thanks Geert, I'll fix that. I see my v2 series shows up as new series on patchwork - do I need to do something different when tagging the next version, Dave? Cheers, Michael On Wed, Apr 18, 2018 at 1:51 AM, David Miller wrote: > From: Geert Uytterhoeven

Re: [PATCH v2 3/8] net: ax88796: Do not free IRQ in ax_remove() (already freed in ax_close()).

Hi Adrian, On Tue, Apr 17, 2018 at 11:40 PM, John Paul Adrian Glaubitz wrote: > On 04/17/2018 04:08 AM, Michael Schmitz wrote: >> >> From: John Paul Adrian Glaubitz > > This should be: > > From: Michael Karcher

Re: [PATCH 08/10] net: ax88796: Make reset more robust on AX88796B

Thanks Florian, I'll keep the Asix PHY driver separate from ax88796 for now. Mainly to simplify testing. Let's see whether it can be used by any other MAC - can still fold it into ax88796 later. Cheers, Michael On Wed, Apr 18, 2018 at 6:08 AM, Florian Fainelli wrote:

Re: [PATCH 04/10] net: ax88796: Add block_input/output hooks to ax_plat_data

Hi Michael, I love your patch! Perhaps something to improve: [auto build test WARNING on v4.16] [cannot apply to net-next/master net/master v4.17-rc1 next-20180417] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com

Re: [PATCH 08/10] net: ax88796: Make reset more robust on AX88796B

On 04/17/2018 06:01 AM, Andrew Lunn wrote: > On Tue, Apr 17, 2018 at 07:18:10AM +0200, Michael Karcher wrote: >> [Andrew, sorry for the dup. I did hit reply-to-auhor instead of >> reply-to-all first.] >> >> Andrew Lunn schrieb: > This should really be fixed in the PHY driver, not the MAC.

Re: [PATCH 10/10] net: New ax88796 platform driver for Amiga X-Surf 100 Zorro board (m68k)

Hi Michael, Thanks for your patch! On Tue, Apr 17, 2018 at 12:04 AM, Michael Schmitz wrote: > Add platform device driver to populate the ax88796 platform data from > information provided by the XSurf100 zorro device driver. > This driver will have to be loaded before

Re: [PATCH v2 3/8] net: ax88796: Do not free IRQ in ax_remove() (already freed in ax_close()).

From: Geert Uytterhoeven Date: Tue, 17 Apr 2018 10:20:25 +0200 > BTW, I have a git alias for that: > > $ git help fixes > `git fixes' is aliased to `show --format='Fixes: %h ("%s")' -s' > $ git fixes 82533ad9a1c > Fixes: 82533ad9a1c ("net: ethernet: ax88796: don't call

Re: [PATCH v2 8/8] net: New ax88796 platform driver for Amiga X-Surf 100 Zorro board (m68k)

On Tue, Apr 17, 2018 at 02:08:15PM +1200, Michael Schmitz wrote: > Add platform device driver to populate the ax88796 platform data from > information provided by the XSurf100 zorro device driver. > This driver will have to be loaded before loading the ax88796 module, > or compiled as built-in. >

Re: [PATCH v2 2/8] net: ax88796: Attach MII bus only when open

On Tue, Apr 17, 2018 at 02:08:09PM +1200, Michael Schmitz wrote: > From: Michael Karcher > > Call ax_mii_init in ax_open(), and unregister/remove mdiobus resources > in ax_close(). > > This is needed to be able to unload the module, as the module is busy >

Re: [PATCH 08/10] net: ax88796: Make reset more robust on AX88796B

On Tue, Apr 17, 2018 at 07:18:10AM +0200, Michael Karcher wrote: > [Andrew, sorry for the dup. I did hit reply-to-auhor instead of > reply-to-all first.] > > Andrew Lunn schrieb: > >> > This should really be fixed in the PHY driver, not the MAC. > >> > >> OK - do you want this separate, or as

Re: [PATCH v2 6/8] net: ax88796: set IRQF_SHARED flag when IRQ resource is marked as shareable

On 04/17/2018 04:08 AM, Michael Schmitz wrote: From: John Paul Adrian Glaubitz This should be: From: Michael Karcher -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaub...@debian.org `. `' Freie

Re: [PATCH v2 3/8] net: ax88796: Do not free IRQ in ax_remove() (already freed in ax_close()).

On 04/17/2018 04:08 AM, Michael Schmitz wrote: From: John Paul Adrian Glaubitz This should be: From: Michael Karcher -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaub...@debian.org `. `' Freie

Re: [PATCH 03/10] net: ax88796: Do not free IRQ in ax_remove() (already freed in ax_close()).

Hello! On 4/17/2018 1:04 AM, Michael Schmitz wrote: From: John Paul Adrian Glaubitz This complements the fix in 82533ad9a1c that removed the free_irq You also need to specify the commit's summary line enclosed in (""). call in the error path of probe, to

Re: [PATCH v2 3/8] net: ax88796: Do not free IRQ in ax_remove() (already freed in ax_close()).

Hi Michael, Adrian, Thanks for your patch! On Tue, Apr 17, 2018 at 4:08 AM, Michael Schmitz wrote: > From: John Paul Adrian Glaubitz > > This complements the fix in 82533ad9a1c that removed the free_irq Please quote the commit's subject,